[pytest-dev] -k EXPRESSION: How to allow for case-insensitive matching

[Bruno Oliveira]

Thanks everyone for their input!

Christoph feel free to open a PR targeting the `features` branch with this
change.

For now I don't think we need an option to revert to the old behavior; if
people claim for it we can consider adding it in the future though.

Cheers,
Bruno

On Wed, Dec 4, 2019 at 12:38 PM RonnyPfannschmidt <
opensource at ronnypfannschmidt.de> wrote:

> Hi all,
>
> it seems to me that a change to
>
>
> https://github.com/pytest-dev/pytest/blob/master/src/_pytest/mark/legacy.py#L28
>
>
> in addition to ensuring lowercase of the expression is all that's needed
> on the technical side
>
> on the release management side its a breaking change that needs a major
> release
>
> nonetheless i'm all for it.
>
> i wonder about the case sensitivity of mark expressions as well
>
>
> -- Ronny
>
>
> Am 04.12.19 um 15:55 schrieb Brian Okken:
> > I think switching to case insensitive by default would be fine. Do we
> need a flag for case sensitive? Not sure.
> >
> > - Brian
> >
> >> On Dec 4, 2019, at 6:26 AM, Florian Bruhin <me at the-compiler.org> wrote:
> >>
> >> Hey,
> >>
> >>> On Wed, Dec 04, 2019 at 10:58:09AM -0300, Bruno Oliveira wrote:
> >>> I would actually vote to change the existing behavior to be
> >>> case-insensitive. I doubt it would break many suites, if at all, and
> would
> >>> be more in alignment with the intent of the option, more of it being a
> >>> "partial match" than an exact match, as it matches against any portion
> of
> >>> the node id currently anyway.
> >> Sounds entirely reasonable to me!
> >>
> >> Florian
> >>
> >> --
> >> me at the-compiler.org (Mail/XMPP) | https://www.qutebrowser.org
> >>        https://bruhin.software/ |
> https://github.com/sponsors/The-Compiler/
> >>        GPG: 916E B0C8 FD55 A072 | https://the-compiler.org/pubkey.asc
> >>              I love long mails! | https://email.is-not-s.ms/
> >> _______________________________________________
> >> pytest-dev mailing list
> >> pytest-dev at python.org
> >> https://mail.python.org/mailman/listinfo/pytest-dev
> > _______________________________________________
> > pytest-dev mailing list
> > pytest-dev at python.org
> > https://mail.python.org/mailman/listinfo/pytest-dev
> _______________________________________________
> pytest-dev mailing list
> pytest-dev at python.org
> https://mail.python.org/mailman/listinfo/pytest-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/pytest-dev/attachments/20191204/38e8cca4/attachment.html>