[py-svn] commit/pytest: hpk42: fix issue197 - in case a function is parametrized with zero arguments,

[Bitbucket]

1 new commit in pytest:


https://bitbucket.org/hpk42/pytest/changeset/b10528b9cd1a/
changeset:   b10528b9cd1a
user:        hpk42
date:        2012-10-06 11:34:06
summary:     fix issue197 - in case a function is parametrized with zero arguments,
skip it during setup
affected #:  3 files

diff -r fe752ae6e18c5108e77a822e8f0e9d3a3ef4f5b7 -r b10528b9cd1acc11edca5172a9d8520069acd246 CHANGELOG
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -1,6 +1,8 @@
 Changes between 2.2.4 and 2.3.0.dev
 -----------------------------------
 
+- fix issue193 skip test functions with were parametrized with empty
+  parameter sets
 - fix python3.3 compat, mostly reporting bits that previously depended
   on dict ordering
 - introduce a generic "markers" object on Nodes and a request.node


diff -r fe752ae6e18c5108e77a822e8f0e9d3a3ef4f5b7 -r b10528b9cd1acc11edca5172a9d8520069acd246 _pytest/python.py
--- a/_pytest/python.py
+++ b/_pytest/python.py
@@ -95,11 +95,11 @@
 
 def pytest_generate_tests(metafunc):
     try:
-        param = metafunc.function.parametrize
+        markers = metafunc.function.parametrize
     except AttributeError:
         return
-    for p in param:
-        metafunc.parametrize(*p.args, **p.kwargs)
+    for marker in markers:
+        metafunc.parametrize(*marker.args, **marker.kwargs)
 
 def pytest_configure(config):
     config.addinivalue_line("markers",
@@ -190,7 +190,7 @@
         if is_generator(obj):
             return Generator(name, parent=collector)
         else:
-            return collector._genfunctions(name, obj)
+            return list(collector._genfunctions(name, obj))
 
 def is_generator(func):
     try:
@@ -313,16 +313,14 @@
         plugins = self.getplugins() + extra
         gentesthook.pcall(plugins, metafunc=metafunc)
         Function = self._getcustomclass("Function")
-        l = []
         if not metafunc._calls:
-            l.append(Function(name, parent=self))
-        for callspec in metafunc._calls:
-            subname = "%s[%s]" %(name, callspec.id)
-            function = Function(name=subname, parent=self,
-                callspec=callspec, callobj=funcobj,
-                keywords={callspec.id:True})
-            l.append(function)
-        return l
+            yield Function(name, parent=self)
+        else:
+            for callspec in metafunc._calls:
+                subname = "%s[%s]" %(name, callspec.id)
+                yield Function(name=subname, parent=self,
+                               callspec=callspec, callobj=funcobj,
+                               keywords={callspec.id:True})
 
 def transfer_markers(funcobj, cls, mod):
     # XXX this should rather be code in the mark plugin or the mark
@@ -584,6 +582,8 @@
             if valtype == "funcargs":
                 self.params[arg] = id
             self._arg2scopenum[arg] = scopenum
+            if val == _notexists:
+                self._emptyparamspecified = True
         self._idlist.append(id)
 
     def setall(self, funcargs, id, param):
@@ -652,6 +652,9 @@
         if not isinstance(argnames, (tuple, list)):
             argnames = (argnames,)
             argvalues = [(val,) for val in argvalues]
+        if not argvalues:
+            argvalues = [(_notexists,) * len(argnames)]
+
         if scope is None:
             scope = "function"
         scopenum = scopes.index(scope)
@@ -659,7 +662,8 @@
             #XXX should we also check for the opposite case?
             for arg in argnames:
                 if arg not in self.fixturenames:
-                    raise ValueError("%r has no argument %r" %(self.function, arg))
+                    raise ValueError("%r uses no fixture %r" %(
+                                     self.function, arg))
         valtype = indirect and "params" or "funcargs"
         if not ids:
             idmaker = IDMaker()
@@ -925,6 +929,16 @@
         self.ihook.pytest_pyfunc_call(pyfuncitem=self)
 
     def setup(self):
+        # check if parametrization happend with an empty list
+        try:
+            empty = self.callspec._emptyparamspecified
+        except AttributeError:
+            pass
+        else:
+            fs, lineno = self._getfslineno()
+            pytest.skip("got empty parameter set, function %s at %s:%d" %(
+                self.function.__name__, fs, lineno))
+
         super(Function, self).setup()
         #if hasattr(self, "_request"):
         #    self._request._callsetup()


diff -r fe752ae6e18c5108e77a822e8f0e9d3a3ef4f5b7 -r b10528b9cd1acc11edca5172a9d8520069acd246 testing/test_python.py
--- a/testing/test_python.py
+++ b/testing/test_python.py
@@ -303,6 +303,16 @@
         assert f1 == f1_b
         assert not f1 != f1_b
 
+    def test_issue197_parametrize_emptyset(self, testdir):
+        testdir.makepyfile("""
+            import pytest
+            @pytest.mark.parametrize('arg', [])
+            def test_function(arg):
+                pass
+        """)
+        reprec = testdir.inline_run()
+        reprec.assertoutcome(skipped=1)
+
     def test_function_equality_with_callspec(self, testdir, tmpdir):
         items = testdir.getitems("""
             import pytest

Repository URL: https://bitbucket.org/hpk42/pytest/

--

This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.