[PyPy-issue] [issue663] [PATCH] Avoid XCHG

[Armin Rigo]

Armin Rigo <armin.rigo at gmail.com> added the comment:

Thanks for the patch!  I tried to apply it, and also comment out the declaration
of XCHG in rx86.py and regloc.py with a comment that explains why using XCHG is
a bad idea.  However I found out that you didn't run any test.  There are issues
like using 0 instead of imm0.  Moreover test_basic segfaults, for reasons that
are probably easy to find and fix.  Can you try to provide an updated patch that
passes all tests as run by "python test_all.py jit/backend/x86/"?  Thank you :-)

_______________________________________________________
PyPy development tracker <pypy-dev-issue at codespeak.net>
<https://codespeak.net/issue/pypy-dev/issue663>
_______________________________________________________