[pypy-commit] pypy unicode-utf8-py3: add asserts for translation - why is this needed?

[mattip]

Author: Matti Picus <matti.picus at gmail.com>
Branch: unicode-utf8-py3
Changeset: r95266:692cf928c31b
Date: 2018-11-01 07:12 +0200
http://bitbucket.org/pypy/pypy/changeset/692cf928c31b/

Log:	add asserts for translation - why is this needed?

diff --git a/TODO b/TODO
--- a/TODO
+++ b/TODO
@@ -9,5 +9,6 @@
 * revisit all places where we do utf8.decode('utf-8'), they should work directly with utf8
   - rutf8.utf8_encode_mbcs
   - unicodehelper.fsencode
+* remove asserts from _WIN32 paths in rlib.rposix.re{name,place}
 * convert all realunicode_w to unicode_w after we flush out all old uses of unicode_w
 * benchmark
diff --git a/rpython/rlib/rposix.py b/rpython/rlib/rposix.py
--- a/rpython/rlib/rposix.py
+++ b/rpython/rlib/rposix.py
@@ -1269,6 +1269,8 @@
         win32traits = make_win32_traits(traits)
         path1 = traits.as_str0(path1)
         path2 = traits.as_str0(path2)
+        assert isinstance(path1, unicode)
+        assert isinstance(path2, unicode)
         if not win32traits.MoveFileEx(path1, path2, 0):
             raise rwin32.lastSavedWindowsError()
 
@@ -1279,6 +1281,8 @@
         win32traits = make_win32_traits(traits)
         path1 = traits.as_str0(path1)
         path2 = traits.as_str0(path2)
+        assert isinstance(path1, unicode)
+        assert isinstance(path2, unicode)
         ret = win32traits.MoveFileEx(path1, path2,
                      win32traits.MOVEFILE_REPLACE_EXISTING)
         if not ret: