[pypy-commit] pypy cpyext-refactor-methodobject: add this fix, because now pass w_kwds=None directly; we should investigate better whether the check is still needed, but first I want to test the heavy changes which I did in the previous checkins

[antocuni]

Author: Antonio Cuni <anto.cuni at gmail.com>
Branch: cpyext-refactor-methodobject
Changeset: r92823:7501b268c626
Date: 2017-10-22 00:43 +0200
http://bitbucket.org/pypy/pypy/changeset/7501b268c626/

Log:	add this fix, because now pass w_kwds=None directly; we should
	investigate better whether the check is still needed, but first I
	want to test the heavy changes which I did in the previous checkins

diff --git a/pypy/module/cpyext/typeobject.py b/pypy/module/cpyext/typeobject.py
--- a/pypy/module/cpyext/typeobject.py
+++ b/pypy/module/cpyext/typeobject.py
@@ -378,7 +378,10 @@
     args_w = space.fixedview(w_args)
     w_subtype = args_w[0]
     w_args = space.newtuple(args_w[1:])
-    if not space.is_true(w_kwds):
+    # CCC: is this check still needed? I think we can safely remove it now
+    # that we manually handle __args__ inside W_PyCFunctionObject.descr_call,
+    # but we need to double check
+    if w_kwds and not space.is_true(w_kwds):
         w_kwds = None
 
     subtype = rffi.cast(PyTypeObjectPtr, make_ref(space, w_subtype))