[pypy-commit] pypy vmprof-0.4.10: I claim that tests should never be skipped implicitly. If there is some platform on which vmprof doesn't work, buildbot will tell us and we can skip them explicitly. Else the risk is to skip tests which are meant to run, as it happened with test_enable and test_native since forever

[antocuni]

Author: Antonio Cuni <anto.cuni at gmail.com>
Branch: vmprof-0.4.10
Changeset: r92969:49caf38340af
Date: 2017-11-08 01:42 +0100
http://bitbucket.org/pypy/pypy/changeset/49caf38340af/

Log:	I claim that tests should never be skipped implicitly. If there is
	some platform on which vmprof doesn't work, buildbot will tell us
	and we can skip them explicitly. Else the risk is to skip tests
	which are meant to run, as it happened with test_enable and
	test_native since forever

diff --git a/rpython/rlib/rvmprof/test/test_rvmprof.py b/rpython/rlib/rvmprof/test/test_rvmprof.py
--- a/rpython/rlib/rvmprof/test/test_rvmprof.py
+++ b/rpython/rlib/rvmprof/test/test_rvmprof.py
@@ -25,11 +25,8 @@
         self.rpy_entry_point = compile(self.entry_point, self.ENTRY_POINT_ARGS)
 
     def register(self):
-        try:
-            rvmprof.register_code_object_class(self.MyCode,
-                                               self.MyCode.get_name)
-        except rvmprof.VMProfPlatformUnsupported as e:
-            py.test.skip(str(e))
+        rvmprof.register_code_object_class(self.MyCode,
+                                           self.MyCode.get_name)
 
 
 class TestExecuteCode(RVMProfTest):