[pypy-commit] pypy faster-rstruct-2: fix a misuse of box.getfloat() vs box.getfloatstorage(): this was harmless on 64 bit of course, but caused test_llop:test_gc_store_indexed_double to fail on 32 bit

antocuni pypy.commits at gmail.com
Sun May 21 05:36:12 EDT 2017


Author: Antonio Cuni <anto.cuni at gmail.com>
Branch: faster-rstruct-2
Changeset: r91358:0e91701e92f0
Date: 2017-05-21 11:35 +0200
http://bitbucket.org/pypy/pypy/changeset/0e91701e92f0/

Log:	fix a misuse of box.getfloat() vs box.getfloatstorage(): this was
	harmless on 64 bit of course, but caused
	test_llop:test_gc_store_indexed_double to fail on 32 bit

diff --git a/rpython/jit/metainterp/executor.py b/rpython/jit/metainterp/executor.py
--- a/rpython/jit/metainterp/executor.py
+++ b/rpython/jit/metainterp/executor.py
@@ -261,7 +261,7 @@
     if arraydescr.is_array_of_pointers():
         raise AssertionError("cannot store GC pointers in gc_store_indexed for now")
     elif arraydescr.is_array_of_floats():
-        floatval = valuebox.getfloat()
+        floatval = valuebox.getfloatstorage()
         cpu.bh_gc_store_indexed_f(addr, index, floatval, scale, base_ofs, bytes,
                                   arraydescr)
     else:


More information about the pypy-commit mailing list