[pypy-commit] pypy py3.5: idna needs unicodedata

pjenvey pypy.commits at gmail.com
Fri Mar 3 23:27:40 EST 2017


Author: Philip Jenvey <pjenvey at underboss.org>
Branch: py3.5
Changeset: r90522:35f5281b39f7
Date: 2017-03-03 20:04 -0800
http://bitbucket.org/pypy/pypy/changeset/35f5281b39f7/

Log:	idna needs unicodedata

diff --git a/pypy/module/_socket/test/test_sock_app.py b/pypy/module/_socket/test/test_sock_app.py
--- a/pypy/module/_socket/test/test_sock_app.py
+++ b/pypy/module/_socket/test/test_sock_app.py
@@ -296,7 +296,8 @@
 
 
 class AppTestSocket:
-    spaceconfig = dict(usemodules=['_socket', '_weakref', 'struct', 'select'])
+    spaceconfig = dict(usemodules=['_socket', '_weakref', 'struct', 'select',
+                                   'unicodedata'])
 
     def setup_class(cls):
         cls.space = space
@@ -667,8 +668,6 @@
     def test_hostname_unicode(self):
         import _socket
         domain = u"испытание.pythontest.net"
-        # XXX figure out why the idna encoding is sometimes missing in
-        # tests, notably if we run all tests instead of just this one
         _socket.gethostbyname(domain)
         _socket.gethostbyname_ex(domain)
         _socket.getaddrinfo(domain, 0, _socket.AF_UNSPEC, _socket.SOCK_STREAM)


More information about the pypy-commit mailing list