[pypy-commit] pypy default: Imperative py.test.skip() is evil

rlamy pypy.commits at gmail.com
Fri Aug 25 10:19:02 EDT 2017


Author: Ronan Lamy <ronan.lamy at gmail.com>
Branch: 
Changeset: r92261:2b1b6c5545d0
Date: 2017-08-25 16:18 +0200
http://bitbucket.org/pypy/pypy/changeset/2b1b6c5545d0/

Log:	Imperative py.test.skip() is evil

diff --git a/rpython/flowspace/test/test_objspace.py b/rpython/flowspace/test/test_objspace.py
--- a/rpython/flowspace/test/test_objspace.py
+++ b/rpython/flowspace/test/test_objspace.py
@@ -839,15 +839,15 @@
             return x[s]
         graph = self.codetest(myfunc)
 
+    @py.test.mark.xfail
     def test_unichr_constfold(self):
-        py.test.skip("not working")
         def myfunc():
             return unichr(1234)
         graph = self.codetest(myfunc)
         assert graph.startblock.exits[0].target is graph.returnblock
 
+    @py.test.mark.xfail
     def test_unicode_constfold(self):
-        py.test.skip("not working for now")
         def myfunc():
             return unicode("1234")
         graph = self.codetest(myfunc)


More information about the pypy-commit mailing list