[pypy-commit] pypy default: ooops! Since 8fb078df2c3d, most of the tests in this file don't run.

arigo pypy.commits at gmail.com
Mon May 2 13:48:06 EDT 2016


Author: Armin Rigo <arigo at tunes.org>
Branch: 
Changeset: r84134:136845ff4b16
Date: 2016-05-02 19:46 +0200
http://bitbucket.org/pypy/pypy/changeset/136845ff4b16/

Log:	ooops! Since 8fb078df2c3d, most of the tests in this file don't run.
	That's because they are local functions of another test function...

diff --git a/rpython/translator/backendopt/test/test_finalizer.py b/rpython/translator/backendopt/test/test_finalizer.py
--- a/rpython/translator/backendopt/test/test_finalizer.py
+++ b/rpython/translator/backendopt/test/test_finalizer.py
@@ -35,31 +35,6 @@
         r = self.analyze(f, [])
         assert not r
 
-def test_various_ops():
-    from rpython.flowspace.model import SpaceOperation, Constant
-
-    X = lltype.Ptr(lltype.GcStruct('X'))
-    Z = lltype.Ptr(lltype.Struct('Z'))
-    S = lltype.GcStruct('S', ('x', lltype.Signed),
-                        ('y', X),
-                        ('z', Z))
-    v1 = varoftype(lltype.Bool)
-    v2 = varoftype(lltype.Signed)
-    f = FinalizerAnalyzer(None)
-    r = f.analyze(SpaceOperation('cast_int_to_bool', [v2],
-                                                       v1))
-    assert not r
-    v1 = varoftype(lltype.Ptr(S))
-    v2 = varoftype(lltype.Signed)
-    v3 = varoftype(X)
-    v4 = varoftype(Z)
-    assert not f.analyze(SpaceOperation('bare_setfield', [v1, Constant('x'),
-                                                          v2], None))
-    assert     f.analyze(SpaceOperation('bare_setfield', [v1, Constant('y'),
-                                                          v3], None))
-    assert not f.analyze(SpaceOperation('bare_setfield', [v1, Constant('z'),
-                                                          v4], None))
-
     def test_malloc(self):
         S = lltype.GcStruct('S')
 
@@ -131,3 +106,30 @@
             pass
         self.analyze(g, []) # did not explode
         py.test.raises(FinalizerError, self.analyze, f, [])
+
+
+def test_various_ops():
+    from rpython.flowspace.model import SpaceOperation, Constant
+
+    X = lltype.Ptr(lltype.GcStruct('X'))
+    Z = lltype.Ptr(lltype.Struct('Z'))
+    S = lltype.GcStruct('S', ('x', lltype.Signed),
+                        ('y', X),
+                        ('z', Z))
+    v1 = varoftype(lltype.Bool)
+    v2 = varoftype(lltype.Signed)
+    f = FinalizerAnalyzer(None)
+    r = f.analyze(SpaceOperation('cast_int_to_bool', [v2],
+                                                       v1))
+    assert not r
+    v1 = varoftype(lltype.Ptr(S))
+    v2 = varoftype(lltype.Signed)
+    v3 = varoftype(X)
+    v4 = varoftype(Z)
+    assert not f.analyze(SpaceOperation('bare_setfield', [v1, Constant('x'),
+                                                          v2], None))
+    assert     f.analyze(SpaceOperation('bare_setfield', [v1, Constant('y'),
+                                                          v3], None))
+    assert not f.analyze(SpaceOperation('bare_setfield', [v1, Constant('z'),
+                                                          v4], None))
+


More information about the pypy-commit mailing list