[pypy-commit] pypy default: Fix bogus assembler generated in a case that never occurs in practice

[arigo]

Author: Armin Rigo <arigo at tunes.org>
Branch: 
Changeset: r81791:664ecc23f550
Date: 2016-01-15 12:58 +0100
http://bitbucket.org/pypy/pypy/changeset/664ecc23f550/

Log:	Fix bogus assembler generated in a case that never occurs in
	practice

diff --git a/rpython/jit/backend/x86/assembler.py b/rpython/jit/backend/x86/assembler.py
--- a/rpython/jit/backend/x86/assembler.py
+++ b/rpython/jit/backend/x86/assembler.py
@@ -2067,7 +2067,9 @@
             if IS_X86_64:
                 tmploc = esi    # already the correct place
                 if argloc is tmploc:
-                    self.mc.MOV_rr(esi.value, edi.value)
+                    # this case is theoretical only so far: in practice,
+                    # argloc is always eax, never esi
+                    self.mc.MOV_rr(edi.value, esi.value)
                     argloc = edi
             else:
                 tmploc = eax