[pypy-commit] pypy py3.5: update comments

plan_rich pypy.commits at gmail.com
Sat Dec 17 05:50:59 EST 2016


Author: Richard Plangger <planrichi at gmail.com>
Branch: py3.5
Changeset: r89111:699a508dff49
Date: 2016-12-17 11:50 +0100
http://bitbucket.org/pypy/pypy/changeset/699a508dff49/

Log:	update comments

diff --git a/lib_pypy/_cffi_ssl/_stdssl/__init__.py b/lib_pypy/_cffi_ssl/_stdssl/__init__.py
--- a/lib_pypy/_cffi_ssl/_stdssl/__init__.py
+++ b/lib_pypy/_cffi_ssl/_stdssl/__init__.py
@@ -100,7 +100,8 @@
 lib.OpenSSL_add_all_algorithms()
 
 def check_signals():
-    # TODO PyErr_CheckSignal equivalent for pypy?
+    # nothing to do, we are on python level, signals are
+    # checked frequently in the bytecode dispatch loop
     pass
 
 def _socket_timeout(s):
@@ -347,7 +348,6 @@
             peer_cert = ffi.gc(peer_cert, lib.X509_free)
         self.peer_cert = peer_cert
 
-        #PySSL_END_ALLOW_THREADS
         self.handshake_done = 1
         return None
 
diff --git a/lib_pypy/_cffi_ssl/_stdssl/certificate.py b/lib_pypy/_cffi_ssl/_stdssl/certificate.py
--- a/lib_pypy/_cffi_ssl/_stdssl/certificate.py
+++ b/lib_pypy/_cffi_ssl/_stdssl/certificate.py
@@ -151,7 +151,6 @@
         value = lib.X509_NAME_ENTRY_get_data(entry);
         attr = _create_tuple_for_attribute(name, value);
         if attr == ffi.NULL:
-            pass # TODO error
             raise NotImplementedError
         rdn.append(attr)
 


More information about the pypy-commit mailing list