[pypy-commit] pypy quad-color-gc: Add FIXME for bug in trace function

ntruessel pypy.commits at gmail.com
Tue Aug 23 01:38:36 EDT 2016


Author: Nicolas Truessel <ntruessel at njsm.de>
Branch: quad-color-gc
Changeset: r86433:5814b9e70ba5
Date: 2016-08-23 07:37 +0200
http://bitbucket.org/pypy/pypy/changeset/5814b9e70ba5/

Log:	Add FIXME for bug in trace function

diff --git a/rpython/memory/gctransform/qcgcframework.py b/rpython/memory/gctransform/qcgcframework.py
--- a/rpython/memory/gctransform/qcgcframework.py
+++ b/rpython/memory/gctransform/qcgcframework.py
@@ -22,7 +22,7 @@
         #     s_gcref], s_gcref)
         #
         def invokecallback(root, visit_fn):
-            visit_fn(root)
+            visit_fn(root) # FIXME: Dereference root before invoking visit_fn
         def pypy_trace_cb(obj, visit_fn):
             gc.trace(obj, invokecallback, visit_fn)
         pypy_trace_cb.c_name = "pypy_trace_cb"


More information about the pypy-commit mailing list