[pypy-commit] stmgc c8-new-page-handling: Add a comment

arigo noreply at buildbot.pypy.org
Tue Sep 23 10:45:07 CEST 2014


Author: Armin Rigo <arigo at tunes.org>
Branch: c8-new-page-handling
Changeset: r1408:fe2e4b498547
Date: 2014-09-23 10:45 +0200
http://bitbucket.org/pypy/stmgc/changeset/fe2e4b498547/

Log:	Add a comment

diff --git a/c8/stm/core.c b/c8/stm/core.c
--- a/c8/stm/core.c
+++ b/c8/stm/core.c
@@ -197,6 +197,9 @@
     dprintf(("-> segment: %d\n", segnum));
     char *seg_base = STM_SEGMENT->segment_base;
     uintptr_t pagenum = ((char*)addr - seg_base) / 4096UL;
+    /* XXX actual segfault also if the pagenum is out of bounds,
+       say < END_NURSERY_PAGE.  Important for crashing cleanly on
+       %gs:NULL accesses */
 
     handle_segfault_in_page(pagenum);
 


More information about the pypy-commit mailing list