[pypy-commit] pypy stringbuilder-perf: Add an XXX comment
arigo
noreply at buildbot.pypy.org
Mon Jun 9 17:09:33 CEST 2014
Author: Armin Rigo <arigo at tunes.org>
Branch: stringbuilder-perf
Changeset: r72002:1bc7e315768b
Date: 2014-06-09 17:08 +0200
http://bitbucket.org/pypy/pypy/changeset/1bc7e315768b/
Log: Add an XXX comment
diff --git a/rpython/rtyper/lltypesystem/rbuilder.py b/rpython/rtyper/lltypesystem/rbuilder.py
--- a/rpython/rtyper/lltypesystem/rbuilder.py
+++ b/rpython/rtyper/lltypesystem/rbuilder.py
@@ -28,6 +28,13 @@
# - The data is copied at most twice, and only once in case it fits
# into the initial size (and the GC supports shrinking the STR).
#
+# XXX too much a mess to handle the case where the JIT sees this code.
+# Think about an easier alternative, like using raw_store(current_buf, ..)
+# uniformly, where current_buf is a GC pointer that can be NULL. We'd
+# need support in the JIT to map that to virtual string index. We'd also
+# need a way to express c_memcpy() below --- similar to copystrcontent,
+# but without the assumption that it's about a string (or unicode).
+#
# ------------------------------------------------------------
More information about the pypy-commit
mailing list