[pypy-commit] pypy gc-incminimark-pinning: remove outdated comments
groggi
noreply at buildbot.pypy.org
Tue Aug 19 21:15:57 CEST 2014
Author: Gregor Wegberg <code at gregorwegberg.com>
Branch: gc-incminimark-pinning
Changeset: r72915:d704858f1a7d
Date: 2014-08-19 21:11 +0200
http://bitbucket.org/pypy/pypy/changeset/d704858f1a7d/
Log: remove outdated comments
diff --git a/rpython/rlib/rgc.py b/rpython/rlib/rgc.py
--- a/rpython/rlib/rgc.py
+++ b/rpython/rlib/rgc.py
@@ -20,7 +20,6 @@
# for test purposes we allow objects to be pinned and use
# the following list to keep track of the pinned objects
-# XXX think about possible unexpected behavior (groggi)
if not we_are_translated():
pinned_objects = []
diff --git a/rpython/rtyper/lltypesystem/rffi.py b/rpython/rtyper/lltypesystem/rffi.py
--- a/rpython/rtyper/lltypesystem/rffi.py
+++ b/rpython/rtyper/lltypesystem/rffi.py
@@ -803,14 +803,6 @@
"""
Either free a non-moving buffer or keep the original storage alive.
"""
- # We cannot rely on rgc.can_move(data) here, because its result
- # might have changed since get_nonmovingbuffer(). Instead we check
- # if 'buf' points inside 'data'. This is only possible if we
- # followed the 2nd case in get_nonmovingbuffer(); in the first case,
- # 'buf' points to its own raw-malloced memory.
- # XXX fix comment (groggi)
-
-
if is_pinned:
rgc.unpin(data)
if is_raw:
More information about the pypy-commit
mailing list