[pypy-commit] pypy pypy-pyarray: remove finished task from TODO.txt

mattip noreply at buildbot.pypy.org
Mon Sep 9 00:05:14 CEST 2013


Author: Matti Picus <matti.picus at gmail.com>
Branch: pypy-pyarray
Changeset: r66853:8501a3de2e2e
Date: 2013-09-04 16:38 +0300
http://bitbucket.org/pypy/pypy/changeset/8501a3de2e2e/

Log:	remove finished task from TODO.txt

diff --git a/TODO.txt b/TODO.txt
--- a/TODO.txt
+++ b/TODO.txt
@@ -4,17 +4,6 @@
 - why do we need to implement array.nonzero on this branch and it was not done
   e.g. on default?
 
-- in cpyext/ndarrayobject.py: most functions starts with code like this:
-
-    @cpython_api([PyObject], rffi.INT_real, error=CANNOT_FAIL)
-    def _PyArray_FLAGS(space, w_array):
-        assert isinstance(w_array, W_NDimArray)
-        ...
-
-  this is very bad because if you pass something which is not a numpy array,
-  you get an RPython AssertionError instead of a nice applevel TypeError
-
-
 -   def _PyArray_FromAny(space, w_obj, dtype, min_depth, max_depth, requirements, context):
         # ignore all additional arguments for now
 


More information about the pypy-commit mailing list