[pypy-commit] pypy default: unused error message in sqlite

bdkearns noreply at buildbot.pypy.org
Mon Mar 11 23:02:02 CET 2013


Author: Brian Kearns <bdkearns at gmail.com>
Branch: 
Changeset: r62298:7d7942e84071
Date: 2013-03-11 16:56 -0400
http://bitbucket.org/pypy/pypy/changeset/7d7942e84071/

Log:	unused error message in sqlite

diff --git a/lib_pypy/_sqlite3.py b/lib_pypy/_sqlite3.py
--- a/lib_pypy/_sqlite3.py
+++ b/lib_pypy/_sqlite3.py
@@ -480,8 +480,6 @@
     @_check_thread_wrap
     @_check_closed_wrap
     def __call__(self, sql):
-        if not isinstance(sql, basestring):
-            raise Warning("SQL is of wrong type. Must be string or unicode.")
         return self._statement_cache.get(sql, self.row_factory)
 
     def cursor(self, factory=None):
@@ -1007,7 +1005,7 @@
         self.__con = connection
 
         if not isinstance(sql, basestring):
-            raise ValueError("sql must be a string")
+            raise Warning("SQL is of wrong type. Must be string or unicode.")
         first_word = self._statement_kind = sql.lstrip().split(" ")[0].upper()
         if first_word in ("INSERT", "UPDATE", "DELETE", "REPLACE"):
             self._kind = Statement._DML


More information about the pypy-commit mailing list