[pypy-commit] pypy default: Disable using a free register as temp register when moving values around, this currently has unintended side-effects in code that emits a jump to a label

bivab noreply at buildbot.pypy.org
Mon Apr 8 15:47:00 CEST 2013


Author: David Schneider <david.schneider at picle.org>
Branch: 
Changeset: r63137:5ec20083ccc5
Date: 2013-04-08 15:45 +0200
http://bitbucket.org/pypy/pypy/changeset/5ec20083ccc5/

Log:	Disable using a free register as temp register when moving values
	around, this currently has unintended side-effects in code that
	emits a jump to a label

diff --git a/rpython/jit/backend/arm/assembler.py b/rpython/jit/backend/arm/assembler.py
--- a/rpython/jit/backend/arm/assembler.py
+++ b/rpython/jit/backend/arm/assembler.py
@@ -1035,7 +1035,8 @@
             assert 0, 'unsupported case'
 
     def _mov_stack_to_loc(self, prev_loc, loc, cond=c.AL):
-        helper = self._regalloc.get_free_reg()
+        # disabled for now, has side effects in combination with remap_frame_layout when called from a jump
+        helper = None # self._regalloc.get_free_reg()
         if loc.is_reg():
             assert prev_loc.type != FLOAT, 'trying to load from an \
                 incompatible location into a core register'


More information about the pypy-commit mailing list