[pypy-commit] pypy stm-thread-2: Mark places that will need fixing once we start improving

[arigo]

Author: Armin Rigo <arigo at tunes.org>
Branch: stm-thread-2
Changeset: r57315:b755d7246cd1
Date: 2012-09-12 22:09 +0200
http://bitbucket.org/pypy/pypy/changeset/b755d7246cd1/

Log:	Mark places that will need fixing once we start improving
	translator/stm/transform2.py.

diff --git a/pypy/jit/backend/llsupport/descr.py b/pypy/jit/backend/llsupport/descr.py
--- a/pypy/jit/backend/llsupport/descr.py
+++ b/pypy/jit/backend/llsupport/descr.py
@@ -345,8 +345,9 @@
                 return 'longlong.int2singlefloat(%s)' % (process('i'),)
             arg = 'args_%s[%d]' % (c, seen[c])
             seen[c] += 1
-            if c == 'r' and stm:
-                arg = 'llop.stm_writebarrier(llmemory.GCREF, %s)' % arg
+            #if c == 'r' and stm:
+            #    arg = 'llop.stm_writebarrier(llmemory.GCREF, %s)' % arg
+            #    XXX stm: barrier on (some?) args
             return arg
 
         def TYPE(arg):
diff --git a/pypy/jit/codewriter/call.py b/pypy/jit/codewriter/call.py
--- a/pypy/jit/codewriter/call.py
+++ b/pypy/jit/codewriter/call.py
@@ -188,6 +188,7 @@
         NON_VOID_ARGS = [ARG for ARG in FUNC.ARGS if ARG is not lltype.Void]
         calldescr = self.cpu.calldescrof(FUNC, tuple(NON_VOID_ARGS),
                                          FUNC.RESULT, EffectInfo.MOST_GENERAL)
+        # XXX stm: record arg and result categories
         return (fnaddr, calldescr)
 
     def getcalldescr(self, op, oopspecindex=EffectInfo.OS_NONE,
@@ -255,6 +256,7 @@
         #
         return self.cpu.calldescrof(FUNC, tuple(NON_VOID_ARGS), RESULT,
                                     effectinfo)
+        # XXX stm: record arg and result categories
 
     def _canraise(self, op):
         if op.opname == 'pseudo_call_cannot_raise':