[pypy-commit] pypy dynamic-specialized-tuple: Kill this optimization, it's bogus. It could, in theory work if neither shape has an object in it.

alex_gaynor noreply at buildbot.pypy.org
Fri Mar 30 03:41:16 CEST 2012


Author: Alex Gaynor <alex.gaynor at gmail.com>
Branch: dynamic-specialized-tuple
Changeset: r54087:eaefbf566c6f
Date: 2012-03-29 21:41 -0400
http://bitbucket.org/pypy/pypy/changeset/eaefbf566c6f/

Log:	Kill this optimization, it's bogus. It could, in theory work if
	neither shape has an object in it.

diff --git a/pypy/objspace/std/tupleobject.py b/pypy/objspace/std/tupleobject.py
--- a/pypy/objspace/std/tupleobject.py
+++ b/pypy/objspace/std/tupleobject.py
@@ -114,8 +114,6 @@
 
 @jit.look_inside_iff(tuple_unroll_condition)
 def eq__Tuple_Tuple(space, w_tuple1, w_tuple2):
-    if w_tuple1.tuplestorage.getshape() is not w_tuple2.tuplestorage.getshape():
-        return space.w_False
     if w_tuple1.length() != w_tuple2.length():
         return space.w_False
     for i in xrange(w_tuple1.length()):


More information about the pypy-commit mailing list