[pypy-commit] [COMMENT] Pull request #29 for pypy/pypy: Finish kqueue support

[Bitbucket]

New comment on pull request:

https://bitbucket.org/pypy/pypy/pull-request/29/finish-kqueue-support#comment-3546

Tobias Oberstein (oberstet) said:

Hi Alex,

I've done all of above, plus a couple of things which bring the implementation more in line with CPy.

After discussion with arigato: I've also corrected the use of integer types. In that context I've added intptr_t, uintptr_t to TYPES in rffi.py.

In general the types: int, ssize_t, intptr_t can be equal, or not. Same for unsigned ones.

See also: http://stackoverflow.com/questions/1464174/size-t-vs-intptr-t

I have merged current upstream, run translate/unit tests. PyPy is building right now. Let me know if there are further things you'd like to have changed.

--
This is a pull request comment notification from bitbucket.org.
You are receiving this either because you are participating
in a pull request, or you are following it.