[pypy-commit] [OPEN] Pull request #23 for pypy/pypy: Fix _sqlite3.py fix for issue996, with test

Bitbucket pullrequests-noreply at bitbucket.org
Mon Jan 23 00:33:41 CET 2012


Pull request #23 has been updated by David Ripton to include new changes.

https://bitbucket.org/pypy/pypy/pull-request/23/fix-_sqlite3py-fix-for-issue996-with-test

Title: Fix _sqlite3.py fix for issue996, with test

Creator: David Ripton

4 commits of trivial cleanups to lib_pypy/_sqlite3.py, a comment to comply with the pysqlite license, a test based on the test case in issue996, and a one-line fix for issue996.  lib-python/2.7/test/test_sqlite.py still passes after the change.

Added an assert to the new test, which previously just looked for exceptions.

Updated list of changes:

fd6e2144e652 by David Ripton: "Add an assert, as requested by Alex."
80014f10414c by David Ripton: "Do not call statement.reset() after executing DDL.

Fixes issue996."
6141b7352630 by David Ripton: "Failing test for issue 996"
01ed002a2b95 by David Ripton: "Add a comment making it clear this file is modified, for license compliance."
d49f44c4a62f by David Ripton: "Fix old-style raise statements (illegal in Python 3, ugly in Python 2)"
014a02a9d3df by David Ripton: "Remove unused local variables."
d39f5493dcaf by David Ripton: "Remove unused import."
3ed178fb213d by David Ripton: "Remove unreachable statement referring to nonexistant variable."


--
This is an issue notification from bitbucket.org.
You are receiving this either because you are the participating
in a pull request, or you are following it.



More information about the pypy-commit mailing list