[pypy-commit] pypy virtual-arguments: the test is actually worthless, because it cannot test the actually interesting cases about constant length-kwargs

cfbolz noreply at buildbot.pypy.org
Mon Apr 16 11:46:34 CEST 2012


Author: Carl Friedrich Bolz <cfbolz at gmx.de>
Branch: virtual-arguments
Changeset: r54395:47edb5fb8a13
Date: 2012-04-14 11:09 +0200
http://bitbucket.org/pypy/pypy/changeset/47edb5fb8a13/

Log:	the test is actually worthless, because it cannot test the actually
	interesting cases about constant length-kwargs

diff --git a/pypy/interpreter/test/test_argument.py b/pypy/interpreter/test/test_argument.py
--- a/pypy/interpreter/test/test_argument.py
+++ b/pypy/interpreter/test/test_argument.py
@@ -322,19 +322,6 @@
             assert l == [1, 2, 3, {'d': 4}]
             assert isinstance(l[-1], kwargsdict)
 
-    def test_match_kwds_creates_kwdict(self):
-        space = DummySpace()
-        kwds = [("c", 3), ('d', 4)]
-        for i in range(4):
-            kwds_w = dict(kwds[:i])
-            keywords = kwds_w.keys()
-            keywords_w = kwds_w.values()
-            w_kwds = dummy_wrapped_dict(kwds[i:])
-            if i == 3:
-                w_kwds = None
-            args = Arguments(space, [1, 2], keywords, keywords_w, w_starstararg=w_kwds)
-            assert args._dont_jit == (i != 3)
-
     def test_duplicate_kwds(self):
         space = DummySpace()
         excinfo = py.test.raises(OperationError, Arguments, space, [], ["a"],


More information about the pypy-commit mailing list