[pypy-commit] pypy default: refactor to not increment two counters

gutworth noreply at buildbot.pypy.org
Fri Jul 29 21:17:43 CEST 2011


Author: Benjamin Peterson <benjamin at python.org>
Branch: 
Changeset: r46097:54515dec1d20
Date: 2011-07-29 14:17 -0500
http://bitbucket.org/pypy/pypy/changeset/54515dec1d20/

Log:	refactor to not increment two counters

diff --git a/pypy/rpython/lltypesystem/rbuilder.py b/pypy/rpython/lltypesystem/rbuilder.py
--- a/pypy/rpython/lltypesystem/rbuilder.py
+++ b/pypy/rpython/lltypesystem/rbuilder.py
@@ -93,23 +93,21 @@
 
     @staticmethod
     def ll_append_multiple_char(ll_builder, char, times):
-        used = ll_builder.used
-        if times + used > ll_builder.allocated:
+        use = ll_builder.used + times
+        if use > ll_builder.allocated:
             ll_builder.grow(ll_builder, times)
-        for i in range(times):
-            ll_builder.buf.chars[used] = char
-            used += 1
-        ll_builder.used = used
+        for i in range(ll_builder.used, use):
+            ll_builder.buf.chars[i] = char
+        ll_builder.used = use
 
     @staticmethod
     def ll_append_charpsize(ll_builder, charp, size):
-        used = ll_builder.used
-        if used + size > ll_builder.allocated:
+        use = ll_builder.used + size
+        if use > ll_builder.allocated:
             ll_builder.grow(ll_builder, size)
-        for i in xrange(size):
-            ll_builder.buf.chars[used] = charp[i]
-            used += 1
-        ll_builder.used = used
+        for i in xrange(ll_builder.used, use):
+            ll_builder.buf.chars[i] = charp[i]
+        ll_builder.used = use
 
     @staticmethod
     def ll_getlength(ll_builder):


More information about the pypy-commit mailing list