[pypy-svn] buildbot default: turn get_commits into a global

[RonnyPfannschmidt]

Author: Ronny Pfannschmidt <Ronny.Pfannschmidt at gmx.de>
Branch: 
Changeset: r456:847d5d247e9a
Date: 2011-04-18 19:15 +0200
http://bitbucket.org/pypy/buildbot/changeset/847d5d247e9a/

Log:	turn get_commits into a global

diff --git a/bitbucket_hook/hook.py b/bitbucket_hook/hook.py
--- a/bitbucket_hook/hook.py
+++ b/bitbucket_hook/hook.py
@@ -95,23 +95,21 @@
     return local_repo.check(dir=True)
 
 
+def get_commits(service, payload):
+    #XXX: service is evil, get rid
+    import operator
+    commits = sorted(payload['commits'],
+                     key=operator.itemgetter('revision'))
+    for commit in commits:
+        node = commit['raw_node']
+        key = service, node
+        if key in seen_nodes:
+            continue
+        seen_nodes.add(key)
+        yield commit
+
+
 class BitbucketHookHandler(object):
-    Popen, PIPE = Popen, PIPE
-
-
-    def get_commits(self, service, payload):
-        import operator
-        commits = sorted(self.payload['commits'],
-                         key=operator.itemgetter('revision'))
-        for commit in commits:
-            node = commit['raw_node']
-            key = service, node
-            if key in seen_nodes:
-                continue
-            seen_nodes.add(key)
-            yield commit
-
-
 
     SMTP = smtplib.SMTP
     def send(self, from_, to, subject, body, test=False):
@@ -154,7 +152,7 @@
     USE_COLOR_CODES = True
     LISTFILES = False
     def handle_irc_message(self, test=False):
-        commits = self.get_commits('irc', self.payload)
+        commits = get_commits('irc', self.payload)
         if test:
             print "#" * 20
             print "IRC messages:"
@@ -189,7 +187,7 @@
             self.send_irc_message(irc_msg, test)
 
     def handle_diff_email(self, test=False):
-        commits = self.get_commits('email', self.payload)
+        commits = get_commits('email', self.payload)
         for commit in commits:
             self.send_diff_for_commit(commit, test)