[pypy-svn] r76522 - in pypy/branch/fast-ctypes/pypy/jit: backend/x86 codewriter metainterp

getxsick at codespeak.net getxsick at codespeak.net
Sat Aug 7 19:01:52 CEST 2010


Author: getxsick
Date: Sat Aug  7 19:01:50 2010
New Revision: 76522

Modified:
   pypy/branch/fast-ctypes/pypy/jit/backend/x86/regalloc.py
   pypy/branch/fast-ctypes/pypy/jit/codewriter/heaptracker.py
   pypy/branch/fast-ctypes/pypy/jit/metainterp/resoperation.py
Log:
add XXX comments to hacks added in r76520


Modified: pypy/branch/fast-ctypes/pypy/jit/backend/x86/regalloc.py
==============================================================================
--- pypy/branch/fast-ctypes/pypy/jit/backend/x86/regalloc.py	(original)
+++ pypy/branch/fast-ctypes/pypy/jit/backend/x86/regalloc.py	Sat Aug  7 19:01:50 2010
@@ -637,7 +637,7 @@
 
     def consider_call_assembler(self, op, guard_op):
         portal_calldescr = self.assembler.cpu.portal_calldescr
-        assert portal_calldescr is not None
+        assert portal_calldescr is not None # XXX is it correct?
         size = portal_calldescr.get_result_size(self.translate_support_code)
         #
         descr = op.descr

Modified: pypy/branch/fast-ctypes/pypy/jit/codewriter/heaptracker.py
==============================================================================
--- pypy/branch/fast-ctypes/pypy/jit/codewriter/heaptracker.py	(original)
+++ pypy/branch/fast-ctypes/pypy/jit/codewriter/heaptracker.py	Sat Aug  7 19:01:50 2010
@@ -85,7 +85,7 @@
         # This is necessary because the 'vtables' are just pointers to
         # static data, so they can't be used as keys in prebuilt dicts.
         d = cpu._vtable_to_descr_dict
-        assert d is not None
+        assert d is not None # XXX this is wrong
         if d is None:
             d = cpu._vtable_to_descr_dict = {}
             for descr in cpu._all_size_descrs_with_vtable:

Modified: pypy/branch/fast-ctypes/pypy/jit/metainterp/resoperation.py
==============================================================================
--- pypy/branch/fast-ctypes/pypy/jit/metainterp/resoperation.py	(original)
+++ pypy/branch/fast-ctypes/pypy/jit/metainterp/resoperation.py	Sat Aug  7 19:01:50 2010
@@ -5,7 +5,7 @@
     """The central ResOperation class, representing one operation."""
 
     # for 'guard_*'
-    fail_args = []
+    fail_args = [] # XXX is it correct?
 
     # debug
     name = ""



More information about the Pypy-commit mailing list