[pypy-svn] r64932 - pypy/branch/pyjitpl5/pypy/jit/metainterp

[arigo at codespeak.net]

Author: arigo
Date: Fri May  1 12:14:55 2009
New Revision: 64932

Modified:
   pypy/branch/pyjitpl5/pypy/jit/metainterp/history.py
Log:
Revert the (accidental?) disabling of check_descr().
Add a comment "don't do that".


Modified: pypy/branch/pyjitpl5/pypy/jit/metainterp/history.py
==============================================================================
--- pypy/branch/pyjitpl5/pypy/jit/metainterp/history.py	(original)
+++ pypy/branch/pyjitpl5/pypy/jit/metainterp/history.py	Fri May  1 12:14:55 2009
@@ -588,7 +588,6 @@
         raise NotImplementedError
 
 class History(RunningMatcher):
-    
     extratext = ''
     def record(self, opnum, argboxes, resbox, descr=None):
         op = ResOperation(opnum, argboxes, resbox, descr)
@@ -698,7 +697,8 @@
     _about_ = check_descr
 
     def compute_result_annotation(self, s_x):
-        return
+        # Failures here mean that 'descr' is not correctly an AbstractDescr.
+        # Please don't check in disabling of this test!
         from pypy.annotation import model as annmodel
         if not annmodel.s_None.contains(s_x):
             assert isinstance(s_x, annmodel.SomeInstance)