[pypy-svn] r50298 - pypy/dist/pypy/rpython/memory/gc

arigo at codespeak.net arigo at codespeak.net
Thu Jan 3 20:46:13 CET 2008


Author: arigo
Date: Thu Jan  3 20:46:13 2008
New Revision: 50298

Modified:
   pypy/dist/pypy/rpython/memory/gc/base.py
Log:
Update a comment with an "XXX maybe that's wrong after all"


Modified: pypy/dist/pypy/rpython/memory/gc/base.py
==============================================================================
--- pypy/dist/pypy/rpython/memory/gc/base.py	(original)
+++ pypy/dist/pypy/rpython/memory/gc/base.py	Thu Jan  3 20:46:13 2008
@@ -161,6 +161,12 @@
         # more non-prebuild GC objects; this is fine because the
         # internal GC ptr in the prebuilt list or dict is found by
         # gctypelayout and listed in addresses_of_static_ptrs.
+
+        # XXX I'm not sure any more about the warning above.  The fields
+        # of 'self' are found by gctypelayout and added to
+        # addresses_of_static_ptrs_in_nongc, so in principle they could
+        # be mutated and still be found by collect().
+
         self.wr_to_objects_with_id = []
         self.object_id_dict = {}
         self.object_id_dict_ends_at = 0



More information about the Pypy-commit mailing list