[pypy-svn] r32189 - in pypy/dist/pypy/module: _md5 _random _ssl bz2 mmap rctime

arigo at codespeak.net arigo at codespeak.net
Mon Sep 11 21:46:08 CEST 2006


Author: arigo
Date: Mon Sep 11 21:46:06 2006
New Revision: 32189

Modified:
   pypy/dist/pypy/module/_md5/__init__.py
   pypy/dist/pypy/module/_random/__init__.py
   pypy/dist/pypy/module/_ssl/__init__.py
   pypy/dist/pypy/module/bz2/__init__.py
   pypy/dist/pypy/module/mmap/__init__.py
   pypy/dist/pypy/module/rctime/__init__.py
Log:
Marked 5 modules with py.test.skip() because they are entierely
unreviewed and have some clear problems.  The idea is to prevent people
from trying to include them into a pypy-c and be under the illusion that
it will work.  I'll open an issue pointing to the REVIEWME and the
FINISHME...



Modified: pypy/dist/pypy/module/_md5/__init__.py
==============================================================================
--- pypy/dist/pypy/module/_md5/__init__.py	(original)
+++ pypy/dist/pypy/module/_md5/__init__.py	Mon Sep 11 21:46:06 2006
@@ -1,3 +1,7 @@
+import py         # FINISHME - well, STARTME
+py.test.skip("The _md5 module is not implemented at all. "
+             "Only the app-level md5 module works so far.")
+
 from pypy.interpreter.mixedmodule import MixedModule
 
 class Module(MixedModule):
@@ -7,4 +11,4 @@
     # constants / module definitions
     'digest_size'   : 'space.wrap(16)',
     'new'           : 'interp_md5.new_md5',
-    'md5'           : 'interp_md5.new_md5'}
\ No newline at end of file
+    'md5'           : 'interp_md5.new_md5'}

Modified: pypy/dist/pypy/module/_random/__init__.py
==============================================================================
--- pypy/dist/pypy/module/_random/__init__.py	(original)
+++ pypy/dist/pypy/module/_random/__init__.py	Mon Sep 11 21:46:06 2006
@@ -1,3 +1,7 @@
+import py             # FINISHME
+py.test.skip("The _random module is not ready: it misses the post-2.2 parts of "
+             "the interface and it needs to use new Mersenne Twister algorithm.")
+
 from pypy.interpreter.mixedmodule import MixedModule
 
 class Module(MixedModule):
@@ -29,4 +33,4 @@
         'weibullvariate'  : 'interp_random.get_random_method(space, "weibullvariate")',
         'whseed'          : 'interp_random.get_random_method(space, "whseed")', # officially obsolete
         }
-    
\ No newline at end of file
+    

Modified: pypy/dist/pypy/module/_ssl/__init__.py
==============================================================================
--- pypy/dist/pypy/module/_ssl/__init__.py	(original)
+++ pypy/dist/pypy/module/_ssl/__init__.py	Mon Sep 11 21:46:06 2006
@@ -1,3 +1,7 @@
+import py               # FINISHME - more thinking needed
+py.test.skip("The _ssl module is only usable when running on the exact "
+             "same platform from which the ssl.py was computed.")
+
 # This module is imported by socket.py. It should *not* be used
 # directly.
 from pypy.interpreter.mixedmodule import MixedModule

Modified: pypy/dist/pypy/module/bz2/__init__.py
==============================================================================
--- pypy/dist/pypy/module/bz2/__init__.py	(original)
+++ pypy/dist/pypy/module/bz2/__init__.py	Mon Sep 11 21:46:06 2006
@@ -1,3 +1,4 @@
+# REVIEWME
 from pypy.interpreter.mixedmodule import MixedModule
 
 class Module(MixedModule):

Modified: pypy/dist/pypy/module/mmap/__init__.py
==============================================================================
--- pypy/dist/pypy/module/mmap/__init__.py	(original)
+++ pypy/dist/pypy/module/mmap/__init__.py	Mon Sep 11 21:46:06 2006
@@ -14,6 +14,11 @@
     }
     
     def buildloaders(cls):
+        import py            # REVIEWME
+        py.test.skip("The mmap module is not ready: many methods do far too "
+                     "much copying, and it uses 'pythonapi', which makes it "
+                     "not translatable.")
+
         from pypy.module.mmap import interp_mmap
         import os
 

Modified: pypy/dist/pypy/module/rctime/__init__.py
==============================================================================
--- pypy/dist/pypy/module/rctime/__init__.py	(original)
+++ pypy/dist/pypy/module/rctime/__init__.py	Mon Sep 11 21:46:06 2006
@@ -19,6 +19,12 @@
     }
 
     def buildloaders(cls):
+        import py              # REVIEWME
+        py.test.skip("The rctime module is not ready: the checks on the input "
+                     "arguments are incomplete; strftime() can eat all your "
+                     "memory in error conditions; the use of math.fmod() "
+                     "should be removed.")
+
         from pypy.module.rctime import interp_time
         import os
         



More information about the Pypy-commit mailing list