[Patches] [ python-Patches-1691032 ] Migrate test_minidom.py to unittest

[SourceForge.net]

Patches item #1691032, was opened at 2007-03-30 00:15
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1691032&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Library (Lib)
Group: Python 2.6
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jason Orendorff (jorend)
Assigned to: Nobody/Anonymous (nobody)
Summary: Migrate test_minidom.py to unittest

Initial Comment:
Update Lib/test/test_minidom.py to use the unittest module.

Also:  I noticed the test_minidom.py contains some code (now long dead) to check for reference cycles.  The code is active only when Node.allnodes exists; this hasn't existed for over four years now.

After re-implementing that test using gc.DEBUG_SAVEALL, I found that many tests failed because of missing unlink() calls.  I added them.

After that, one test was still failing.  This is because expatbuilder.parseString() and friends do not clean up some cyclic references on error.  The patch includes a fix for that (in Lib/xml/dom/expatbuilder.py).  An alternative would be to ditch the cycle-checking test entirely.  I can submit a patch that does that instead, if desired.




----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1691032&group_id=5470