[Patches] [ python-Patches-1462488 ] Patch for bug #931877 Segfault in object_reduce_ex

[SourceForge.net]

Patches item #1462488, was opened at 2006-04-01 02:30
Message generated for change (Comment added) made by zseil
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1462488&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core (C code)
Group: None
>Status: Closed
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Žiga Seilnacht (zseil)
Assigned to: Žiga Seilnacht (zseil)
Summary: Patch for bug #931877  Segfault in object_reduce_ex

Initial Comment:
This prevents unbounded recursion in typeobject.c's
object_reduce_ex(). It does so by splitting
implementation for object.__reduce_ex__ and
object.__reduce__ into two different C functions.
See the apended file details.txt for more detailed
explanation.

----------------------------------------------------------------------

>Comment By: Žiga Seilnacht (zseil)
Date: 2007-03-15 12:51

Message:
Logged In: YES 
user_id=1326842
Originator: YES

Commited as revision 54397, 54398 (2.5).

----------------------------------------------------------------------

Comment By: Georg Brandl (gbrandl)
Date: 2007-03-15 00:08

Message:
Logged In: YES 
user_id=849994
Originator: NO

Looks good to me -- as you say, there shouldn't be any behavioral
differences.

----------------------------------------------------------------------

Comment By: Žiga Seilnacht (zseil)
Date: 2007-03-14 17:52

Message:
Logged In: YES 
user_id=1326842
Originator: YES

I would like to backport this patch to the 2.5 branch
so I made a new wersion that is fully backwards compatible
(well, except for the segfault :). Georg, could you please
take another look? And thanks for all the reviews, I can
hardly keep up :).
File Added: typeobject_reduce_2.diff

----------------------------------------------------------------------

Comment By: Georg Brandl (gbrandl)
Date: 2007-03-13 21:17

Message:
Logged In: YES 
user_id=849994
Originator: NO

I think this patch is fine, but you should include at least some of the
detailed description as a comment for the new reduce method.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1462488&group_id=5470