[Patches] [ python-Patches-1542451 ] fix crash with continue in nested try/finally

[SourceForge.net]

Patches item #1542451, was opened at 2006-08-18 00:27
Message generated for change (Comment added) made by nnorwitz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1542451&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Parser/Compiler
Group: Python 2.5
Status: Closed
Resolution: Fixed
Priority: 7
Private: No
Submitted By: Neal Norwitz (nnorwitz)
Assigned to: Nobody/Anonymous (nobody)
Summary: fix crash with continue in nested try/finally

Initial Comment:
Based on mail from python-dev.

http://mail.python.org/pipermail/python-dev/2006-August/068306.html

def test():
   for abc in range(10):
       try: pass
       finally:
           try:
               continue
           except:
               pass

crashes.

----------------------------------------------------------------------

>Comment By: Neal Norwitz (nnorwitz)
Date: 2007-03-05 00:28

Message:
Logged In: YES 
user_id=33168
Originator: YES

The bug was fixed after 2.5 was released.  The fix is in SVN currently and
will be part of the 2.5.1 release.

----------------------------------------------------------------------

Comment By: Viktor Ferenczi (complex)
Date: 2007-03-04 15:21

Message:
Logged In: YES 
user_id=142612
Originator: NO

Example code crashes Python 2.5 (r25:51908, Sep 19 2006, 09:52:17) [MSC
v.1310 32 bit (Intel)], but this bug is closed as fixed. Is this OK? (Maybe
I missed something, but this bug still exists...)

----------------------------------------------------------------------

Comment By: Georg Brandl (gbrandl)
Date: 2006-10-08 00:06

Message:
Logged In: YES 
user_id=849994

Committed rev. 52220 in 2.5 branch. Closing now.

----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2006-10-07 17:49

Message:
Logged In: YES 
user_id=33168

Georg, if you don't mind doing this, I think it's fine to go
into 2.5.1.  I'll try to get around to it at some point if not.

----------------------------------------------------------------------

Comment By: Georg Brandl (gbrandl)
Date: 2006-09-30 01:48

Message:
Logged In: YES 
user_id=849994

Time to checkin for 2.5.1?

----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2006-08-21 12:48

Message:
Logged In: YES 
user_id=33168

Committed revision 51439. (2.6)

Thomas Wouters thinks this is fine to go in 2.5.  I'll leave
open for now until we decide what to do.


----------------------------------------------------------------------

Comment By: Thomas Wouters (twouters)
Date: 2006-08-21 12:37

Message:
Logged In: YES 
user_id=34209

I think we should just check this in in 2.5.0. It looks
fine, it's the simple and correct fix, and I don't see how
it could break legitimate code. It's not a complex piece of
code.

----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2006-08-19 08:08

Message:
Logged In: YES 
user_id=33168

I've been thinking similarly.  I didn't even update the
import magic for this.

Did you get a chance to review the patch?  It would be nice
to get this into 2.6 and then we can figure out if this
should go into 2.5.0 (probably not) or 2.5.1 (probably in my
current thinking), or just leave it for 2.6.

----------------------------------------------------------------------

Comment By: Armin Rigo (arigo)
Date: 2006-08-19 01:04

Message:
Logged In: YES 
user_id=4771

My two cents are a meta-note: I think that this should not go
into 2.5.0.  It fixes a bug with syntactically invalid
code, which nobody stumbled upon until recently although
it has been here for ages, and there is a (small) risk to
break syntactically valid code.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1542451&group_id=5470