[Patches] [ python-Patches-1686273 ] More PEP 3116 classes

SourceForge.net noreply at sourceforge.net
Fri Apr 6 19:34:33 CEST 2007


Patches item #1686273, was opened at 2007-03-22 14:18
Message generated for change (Comment added) made by gvanrossum
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1686273&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Library (Lib)
Group: Python 3000
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Mark Russell (mark_t_russell)
Assigned to: Nobody/Anonymous (nobody)
Summary: More PEP 3116 classes

Initial Comment:
More PEP 3116 implementation:

   - docstrings for RawIOBase methods

   - Simple implementations of StringIO, TextIOBase and TextIOWrapper

   - Simplify while condition in BufferedReader.read()

   - Add unit tests for StringIO (modified copy of the ByteIO tests)


----------------------------------------------------------------------

>Comment By: Guido van Rossum (gvanrossum)
Date: 2007-04-06 13:34

Message:
Logged In: YES 
user_id=6380
Originator: NO

The code patches are checked in too, with some cleanup applied.  I rolled
back your change to codecs.py, as it broke test_codecs.py; instead, I added
an ugly hack where we patch the codec after it's been created.

I'll be working more on this code soon, I expect.  Stay tuned -- and
thanks for your work!  (Technically, the PSF needs a contribution form from
you, see http://www.python.org/psf/contrib/.)

----------------------------------------------------------------------

Comment By: Guido van Rossum (gvanrossum)
Date: 2007-04-05 14:26

Message:
Logged In: YES 
user_id=6380
Originator: NO

I'm finally getting to this.  Sorry for my tardiness!

I've started by applying the PEP patch.  Now reviewing the code patch...

----------------------------------------------------------------------

Comment By: Mark Russell (mark_t_russell)
Date: 2007-03-24 18:46

Message:
Logged In: YES 
user_id=1017234
Originator: YES

File Added: pep-3116-pep.diff

----------------------------------------------------------------------

Comment By: Mark Russell (mark_t_russell)
Date: 2007-03-24 18:34

Message:
Logged In: YES 
user_id=1017234
Originator: YES

More changes:

   - Make TextIOWrapper.readline() reasonably efficient

   - Fix TextIOWrapper.read()

   - Unit tests for TextIOWrapper .readline() and .read() (more needed)

   - Readahead support for BufferedReader (i.e. so it reads in buffer size
chunks)

   - Fix codecs.BufferedIncrementalDecoder buffer type (bytes not str)

   - Unit test to check the raw reads that BufferedReader is doing

   - Fix BufferedRandom positioning bug when switching from reading to
writing
File Added: pep-3116-textio.diff

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1686273&group_id=5470


More information about the Patches mailing list