[Patches] [ python-Patches-1583506 ] tarfile.py: 100-char filenames are truncated

SourceForge.net noreply at sourceforge.net
Tue Oct 24 18:54:41 CEST 2006


Patches item #1583506, was opened at 2006-10-24 11:21
Message generated for change (Comment added) made by gbrandl
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1583506&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Library (Lib)
Group: Python 2.6
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Lars Gustäbel (gustaebel)
Assigned to: Nobody/Anonymous (nobody)
Summary: tarfile.py: 100-char filenames are truncated

Initial Comment:
Patch #1484695 applied with rev 45954 introduced an
error in the creation of string header fields. The
stn() function used to zero-pad strings assumes that a
string to be put in an N character field, can be at
most N-1 chars long plus a '\0' char. This is wrong. An
N char field can store a N char string, the '\0' is
left out in this case.
The worst effect of this bug is that filenames that are
exactly 100 chars long will be silently truncated to 99
chars. Python 2.5 and 2.6 are affected.

Attached patch fixes the stn() function and adds a
testcase to test_tarfile.py.

----------------------------------------------------------------------

>Comment By: Georg Brandl (gbrandl)
Date: 2006-10-24 16:54

Message:
Logged In: YES 
user_id=849994

Applied in rev. 52431, 52432 (2.5).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1583506&group_id=5470


More information about the Patches mailing list