[Patches] [ python-Patches-1576954 ] Fix VC6 build, remove redundant files for VC7 build

[SourceForge.net]

Patches item #1576954, was opened at 2006-10-14 02:09
Message generated for change (Comment added) made by loewis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1576954&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Build
Group: Python 2.6
Status: Open
Resolution: None
Priority: 5
Submitted By: Larry Hastings (lhastings)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fix VC6 build, remove redundant files for VC7 build

Initial Comment:
The VC6 build for pythoncore (PC/VC6/pythoncore.dsp) was shipped broken in 2.5.  This fixes it, as well as updating it for Python 2.6, and you can now once again produce python.exe (and python_d.exe) using VC6.  (This fix could easily be backported to 2.5; I would be happy to submit that separately.)

The VC7 build for pythoncore (PCBuild/pythoncore.vcproj) has two instances of "sha512module.c" and "signalmodule.c".  While this is harmless, it is also totally unnecessary.  The only change was to remove those two files.

I built all four exes (python|python_d built with vc6|vc7) and ran the regression tests on them.  They passed all expected tests except for the four modules I didn't build (tcl, sqlite, bz2, and bsddb).

The patch is in the form of a zip file containing the build files themselves rather than a patch.  This is because PC/VC6/pythoncore.dsp is marked as a binary file in svn, so "svn diff" declined to produce a good diff.  I'm not sure *why* the file is marked this way; perhaps it's overly sensitive to EOL conventions?  Anyway, I thought it best to honor this, and it was simpler to submit both as a single zip than as a zip and a patch, so here you are.

----------------------------------------------------------------------

>Comment By: Martin v. Löwis (loewis)
Date: 2006-10-14 21:49

Message:
Logged In: YES 
user_id=21627

The file is marked binary because it was that way in CVS; it
was binary in CVS because not making it binary would cause a
Unix checkout to use Unix EOL (i.e. LF only). That, in turn
would cause VC to reject the files. Since the release
tarball is made on Unix, it would have cause the released
version not to build with VC.

Patching over the entire file is fine in this case. Please
indicate the base revision you had been using. For
pythoncore.vcproj, svn should allow you to create a patch,
though.

Also, please do provide a backport for 2.5; I will then
apply them all simultaneously (or shortly after another).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1576954&group_id=5470