[Patches] [ python-Patches-1572724 ] typo in PC/_msi.c

[SourceForge.net]

Patches item #1572724, was opened at 2006-10-07 13:17
Message generated for change (Comment added) made by gbrandl
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1572724&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core (C code)
Group: Python 2.5
Status: Open
Resolution: None
Priority: 5
Submitted By: jose nazario (jnazario)
>Assigned to: Martin v. Löwis (loewis)
Summary: typo in PC/_msi.c

Initial Comment:
basic typo in PC/_msi.c, assignment vs comparison (fat
fingered?)

not sure of the implications, but it looks like more of
a relibility fix than anything. 

--- PC/_msi.c.orig      Sat Oct  7 09:12:46 2006
+++ PC/_msi.c   Sat Oct  7 09:12:59 2006
@@ -495,7 +495,7 @@
 
     status = MsiSummaryInfoGetProperty(si->h, field,
&type, &ival, 
        &fval, sval, &ssize);
-    if (status = ERROR_MORE_DATA) {
+    if (status == ERROR_MORE_DATA) {
        sval = malloc(ssize);
         status = MsiSummaryInfoGetProperty(si->h,
field, &type, &ival, 
            &fval, sval, &ssize);

----------------------------------------------------------------------

>Comment By: Georg Brandl (gbrandl)
Date: 2006-10-07 13:22

Message:
Logged In: YES 
user_id=849994

Assigning to Martin.

----------------------------------------------------------------------

Comment By: jose nazario (jnazario)
Date: 2006-10-07 13:17

Message:
Logged In: YES 
user_id=350099

PS: verified this is also present in the latest SVN repository. 

http://svn.python.org/view/python/trunk/PC/_msi.c?rev=42848&view=markup

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1572724&group_id=5470