[Patches] [ python-Patches-1360200 ] bdist_rpm still can't handle dashes in versions

[SourceForge.net]

Patches item #1360200, was opened at 2005-11-18 16:41
Message generated for change (Comment added) made by loewis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1360200&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Distutils and setup.py
Group: Python 2.6
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: jared jennings (sarynx)
Assigned to: Sean Reifschneider (jafo)
Summary: bdist_rpm still can't handle dashes in versions

Initial Comment:
I tried to use Python 2.4.2 to create a bdist_rpm of
setuptools, whose version string was 0.6a9dev-r41475.
The distutils/command/bdist_rpm module's
_make_spec_file method mangled the version to
0.6a9dev_r41475 (line 370). Then when the spec file was
being built by rpmbuild, it looked for the sdist named
setuptools-0.6a9dev_r41475.tar.gz, which didn't exist:
it was called setuptools-0.6a9dev-r41475.tar.gz (note
dash). 

So you have to mangle the version to make rpm happy -
but you can't expect the sdist to have the mangled
version as part of its name.

I looked at the nightly Python source as of 17 Nov 2005
and saw that this bug still exists in the development
version of Python.

A patch is attached which fixed this bug for me.


----------------------------------------------------------------------

>Comment By: Martin v. Löwis (loewis)
Date: 2006-11-12 19:56

Message:
Logged In: YES 
user_id=21627

Thanks for the patch. Committed as r52741 and r52742

----------------------------------------------------------------------

Comment By: Sean Reifschneider (jafo)
Date: 2006-09-03 01:25

Message:
Logged In: YES 
user_id=81797

This patch looks good to me.  I checked in python-trunk and
it still seems to need to be fixed.  I'd recommend it gets
checked in for the 2.6 release.  I'd like one of the
distutils people to confirm this though.

----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2005-11-21 03:17

Message:
Logged In: YES 
user_id=33168

Sean, you seem to know a lot more about rpms than most of
us.  Any comment on this approach?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1360200&group_id=5470