[Patches] [ python-Patches-1589070 ] MacPython Build Installer - Typos and Style corrections
SourceForge.net
noreply at sourceforge.net
Tue Nov 7 16:37:24 CET 2006
Patches item #1589070, was opened at 2006-11-02 06:44
Message generated for change (Comment added) made by ronaldoussoren
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1589070&group_id=5470
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Macintosh
Group: None
Status: Open
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Humberto Diógenes (virtualspirit)
Assigned to: Ronald Oussoren (ronaldoussoren)
Summary: MacPython Build Installer - Typos and Style corrections
Initial Comment:
* Corrected many typos (such as "IDLE is an IDLE" instead of "IDLE is an
IDE");
* Simplified SRCDIR guessing;
* PEP8 style;
Includes patch #1589013 ("Univeral" MacPython).
----------------------------------------------------------------------
>Comment By: Ronald Oussoren (ronaldoussoren)
Date: 2006-11-07 16:37
Message:
Logged In: YES
user_id=580910
The change to SRCDIR looks bogus and even if it works I find the current version more readable. That will definitely not go in.
I will apply the typo fixes, and may do the same with the style changes.
BTW. Humberto, it would be better to split the formatting changes from functional changes in future patches. We now had to hunt down the
patch fragments that weren't formatting changes. Anyway, thanks for the patch.
----------------------------------------------------------------------
Comment By: Jack Jansen (jackjansen)
Date: 2006-11-02 13:51
Message:
Logged In: YES
user_id=45365
Ronald, aside from a number of typo fixes (it took me 5 minutes to see that there's an "s" missing in "Univeral MacPython" :-) there's also some
changes in the logic; those probably need some eyeballing over (the changes to SRCDIR look a bit suspect).
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1589070&group_id=5470
More information about the Patches
mailing list