[Patches] [ python-Patches-1519796 ] Fix for #1513611 and #1511497; xml.sax imports

[SourceForge.net]

Patches item #1519796, was opened at 2006-07-10 09:32
Message generated for change (Comment added) made by zseil
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1519796&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: XML
Group: Python 2.5
>Status: Closed
>Resolution: Invalid
Priority: 5
Submitted By: Žiga Seilnacht (zseil)
Assigned to: Fred L. Drake, Jr. (fdrake)
Summary: Fix for #1513611 and #1511497; xml.sax imports

Initial Comment:
Package xmlcore.sax currently uses a mix of realtive
and absolute imports. This caused the following bugs:
http://python.org/sf/1513611
http://python.org/sf/1511497

This patch fixes it, by using relative imports.
I tried using absolute imports, but then some of
the tests in the attached test_xml_importing
module fail.

The tests are separate because I don't know how
to include setUp() and tearDown() methods into
non unittest based tests.

----------------------------------------------------------------------

>Comment By: Žiga Seilnacht (zseil)
Date: 2006-07-27 14:48

Message:
Logged In: YES 
user_id=1326842

The patch is extremely fragile and works only if you don't
mix objects from xml and xmlcore. As your test shows, it
breaks if you import 'make_parser' and 'SAXParseException'
from different packages.

As for the tests, the first four fail for me if I run them
as a script. They are not integrated into the test suite
since they are missing a test_main() function.

It seems that renaming xmlcore back to xml is the simplest
solution, so I'll just close this patch.


----------------------------------------------------------------------

Comment By: Fred L. Drake, Jr. (fdrake)
Date: 2006-07-27 05:17

Message:
Logged In: YES 
user_id=3066

These tests do not trigger any failures for me with the
current trunk, so I'm not sure what the patch is fixing.

I'm attaching a patch that includes tests cases for both of
the issues reportedly fixed by this patch.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2006-07-10 23:03

Message:
Logged In: YES 
user_id=21627

Assigning to Fred Drake, who introduced xmlcore.

----------------------------------------------------------------------

Comment By: Žiga Seilnacht (zseil)
Date: 2006-07-10 09:59

Message:
Logged In: YES 
user_id=1326842

Attaching a new patch and updated tests, since I missed
that make_parser() uses __import__().


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1519796&group_id=5470