[Patches] [ python-Patches-1307806 ] PCbuild vcproj project files need a cleanup

[SourceForge.net]

Patches item #1307806, was opened at 2005-09-29 12:08
Message generated for change (Comment added) made by loewis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1307806&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Build
Group: Python 2.4
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Adal Chiriliuc (adalx)
Assigned to: Nobody/Anonymous (nobody)
Summary: PCbuild vcproj project files need a cleanup

Initial Comment:
The Visual Studio .NET vcproj files were probably
generated by importing the older Visual C++ 6.0 dsp
files and saving them back into the new format. The
convertor is not perfect. The bigest problem it has
it's the handling of the configuration macro defines.
Instead of defining the used macros once for each
configuration, it defines them for each individual
file. This causes file bloat and could cause problems
when new files are added to the project since we could
get builds with mixed defines due to the $(NoInherit)
flag which makes the compiler ignore global defines.

For example, the current pythoncore.vcproj file has 100
KB. A cleaned up version is less than 25 KB.

NOW:
<File
	RelativePath="..\Parser\acceler.c">
	<FileConfiguration
		Name="Release|Win32">
		<Tool
			Name="VCCLCompilerTool"
			Optimization="2"
			AdditionalIncludeDirectories=""
		
PreprocessorDefinitions="NDEBUG;WIN32;_WINDOWS;USE_DL_EXPORT;$(NoInherit)"/>
	</FileConfiguration>
	<FileConfiguration
		Name="Debug|Win32">
		<Tool
			Name="VCCLCompilerTool"
			Optimization="0"
			AdditionalIncludeDirectories=""
		
PreprocessorDefinitions="_DEBUG;USE_DL_EXPORT;WIN32;_WINDOWS;$(NoInherit)"/>
	</FileConfiguration>
	<FileConfiguration
		Name="ReleaseItanium|Win32">
		<Tool
			Name="VCCLCompilerTool"
			Optimization="2"
			AdditionalIncludeDirectories=""
		
PreprocessorDefinitions="NDEBUG;WIN32;_WINDOWS;USE_DL_EXPORT;$(NoInherit)"/>
	</FileConfiguration>
</File>

CLEANED-UP:
<File
	RelativePath="..\Parser\acceler.c">
</File>

There are a couple of files which require custom options:

..\Modules\getbuildinfo.c - 					
PreprocessorDefinitions="BUILD=67"

..\PC\import_nt.c - 					
AdditionalIncludeDirectories="..\Python"


----------------------------------------------------------------------

>Comment By: Martin v. Löwis (loewis)
Date: 2006-01-03 08:40

Message:
Logged In: YES 
user_id=21627

Thanks for the patch. Committed as r41897.

If you have further simplifications that you would like to
see implemented, please submit another patch.

----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2005-10-04 05:47

Message:
Logged In: YES 
user_id=33168

Thanks.  I'm moving this to patches.

----------------------------------------------------------------------

Comment By: Adal Chiriliuc (adalx)
Date: 2005-10-03 23:32

Message:
Logged In: YES 
user_id=1067739

Attached patch with cleaned up .vcproj files.

VCCLCompilerTool: removed PrecompiledHeaderFile,
AssemblerListingLocation, ObjectFile,
ProgramDataBaseFileName entires. They are defined by default
to the same values.

VCMIDLTool: removed all entries.

VCResourceCompilerTool: removed all entries for all but a
couple of projects which actually have resource files.

Removed FileConfiguration entries for all project files
which don't need it.

There's still stuff which could be cleaned up, I've only
removed the biggest offenders.

----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2005-10-03 21:56

Message:
Logged In: YES 
user_id=33168

Can you provide a patch (attach to this bug report if
possible) for what the new file should look like?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1307806&group_id=5470