[Patches] [ python-Patches-970288 ] Fix for #876637 - Random stack corruption from socketmodule

[SourceForge.net]

Patches item #970288, was opened at 2004-06-10 04:13
Message generated for change (Comment added) made by nnorwitz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=970288&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Modules
>Group: Python 2.4
Status: Open
Resolution: None
Priority: 5
Submitted By: Troels Walsted Hansen (troels)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fix for #876637 - Random stack corruption from socketmodule

Initial Comment:
Here's a patch to convert socketmodule to use poll()
for the timeout handling.

ifdefs and includes have been copied from selectmodule,
so I believe they should be correct for all platforms.

Compiled and tested on Linux (RH73).


----------------------------------------------------------------------

>Comment By: Neal Norwitz (nnorwitz)
Date: 2006-02-06 23:18

Message:
Logged In: YES 
user_id=33168

A fix for the bug (sd over FD_SETSIZE) has been checked in.
 Note select is called in Modules/_ssl.c too.

----------------------------------------------------------------------

Comment By: Troels Walsted Hansen (troels)
Date: 2004-08-26 00:07

Message:
Logged In: YES 
user_id=32863

You're right, however I think that it is a very minor
problem compared to the current situation. All major UNIX
platforms support poll(2) in my experience. The only
important Python platform without poll is Windows, and it
doesn't have the FD_SETSIZE problem.

Thus I think the patch should be applied as it stands, but
the original bug ticket can be left open for another
enterprising individual to make the changes you suggest.

I'm afraid that work commitments prevent me from being that
individual for the foreseeable future...


----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2004-08-22 09:30

Message:
Logged In: YES 
user_id=21627

While the patch is good as it stands, it is also incomplete:
If poll(2) is not available, it might still overrun the
FD_SETSIZE. I think there should be another return value
from internal_select (-1), indicating an internal error. A
Python RuntimeError should be set in this case. Callers
should check for -1, and return immediately.

Are you willing to extend the patch in that direction?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=970288&group_id=5470