[Patches] [ python-Patches-1351997 ] fix for resource leak in _subprocess

[SourceForge.net]

Patches item #1351997, was opened at 2005-11-09 10:05
Message generated for change (Comment added) made by effbot
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1351997&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Modules
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Fredrik Lundh (effbot)
>Assigned to: Fredrik Lundh (effbot)
Summary: fix for resource leak in _subprocess

Initial Comment:
The _subprocess CreateProcess driver may leak if you
pass in an explicit environment dictionary.  This
trivial patch fixes this.

Can be backported to 2.3 and 2.4.

----------------------------------------------------------------------

>Comment By: Fredrik Lundh (effbot)
Date: 2005-11-12 11:26

Message:
Logged In: YES 
user_id=38376

MvL fixed my account, so I went ahead and checked this in.

This patch can be backported to all subprocess releases, but
I think the problem is relatively minor, so I won't do that now.

----------------------------------------------------------------------

Comment By: Fredrik Lundh (effbot)
Date: 2005-11-10 23:48

Message:
Logged In: YES 
user_id=38376

I've updated the patch to address #1346547 as well.

If you have the time, feel free to check this in.  I don't
have a
proper account set up yet (but I promise to fix that soon).

thanks /F

----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2005-11-10 06:53

Message:
Logged In: YES 
user_id=33168

/f did you want to check this in yourself?  I'm not sure if
you have an svn account or if you want one.  I can check it
in if you'd like.

See also bug #1346547.  There is another problem in this
area (lines 379/380) should check if an error occurred.  I
can't test this stuff, but if you test, I can check in.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1351997&group_id=5470