[Patches] [ python-Patches-1349118 ] Patch f. bug 495682 cannot handle http_proxy with user:pass@

[SourceForge.net]

Patches item #1349118, was opened at 2005-11-05 12:05
Message generated for change (Comment added) made by gvanrossum
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1349118&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Library (Lib)
Group: Python 2.5
Status: Open
Resolution: None
Priority: 5
Submitted By: Johannes Nicolai (jonico)
Assigned to: Nobody/Anonymous (nobody)
Summary: Patch f. bug 495682 cannot handle http_proxy with user:pass@

Initial Comment:
solves problems for http and https proxies described in 
this bug 
solves tracebacks if proxy is specified for a protocol 
where no proxy is currently supported 
added dynamic proxy authentification for http and https 
solved bug that if a host accessed by the https protocol 
requires authentification, the https proxy won't be used 
after questioning the password 

----------------------------------------------------------------------

>Comment By: Guido van Rossum (gvanrossum)
Date: 2005-12-13 11:47

Message:
Logged In: YES 
user_id=6380

The patch looks good as a fix for bug 495682.

I don't see which lines in the patch warrant the claim
"solves tracebacks if proxy is specified for a protocol
where no proxy is currently supported" -- can you explain this?

I'd like you to request validation (testing) from someone
else on python-dev who can actually run this code -- I have
no way to verify that it works as advertised.

----------------------------------------------------------------------

Comment By: Johannes Nicolai (jonico)
Date: 2005-11-07 05:27

Message:
Logged In: YES 
user_id=863272

Perhaps some words about the accuracy of the patch: 
I have successfully tested it with squid 2.5 and squid 3.0 as http 
and https proxy with and without password. 
I used the integrated test routines in urllib.py 

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1349118&group_id=5470