[Patches] [ python-Patches-975056 ] Signal fixes for BSD systems
SourceForge.net
noreply at sourceforge.net
Fri Oct 15 07:05:39 CEST 2004
Patches item #975056, was opened at 2004-06-17 19:05
Message generated for change (Comment added) made by kbk
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=975056&group_id=5470
Category: None
Group: None
Status: Closed
Resolution: Accepted
Priority: 5
Submitted By: Luke Mewburn (lukem)
Assigned to: Anthony Baxter (anthonybaxter)
Summary: Signal fixes for BSD systems
Initial Comment:
As documented in bug 969574, restartable signals are
not correctly disabled on BSD systems (e.g, NetBSD 2.0,
FreeBSD 4.8).
The attached patch is a more complete version of the
one I provided in that bug report, and it more closely
follows the patch submission guidelines (context
instead of unified diff, against python CVS instead of
python 2.3.4, ...). It also fixes:
* A few sections of the tree that weren't converted
from signal() to PyOS_setsig().
* There's no need to call siginterrupt() before
PyOS_setsig() in Module/signalmodule.c because
PyOS_setsig() handles that, and calling siginterrupt()
before changing a signal's handler (via
signal/sigaction) doesn't work correctly anyway; it
should have been called after.
I have compiled the source with and without
"--without-signal-module" and successfully run "make
test" on both cases.
Suggested NEWS entry:
===
Bug #969574: Restartable signals were not correctly
disabled on BSD systems. Consistently use PyOS_setsig()
instead of signal().
===
Cheers,
Luke.
----------------------------------------------------------------------
>Comment By: Kurt B. Kaiser (kbk)
Date: 2004-10-15 00:05
Message:
Logged In: YES
user_id=149084
OpenBSD 3.3 didn't exhibit the bug before the change.
It appears to be fine after the change, passes make test.
----------------------------------------------------------------------
Comment By: Luke Mewburn (lukem)
Date: 2004-10-14 22:53
Message:
Logged In: YES
user_id=135998
The latest version in CVS appears to work OK on NetBSD.
----------------------------------------------------------------------
Comment By: Anthony Baxter (anthonybaxter)
Date: 2004-10-13 09:56
Message:
Logged In: YES
user_id=29957
Applied. I've tried it on a bunch of systems I can get
access to - you (Luke) probably have more, so feel free to
grab CVS and try it out there.
----------------------------------------------------------------------
Comment By: Luke Mewburn (lukem)
Date: 2004-09-16 08:47
Message:
Logged In: YES
user_id=135998
Whilst NetBSD isn't the world's most common UNIX operating
system, FreeBSD 4.x is fairly widespread _and_ is affected
by the bug as well... :)
----------------------------------------------------------------------
Comment By: Michael Hudson (mwh)
Date: 2004-09-14 12:25
Message:
Logged In: YES
user_id=6656
The patch has bitrotted slightly. I'm attaching an updated
version.
It looks reasonable to me, though I'm officially leery of
checking in patches that affect platforms I can't test...
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=975056&group_id=5470
More information about the Patches
mailing list