[Patches] [ python-Patches-605370 ] nntplib: group descriptions and RFC2980

[SourceForge.net]

Patches item #605370, was opened at 2002-09-06 04:37
Message generated for change (Comment added) made by loewis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=605370&group_id=5470

Category: Library (Lib)
Group: Python 2.4
>Status: Closed
>Resolution: Accepted
Priority: 6
Submitted By: Jürgen A. Erhard (jae)
Assigned to: Martin v. Löwis (loewis)
Summary: nntplib: group descriptions and RFC2980

Initial Comment:
nntplib's NNTP.xgtitle() is deprecated by RFC2980.  And
some servers
(like leafnode) don't even know XGTITLE.

This adds two methods to NNTP, description and
descriptions.

NNTP.description just gets the description of one group
(and doesn't
return the server status code).

NNTP.descriptions does the same as xgtitle does now, but in
a more general, and RFC2980 compliant way.

It tries the RFC2980 way (LIST NEWSGROUPS) and if this
fails,
falls back to XGTITLE.

This patch also adds an new optional "groups" argument
to the
NNTP.list.  I thought it fitting to mirror the
"LIST/LIST NEWSGROUPS" in the method.

Feel free to kill this part, I'm not really attached to
it.  I do prefer description/descriptions, as they make
the code more self-documenting.

(If you insist: I'm on Debian GNU/Linux "sid",
python2.2.1... but the patch should apply cleanly
against CVS, doerwalter's checkin
shouldn't conflict)

----------------------------------------------------------------------

>Comment By: Martin v. Löwis (loewis)
Date: 2004-07-26 14:41

Message:
Logged In: YES 
user_id=21627

Thanks for the patch. Applied as 

libnntplib.tex 1.30
nntplib.py 1.38
ACKS 1.273
NEWS 1.1054


----------------------------------------------------------------------

Comment By: Jürgen A. Erhard (jae)
Date: 2004-07-26 05:17

Message:
Logged In: YES 
user_id=10380

Killed the change to the "list" method.

Removed old patch, added new patch, and a doc patch.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2002-10-13 15:08

Message:
Logged In: YES 
user_id=21627

Can you please provide documentation patches (for
libnntplib.tex) as well?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=605370&group_id=5470