[Patches] [ python-Patches-970288 ] Fix for #876637 - Random stack corruption from socketmodule

[SourceForge.net]

Patches item #970288, was opened at 2004-06-10 13:13
Message generated for change (Comment added) made by loewis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=970288&group_id=5470

Category: Modules
Group: Python 2.3
Status: Open
Resolution: None
Priority: 5
Submitted By: Troels Walsted Hansen (troels)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fix for #876637 - Random stack corruption from socketmodule

Initial Comment:
Here's a patch to convert socketmodule to use poll()
for the timeout handling.

ifdefs and includes have been copied from selectmodule,
so I believe they should be correct for all platforms.

Compiled and tested on Linux (RH73).


----------------------------------------------------------------------

>Comment By: Martin v. Löwis (loewis)
Date: 2004-08-22 18:30

Message:
Logged In: YES 
user_id=21627

While the patch is good as it stands, it is also incomplete:
If poll(2) is not available, it might still overrun the
FD_SETSIZE. I think there should be another return value
from internal_select (-1), indicating an internal error. A
Python RuntimeError should be set in this case. Callers
should check for -1, and return immediately.

Are you willing to extend the patch in that direction?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=970288&group_id=5470