[Patches] [ python-Patches-791706 ] POP3 over SSL support for poplib

[SourceForge.net]

Patches item #791706, was opened at 2003-08-20 05:53
Message generated for change (Comment added) made by mrbook
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=791706&group_id=5470

Category: Library (Lib)
Group: Python 2.3
Status: Open
Resolution: None
Priority: 5
Submitted By: Hector urtubia (mrbook)
Assigned to: Nobody/Anonymous (nobody)
Summary: POP3 over SSL support for poplib

Initial Comment:
This patch creates a class POP3_SSL which is a child of

POP3 on the poplib module.

This class is able to handle POP3 over SSL. It borrows

some code from IMAP_SSL.

----------------------------------------------------------------------

>Comment By: Hector urtubia (mrbook)
Date: 2003-09-11 01:11

Message:
Logged In: YES 
user_id=10927

I have added a patch for the documentation (lipoplibdoc-

1_0.patch) and have addressed most of the requests from 

the reviewer on newer patch revision (poplibssl-1_0.patch).



- Tabs and spaces issues fixed

- Fixed port on comment

- Data is now read on big chunks

- Unable to reuse base-claass __init__ because of parent's 

design issues.



Cheers.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2003-08-31 16:38

Message:
Logged In: YES 
user_id=21627

Can you please provide a patch for the documentation as well?



Please don't mix tabs and spaces; I recommend to run

reindent.py before producing the diff.



In the class comment, the default port is incorrect.



Please don't build up strings by adding one character at a

time, use [c]StringIO instead, or a list. Also consider

reading larger chunks of data a time, buffering extra data

in the class.



Try to reuse the base-class __init__.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=791706&group_id=5470