From noreply at sourceforge.net Wed Oct 1 02:03:11 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 1 02:03:16 2003 Subject: [Patches] [ python-Patches-813877 ] entry size for bsddb cursors Message-ID: Patches item #813877, was opened at 2003-09-27 22:55 Message generated for change (Settings changed) made by greg You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=813877&group_id=5470 Category: Modules Group: None Status: Open Resolution: None Priority: 5 Submitted By: Itamar Shtull-Trauring (itamar) >Assigned to: Gregory P. Smith (greg) Summary: entry size for bsddb cursors Initial Comment: If you store large entries in a database, there is currently no way to get their size without reading the whole thing into memory when using cursors. Knowing the length is useful for doing partial reads from a record. The patch adds a method get_current_size() that returns the length of the data in the current entry the cursor is pointing at. Implemented at the request of the Quotient developers (divmod.org). I have pybsddb cvs access so I can check in the docs there if/when this goes in to core python. (Patch is concatenated two files, hope it's ok.) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=813877&group_id=5470 From noreply at sourceforge.net Wed Oct 1 02:39:08 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 1 02:39:13 2003 Subject: [Patches] [ python-Patches-813877 ] entry size for bsddb cursors Message-ID: Patches item #813877, was opened at 2003-09-27 22:55 Message generated for change (Comment added) made by greg You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=813877&group_id=5470 Category: Modules >Group: Python 2.4 >Status: Pending Resolution: None Priority: 5 Submitted By: Itamar Shtull-Trauring (itamar) Assigned to: Gregory P. Smith (greg) Summary: entry size for bsddb cursors Initial Comment: If you store large entries in a database, there is currently no way to get their size without reading the whole thing into memory when using cursors. Knowing the length is useful for doing partial reads from a record. The patch adds a method get_current_size() that returns the length of the data in the current entry the cursor is pointing at. Implemented at the request of the Quotient developers (divmod.org). I have pybsddb cvs access so I can check in the docs there if/when this goes in to core python. (Patch is concatenated two files, hope it's ok.) ---------------------------------------------------------------------- >Comment By: Gregory P. Smith (greg) Date: 2003-09-30 23:39 Message: Logged In: YES user_id=413 This patch doesn't handle zero length values properly and misuses makeDbErr; i've got a fixed patch and test case in my sandbox currently running the testsuite. I'll commit it shortly. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=813877&group_id=5470 From noreply at sourceforge.net Wed Oct 1 02:50:20 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 1 02:50:24 2003 Subject: [Patches] [ python-Patches-813877 ] entry size for bsddb cursors Message-ID: Patches item #813877, was opened at 2003-09-27 22:55 Message generated for change (Comment added) made by greg You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=813877&group_id=5470 Category: Modules Group: Python 2.4 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Itamar Shtull-Trauring (itamar) Assigned to: Gregory P. Smith (greg) Summary: entry size for bsddb cursors Initial Comment: If you store large entries in a database, there is currently no way to get their size without reading the whole thing into memory when using cursors. Knowing the length is useful for doing partial reads from a record. The patch adds a method get_current_size() that returns the length of the data in the current entry the cursor is pointing at. Implemented at the request of the Quotient developers (divmod.org). I have pybsddb cvs access so I can check in the docs there if/when this goes in to core python. (Patch is concatenated two files, hope it's ok.) ---------------------------------------------------------------------- >Comment By: Gregory P. Smith (greg) Date: 2003-09-30 23:50 Message: Logged In: YES user_id=413 Okay, a working get_current_size() and test case have been committed. ---------------------------------------------------------------------- Comment By: Gregory P. Smith (greg) Date: 2003-09-30 23:39 Message: Logged In: YES user_id=413 This patch doesn't handle zero length values properly and misuses makeDbErr; i've got a fixed patch and test case in my sandbox currently running the testsuite. I'll commit it shortly. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=813877&group_id=5470 From noreply at sourceforge.net Wed Oct 1 02:51:27 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 1 02:51:31 2003 Subject: [Patches] [ python-Patches-813877 ] entry size for bsddb cursors Message-ID: Patches item #813877, was opened at 2003-09-27 22:55 Message generated for change (Comment added) made by greg You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=813877&group_id=5470 Category: Modules Group: Python 2.4 Status: Closed Resolution: Accepted Priority: 5 Submitted By: Itamar Shtull-Trauring (itamar) Assigned to: Gregory P. Smith (greg) Summary: entry size for bsddb cursors Initial Comment: If you store large entries in a database, there is currently no way to get their size without reading the whole thing into memory when using cursors. Knowing the length is useful for doing partial reads from a record. The patch adds a method get_current_size() that returns the length of the data in the current entry the cursor is pointing at. Implemented at the request of the Quotient developers (divmod.org). I have pybsddb cvs access so I can check in the docs there if/when this goes in to core python. (Patch is concatenated two files, hope it's ok.) ---------------------------------------------------------------------- >Comment By: Gregory P. Smith (greg) Date: 2003-09-30 23:51 Message: Logged In: YES user_id=413 please commit your documentation update to pybsddb. ---------------------------------------------------------------------- Comment By: Gregory P. Smith (greg) Date: 2003-09-30 23:50 Message: Logged In: YES user_id=413 Okay, a working get_current_size() and test case have been committed. ---------------------------------------------------------------------- Comment By: Gregory P. Smith (greg) Date: 2003-09-30 23:39 Message: Logged In: YES user_id=413 This patch doesn't handle zero length values properly and misuses makeDbErr; i've got a fixed patch and test case in my sandbox currently running the testsuite. I'll commit it shortly. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=813877&group_id=5470 From noreply at sourceforge.net Wed Oct 1 11:06:51 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 1 11:06:58 2003 Subject: [Patches] [ python-Patches-815911 ] Extension logging.handlers.SocketHandler Message-ID: Patches item #815911, was opened at 2003-10-01 10:06 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=815911&group_id=5470 Category: Library (Lib) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Robert Olson (olson) Assigned to: Nobody/Anonymous (nobody) Summary: Extension logging.handlers.SocketHandler Initial Comment: I've started using the logging SocketHandler, but don't want the absence of a server to affect the running application. The attached subclass of SocketHandler should handle the cases where a server cannot be contacted, or where the connection is dropped. If the server cannot be contacted after a drop, the connection is periodically retried using a simple exponential backoff scheme. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=815911&group_id=5470 From noreply at sourceforge.net Wed Oct 1 12:16:13 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 1 12:16:28 2003 Subject: [Patches] [ python-Patches-813877 ] entry size for bsddb cursors Message-ID: Patches item #813877, was opened at 2003-09-28 08:55 Message generated for change (Comment added) made by itamar You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=813877&group_id=5470 Category: Modules Group: Python 2.4 Status: Closed Resolution: Accepted Priority: 5 Submitted By: Itamar Shtull-Trauring (itamar) Assigned to: Gregory P. Smith (greg) Summary: entry size for bsddb cursors Initial Comment: If you store large entries in a database, there is currently no way to get their size without reading the whole thing into memory when using cursors. Knowing the length is useful for doing partial reads from a record. The patch adds a method get_current_size() that returns the length of the data in the current entry the cursor is pointing at. Implemented at the request of the Quotient developers (divmod.org). I have pybsddb cvs access so I can check in the docs there if/when this goes in to core python. (Patch is concatenated two files, hope it's ok.) ---------------------------------------------------------------------- >Comment By: Itamar Shtull-Trauring (itamar) Date: 2003-10-01 19:16 Message: Logged In: YES user_id=32065 Sorry about the bugs. Docs commited. I guess next step is to look at making a cursor specific dbrecio and unscrewing dbrecio in general. ---------------------------------------------------------------------- Comment By: Gregory P. Smith (greg) Date: 2003-10-01 09:51 Message: Logged In: YES user_id=413 please commit your documentation update to pybsddb. ---------------------------------------------------------------------- Comment By: Gregory P. Smith (greg) Date: 2003-10-01 09:50 Message: Logged In: YES user_id=413 Okay, a working get_current_size() and test case have been committed. ---------------------------------------------------------------------- Comment By: Gregory P. Smith (greg) Date: 2003-10-01 09:39 Message: Logged In: YES user_id=413 This patch doesn't handle zero length values properly and misuses makeDbErr; i've got a fixed patch and test case in my sandbox currently running the testsuite. I'll commit it shortly. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=813877&group_id=5470 From noreply at sourceforge.net Wed Oct 1 14:48:20 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 1 16:01:33 2003 Subject: [Patches] [ python-Patches-816059 ] popen2 work, fixes bugs 768649 and 761888 Message-ID: Patches item #816059, was opened at 2003-10-01 13:48 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=816059&group_id=5470 Category: Library (Lib) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Andrew Gaul (gaul) Assigned to: Nobody/Anonymous (nobody) Summary: popen2 work, fixes bugs 768649 and 761888 Initial Comment: Plug popen2.popen[234] leak (see bug #768649 for discussion). Handle os.{pipe,fork} exceptions (see bug #761888). Change class variables into instance variables, allowing following code to work properly: from popen2 import Popen3 p1 = Popen3('ls') p1.fromchild.read() Popen3('ls').fromchild.read() Popen3('ls').fromchild.read() p1.wait() Update docstrings to mention popen4 and warn about mixing Popen3 objects and threading. Expand on MAX_FD comment. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=816059&group_id=5470 From noreply at sourceforge.net Thu Oct 2 04:50:34 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Thu Oct 2 04:50:40 2003 Subject: [Patches] [ python-Patches-816420 ] make fails under OpenBSD 3.4 Message-ID: Patches item #816420, was opened at 2003-10-02 08:50 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=816420&group_id=5470 Category: Build Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: John Draper (crunch) Assigned to: Nobody/Anonymous (nobody) Summary: make fails under OpenBSD 3.4 Initial Comment: Python fails to make under the soon-to-be-released OpenBSD 3.4 with this: /usr/include/sys/event.h:53: syntax error before `u_int' /usr/include/sys/event.h:55: syntax error before `u_short' *** Error code 1 This patch fixes the problem for OpenBSD 3.4 (though 3.* would fix for all 3.x versions). This matter was mentioned in https://sourceforge.net/tracker/? group_id=5470&atid=105470&func=detail&aid=635034 but it is being submitted since it has become an actual bug. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=816420&group_id=5470 From noreply at sourceforge.net Thu Oct 2 15:09:44 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Thu Oct 2 15:09:51 2003 Subject: [Patches] [ python-Patches-808210 ] fix for external test regression in test.regrtest Message-ID: Patches item #808210, was opened at 2003-09-17 17:48 Message generated for change (Comment added) made by nriley You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=808210&group_id=5470 Category: Modules Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Nicholas Riley (nriley) Assigned to: Nobody/Anonymous (nobody) Summary: fix for external test regression in test.regrtest Initial Comment: A detailed description of the bug introduced in Python 2.3 is here: http://sourceforge.net/tracker/index.php? func=detail&aid=798274&group_id=5470&atid=105470 This patch implements the solution as suggested in the report: if a testdir argument is provided and the test module is not in a package, it attempts to import modules from that directory. This restores compatibility with the test suites I wrote in Python 2.2, and does not interfere with the current behavior as used by the Python regression test suite. ---------------------------------------------------------------------- >Comment By: Nicholas Riley (nriley) Date: 2003-10-02 14:09 Message: Logged In: YES user_id=34933 Sorry, I'm not familiar with Python patch policies, but it seems a second 2.3.x release is about to be released without this patch included. This makes it difficult for users of the test suite I wrote to use it, because they have to replace their version of regrtest.py with mine, or go back to Python 2.2. Is there anything else I need to do in order to get this version incorporated? Thanks. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=808210&group_id=5470 From noreply at sourceforge.net Thu Oct 2 16:16:08 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Thu Oct 2 16:16:14 2003 Subject: [Patches] [ python-Patches-816787 ] urllib2.URLError don't calll IOError.__init__ Message-ID: Patches item #816787, was opened at 2003-10-02 23:16 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=816787&group_id=5470 Category: Library (Lib) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Miki Tebeka (tebeka) Assigned to: Nobody/Anonymous (nobody) Summary: urllib2.URLError don't calll IOError.__init__ Initial Comment: The comments says it's not needed by in the case of: --------------- from urllib2 import URLError u = URLError(1) u[-1] Traceback (most recent call last): File "u.py", line 6, in ? u[-1] AttributeError: URLError instance has no attribute 'args' -------------- it's not what we excpect. Attaching a patch to call IOError.__init__ ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=816787&group_id=5470 From noreply at sourceforge.net Thu Oct 2 17:13:22 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Thu Oct 2 17:13:27 2003 Subject: [Patches] [ python-Patches-816420 ] make fails under OpenBSD 3.4 Message-ID: Patches item #816420, was opened at 2003-10-02 03:50 Message generated for change (Comment added) made by gaul You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=816420&group_id=5470 Category: Build Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: John Draper (crunch) Assigned to: Nobody/Anonymous (nobody) Summary: make fails under OpenBSD 3.4 Initial Comment: Python fails to make under the soon-to-be-released OpenBSD 3.4 with this: /usr/include/sys/event.h:53: syntax error before `u_int' /usr/include/sys/event.h:55: syntax error before `u_short' *** Error code 1 This patch fixes the problem for OpenBSD 3.4 (though 3.* would fix for all 3.x versions). This matter was mentioned in https://sourceforge.net/tracker/? group_id=5470&atid=105470&func=detail&aid=635034 but it is being submitted since it has become an actual bug. ---------------------------------------------------------------------- Comment By: Andrew Gaul (gaul) Date: 2003-10-02 16:13 Message: Logged In: YES user_id=139865 Duplicate of patch #814764. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=816420&group_id=5470 From rosavillosa2000 at yahoo.com Fri Oct 3 08:23:06 2003 From: rosavillosa2000 at yahoo.com (Business Marketing) Date: Fri Oct 3 08:20:30 2003 Subject: [Patches] Trade Secrets Message-ID: An HTML attachment was scrubbed... URL: http://mail.python.org/pipermail/patches/attachments/20031003/51ec28dd/attachment.html From noreply at sourceforge.net Fri Oct 3 09:49:20 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 3 09:49:29 2003 Subject: [Patches] [ python-Patches-814764 ] OpenBSD 3.4 requires define_xopen_source=no Message-ID: Patches item #814764, was opened at 2003-09-29 23:59 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=814764&group_id=5470 Category: Build Group: Python 2.3 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Jason Ish (ish1) Assigned to: Nobody/Anonymous (nobody) Summary: OpenBSD 3.4 requires define_xopen_source=no Initial Comment: I have verified that OpenBSD 3.4 requires define_xopen_source=no just like previous versions of OpenBSD. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-03 15:49 Message: Logged In: YES user_id=21627 Thanks for the patch. Committed as configure 1.427 configure.in 1.437 configure 1.416.4.8 configure.in 1.427.4.7 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=814764&group_id=5470 From noreply at sourceforge.net Fri Oct 3 09:51:08 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 3 09:51:12 2003 Subject: [Patches] [ python-Patches-816420 ] make fails under OpenBSD 3.4 Message-ID: Patches item #816420, was opened at 2003-10-02 10:50 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=816420&group_id=5470 Category: Build Group: Python 2.3 >Status: Closed >Resolution: Duplicate Priority: 5 Submitted By: John Draper (crunch) Assigned to: Nobody/Anonymous (nobody) Summary: make fails under OpenBSD 3.4 Initial Comment: Python fails to make under the soon-to-be-released OpenBSD 3.4 with this: /usr/include/sys/event.h:53: syntax error before `u_int' /usr/include/sys/event.h:55: syntax error before `u_short' *** Error code 1 This patch fixes the problem for OpenBSD 3.4 (though 3.* would fix for all 3.x versions). This matter was mentioned in https://sourceforge.net/tracker/? group_id=5470&atid=105470&func=detail&aid=635034 but it is being submitted since it has become an actual bug. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-03 15:51 Message: Logged In: YES user_id=21627 #814764 has been committed. Closing this as a duplicate. Writing 3.* would not be appropriate, since you cannot know, yet, how 3.5 will behave. Maybe the system vendor will fix their bugs some day. ---------------------------------------------------------------------- Comment By: Andrew Gaul (gaul) Date: 2003-10-02 23:13 Message: Logged In: YES user_id=139865 Duplicate of patch #814764. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=816420&group_id=5470 From noreply at sourceforge.net Fri Oct 3 09:58:23 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 3 09:58:31 2003 Subject: [Patches] [ python-Patches-813445 ] Add IPPROTO_IPV6 option to the socketmodule Message-ID: Patches item #813445, was opened at 2003-09-27 10:43 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=813445&group_id=5470 Category: Modules Group: Python 2.3 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Matthias Klose (doko) Assigned to: Nobody/Anonymous (nobody) Summary: Add IPPROTO_IPV6 option to the socketmodule Initial Comment: the abovementioned socket option is missing from python2.2 as well 2.3. it's needed by nearly all server programs, since i believe the default behaviour in linux changed between kernel versions 2.4 and 2.6. the default also currently varies between operating systems. it controls whether listening to * on a ipv6 socket also accepts ipv4 connections. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-03 15:58 Message: Logged In: YES user_id=21627 Thanks for the patch. Committed as socketmodule.c 1.274 socketmodule.c 1.271.6.3 NEWS 1.831.4.58, 1.862 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=813445&group_id=5470 From noreply at sourceforge.net Fri Oct 3 14:07:05 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 3 14:07:09 2003 Subject: [Patches] [ python-Patches-817329 ] dynamic popen2 MAXFD Message-ID: Patches item #817329, was opened at 2003-10-03 13:07 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=817329&group_id=5470 Category: Library (Lib) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Andrew Gaul (gaul) Assigned to: Nobody/Anonymous (nobody) Summary: dynamic popen2 MAXFD Initial Comment: Pull SC_OPEN_MAX out of sysconf instead of guessing a value. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=817329&group_id=5470 From noreply at sourceforge.net Fri Oct 3 15:45:57 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 3 15:46:01 2003 Subject: [Patches] [ python-Patches-817379 ] urllib2 does not allow for absolute ftp paths Message-ID: Patches item #817379, was opened at 2003-10-03 15:45 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=817379&group_id=5470 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Mihai Ibanescu (misa) Assigned to: Nobody/Anonymous (nobody) Summary: urllib2 does not allow for absolute ftp paths Initial Comment: urllib does the unquote() on FTP paths too early; therefore, URLs like: ftp://myname@host.dom/%2Fetc/motd are unquoted as: //etc/motd and then the wrong thing happens. The correct behaviour is documented in: http://ietf.org/rfc/rfc1738.txt section 3.2.2 Within a name or CWD component, the characters "/" and ";" are reserved and must be encoded. The components are decoded prior to their use in the FTP protocol. In particular, if the appropriate FTP sequence to access a particular file requires supplying a string containing a "/" as an argument to a CWD or RETR command, it is necessary to encode each "/". For example, the URL is interpreted by FTP-ing to "host.dom", logging in as "myname" (prompting for a password if it is asked for), and then executing "CWD /etc" and then "RETR motd". This has a different meaning from which would "CWD etc" and then "RETR motd"; the initial "CWD" might be executed relative to the default directory for "myname". On the other hand, , would "CWD " with a null argument, then "CWD etc", and then "RETR motd". ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=817379&group_id=5470 From noreply at sourceforge.net Fri Oct 3 15:48:16 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 3 15:48:20 2003 Subject: [Patches] [ python-Patches-817379 ] urllib2 does not allow for absolute ftp paths Message-ID: Patches item #817379, was opened at 2003-10-03 15:45 Message generated for change (Comment added) made by misa You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=817379&group_id=5470 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Mihai Ibanescu (misa) Assigned to: Nobody/Anonymous (nobody) Summary: urllib2 does not allow for absolute ftp paths Initial Comment: urllib does the unquote() on FTP paths too early; therefore, URLs like: ftp://myname@host.dom/%2Fetc/motd are unquoted as: //etc/motd and then the wrong thing happens. The correct behaviour is documented in: http://ietf.org/rfc/rfc1738.txt section 3.2.2 Within a name or CWD component, the characters "/" and ";" are reserved and must be encoded. The components are decoded prior to their use in the FTP protocol. In particular, if the appropriate FTP sequence to access a particular file requires supplying a string containing a "/" as an argument to a CWD or RETR command, it is necessary to encode each "/". For example, the URL is interpreted by FTP-ing to "host.dom", logging in as "myname" (prompting for a password if it is asked for), and then executing "CWD /etc" and then "RETR motd". This has a different meaning from which would "CWD etc" and then "RETR motd"; the initial "CWD" might be executed relative to the default directory for "myname". On the other hand, , would "CWD " with a null argument, then "CWD etc", and then "RETR motd". ---------------------------------------------------------------------- >Comment By: Mihai Ibanescu (misa) Date: 2003-10-03 15:48 Message: Logged In: YES user_id=205865 Note: patch was generated a long time ago against python 2.2.2, and I was sure I uploaded it to sourceforge. Anyway, patch still applies cleanly to 2.3.1 urllib2; the bug is still present in HEAD. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=817379&group_id=5470 From noreply at sourceforge.net Fri Oct 3 16:19:23 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 3 16:19:45 2003 Subject: [Patches] [ python-Patches-562100 ] Installation database patch Message-ID: Patches item #562100, was opened at 2002-05-29 17:21 Message generated for change (Comment added) made by etrepum You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=562100&group_id=5470 Category: Distutils and setup.py Group: None Status: Closed Resolution: Invalid Priority: 5 Submitted By: A.M. Kuchling (akuchling) Assigned to: A.M. Kuchling (akuchling) Summary: Installation database patch Initial Comment: The attached patch implements an installation database. This patch is not yet correct; don't bother proofreading it yet. I simply wanted to create a patch number so I could put it in PEP 262. ---------------------------------------------------------------------- Comment By: Bob Ippolito (etrepum) Date: 2003-10-03 16:19 Message: Logged In: YES user_id=139309 This should be brought back into play (patch finished, PEP heavily considered, or however that goes), the Package Manager effort going on in pythonmac-sig needs this functionality as part of distutils. ---------------------------------------------------------------------- Comment By: A.M. Kuchling (akuchling) Date: 2002-10-24 15:13 Message: Logged In: YES user_id=11375 Closing this patch with the withdrawal of PEP 262. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=562100&group_id=5470 From noreply at sourceforge.net Fri Oct 3 16:59:03 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 3 16:59:10 2003 Subject: [Patches] [ python-Patches-817379 ] urllib2 does not allow for absolute ftp paths Message-ID: Patches item #817379, was opened at 2003-10-03 19:45 Message generated for change (Comment added) made by jhylton You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=817379&group_id=5470 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Mihai Ibanescu (misa) >Assigned to: Jeremy Hylton (jhylton) Summary: urllib2 does not allow for absolute ftp paths Initial Comment: urllib does the unquote() on FTP paths too early; therefore, URLs like: ftp://myname@host.dom/%2Fetc/motd are unquoted as: //etc/motd and then the wrong thing happens. The correct behaviour is documented in: http://ietf.org/rfc/rfc1738.txt section 3.2.2 Within a name or CWD component, the characters "/" and ";" are reserved and must be encoded. The components are decoded prior to their use in the FTP protocol. In particular, if the appropriate FTP sequence to access a particular file requires supplying a string containing a "/" as an argument to a CWD or RETR command, it is necessary to encode each "/". For example, the URL is interpreted by FTP-ing to "host.dom", logging in as "myname" (prompting for a password if it is asked for), and then executing "CWD /etc" and then "RETR motd". This has a different meaning from which would "CWD etc" and then "RETR motd"; the initial "CWD" might be executed relative to the default directory for "myname". On the other hand, , would "CWD " with a null argument, then "CWD etc", and then "RETR motd". ---------------------------------------------------------------------- >Comment By: Jeremy Hylton (jhylton) Date: 2003-10-03 20:59 Message: Logged In: YES user_id=31392 Sounds like an easy fix. I'll do it tonight. ---------------------------------------------------------------------- Comment By: Mihai Ibanescu (misa) Date: 2003-10-03 19:48 Message: Logged In: YES user_id=205865 Note: patch was generated a long time ago against python 2.2.2, and I was sure I uploaded it to sourceforge. Anyway, patch still applies cleanly to 2.3.1 urllib2; the bug is still present in HEAD. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=817379&group_id=5470 From noreply at sourceforge.net Sat Oct 4 16:28:44 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 4 16:28:47 2003 Subject: [Patches] [ python-Patches-817854 ] sprout more file operations in SSLFile, fixes 792101 Message-ID: Patches item #817854, was opened at 2003-10-04 15:28 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=817854&group_id=5470 Category: Library (Lib) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Andrew Gaul (gaul) Assigned to: Nobody/Anonymous (nobody) Summary: sprout more file operations in SSLFile, fixes 792101 Initial Comment: Fixes bug #792101. Add readlines, fileno, and support iterator protocol so that SSLFile implements all the file operations that urllib.urlopen describes. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=817854&group_id=5470 From noreply at sourceforge.net Sun Oct 5 16:20:20 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 5 16:20:25 2003 Subject: [Patches] [ python-Patches-814560 ] deprecated modules Message-ID: Patches item #814560, was opened at 2003-09-29 12:54 Message generated for change (Comment added) made by tjreedy You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=814560&group_id=5470 Category: Documentation Group: None Status: Open Resolution: None Priority: 5 Submitted By: Juan David Ib??ez Palomar (jdavid) Assigned to: Nobody/Anonymous (nobody) Summary: deprecated modules Initial Comment: it would be nice if the "Global Module Index" showed the deprecated modules clearly separated from the non deprecated modules ---------------------------------------------------------------------- Comment By: Terry J. Reedy (tjreedy) Date: 2003-10-05 16:20 Message: Logged In: YES user_id=593130 This is not a patch submission. It also dupicates bug report [ 816725 ] mark deprecated modules in indexes. Please close. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=814560&group_id=5470 From noreply at sourceforge.net Mon Oct 6 01:10:57 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 6 01:11:04 2003 Subject: [Patches] [ python-Patches-816787 ] urllib2.URLError don't calll IOError.__init__ Message-ID: Patches item #816787, was opened at 2003-10-02 20:16 Message generated for change (Comment added) made by jhylton You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=816787&group_id=5470 Category: Library (Lib) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Miki Tebeka (tebeka) >Assigned to: Jeremy Hylton (jhylton) Summary: urllib2.URLError don't calll IOError.__init__ Initial Comment: The comments says it's not needed by in the case of: --------------- from urllib2 import URLError u = URLError(1) u[-1] Traceback (most recent call last): File "u.py", line 6, in ? u[-1] AttributeError: URLError instance has no attribute 'args' -------------- it's not what we excpect. Attaching a patch to call IOError.__init__ ---------------------------------------------------------------------- >Comment By: Jeremy Hylton (jhylton) Date: 2003-10-06 05:10 Message: Logged In: YES user_id=31392 I've changed URLError to call IOError.__init__(). That's an improvement, but it's still not great. The typical EnvironmentError has a two- or three-tuple where item 0 is the errno, item 1 is a string explaining the error, and item 3 is a filenumber. The change will creates args, but won't set errno or strerrror. Code expecting an errno in args[0] will be surprised. What do you think? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=816787&group_id=5470 From noreply at sourceforge.net Mon Oct 6 17:35:00 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 6 17:35:09 2003 Subject: [Patches] [ python-Patches-817329 ] dynamic popen2 MAXFD Message-ID: Patches item #817329, was opened at 2003-10-03 20:07 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=817329&group_id=5470 Category: Library (Lib) Group: Python 2.3 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Andrew Gaul (gaul) Assigned to: Nobody/Anonymous (nobody) Summary: dynamic popen2 MAXFD Initial Comment: Pull SC_OPEN_MAX out of sysconf instead of guessing a value. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-06 23:35 Message: Logged In: YES user_id=21627 Thanks for the patch. Applied as popen2.py 1.27.6.1 and 1.28. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=817329&group_id=5470 From noreply at sourceforge.net Mon Oct 6 17:36:08 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 6 17:36:11 2003 Subject: [Patches] [ python-Patches-816059 ] popen2 work, fixes bugs 768649 and 761888 Message-ID: Patches item #816059, was opened at 2003-10-01 20:48 Message generated for change (Settings changed) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=816059&group_id=5470 Category: Library (Lib) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Andrew Gaul (gaul) >Assigned to: Martin v. L?wis (loewis) Summary: popen2 work, fixes bugs 768649 and 761888 Initial Comment: Plug popen2.popen[234] leak (see bug #768649 for discussion). Handle os.{pipe,fork} exceptions (see bug #761888). Change class variables into instance variables, allowing following code to work properly: from popen2 import Popen3 p1 = Popen3('ls') p1.fromchild.read() Popen3('ls').fromchild.read() Popen3('ls').fromchild.read() p1.wait() Update docstrings to mention popen4 and warn about mixing Popen3 objects and threading. Expand on MAX_FD comment. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=816059&group_id=5470 From noreply at sourceforge.net Mon Oct 6 23:21:55 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 6 23:21:59 2003 Subject: [Patches] [ python-Patches-819012 ] Fix for former/latter confusion in Extending documentation Message-ID: Patches item #819012, was opened at 2003-10-07 16:21 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=819012&group_id=5470 Category: Documentation Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Tony Meyer (anadelonbrin) Assigned to: Nobody/Anonymous (nobody) Summary: Fix for former/latter confusion in Extending documentation Initial Comment: Section 1.10 ("Reference Counts" in Extending Python) has this: "In C++, the operators new and delete are used with essentially the same meaning and we'll restrict the following discussion to the latter." However, the following discussion uses malloc() and free () (i.e. "the former"), not new and delete. Either this should be corrected to say "the former" (as with the attached one line patch), or the whole section should be corrected to use new and delete. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=819012&group_id=5470 From noreply at sourceforge.net Tue Oct 7 03:23:47 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Tue Oct 7 03:23:51 2003 Subject: [Patches] [ python-Patches-819077 ] fix import problem(unittest.py) Message-ID: Patches item #819077, was opened at 2003-10-07 16:23 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=819077&group_id=5470 Category: Library (Lib) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: George Yoshida (quiver) Assigned to: Nobody/Anonymous (nobody) Summary: fix import problem(unittest.py) Initial Comment: This patch includes 3 changes to unittest.py. * Don't import unittest.(important) unittest is imported in the original script. This can be the cause of trouble. * cast float (trivial) TextTestRunner.run() method has the line as follows: timeTaken = float(stopTime - startTime) However, time.time() returns the time by a floating point number by default. So you don't need to cast the value to a float. * fix typo (trivial) """Note that decimal places (from zero) is usually ...""" 'is' should be 'are'. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=819077&group_id=5470 From noreply at sourceforge.net Wed Oct 8 08:32:20 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 8 08:32:24 2003 Subject: [Patches] [ python-Patches-819955 ] Erroneous \seemodule in tarfile docs Message-ID: Patches item #819955, was opened at 2003-10-08 14:32 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=819955&group_id=5470 Category: Documentation Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Johannes Gijsbers (jlgijsbers) Assigned to: Nobody/Anonymous (nobody) Summary: Erroneous \seemodule in tarfile docs Initial Comment: The reference to the zipfile module in libtarfile.tex refers to 'module-module-zipfile.html'. It doesn't need the explicit key (and certainly not a wrong one). ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=819955&group_id=5470 From noreply at sourceforge.net Wed Oct 8 15:52:36 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 8 15:52:59 2003 Subject: [Patches] [ python-Patches-820195 ] obj.__contains__() returns 1/0... Message-ID: Patches item #820195, was opened at 2003-10-08 21:52 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=820195&group_id=5470 Category: Core (C code) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Wojtek Walczak (gminick) Assigned to: Nobody/Anonymous (nobody) Summary: obj.__contains__() returns 1/0... Initial Comment: shouldn't it return True/False? examples: >>> a = 'python' >>> a.__contains__('perl') 0 >>> a.__contains__('python') 1 >>> a = { 'python' : 1, 'ruby' : 1 } >>> a.__contains__('perl') 0 >>> a.__contains__('python') 1 >>> instead of: >>> a = 'python' >>> a.__contains__('perl') False >>> a.__contains__('python') True >>> a = { 'python' : 1, 'ruby' : 1 } >>> a.__contains__('perl') False >>> a.__contains__('python') True >>> The reason for asking is that i.e. obj.__eq__() returns True/False, and besides True/False looks nicer than 1/0 ;> ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=820195&group_id=5470 From noreply at sourceforge.net Wed Oct 8 16:12:26 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 8 16:12:35 2003 Subject: [Patches] [ python-Patches-820195 ] obj.__contains__() returns 1/0... Message-ID: Patches item #820195, was opened at 2003-10-08 15:52 Message generated for change (Comment added) made by gvanrossum You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=820195&group_id=5470 Category: Core (C code) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Wojtek Walczak (gminick) Assigned to: Nobody/Anonymous (nobody) Summary: obj.__contains__() returns 1/0... Initial Comment: shouldn't it return True/False? examples: >>> a = 'python' >>> a.__contains__('perl') 0 >>> a.__contains__('python') 1 >>> a = { 'python' : 1, 'ruby' : 1 } >>> a.__contains__('perl') 0 >>> a.__contains__('python') 1 >>> instead of: >>> a = 'python' >>> a.__contains__('perl') False >>> a.__contains__('python') True >>> a = { 'python' : 1, 'ruby' : 1 } >>> a.__contains__('perl') False >>> a.__contains__('python') True >>> The reason for asking is that i.e. obj.__eq__() returns True/False, and besides True/False looks nicer than 1/0 ;> ---------------------------------------------------------------------- >Comment By: Guido van Rossum (gvanrossum) Date: 2003-10-08 16:12 Message: Logged In: YES user_id=6380 Looks good, I'll check this in. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=820195&group_id=5470 From noreply at sourceforge.net Wed Oct 8 17:09:03 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 8 17:09:07 2003 Subject: [Patches] [ python-Patches-820195 ] obj.__contains__() returns 1/0... Message-ID: Patches item #820195, was opened at 2003-10-08 15:52 Message generated for change (Comment added) made by gvanrossum You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=820195&group_id=5470 Category: Core (C code) Group: Python 2.3 >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: Wojtek Walczak (gminick) Assigned to: Nobody/Anonymous (nobody) Summary: obj.__contains__() returns 1/0... Initial Comment: shouldn't it return True/False? examples: >>> a = 'python' >>> a.__contains__('perl') 0 >>> a.__contains__('python') 1 >>> a = { 'python' : 1, 'ruby' : 1 } >>> a.__contains__('perl') 0 >>> a.__contains__('python') 1 >>> instead of: >>> a = 'python' >>> a.__contains__('perl') False >>> a.__contains__('python') True >>> a = { 'python' : 1, 'ruby' : 1 } >>> a.__contains__('perl') False >>> a.__contains__('python') True >>> The reason for asking is that i.e. obj.__eq__() returns True/False, and besides True/False looks nicer than 1/0 ;> ---------------------------------------------------------------------- >Comment By: Guido van Rossum (gvanrossum) Date: 2003-10-08 17:09 Message: Logged In: YES user_id=6380 Thanks, checked in! ---------------------------------------------------------------------- Comment By: Guido van Rossum (gvanrossum) Date: 2003-10-08 16:12 Message: Logged In: YES user_id=6380 Looks good, I'll check this in. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=820195&group_id=5470 From noreply at sourceforge.net Fri Oct 10 05:45:16 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 10 05:45:18 2003 Subject: [Patches] [ python-Patches-821093 ] fix doc typos Message-ID: Patches item #821093, was opened at 2003-10-10 18:45 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=821093&group_id=5470 Category: Documentation Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: George Yoshida (quiver) Assigned to: Nobody/Anonymous (nobody) Summary: fix doc typos Initial Comment: This patch fixes documentation typos(about 15 in total). Related directories are api, dist, inst, ref, and tut. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=821093&group_id=5470 From noreply at sourceforge.net Fri Oct 10 18:44:29 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 10 18:44:35 2003 Subject: [Patches] [ python-Patches-821093 ] fix doc typos Message-ID: Patches item #821093, was opened at 2003-10-10 04:45 Message generated for change (Settings changed) made by rhettinger You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=821093&group_id=5470 Category: Documentation Group: Python 2.3 Status: Open >Resolution: Accepted Priority: 5 Submitted By: George Yoshida (quiver) Assigned to: Nobody/Anonymous (nobody) Summary: fix doc typos Initial Comment: This patch fixes documentation typos(about 15 in total). Related directories are api, dist, inst, ref, and tut. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=821093&group_id=5470 From noreply at sourceforge.net Sat Oct 11 14:04:55 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 11 14:04:58 2003 Subject: [Patches] [ python-Patches-821862 ] ftplib: Strict RFC 959 (telnet in command channel) Message-ID: Patches item #821862, was opened at 2003-10-11 22:04 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=821862&group_id=5470 Category: Library (Lib) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Oleg Broytmann (phd) Assigned to: Nobody/Anonymous (nobody) Summary: ftplib: Strict RFC 959 (telnet in command channel) Initial Comment: RFC 959 *requires* to implemet a portion of the telnet protocol in the command channel. Without this ftlib has problems interacting with RFC959-compliant server (most Unix ftp daemons are compliant) if, e.g., a directory or a filename contains russian characters. The attched patch implements a minimal requirement (it doubles chr(255) in the .putline() method), but it allows a programer to choose if a session will be strict or not. Default value is "not strict" because most clients (even Unix clients) do not implemet this telnet option, and most Windoze servers do not implemet it. Tested with ProFTPd on GNU/Linux system. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=821862&group_id=5470 From noreply at sourceforge.net Sat Oct 11 22:03:33 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 11 22:03:36 2003 Subject: [Patches] [ python-Patches-819955 ] Erroneous \seemodule in tarfile docs Message-ID: Patches item #819955, was opened at 2003-10-08 07:32 Message generated for change (Comment added) made by rhettinger You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=819955&group_id=5470 Category: Documentation Group: Python 2.3 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Johannes Gijsbers (jlgijsbers) Assigned to: Nobody/Anonymous (nobody) Summary: Erroneous \seemodule in tarfile docs Initial Comment: The reference to the zipfile module in libtarfile.tex refers to 'module-module-zipfile.html'. It doesn't need the explicit key (and certainly not a wrong one). ---------------------------------------------------------------------- >Comment By: Raymond Hettinger (rhettinger) Date: 2003-10-11 21:03 Message: Logged In: YES user_id=80475 Accepted and applied. Thanks for the patch. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=819955&group_id=5470 From noreply at sourceforge.net Sun Oct 12 01:16:39 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 12 01:23:08 2003 Subject: [Patches] [ python-Patches-785752 ] Documentation for platform module Message-ID: Patches item #785752, was opened at 2003-08-08 23:05 Message generated for change (Comment added) made by bcannon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=785752&group_id=5470 Category: Documentation Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Bjorn Pettersen (bpettersen) Assigned to: M.-A. Lemburg (lemburg) Summary: Documentation for platform module Initial Comment: This is my first time writing module documentation so be gentle . Let me know if I did something wrong and I'll fix and resubmit (compiling the docs sounded like dark magic, so I skipped that part ;-) -- bjorn ---------------------------------------------------------------------- >Comment By: Brett Cannon (bcannon) Date: 2003-10-11 22:16 Message: Logged In: YES user_id=357491 Ran the docs through texcheck.py and added spaces between function parameters. It looks like it is pretty much just a copy and paste job from the docstrings, right, Bjorn? If so then as long as Bjorn did his copying after 2003-08-05 when I committed some cleanup of the of the docstrings there is no need to check it for correctness in terms of grammar and such. So if Bjorn can verify he copied and pasted the docs after my patch to platform.py I can commit this so Fred can work his LaTeX magic on it. ---------------------------------------------------------------------- Comment By: Fred L. Drake, Jr. (fdrake) Date: 2003-08-14 20:18 Message: Logged In: YES user_id=3066 Marc-Andre, could you please review these docs? Thanks! ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-08-11 00:26 Message: Logged In: YES user_id=357491 If this patch gets accepted, please close bug #726911. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-08-09 02:17 Message: Logged In: YES user_id=21627 Thanks for this document. It currently does not follow the grammatical conventions. Please use the imperative voice; quoting from PEP 257 It prescribes the function or method's effect as a command ("Do this", "Return that"), not as a description; e.g. don't write "Returns the pathname ...". In addition, please indicate where you suggest this documentation to go in the table-of-contents, preferably by means of a patch. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=785752&group_id=5470 From noreply at sourceforge.net Sun Oct 12 06:41:45 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 12 06:46:30 2003 Subject: [Patches] [ python-Patches-785752 ] Documentation for platform module Message-ID: Patches item #785752, was opened at 2003-08-09 08:05 Message generated for change (Comment added) made by lemburg You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=785752&group_id=5470 Category: Documentation Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Bjorn Pettersen (bpettersen) Assigned to: M.-A. Lemburg (lemburg) Summary: Documentation for platform module Initial Comment: This is my first time writing module documentation so be gentle . Let me know if I did something wrong and I'll fix and resubmit (compiling the docs sounded like dark magic, so I skipped that part ;-) -- bjorn ---------------------------------------------------------------------- >Comment By: M.-A. Lemburg (lemburg) Date: 2003-10-12 12:41 Message: Logged In: YES user_id=38388 Some nits: References to _default_architecture should either get removed or made explicit in that the defaults are listed somewhere in the documentation. I'd suggest to use "reasonable defaults are chosen" since that leaves the details to the module rather than the documentation. References to "True" and "False" should be changed to true and false. The APIs don't use Python 2.1 style boolean singletons and only check for truth values (needed for Python 1.5.2 compatibility and useful in general). _popen is used in the documentation but not explained. I'd suggest to remove these details from the documentation. Apart from that: great job ! (BTW, is there a tool which does this in an automatic way, e.g. in docutils ?) ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-10-12 07:16 Message: Logged In: YES user_id=357491 Ran the docs through texcheck.py and added spaces between function parameters. It looks like it is pretty much just a copy and paste job from the docstrings, right, Bjorn? If so then as long as Bjorn did his copying after 2003-08-05 when I committed some cleanup of the of the docstrings there is no need to check it for correctness in terms of grammar and such. So if Bjorn can verify he copied and pasted the docs after my patch to platform.py I can commit this so Fred can work his LaTeX magic on it. ---------------------------------------------------------------------- Comment By: Fred L. Drake, Jr. (fdrake) Date: 2003-08-15 05:18 Message: Logged In: YES user_id=3066 Marc-Andre, could you please review these docs? Thanks! ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-08-11 09:26 Message: Logged In: YES user_id=357491 If this patch gets accepted, please close bug #726911. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-08-09 11:17 Message: Logged In: YES user_id=21627 Thanks for this document. It currently does not follow the grammatical conventions. Please use the imperative voice; quoting from PEP 257 It prescribes the function or method's effect as a command ("Do this", "Return that"), not as a description; e.g. don't write "Returns the pathname ...". In addition, please indicate where you suggest this documentation to go in the table-of-contents, preferably by means of a patch. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=785752&group_id=5470 From noreply at sourceforge.net Sun Oct 12 13:38:01 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 12 13:38:08 2003 Subject: [Patches] [ python-Patches-810914 ] fix for mkstemp with relative paths (bug #810408) Message-ID: Patches item #810914, was opened at 2003-09-23 03:18 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=810914&group_id=5470 Category: Library (Lib) Group: Python 2.4 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Michael Bartl (midramas) Assigned to: Nobody/Anonymous (nobody) Summary: fix for mkstemp with relative paths (bug #810408) Initial Comment: Fixed: - Added a testcase to test_tempfile.py to catch the bug - Fixed mkstemp() to return absolute pathname Bug description: The document of tempfile.mkstemp says that, "mkstemp() returns a tuple containing an OS-level handle to an open file (as would be returned by os.open()) and the absolute pathname of that file, in that order." However, if you specify the directory as relative path, it doesn't return an absolute pathname. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-12 19:38 Message: Logged In: YES user_id=21627 Thanks for the patch. Applied as tempfile.py 1.57 test_tempfile.py 1.15 NEWS 1.868 I did not back-port it to 2.3, as it may cause an incompatibility, in case applications where expecting to get back a relative path. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=810914&group_id=5470 From noreply at sourceforge.net Sun Oct 12 14:12:38 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 12 14:12:42 2003 Subject: [Patches] [ python-Patches-822290 ] Faster startup by distutils diet Message-ID: Patches item #822290, was opened at 2003-10-12 18:12 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=822290&group_id=5470 Category: Library (Lib) Group: Python 2.4 Status: Open Resolution: None Priority: 5 Submitted By: Oren Tirosh (orenti) Assigned to: Nobody/Anonymous (nobody) Summary: Faster startup by distutils diet Initial Comment: site.py imports get_platform from distutils.utils. This results in importing of some other modules not used by the get_platform function such as re. This patch moves get_platform to a separate module and speeds up ' python -c "raise SystemExit" ' by about 20% ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=822290&group_id=5470 From noreply at sourceforge.net Sun Oct 12 16:33:04 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 12 16:40:41 2003 Subject: [Patches] [ python-Patches-785752 ] Documentation for platform module Message-ID: Patches item #785752, was opened at 2003-08-08 23:05 Message generated for change (Comment added) made by bcannon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=785752&group_id=5470 Category: Documentation Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Bjorn Pettersen (bpettersen) Assigned to: M.-A. Lemburg (lemburg) Summary: Documentation for platform module Initial Comment: This is my first time writing module documentation so be gentle . Let me know if I did something wrong and I'll fix and resubmit (compiling the docs sounded like dark magic, so I skipped that part ;-) -- bjorn ---------------------------------------------------------------------- >Comment By: Brett Cannon (bcannon) Date: 2003-10-12 13:33 Message: Logged In: YES user_id=357491 OK, I will try to get to the fixes today, MA. Do you want the docstrings changed as well? I can understand doing that for the True/False deal, but not necessarily for _default_architecture. And as for a tool that automates this, I don't know but I was wondering the same thing last night. If not it might be worth it to try to come up with a rough one that at least takes the docstrings, and puts them into a rough LaTeX document that at least spits out a template header and does the function parameter lists and such. In other words get the brain-dead LaTeX conversion stuff out of the way. ---------------------------------------------------------------------- Comment By: M.-A. Lemburg (lemburg) Date: 2003-10-12 03:41 Message: Logged In: YES user_id=38388 Some nits: References to _default_architecture should either get removed or made explicit in that the defaults are listed somewhere in the documentation. I'd suggest to use "reasonable defaults are chosen" since that leaves the details to the module rather than the documentation. References to "True" and "False" should be changed to true and false. The APIs don't use Python 2.1 style boolean singletons and only check for truth values (needed for Python 1.5.2 compatibility and useful in general). _popen is used in the documentation but not explained. I'd suggest to remove these details from the documentation. Apart from that: great job ! (BTW, is there a tool which does this in an automatic way, e.g. in docutils ?) ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-10-11 22:16 Message: Logged In: YES user_id=357491 Ran the docs through texcheck.py and added spaces between function parameters. It looks like it is pretty much just a copy and paste job from the docstrings, right, Bjorn? If so then as long as Bjorn did his copying after 2003-08-05 when I committed some cleanup of the of the docstrings there is no need to check it for correctness in terms of grammar and such. So if Bjorn can verify he copied and pasted the docs after my patch to platform.py I can commit this so Fred can work his LaTeX magic on it. ---------------------------------------------------------------------- Comment By: Fred L. Drake, Jr. (fdrake) Date: 2003-08-14 20:18 Message: Logged In: YES user_id=3066 Marc-Andre, could you please review these docs? Thanks! ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-08-11 00:26 Message: Logged In: YES user_id=357491 If this patch gets accepted, please close bug #726911. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-08-09 02:17 Message: Logged In: YES user_id=21627 Thanks for this document. It currently does not follow the grammatical conventions. Please use the imperative voice; quoting from PEP 257 It prescribes the function or method's effect as a command ("Do this", "Return that"), not as a description; e.g. don't write "Returns the pathname ...". In addition, please indicate where you suggest this documentation to go in the table-of-contents, preferably by means of a patch. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=785752&group_id=5470 From noreply at sourceforge.net Mon Oct 13 03:35:03 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 13 03:39:25 2003 Subject: [Patches] [ python-Patches-785752 ] Documentation for platform module Message-ID: Patches item #785752, was opened at 2003-08-09 08:05 Message generated for change (Comment added) made by lemburg You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=785752&group_id=5470 Category: Documentation Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Bjorn Pettersen (bpettersen) Assigned to: M.-A. Lemburg (lemburg) Summary: Documentation for platform module Initial Comment: This is my first time writing module documentation so be gentle . Let me know if I did something wrong and I'll fix and resubmit (compiling the docs sounded like dark magic, so I skipped that part ;-) -- bjorn ---------------------------------------------------------------------- >Comment By: M.-A. Lemburg (lemburg) Date: 2003-10-13 09:35 Message: Logged In: YES user_id=38388 No need to change the doc-strings (the source for all of the APIs in question is included in the same file, so there's no problem). Thanks. ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-10-12 22:33 Message: Logged In: YES user_id=357491 OK, I will try to get to the fixes today, MA. Do you want the docstrings changed as well? I can understand doing that for the True/False deal, but not necessarily for _default_architecture. And as for a tool that automates this, I don't know but I was wondering the same thing last night. If not it might be worth it to try to come up with a rough one that at least takes the docstrings, and puts them into a rough LaTeX document that at least spits out a template header and does the function parameter lists and such. In other words get the brain-dead LaTeX conversion stuff out of the way. ---------------------------------------------------------------------- Comment By: M.-A. Lemburg (lemburg) Date: 2003-10-12 12:41 Message: Logged In: YES user_id=38388 Some nits: References to _default_architecture should either get removed or made explicit in that the defaults are listed somewhere in the documentation. I'd suggest to use "reasonable defaults are chosen" since that leaves the details to the module rather than the documentation. References to "True" and "False" should be changed to true and false. The APIs don't use Python 2.1 style boolean singletons and only check for truth values (needed for Python 1.5.2 compatibility and useful in general). _popen is used in the documentation but not explained. I'd suggest to remove these details from the documentation. Apart from that: great job ! (BTW, is there a tool which does this in an automatic way, e.g. in docutils ?) ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-10-12 07:16 Message: Logged In: YES user_id=357491 Ran the docs through texcheck.py and added spaces between function parameters. It looks like it is pretty much just a copy and paste job from the docstrings, right, Bjorn? If so then as long as Bjorn did his copying after 2003-08-05 when I committed some cleanup of the of the docstrings there is no need to check it for correctness in terms of grammar and such. So if Bjorn can verify he copied and pasted the docs after my patch to platform.py I can commit this so Fred can work his LaTeX magic on it. ---------------------------------------------------------------------- Comment By: Fred L. Drake, Jr. (fdrake) Date: 2003-08-15 05:18 Message: Logged In: YES user_id=3066 Marc-Andre, could you please review these docs? Thanks! ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-08-11 09:26 Message: Logged In: YES user_id=357491 If this patch gets accepted, please close bug #726911. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-08-09 11:17 Message: Logged In: YES user_id=21627 Thanks for this document. It currently does not follow the grammatical conventions. Please use the imperative voice; quoting from PEP 257 It prescribes the function or method's effect as a command ("Do this", "Return that"), not as a description; e.g. don't write "Returns the pathname ...". In addition, please indicate where you suggest this documentation to go in the table-of-contents, preferably by means of a patch. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=785752&group_id=5470 From noreply at sourceforge.net Mon Oct 13 06:02:04 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 13 06:02:09 2003 Subject: [Patches] [ python-Patches-822290 ] Faster startup by distutils diet Message-ID: Patches item #822290, was opened at 2003-10-12 19:12 Message generated for change (Comment added) made by mwh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=822290&group_id=5470 Category: Library (Lib) Group: Python 2.4 Status: Open Resolution: None Priority: 5 Submitted By: Oren Tirosh (orenti) Assigned to: Nobody/Anonymous (nobody) Summary: Faster startup by distutils diet Initial Comment: site.py imports get_platform from distutils.utils. This results in importing of some other modules not used by the get_platform function such as re. This patch moves get_platform to a separate module and speeds up ' python -c "raise SystemExit" ' by about 20% ---------------------------------------------------------------------- >Comment By: Michael Hudson (mwh) Date: 2003-10-13 11:02 Message: Logged In: YES user_id=6656 This only affects an uninstalled Python build, right? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=822290&group_id=5470 From noreply at sourceforge.net Mon Oct 13 11:43:18 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 13 11:43:27 2003 Subject: [Patches] [ python-Patches-822290 ] Faster startup by distutils diet Message-ID: Patches item #822290, was opened at 2003-10-12 18:12 Message generated for change (Comment added) made by jhylton You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=822290&group_id=5470 Category: Library (Lib) Group: Python 2.4 >Status: Closed >Resolution: Wont Fix Priority: 5 Submitted By: Oren Tirosh (orenti) Assigned to: Nobody/Anonymous (nobody) Summary: Faster startup by distutils diet Initial Comment: site.py imports get_platform from distutils.utils. This results in importing of some other modules not used by the get_platform function such as re. This patch moves get_platform to a separate module and speeds up ' python -c "raise SystemExit" ' by about 20% ---------------------------------------------------------------------- >Comment By: Jeremy Hylton (jhylton) Date: 2003-10-13 15:43 Message: Logged In: YES user_id=31392 That's right. I've been fooled by this decoy before :-). ---------------------------------------------------------------------- Comment By: Michael Hudson (mwh) Date: 2003-10-13 10:02 Message: Logged In: YES user_id=6656 This only affects an uninstalled Python build, right? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=822290&group_id=5470 From noreply at sourceforge.net Mon Oct 13 15:47:15 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 13 15:47:18 2003 Subject: [Patches] [ python-Patches-822994 ] StringIO.py clean-up. Message-ID: Patches item #822994, was opened at 2003-10-13 21:47 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=822994&group_id=5470 Category: Library (Lib) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Wojtek Walczak (gminick) Assigned to: Nobody/Anonymous (nobody) Summary: StringIO.py clean-up. Initial Comment: Well, a one frequently used piece of code closed into function, self.closed returns True/False instead of 1/0, self.softspace removed because it wasn't used. Sorry for wasting your time if you don't treat it as a clean-up ;) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=822994&group_id=5470 From noreply at sourceforge.net Mon Oct 13 18:09:59 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 13 18:10:04 2003 Subject: [Patches] [ python-Patches-823072 ] add option to NOT use ~/.netrc in nntplib.NNTP() Message-ID: Patches item #823072, was opened at 2003-10-13 22:09 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=823072&group_id=5470 Category: Library (Lib) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Matthias Klose (doko) Assigned to: Nobody/Anonymous (nobody) Summary: add option to NOT use ~/.netrc in nntplib.NNTP() Initial Comment: [forwarded from http://bugs.debian.org/215446] It should be possible to circumvent the use of ~/.netrc when calling the nntplib.NNTP() method by adding an addtional parameter. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=823072&group_id=5470 From noreply at sourceforge.net Mon Oct 13 20:29:38 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 13 20:29:43 2003 Subject: [Patches] [ python-Patches-823072 ] add option to NOT use ~/.netrc in nntplib.NNTP() Message-ID: Patches item #823072, was opened at 2003-10-13 15:09 Message generated for change (Comment added) made by mrovner You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=823072&group_id=5470 Category: Library (Lib) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Matthias Klose (doko) Assigned to: Nobody/Anonymous (nobody) Summary: add option to NOT use ~/.netrc in nntplib.NNTP() Initial Comment: [forwarded from http://bugs.debian.org/215446] It should be possible to circumvent the use of ~/.netrc when calling the nntplib.NNTP() method by adding an addtional parameter. ---------------------------------------------------------------------- Comment By: Mike Rovner (mrovner) Date: 2003-10-13 17:29 Message: Logged In: YES user_id=162094 No documentation (http://www.python.org/doc/current/lib/module- nntplib.html) patch provided. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=823072&group_id=5470 From noreply at sourceforge.net Mon Oct 13 21:51:55 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 13 21:52:00 2003 Subject: [Patches] [ python-Patches-658316 ] skips.txt for regrtest.py Message-ID: Patches item #658316, was opened at 2002-12-24 12:03 Message generated for change (Comment added) made by bcannon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=658316&group_id=5470 Category: Tests Group: Python 2.4 Status: Open Resolution: None Priority: 5 Submitted By: Brett Cannon (bcannon) Assigned to: Brett Cannon (bcannon) Summary: skips.txt for regrtest.py Initial Comment: As I promised on python-dev here is the functionality to have a skips.txt file for regrtest.py. If the file is present in the current directory it is parsed (using the exact same code as used for the -f option for regrtest; good, old copy-n-paste) and all tests are added to the expected skip set. And as commented in the file, the name of the file is so named after Skip Montanaro because he is too shy. ---------------------------------------------------------------------- >Comment By: Brett Cannon (bcannon) Date: 2003-10-13 18:51 Message: Logged In: YES user_id=357491 Because I was getting slightly annoyed by having what tests were to be skipped printed every time a test is run, I changed it so that skips.txt is run only when you are executing the entire testing suite (i.e., not passing command-line arguments or not listing the tests in a file). ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-05-08 17:46 Message: Logged In: YES user_id=357491 OK, I am uploading a new patch but now it prints out if a test was not executed and then listed all the tests not executed. This is for several reasons. One is so you don't forget you have a skips.txt file and what tests are in it. You also don't get any possible confusion on why the test was not listed while the tests are being executed or if it was printed that it was actually run and passed. I also factored out the file parsing code used by the -f option to the function parsefile and use it for both -f and for parsing skips.txt . Can someone please just take a quick look and tell me that the "not executed" statements are reasonable? If someone gives me the all-clear I will apply the patch. ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-04-23 15:27 Message: Logged In: YES user_id=357491 =) Sure thing. Noticed it was assigned to me and everything. Just need to add one feature; I want it to print out what tests were specifically skipped because of the skips.txt file so people don't forget that they have tests being skipped because of what they have in the file. ---------------------------------------------------------------------- Comment By: Raymond Hettinger (rhettinger) Date: 2003-04-23 11:33 Message: Logged In: YES user_id=80475 It is time to exercise your new commit priviledges. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-03-30 13:15 Message: Logged In: YES user_id=21627 Raymond, any further comments? ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2002-12-29 17:37 Message: Logged In: YES user_id=357491 Oops. =) New diff includes a paragraph at the end of the module documentation that mentions how to use the new functionality. Please delete the old diff. ---------------------------------------------------------------------- Comment By: Raymond Hettinger (rhettinger) Date: 2002-12-28 21:09 Message: Logged In: YES user_id=80475 The patch looks good. Now, it needs documentation. ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2002-12-26 13:04 Message: Logged In: YES user_id=357491 Sorry about that! I could have sworn I checked the box. I have uploaded enough files here you would think it would be habitual by now. ---------------------------------------------------------------------- Comment By: Neal Norwitz (nnorwitz) Date: 2002-12-26 10:10 Message: Logged In: YES user_id=33168 There's no uploaded file! You have to check the checkbox labeled "Check to Upload & Attach File" when you upload a file. Please try again. (This is a SourceForge annoyance that we can do nothing about. :-( ) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=658316&group_id=5470 From noreply at sourceforge.net Mon Oct 13 21:59:26 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 13 22:03:23 2003 Subject: [Patches] [ python-Patches-785752 ] Documentation for platform module Message-ID: Patches item #785752, was opened at 2003-08-08 23:05 Message generated for change (Comment added) made by bcannon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=785752&group_id=5470 Category: Documentation Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Bjorn Pettersen (bpettersen) Assigned to: M.-A. Lemburg (lemburg) Summary: Documentation for platform module Initial Comment: This is my first time writing module documentation so be gentle . Let me know if I did something wrong and I'll fix and resubmit (compiling the docs sounded like dark magic, so I skipped that part ;-) -- bjorn ---------------------------------------------------------------------- >Comment By: Brett Cannon (bcannon) Date: 2003-10-13 18:59 Message: Logged In: YES user_id=357491 OK, I made the changes as requested by MAL. Do this good enough to you, MA, to check this in as-is? ---------------------------------------------------------------------- Comment By: M.-A. Lemburg (lemburg) Date: 2003-10-13 00:35 Message: Logged In: YES user_id=38388 No need to change the doc-strings (the source for all of the APIs in question is included in the same file, so there's no problem). Thanks. ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-10-12 13:33 Message: Logged In: YES user_id=357491 OK, I will try to get to the fixes today, MA. Do you want the docstrings changed as well? I can understand doing that for the True/False deal, but not necessarily for _default_architecture. And as for a tool that automates this, I don't know but I was wondering the same thing last night. If not it might be worth it to try to come up with a rough one that at least takes the docstrings, and puts them into a rough LaTeX document that at least spits out a template header and does the function parameter lists and such. In other words get the brain-dead LaTeX conversion stuff out of the way. ---------------------------------------------------------------------- Comment By: M.-A. Lemburg (lemburg) Date: 2003-10-12 03:41 Message: Logged In: YES user_id=38388 Some nits: References to _default_architecture should either get removed or made explicit in that the defaults are listed somewhere in the documentation. I'd suggest to use "reasonable defaults are chosen" since that leaves the details to the module rather than the documentation. References to "True" and "False" should be changed to true and false. The APIs don't use Python 2.1 style boolean singletons and only check for truth values (needed for Python 1.5.2 compatibility and useful in general). _popen is used in the documentation but not explained. I'd suggest to remove these details from the documentation. Apart from that: great job ! (BTW, is there a tool which does this in an automatic way, e.g. in docutils ?) ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-10-11 22:16 Message: Logged In: YES user_id=357491 Ran the docs through texcheck.py and added spaces between function parameters. It looks like it is pretty much just a copy and paste job from the docstrings, right, Bjorn? If so then as long as Bjorn did his copying after 2003-08-05 when I committed some cleanup of the of the docstrings there is no need to check it for correctness in terms of grammar and such. So if Bjorn can verify he copied and pasted the docs after my patch to platform.py I can commit this so Fred can work his LaTeX magic on it. ---------------------------------------------------------------------- Comment By: Fred L. Drake, Jr. (fdrake) Date: 2003-08-14 20:18 Message: Logged In: YES user_id=3066 Marc-Andre, could you please review these docs? Thanks! ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-08-11 00:26 Message: Logged In: YES user_id=357491 If this patch gets accepted, please close bug #726911. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-08-09 02:17 Message: Logged In: YES user_id=21627 Thanks for this document. It currently does not follow the grammatical conventions. Please use the imperative voice; quoting from PEP 257 It prescribes the function or method's effect as a command ("Do this", "Return that"), not as a description; e.g. don't write "Returns the pathname ...". In addition, please indicate where you suggest this documentation to go in the table-of-contents, preferably by means of a patch. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=785752&group_id=5470 From noreply at sourceforge.net Tue Oct 14 03:50:16 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Tue Oct 14 03:50:21 2003 Subject: [Patches] [ python-Patches-823259 ] Updated .spec file. Message-ID: Patches item #823259, was opened at 2003-10-14 07:50 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=823259&group_id=5470 Category: Build Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Sean Reifschneider (jafo) Assigned to: Nobody/Anonymous (nobody) Summary: Updated .spec file. Initial Comment: I have created a new .spec file with a few small changes and one larger one. This version detects if the HTML documentation is available, and continues building without the documentation if it is not available. This goes in Misc/RPMS ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=823259&group_id=5470 From noreply at sourceforge.net Tue Oct 14 04:12:32 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Tue Oct 14 04:12:45 2003 Subject: [Patches] [ python-Patches-785752 ] Documentation for platform module Message-ID: Patches item #785752, was opened at 2003-08-09 08:05 Message generated for change (Settings changed) made by lemburg You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=785752&group_id=5470 Category: Documentation Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Bjorn Pettersen (bpettersen) >Assigned to: Brett Cannon (bcannon) Summary: Documentation for platform module Initial Comment: This is my first time writing module documentation so be gentle . Let me know if I did something wrong and I'll fix and resubmit (compiling the docs sounded like dark magic, so I skipped that part ;-) -- bjorn ---------------------------------------------------------------------- Comment By: M.-A. Lemburg (lemburg) Date: 2003-10-14 10:11 Message: Logged In: YES user_id=38388 Looks good :-) ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-10-14 03:59 Message: Logged In: YES user_id=357491 OK, I made the changes as requested by MAL. Do this good enough to you, MA, to check this in as-is? ---------------------------------------------------------------------- Comment By: M.-A. Lemburg (lemburg) Date: 2003-10-13 09:35 Message: Logged In: YES user_id=38388 No need to change the doc-strings (the source for all of the APIs in question is included in the same file, so there's no problem). Thanks. ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-10-12 22:33 Message: Logged In: YES user_id=357491 OK, I will try to get to the fixes today, MA. Do you want the docstrings changed as well? I can understand doing that for the True/False deal, but not necessarily for _default_architecture. And as for a tool that automates this, I don't know but I was wondering the same thing last night. If not it might be worth it to try to come up with a rough one that at least takes the docstrings, and puts them into a rough LaTeX document that at least spits out a template header and does the function parameter lists and such. In other words get the brain-dead LaTeX conversion stuff out of the way. ---------------------------------------------------------------------- Comment By: M.-A. Lemburg (lemburg) Date: 2003-10-12 12:41 Message: Logged In: YES user_id=38388 Some nits: References to _default_architecture should either get removed or made explicit in that the defaults are listed somewhere in the documentation. I'd suggest to use "reasonable defaults are chosen" since that leaves the details to the module rather than the documentation. References to "True" and "False" should be changed to true and false. The APIs don't use Python 2.1 style boolean singletons and only check for truth values (needed for Python 1.5.2 compatibility and useful in general). _popen is used in the documentation but not explained. I'd suggest to remove these details from the documentation. Apart from that: great job ! (BTW, is there a tool which does this in an automatic way, e.g. in docutils ?) ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-10-12 07:16 Message: Logged In: YES user_id=357491 Ran the docs through texcheck.py and added spaces between function parameters. It looks like it is pretty much just a copy and paste job from the docstrings, right, Bjorn? If so then as long as Bjorn did his copying after 2003-08-05 when I committed some cleanup of the of the docstrings there is no need to check it for correctness in terms of grammar and such. So if Bjorn can verify he copied and pasted the docs after my patch to platform.py I can commit this so Fred can work his LaTeX magic on it. ---------------------------------------------------------------------- Comment By: Fred L. Drake, Jr. (fdrake) Date: 2003-08-15 05:18 Message: Logged In: YES user_id=3066 Marc-Andre, could you please review these docs? Thanks! ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-08-11 09:26 Message: Logged In: YES user_id=357491 If this patch gets accepted, please close bug #726911. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-08-09 11:17 Message: Logged In: YES user_id=21627 Thanks for this document. It currently does not follow the grammatical conventions. Please use the imperative voice; quoting from PEP 257 It prescribes the function or method's effect as a command ("Do this", "Return that"), not as a description; e.g. don't write "Returns the pathname ...". In addition, please indicate where you suggest this documentation to go in the table-of-contents, preferably by means of a patch. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=785752&group_id=5470 From noreply at sourceforge.net Tue Oct 14 04:11:53 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Tue Oct 14 04:18:31 2003 Subject: [Patches] [ python-Patches-785752 ] Documentation for platform module Message-ID: Patches item #785752, was opened at 2003-08-09 08:05 Message generated for change (Comment added) made by lemburg You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=785752&group_id=5470 Category: Documentation Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Bjorn Pettersen (bpettersen) Assigned to: M.-A. Lemburg (lemburg) Summary: Documentation for platform module Initial Comment: This is my first time writing module documentation so be gentle . Let me know if I did something wrong and I'll fix and resubmit (compiling the docs sounded like dark magic, so I skipped that part ;-) -- bjorn ---------------------------------------------------------------------- >Comment By: M.-A. Lemburg (lemburg) Date: 2003-10-14 10:11 Message: Logged In: YES user_id=38388 Looks good :-) ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-10-14 03:59 Message: Logged In: YES user_id=357491 OK, I made the changes as requested by MAL. Do this good enough to you, MA, to check this in as-is? ---------------------------------------------------------------------- Comment By: M.-A. Lemburg (lemburg) Date: 2003-10-13 09:35 Message: Logged In: YES user_id=38388 No need to change the doc-strings (the source for all of the APIs in question is included in the same file, so there's no problem). Thanks. ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-10-12 22:33 Message: Logged In: YES user_id=357491 OK, I will try to get to the fixes today, MA. Do you want the docstrings changed as well? I can understand doing that for the True/False deal, but not necessarily for _default_architecture. And as for a tool that automates this, I don't know but I was wondering the same thing last night. If not it might be worth it to try to come up with a rough one that at least takes the docstrings, and puts them into a rough LaTeX document that at least spits out a template header and does the function parameter lists and such. In other words get the brain-dead LaTeX conversion stuff out of the way. ---------------------------------------------------------------------- Comment By: M.-A. Lemburg (lemburg) Date: 2003-10-12 12:41 Message: Logged In: YES user_id=38388 Some nits: References to _default_architecture should either get removed or made explicit in that the defaults are listed somewhere in the documentation. I'd suggest to use "reasonable defaults are chosen" since that leaves the details to the module rather than the documentation. References to "True" and "False" should be changed to true and false. The APIs don't use Python 2.1 style boolean singletons and only check for truth values (needed for Python 1.5.2 compatibility and useful in general). _popen is used in the documentation but not explained. I'd suggest to remove these details from the documentation. Apart from that: great job ! (BTW, is there a tool which does this in an automatic way, e.g. in docutils ?) ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-10-12 07:16 Message: Logged In: YES user_id=357491 Ran the docs through texcheck.py and added spaces between function parameters. It looks like it is pretty much just a copy and paste job from the docstrings, right, Bjorn? If so then as long as Bjorn did his copying after 2003-08-05 when I committed some cleanup of the of the docstrings there is no need to check it for correctness in terms of grammar and such. So if Bjorn can verify he copied and pasted the docs after my patch to platform.py I can commit this so Fred can work his LaTeX magic on it. ---------------------------------------------------------------------- Comment By: Fred L. Drake, Jr. (fdrake) Date: 2003-08-15 05:18 Message: Logged In: YES user_id=3066 Marc-Andre, could you please review these docs? Thanks! ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-08-11 09:26 Message: Logged In: YES user_id=357491 If this patch gets accepted, please close bug #726911. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-08-09 11:17 Message: Logged In: YES user_id=21627 Thanks for this document. It currently does not follow the grammatical conventions. Please use the imperative voice; quoting from PEP 257 It prescribes the function or method's effect as a command ("Do this", "Return that"), not as a description; e.g. don't write "Returns the pathname ...". In addition, please indicate where you suggest this documentation to go in the table-of-contents, preferably by means of a patch. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=785752&group_id=5470 From noreply at sourceforge.net Tue Oct 14 04:53:43 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Tue Oct 14 04:53:47 2003 Subject: [Patches] [ python-Patches-823292 ] Optional list.sort() args for DSU pattern and reverse Message-ID: Patches item #823292, was opened at 2003-10-14 03:53 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=823292&group_id=5470 Category: Core (C code) Group: Python 2.4 Status: Open Resolution: None Priority: 5 Submitted By: Raymond Hettinger (rhettinger) Assigned to: Nobody/Anonymous (nobody) Summary: Optional list.sort() args for DSU pattern and reverse Initial Comment: Here is a first draft patch as discussed on python-dev. Docs and tests to follow. The keywords are: cmpfunc, key, reverse This patch passes regression tests and a minimal set of basic functionality tests which need to be expanded considerably. I'll need to go back over this one in more detail to check: * Was the code inserted in the right place with respect to the existing anti-mutation code. * Is the strategy of decorating in-place to aggressive? Decoration consists of *replacing* each value x with (x, key(x)). * Verify reference counting and error handling. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=823292&group_id=5470 From noreply at sourceforge.net Tue Oct 14 07:43:09 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Tue Oct 14 07:43:16 2003 Subject: [Patches] [ python-Patches-822994 ] StringIO.py clean-up. Message-ID: Patches item #822994, was opened at 2003-10-13 20:47 Message generated for change (Comment added) made by mwh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=822994&group_id=5470 Category: Library (Lib) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Wojtek Walczak (gminick) Assigned to: Nobody/Anonymous (nobody) Summary: StringIO.py clean-up. Initial Comment: Well, a one frequently used piece of code closed into function, self.closed returns True/False instead of 1/0, self.softspace removed because it wasn't used. Sorry for wasting your time if you don't treat it as a clean-up ;) ---------------------------------------------------------------------- >Comment By: Michael Hudson (mwh) Date: 2003-10-14 12:43 Message: Logged In: YES user_id=6656 softspace can be used, just not in this file. don't take it out. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=822994&group_id=5470 From noreply at sourceforge.net Tue Oct 14 13:59:54 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Tue Oct 14 14:00:02 2003 Subject: [Patches] [ python-Patches-796919 ] Windows installer changes for 2.3.1 Message-ID: Patches item #796919, was opened at 2003-08-28 22:14 Message generated for change (Comment added) made by theller You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=796919&group_id=5470 Category: None Group: Python 2.3 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Thomas Heller (theller) Assigned to: Thomas Heller (theller) Summary: Windows installer changes for 2.3.1 Initial Comment: Temporary url for the installer is http://starship.python.net/crew/theller/python-2.3.1-beta1.exe Remarks: Only .pyc files, no .pyo are compiled by the installer. This is the default, can be switched off in the "advanced options" installation dialog. In the selecte components dialog, 'Python HTML docs' should be renamed to 'Python HTMLHelp docs'. At the interactive prompt, 'help("BOOLEAN")' prints this: Python 2.3+ (#46, Aug 28 2003, 17:42:54) [MSC v.1200 32 bit (Intel)] on win32 Type "help", "copyright", "credits" or "license" for more information. >>> help("BOOLEAN") Sorry, topic and keyword documentation is not available because the Python HTML documentation files could not be found. If you have installed them, please set the environment variable PYTHONDOCS to indicate their location. >>> I only tested Windows XP Pro, admin install (default path, and path containing spaces). On Windows XP Pro, after installing to 'c:\path with spaces', everything seems to work, including IDLE (at least it starts, and finds to chm file). ---------------------------------------------------------------------- >Comment By: Thomas Heller (theller) Date: 2003-10-14 19:59 Message: Logged In: YES user_id=11105 All this is already in the 2.3.1 installer. ---------------------------------------------------------------------- Comment By: Thomas Heller (theller) Date: 2003-08-28 22:19 Message: Logged In: YES user_id=11105 No need to check anything in, but report bugs and make comments, please. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=796919&group_id=5470 From noreply at sourceforge.net Tue Oct 14 14:05:24 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Tue Oct 14 14:06:30 2003 Subject: [Patches] [ python-Patches-722638 ] Better output for unittest Message-ID: Patches item #722638, was opened at 2003-04-16 19:49 Message generated for change (Comment added) made by theller You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=722638&group_id=5470 Category: Library (Lib) Group: None Status: Open Resolution: None Priority: 5 Submitted By: Thomas Heller (theller) >Assigned to: Steve Purcell (purcell) Summary: Better output for unittest Initial Comment: This patch enables more useful output for unittests: If a test crashes (raises an unexpected exception), a full traceback is printed. If a test failes, the output is something like this: ======================================== FAIL: test_failUnlessEqual (__main__.FailingTests) ---------------------------------------------------------------------- TestFailed: 0 != 1 File "xunit.py", line 12, in test_failUnlessEqual self.failUnlessEqual(self.a, self.b) ======================================== Before, this was printed: ======================================== FAIL: test_failIfEqual (__main__.FailingTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "xunit.py", line 15, in test_failIfEqual self.failIfEqual(self.a, self.a) File "c:\python23\lib\unittest.py", line 300, in failIfEqual raise self.failureException, AssertionError: 0 == 0 ======================================== If needed, I can upload the test script I use, together with the results before and after the patch. This has shortly been discussed on c.l.p, response was mostly positive. http://tinyurl.com/9obf ---------------------------------------------------------------------- >Comment By: Thomas Heller (theller) Date: 2003-10-14 20:05 Message: Logged In: YES user_id=11105 Assigned to Steve for pronouncement (didn't he already comment on python-dev some time ago?) ---------------------------------------------------------------------- Comment By: Tim Peters (tim_one) Date: 2003-05-06 22:27 Message: Logged In: YES user_id=31435 That's why I'm split: I do like the new *messages* better (their content), but I don't like losing the tracebacks. Sometimes it's a bug in the test driver-- or in 20 layers of test driver code --and sometimes it's even a bug in unittest itself. The traceback is a fundamental tool when things go wrong, so I'm never in favor of hiding parts of tracebacks (hiding could be appropriate if you *knew* the true cause isn't in the part you're hiding -- but you can't know that). ---------------------------------------------------------------------- Comment By: Thomas Heller (theller) Date: 2003-05-06 22:08 Message: Logged In: YES user_id=11105 That's exactly how I was feeling. When an assertRaises test failed, I usually inserted the call it made before this line, to see the real traceback. And that's what this patch tries to fix. I don't want to see tracebacks when a test fails, I want a clear indication that it failed (the patch prints "TestFailed" instead of "Traceback:"). For the output of a failed assertRaises, see the first comment I added. IMO it clearly says what which exception was expected, and which one was raised. ---------------------------------------------------------------------- Comment By: Tim Peters (tim_one) Date: 2003-05-06 21:52 Message: Logged In: YES user_id=31435 I'm split. The current output when assertRaises fails is a frequent cause of head-scratching ("what? it's complaining because ValueError got raised? ... no, it's complaining because ValueError wasn't raised? ..."). OTOH, I see no value in trimming the traceback. Now that *could* be because the assertRaises output can be so confusing that we end up using the rest of the traceback to figure out what unittest is trying to tell us in those cases. ---------------------------------------------------------------------- Comment By: Raymond Hettinger (rhettinger) Date: 2003-05-06 09:11 Message: Logged In: YES user_id=80475 I would like to see Thomas's patch or some comformant variant go in. Usability problems are a bug. Friendlier output makes it more likely that unittest will be used in the first place. ---------------------------------------------------------------------- Comment By: Thomas Heller (theller) Date: 2003-04-25 14:52 Message: Logged In: YES user_id=11105 Last attempt to convince you: I could try to port the changes to Python 1.5, if you want to stay compatible. If you still reject the patch (you're the unittest boss), I'll have to live with subclassing unittest ;-) ---------------------------------------------------------------------- Comment By: Steve Purcell (purcell) Date: 2003-04-25 14:37 Message: Logged In: YES user_id=21477 After investigation, this seems to work with Jython (though not JPython, which didn't have tb_next etc.). In general I've been trying hard to keep 'unittest.py' vanilla, since a lot of people are still using it with Python 1.5 and even JPython. Hence the complete absence of string methods, list comprehensions and other new language features. Don't know if this policy makes sense in the longer term, but I value it right now. In that sense, I'm not sure if it's worth changing the message. ---------------------------------------------------------------------- Comment By: Thomas Heller (theller) Date: 2003-04-25 14:05 Message: Logged In: YES user_id=11105 What a pity! What exactly does not work in Jython? Before giving up on this, there are at least two ways to proceed: - Behave as before in Jython, and use the better output in CPython. - Apply this patch only the the unittest version bundled with CPython. How are the chances for one of this? ---------------------------------------------------------------------- Comment By: Steve Purcell (purcell) Date: 2003-04-25 13:52 Message: Logged In: YES user_id=21477 This behaviour of trimming the traceback was implemented in a previous version of PyUnit, but dropped because it did not work with Jython. My aim is that the same 'unittest.py' should work out of the box with both CPython and Jython. ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-04-20 04:57 Message: Logged In: YES user_id=357491 I like the new output, personally. I am +1 on letting Thomas add the changes. Does this mean we no longer treat unittest as a separate project? ---------------------------------------------------------------------- Comment By: Thomas Heller (theller) Date: 2003-04-17 17:31 Message: Logged In: YES user_id=11105 Attaching new version of the patch (unittest-2.diff). This gives better output for failUnlessRaises, like this: ====================================================================== FAIL: test_failUnlessRaises (__main__.FailingTests) ---------------------------------------------------------------------- TestFailed: wrong exception, expected TypeError got: 'ValueError: 10' File "xunit.py", line 18, in test_failUnlessRaises self.failUnlessRaises(TypeError, self._raise, ValueError, 10) ====================================================================== FAIL: test_failUnlessRaises_2 (__main__.FailingTests) ---------------------------------------------------------------------- TestFailed: wrong exception, expected TypeError, IndexError, or AttributeError got: 'ValueError: 10' File "xunit.py", line 21, in test_failUnlessRaises_2 self.failUnlessRaises((TypeError, IndexError, AttributeError), self._raise, ValueError, 10) ---------------------------------------------------------------------- ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=722638&group_id=5470 From noreply at sourceforge.net Tue Oct 14 15:53:23 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Tue Oct 14 15:53:28 2003 Subject: [Patches] [ python-Patches-822994 ] StringIO.py clean-up. Message-ID: Patches item #822994, was opened at 2003-10-13 21:47 Message generated for change (Comment added) made by gminick You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=822994&group_id=5470 Category: Library (Lib) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Wojtek Walczak (gminick) Assigned to: Nobody/Anonymous (nobody) Summary: StringIO.py clean-up. Initial Comment: Well, a one frequently used piece of code closed into function, self.closed returns True/False instead of 1/0, self.softspace removed because it wasn't used. Sorry for wasting your time if you don't treat it as a clean-up ;) ---------------------------------------------------------------------- >Comment By: Wojtek Walczak (gminick) Date: 2003-10-14 21:53 Message: Logged In: YES user_id=679226 Sorry, self.softspace is back again in the code. New patch attached. Thank you for a comment, Michael. ---------------------------------------------------------------------- Comment By: Michael Hudson (mwh) Date: 2003-10-14 13:43 Message: Logged In: YES user_id=6656 softspace can be used, just not in this file. don't take it out. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=822994&group_id=5470 From noreply at sourceforge.net Tue Oct 14 17:49:09 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Tue Oct 14 17:52:56 2003 Subject: [Patches] [ python-Patches-785752 ] Documentation for platform module Message-ID: Patches item #785752, was opened at 2003-08-08 23:05 Message generated for change (Comment added) made by bcannon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=785752&group_id=5470 Category: Documentation Group: Python 2.3 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Bjorn Pettersen (bpettersen) Assigned to: Brett Cannon (bcannon) Summary: Documentation for platform module Initial Comment: This is my first time writing module documentation so be gentle . Let me know if I did something wrong and I'll fix and resubmit (compiling the docs sounded like dark magic, so I skipped that part ;-) -- bjorn ---------------------------------------------------------------------- >Comment By: Brett Cannon (bcannon) Date: 2003-10-14 14:49 Message: Logged In: YES user_id=357491 OK, with MAL's blessing I checked in libplatform.tex and added an entry in Doc/lib/lib.text under the generic OS section. Closes bug #726911. Now Fred just has to work his magic. =) ---------------------------------------------------------------------- Comment By: M.-A. Lemburg (lemburg) Date: 2003-10-14 01:11 Message: Logged In: YES user_id=38388 Looks good :-) ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-10-13 18:59 Message: Logged In: YES user_id=357491 OK, I made the changes as requested by MAL. Do this good enough to you, MA, to check this in as-is? ---------------------------------------------------------------------- Comment By: M.-A. Lemburg (lemburg) Date: 2003-10-13 00:35 Message: Logged In: YES user_id=38388 No need to change the doc-strings (the source for all of the APIs in question is included in the same file, so there's no problem). Thanks. ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-10-12 13:33 Message: Logged In: YES user_id=357491 OK, I will try to get to the fixes today, MA. Do you want the docstrings changed as well? I can understand doing that for the True/False deal, but not necessarily for _default_architecture. And as for a tool that automates this, I don't know but I was wondering the same thing last night. If not it might be worth it to try to come up with a rough one that at least takes the docstrings, and puts them into a rough LaTeX document that at least spits out a template header and does the function parameter lists and such. In other words get the brain-dead LaTeX conversion stuff out of the way. ---------------------------------------------------------------------- Comment By: M.-A. Lemburg (lemburg) Date: 2003-10-12 03:41 Message: Logged In: YES user_id=38388 Some nits: References to _default_architecture should either get removed or made explicit in that the defaults are listed somewhere in the documentation. I'd suggest to use "reasonable defaults are chosen" since that leaves the details to the module rather than the documentation. References to "True" and "False" should be changed to true and false. The APIs don't use Python 2.1 style boolean singletons and only check for truth values (needed for Python 1.5.2 compatibility and useful in general). _popen is used in the documentation but not explained. I'd suggest to remove these details from the documentation. Apart from that: great job ! (BTW, is there a tool which does this in an automatic way, e.g. in docutils ?) ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-10-11 22:16 Message: Logged In: YES user_id=357491 Ran the docs through texcheck.py and added spaces between function parameters. It looks like it is pretty much just a copy and paste job from the docstrings, right, Bjorn? If so then as long as Bjorn did his copying after 2003-08-05 when I committed some cleanup of the of the docstrings there is no need to check it for correctness in terms of grammar and such. So if Bjorn can verify he copied and pasted the docs after my patch to platform.py I can commit this so Fred can work his LaTeX magic on it. ---------------------------------------------------------------------- Comment By: Fred L. Drake, Jr. (fdrake) Date: 2003-08-14 20:18 Message: Logged In: YES user_id=3066 Marc-Andre, could you please review these docs? Thanks! ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-08-11 00:26 Message: Logged In: YES user_id=357491 If this patch gets accepted, please close bug #726911. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-08-09 02:17 Message: Logged In: YES user_id=21627 Thanks for this document. It currently does not follow the grammatical conventions. Please use the imperative voice; quoting from PEP 257 It prescribes the function or method's effect as a command ("Do this", "Return that"), not as a description; e.g. don't write "Returns the pathname ...". In addition, please indicate where you suggest this documentation to go in the table-of-contents, preferably by means of a patch. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=785752&group_id=5470 From noreply at sourceforge.net Tue Oct 14 18:58:22 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Tue Oct 14 18:58:29 2003 Subject: [Patches] [ python-Patches-823775 ] use just built python interp. to build the docs. Message-ID: Patches item #823775, was opened at 2003-10-14 22:58 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=823775&group_id=5470 Category: Build Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Matthias Klose (doko) Assigned to: Nobody/Anonymous (nobody) Summary: use just built python interp. to build the docs. Initial Comment: this patch doesn't change the default behaviour, but does allow passing a PYTHON interpreter for building the docs. Of ycourse you could pass MKHOWTO as well, but then you have to know the environmnet (TEXINPUTS) as well. The "$(shell ...)" construct is already used, so it does not introduce a new incompatibility. [note: I think as the default the just built interpreter should be used to build the docs] ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=823775&group_id=5470 From noreply at sourceforge.net Tue Oct 14 22:35:47 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Tue Oct 14 22:35:53 2003 Subject: [Patches] [ python-Patches-823292 ] Optional list.sort() args for DSU pattern and reverse Message-ID: Patches item #823292, was opened at 2003-10-14 03:53 Message generated for change (Comment added) made by rhettinger You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=823292&group_id=5470 Category: Core (C code) Group: Python 2.4 Status: Open Resolution: None Priority: 5 Submitted By: Raymond Hettinger (rhettinger) Assigned to: Nobody/Anonymous (nobody) Summary: Optional list.sort() args for DSU pattern and reverse Initial Comment: Here is a first draft patch as discussed on python-dev. Docs and tests to follow. The keywords are: cmpfunc, key, reverse This patch passes regression tests and a minimal set of basic functionality tests which need to be expanded considerably. I'll need to go back over this one in more detail to check: * Was the code inserted in the right place with respect to the existing anti-mutation code. * Is the strategy of decorating in-place to aggressive? Decoration consists of *replacing* each value x with (x, key(x)). * Verify reference counting and error handling. ---------------------------------------------------------------------- >Comment By: Raymond Hettinger (rhettinger) Date: 2003-10-14 21:35 Message: Logged In: YES user_id=80475 Here is a second patch including unittests and docs. * The optional keywords arguments are: cmp, key, reverse. * The key function triggers a DSU step with a wrapper object that holds the full record, but returns only the key for a comparision. This is fast and doesn't change the underlying stability characteristics of the sort. (I think this was Neil's idea -- and it works well.) * If the key function is not specified, no wrapping occurs so that sort performance is not affected. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=823292&group_id=5470 From noreply at sourceforge.net Wed Oct 15 00:51:10 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 15 00:51:17 2003 Subject: [Patches] [ python-Patches-823292 ] Optional list.sort() args for DSU pattern and reverse Message-ID: Patches item #823292, was opened at 2003-10-14 03:53 Message generated for change (Comment added) made by rhettinger You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=823292&group_id=5470 Category: Core (C code) Group: Python 2.4 Status: Open Resolution: None Priority: 5 Submitted By: Raymond Hettinger (rhettinger) Assigned to: Nobody/Anonymous (nobody) Summary: Optional list.sort() args for DSU pattern and reverse Initial Comment: Here is a first draft patch as discussed on python-dev. Docs and tests to follow. The keywords are: cmpfunc, key, reverse This patch passes regression tests and a minimal set of basic functionality tests which need to be expanded considerably. I'll need to go back over this one in more detail to check: * Was the code inserted in the right place with respect to the existing anti-mutation code. * Is the strategy of decorating in-place to aggressive? Decoration consists of *replacing* each value x with (x, key(x)). * Verify reference counting and error handling. ---------------------------------------------------------------------- >Comment By: Raymond Hettinger (rhettinger) Date: 2003-10-14 23:51 Message: Logged In: YES user_id=80475 Added a cmp function wrapper so that the key will be unwrapped for a user specified cmp function applied to wrapped keys. ---------------------------------------------------------------------- Comment By: Raymond Hettinger (rhettinger) Date: 2003-10-14 21:35 Message: Logged In: YES user_id=80475 Here is a second patch including unittests and docs. * The optional keywords arguments are: cmp, key, reverse. * The key function triggers a DSU step with a wrapper object that holds the full record, but returns only the key for a comparision. This is fast and doesn't change the underlying stability characteristics of the sort. (I think this was Neil's idea -- and it works well.) * If the key function is not specified, no wrapping occurs so that sort performance is not affected. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=823292&group_id=5470 From noreply at sourceforge.net Wed Oct 15 13:55:24 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 15 13:55:41 2003 Subject: [Patches] [ python-Patches-823292 ] Optional list.sort() args for DSU pattern and reverse Message-ID: Patches item #823292, was opened at 2003-10-14 03:53 Message generated for change (Comment added) made by rhettinger You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=823292&group_id=5470 Category: Core (C code) Group: Python 2.4 Status: Open Resolution: None Priority: 5 Submitted By: Raymond Hettinger (rhettinger) Assigned to: Nobody/Anonymous (nobody) Summary: Optional list.sort() args for DSU pattern and reverse Initial Comment: Here is a first draft patch as discussed on python-dev. Docs and tests to follow. The keywords are: cmpfunc, key, reverse This patch passes regression tests and a minimal set of basic functionality tests which need to be expanded considerably. I'll need to go back over this one in more detail to check: * Was the code inserted in the right place with respect to the existing anti-mutation code. * Is the strategy of decorating in-place to aggressive? Decoration consists of *replacing* each value x with (x, key(x)). * Verify reference counting and error handling. ---------------------------------------------------------------------- >Comment By: Raymond Hettinger (rhettinger) Date: 2003-10-15 12:55 Message: Logged In: YES user_id=80475 Updated the patch to make reversed sorts stable. The python version of the code is: class sortwrapper: def __init__(self, key, value): self.key = key self.value = value def __cmp__(self, other): return cmp(self.key, other.key) def getvalue(self): return self.value class cmpwrapper: def __init__(self, cmpfunc): self.cmpfunc = cmpfunc def __call__(self, x, y): return self.cmpfunc(x.key, y.key) def sort(self, cmp=None, key=None, reverse=None): if cmp is not None and key is not None: cmp = cmpwrapper(cmp) if key is not None: self[:] = [sortwrapper(key(x), x) for x in self] if reverse is not None: self.reverse() self.sort(cmp) if key is not None: self[:] = [x.getvalue() for x in self] if reverse is not None: self.reverse() ---------------------------------------------------------------------- Comment By: Raymond Hettinger (rhettinger) Date: 2003-10-14 23:51 Message: Logged In: YES user_id=80475 Added a cmp function wrapper so that the key will be unwrapped for a user specified cmp function applied to wrapped keys. ---------------------------------------------------------------------- Comment By: Raymond Hettinger (rhettinger) Date: 2003-10-14 21:35 Message: Logged In: YES user_id=80475 Here is a second patch including unittests and docs. * The optional keywords arguments are: cmp, key, reverse. * The key function triggers a DSU step with a wrapper object that holds the full record, but returns only the key for a comparision. This is fast and doesn't change the underlying stability characteristics of the sort. (I think this was Neil's idea -- and it works well.) * If the key function is not specified, no wrapping occurs so that sort performance is not affected. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=823292&group_id=5470 From noreply at sourceforge.net Wed Oct 15 23:44:57 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 15 23:45:03 2003 Subject: [Patches] [ python-Patches-823292 ] Optional list.sort() args for DSU pattern and reverse Message-ID: Patches item #823292, was opened at 2003-10-14 03:53 Message generated for change (Settings changed) made by rhettinger You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=823292&group_id=5470 Category: Core (C code) Group: Python 2.4 >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: Raymond Hettinger (rhettinger) Assigned to: Nobody/Anonymous (nobody) Summary: Optional list.sort() args for DSU pattern and reverse Initial Comment: Here is a first draft patch as discussed on python-dev. Docs and tests to follow. The keywords are: cmpfunc, key, reverse This patch passes regression tests and a minimal set of basic functionality tests which need to be expanded considerably. I'll need to go back over this one in more detail to check: * Was the code inserted in the right place with respect to the existing anti-mutation code. * Is the strategy of decorating in-place to aggressive? Decoration consists of *replacing* each value x with (x, key(x)). * Verify reference counting and error handling. ---------------------------------------------------------------------- >Comment By: Raymond Hettinger (rhettinger) Date: 2003-10-15 22:44 Message: Logged In: YES user_id=80475 Modified patch as suggested by Tim Peters and eliminated the use of GC for the wrapper objects. Committed as: Objects/listobject.c 2.159 Doc/lib/libstdtypes.tex 1.134 Lib/test/test_sort 1.5 ---------------------------------------------------------------------- Comment By: Raymond Hettinger (rhettinger) Date: 2003-10-15 12:55 Message: Logged In: YES user_id=80475 Updated the patch to make reversed sorts stable. The python version of the code is: class sortwrapper: def __init__(self, key, value): self.key = key self.value = value def __cmp__(self, other): return cmp(self.key, other.key) def getvalue(self): return self.value class cmpwrapper: def __init__(self, cmpfunc): self.cmpfunc = cmpfunc def __call__(self, x, y): return self.cmpfunc(x.key, y.key) def sort(self, cmp=None, key=None, reverse=None): if cmp is not None and key is not None: cmp = cmpwrapper(cmp) if key is not None: self[:] = [sortwrapper(key(x), x) for x in self] if reverse is not None: self.reverse() self.sort(cmp) if key is not None: self[:] = [x.getvalue() for x in self] if reverse is not None: self.reverse() ---------------------------------------------------------------------- Comment By: Raymond Hettinger (rhettinger) Date: 2003-10-14 23:51 Message: Logged In: YES user_id=80475 Added a cmp function wrapper so that the key will be unwrapped for a user specified cmp function applied to wrapped keys. ---------------------------------------------------------------------- Comment By: Raymond Hettinger (rhettinger) Date: 2003-10-14 21:35 Message: Logged In: YES user_id=80475 Here is a second patch including unittests and docs. * The optional keywords arguments are: cmp, key, reverse. * The key function triggers a DSU step with a wrapper object that holds the full record, but returns only the key for a comparision. This is fast and doesn't change the underlying stability characteristics of the sort. (I think this was Neil's idea -- and it works well.) * If the key function is not specified, no wrapping occurs so that sort performance is not affected. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=823292&group_id=5470 From noreply at sourceforge.net Thu Oct 16 17:32:10 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Thu Oct 16 17:32:16 2003 Subject: [Patches] [ python-Patches-722638 ] Better output for unittest Message-ID: Patches item #722638, was opened at 2003-04-16 19:49 Message generated for change (Comment added) made by purcell You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=722638&group_id=5470 Category: Library (Lib) Group: None Status: Open Resolution: None Priority: 5 Submitted By: Thomas Heller (theller) Assigned to: Steve Purcell (purcell) Summary: Better output for unittest Initial Comment: This patch enables more useful output for unittests: If a test crashes (raises an unexpected exception), a full traceback is printed. If a test failes, the output is something like this: ======================================== FAIL: test_failUnlessEqual (__main__.FailingTests) ---------------------------------------------------------------------- TestFailed: 0 != 1 File "xunit.py", line 12, in test_failUnlessEqual self.failUnlessEqual(self.a, self.b) ======================================== Before, this was printed: ======================================== FAIL: test_failIfEqual (__main__.FailingTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "xunit.py", line 15, in test_failIfEqual self.failIfEqual(self.a, self.a) File "c:\python23\lib\unittest.py", line 300, in failIfEqual raise self.failureException, AssertionError: 0 == 0 ======================================== If needed, I can upload the test script I use, together with the results before and after the patch. This has shortly been discussed on c.l.p, response was mostly positive. http://tinyurl.com/9obf ---------------------------------------------------------------------- >Comment By: Steve Purcell (purcell) Date: 2003-10-16 23:32 Message: Logged In: YES user_id=21477 I'm looking at all this and will certainly incorporate some of the suggestions: - I'm +1 on the clearer message for assertRaises() - I'm +1 on clearer messages for _all_ assert*()/fail*() methods - The TestFailed exception doesn't really add much, since AssertionError works well already - I'm loathe to ever suppress tracebacks, or fiddle with them much: the traceback is the canonical way for IDEs to find lines in the code ---------------------------------------------------------------------- Comment By: Thomas Heller (theller) Date: 2003-10-14 20:05 Message: Logged In: YES user_id=11105 Assigned to Steve for pronouncement (didn't he already comment on python-dev some time ago?) ---------------------------------------------------------------------- Comment By: Tim Peters (tim_one) Date: 2003-05-06 22:27 Message: Logged In: YES user_id=31435 That's why I'm split: I do like the new *messages* better (their content), but I don't like losing the tracebacks. Sometimes it's a bug in the test driver-- or in 20 layers of test driver code --and sometimes it's even a bug in unittest itself. The traceback is a fundamental tool when things go wrong, so I'm never in favor of hiding parts of tracebacks (hiding could be appropriate if you *knew* the true cause isn't in the part you're hiding -- but you can't know that). ---------------------------------------------------------------------- Comment By: Thomas Heller (theller) Date: 2003-05-06 22:08 Message: Logged In: YES user_id=11105 That's exactly how I was feeling. When an assertRaises test failed, I usually inserted the call it made before this line, to see the real traceback. And that's what this patch tries to fix. I don't want to see tracebacks when a test fails, I want a clear indication that it failed (the patch prints "TestFailed" instead of "Traceback:"). For the output of a failed assertRaises, see the first comment I added. IMO it clearly says what which exception was expected, and which one was raised. ---------------------------------------------------------------------- Comment By: Tim Peters (tim_one) Date: 2003-05-06 21:52 Message: Logged In: YES user_id=31435 I'm split. The current output when assertRaises fails is a frequent cause of head-scratching ("what? it's complaining because ValueError got raised? ... no, it's complaining because ValueError wasn't raised? ..."). OTOH, I see no value in trimming the traceback. Now that *could* be because the assertRaises output can be so confusing that we end up using the rest of the traceback to figure out what unittest is trying to tell us in those cases. ---------------------------------------------------------------------- Comment By: Raymond Hettinger (rhettinger) Date: 2003-05-06 09:11 Message: Logged In: YES user_id=80475 I would like to see Thomas's patch or some comformant variant go in. Usability problems are a bug. Friendlier output makes it more likely that unittest will be used in the first place. ---------------------------------------------------------------------- Comment By: Thomas Heller (theller) Date: 2003-04-25 14:52 Message: Logged In: YES user_id=11105 Last attempt to convince you: I could try to port the changes to Python 1.5, if you want to stay compatible. If you still reject the patch (you're the unittest boss), I'll have to live with subclassing unittest ;-) ---------------------------------------------------------------------- Comment By: Steve Purcell (purcell) Date: 2003-04-25 14:37 Message: Logged In: YES user_id=21477 After investigation, this seems to work with Jython (though not JPython, which didn't have tb_next etc.). In general I've been trying hard to keep 'unittest.py' vanilla, since a lot of people are still using it with Python 1.5 and even JPython. Hence the complete absence of string methods, list comprehensions and other new language features. Don't know if this policy makes sense in the longer term, but I value it right now. In that sense, I'm not sure if it's worth changing the message. ---------------------------------------------------------------------- Comment By: Thomas Heller (theller) Date: 2003-04-25 14:05 Message: Logged In: YES user_id=11105 What a pity! What exactly does not work in Jython? Before giving up on this, there are at least two ways to proceed: - Behave as before in Jython, and use the better output in CPython. - Apply this patch only the the unittest version bundled with CPython. How are the chances for one of this? ---------------------------------------------------------------------- Comment By: Steve Purcell (purcell) Date: 2003-04-25 13:52 Message: Logged In: YES user_id=21477 This behaviour of trimming the traceback was implemented in a previous version of PyUnit, but dropped because it did not work with Jython. My aim is that the same 'unittest.py' should work out of the box with both CPython and Jython. ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-04-20 04:57 Message: Logged In: YES user_id=357491 I like the new output, personally. I am +1 on letting Thomas add the changes. Does this mean we no longer treat unittest as a separate project? ---------------------------------------------------------------------- Comment By: Thomas Heller (theller) Date: 2003-04-17 17:31 Message: Logged In: YES user_id=11105 Attaching new version of the patch (unittest-2.diff). This gives better output for failUnlessRaises, like this: ====================================================================== FAIL: test_failUnlessRaises (__main__.FailingTests) ---------------------------------------------------------------------- TestFailed: wrong exception, expected TypeError got: 'ValueError: 10' File "xunit.py", line 18, in test_failUnlessRaises self.failUnlessRaises(TypeError, self._raise, ValueError, 10) ====================================================================== FAIL: test_failUnlessRaises_2 (__main__.FailingTests) ---------------------------------------------------------------------- TestFailed: wrong exception, expected TypeError, IndexError, or AttributeError got: 'ValueError: 10' File "xunit.py", line 21, in test_failUnlessRaises_2 self.failUnlessRaises((TypeError, IndexError, AttributeError), self._raise, ValueError, 10) ---------------------------------------------------------------------- ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=722638&group_id=5470 From noreply at sourceforge.net Fri Oct 17 01:47:23 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 17 01:47:43 2003 Subject: [Patches] [ python-Patches-825313 ] Add addition isxxx functions to string object. Message-ID: Patches item #825313, was opened at 2003-10-16 22:47 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825313&group_id=5470 Category: Core (C code) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Eric Huss (ehuss) Assigned to: Nobody/Anonymous (nobody) Summary: Add addition isxxx functions to string object. Initial Comment: This patch adds the following ctype.h functions to the string object. iscntrl isgraph isprint ispunct isxdigit These are pretty standard C functions...I'm not sure why they were left out. It also deletes a lot of duplicated code. This patch might not be 100% useful because it does not have the unicode equivalents. Thoughts? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825313&group_id=5470 From noreply at sourceforge.net Fri Oct 17 01:47:45 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 17 01:48:00 2003 Subject: [Patches] [ python-Patches-825313 ] Add additional isxxx functions to string object. Message-ID: Patches item #825313, was opened at 2003-10-16 22:47 Message generated for change (Settings changed) made by ehuss You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825313&group_id=5470 Category: Core (C code) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Eric Huss (ehuss) Assigned to: Nobody/Anonymous (nobody) >Summary: Add additional isxxx functions to string object. Initial Comment: This patch adds the following ctype.h functions to the string object. iscntrl isgraph isprint ispunct isxdigit These are pretty standard C functions...I'm not sure why they were left out. It also deletes a lot of duplicated code. This patch might not be 100% useful because it does not have the unicode equivalents. Thoughts? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825313&group_id=5470 From noreply at sourceforge.net Fri Oct 17 06:24:58 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 17 06:25:02 2003 Subject: [Patches] [ python-Patches-825417 ] telnetlib timeout fix (bug 822974) Message-ID: Patches item #825417, was opened at 2003-10-17 12:24 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825417&group_id=5470 Category: Library (Lib) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Johan M. Hahn (johahn) Assigned to: Nobody/Anonymous (nobody) Summary: telnetlib timeout fix (bug 822974) Initial Comment: Timeout behaviour do not match the docs. This patch fixes the read_until and expect methods to decreese the timeout between subsequent calls to select.select. See bu g 822974 for more info. My system: Python 2.3 final Windows 2000 5.00.2951 sp4 ...johahn ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825417&group_id=5470 From noreply at sourceforge.net Fri Oct 17 13:49:36 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 17 13:49:52 2003 Subject: [Patches] [ python-Patches-825639 ] let's get rid of cyclic object comparison Message-ID: Patches item #825639, was opened at 2003-10-17 17:49 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825639&group_id=5470 Category: Core (C code) Group: Python 2.4 Status: Open Resolution: None Priority: 5 Submitted By: Armin Rigo (arigo) Assigned to: Nobody/Anonymous (nobody) Summary: let's get rid of cyclic object comparison Initial Comment: Comparison of objects with recursive references is a cool feature but it leaves too many questions open and feels too much like a "do-what-i-mean" hack. Attached patch casts it into the obscure world of CVS history. On the positive side, the patch contributes a Py_EnterRecursiveCall()/Py_LeaveRecursiveCall() pair of functions to the C API, to use at any point where an infinite C-level recursion could occur. This is now used by: eval_frame() PyObject_Compare() PyObject_RichCompare() instance_call() and maybe it should be extended to cPickle.c, which has its own notion of maximum nesting as well. The diff also changes the tests to expect a RuntimeError when comparing nested structures. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825639&group_id=5470 From noreply at sourceforge.net Fri Oct 17 14:53:29 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 17 14:53:33 2003 Subject: [Patches] [ python-Patches-825679 ] document string.isfoo() behaviour with empty strings Message-ID: Patches item #825679, was opened at 2003-10-17 13:53 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825679&group_id=5470 Category: Documentation Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Andrew Gaul (gaul) Assigned to: Nobody/Anonymous (nobody) Summary: document string.isfoo() behaviour with empty strings Initial Comment: Add documentation to string.isfoo() discussing behaviour with empty strings. Change wording to be consistent between docstrings and documentation. Change docstring double whitespace between words to single. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825679&group_id=5470 From noreply at sourceforge.net Fri Oct 17 15:26:20 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 17 15:26:24 2003 Subject: [Patches] [ python-Patches-825313 ] Add additional isxxx functions to string object. Message-ID: Patches item #825313, was opened at 2003-10-17 00:47 Message generated for change (Comment added) made by gaul You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825313&group_id=5470 Category: Core (C code) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Eric Huss (ehuss) Assigned to: Nobody/Anonymous (nobody) Summary: Add additional isxxx functions to string object. Initial Comment: This patch adds the following ctype.h functions to the string object. iscntrl isgraph isprint ispunct isxdigit These are pretty standard C functions...I'm not sure why they were left out. It also deletes a lot of duplicated code. This patch might not be 100% useful because it does not have the unicode equivalents. Thoughts? ---------------------------------------------------------------------- Comment By: Andrew Gaul (gaul) Date: 2003-10-17 14:26 Message: Logged In: YES user_id=139865 I like shedding ~80 lines with is_helper, especially if you add inline. Otherwise, function call overhead might be incurred for every call to C isfoo() instead of inlining the comparison. I dislike increasing the distinction between ASCII and Unicode strings, although Unicode strings already have isdecimal and isnumeric methods which ASCII strings lack. I would at least add iscntrl, ispunct, and isxdigit to Unicode strings if they are added to ASCII strings. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825313&group_id=5470 From noreply at sourceforge.net Fri Oct 17 15:53:43 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 17 15:53:59 2003 Subject: [Patches] [ python-Patches-825313 ] Add additional isxxx functions to string object. Message-ID: Patches item #825313, was opened at 2003-10-16 22:47 Message generated for change (Comment added) made by bcannon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825313&group_id=5470 Category: Core (C code) >Group: Python 2.4 Status: Open Resolution: None >Priority: 4 Submitted By: Eric Huss (ehuss) Assigned to: Nobody/Anonymous (nobody) Summary: Add additional isxxx functions to string object. Initial Comment: This patch adds the following ctype.h functions to the string object. iscntrl isgraph isprint ispunct isxdigit These are pretty standard C functions...I'm not sure why they were left out. It also deletes a lot of duplicated code. This patch might not be 100% useful because it does not have the unicode equivalents. Thoughts? ---------------------------------------------------------------------- >Comment By: Brett Cannon (bcannon) Date: 2003-10-17 12:53 Message: Logged In: YES user_id=357491 I don't really see a good use for any of these. Chances that most people are going to need most of these is very minor (heck, I don't even know what isgraph would test for). isxdigit might be slightly helpful if you renamed it isnum, but you can fake that already with ``x.isalnum() and not x.isalpha()``. But in general I am -1 on these. str has enough methods as it is. ---------------------------------------------------------------------- Comment By: Andrew Gaul (gaul) Date: 2003-10-17 12:26 Message: Logged In: YES user_id=139865 I like shedding ~80 lines with is_helper, especially if you add inline. Otherwise, function call overhead might be incurred for every call to C isfoo() instead of inlining the comparison. I dislike increasing the distinction between ASCII and Unicode strings, although Unicode strings already have isdecimal and isnumeric methods which ASCII strings lack. I would at least add iscntrl, ispunct, and isxdigit to Unicode strings if they are added to ASCII strings. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825313&group_id=5470 From noreply at sourceforge.net Fri Oct 17 20:34:53 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 17 20:34:57 2003 Subject: [Patches] [ python-Patches-825814 ] Add list.copysort() Message-ID: Patches item #825814, was opened at 2003-10-17 19:34 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825814&group_id=5470 Category: Core (C code) Group: Python 2.4 Status: Open Resolution: None Priority: 5 Submitted By: Raymond Hettinger (rhettinger) Assigned to: Nobody/Anonymous (nobody) Summary: Add list.copysort() Initial Comment: As discussed on py-dev, this returns a sorted copy of a list while leaving the original intact. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825814&group_id=5470 From ronnymitch5s at webtv.net Sat Oct 18 02:21:05 2003 From: ronnymitch5s at webtv.net (heyen) Date: Sat Oct 18 02:21:15 2003 Subject: [Patches] patches, Higher Education Diploma Program Message-ID: An HTML attachment was scrubbed... URL: http://mail.python.org/pipermail/patches/attachments/20031018/0c1059cc/attachment.html From noreply at sourceforge.net Sat Oct 18 02:26:40 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 18 02:26:44 2003 Subject: [Patches] [ python-Patches-825814 ] Add list.copysort() Message-ID: Patches item #825814, was opened at 2003-10-17 19:34 Message generated for change (Comment added) made by rhettinger You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825814&group_id=5470 Category: Core (C code) Group: Python 2.4 Status: Open Resolution: None Priority: 5 Submitted By: Raymond Hettinger (rhettinger) Assigned to: Nobody/Anonymous (nobody) Summary: Add list.copysort() Initial Comment: As discussed on py-dev, this returns a sorted copy of a list while leaving the original intact. ---------------------------------------------------------------------- >Comment By: Raymond Hettinger (rhettinger) Date: 2003-10-18 01:26 Message: Logged In: YES user_id=80475 Revised the patch to avoid an unnecessary copy whenever the underlying object is not referenced anywhere else -- this occurs in the common use case: for elem in d.keys().copysort(): . . . ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825814&group_id=5470 From noreply at sourceforge.net Sat Oct 18 05:32:14 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 18 05:33:20 2003 Subject: [Patches] [ python-Patches-662475 ] 642391: tempfile.mktemp() docs to include dir info Message-ID: Patches item #662475, was opened at 2003-01-05 05:41 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=662475&group_id=5470 Category: Documentation Group: Python 2.3 >Status: Closed >Resolution: Rejected Priority: 5 Submitted By: Christopher Blunck (blunck2) Assigned to: Martin v. L?wis (loewis) Summary: 642391: tempfile.mktemp() docs to include dir info Initial Comment: added text that states that if a directory is not provided to mktemp(), the system wide temporary directory, or a suitable unique directory name is prepended to the filename ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 11:32 Message: Logged In: YES user_id=21627 So closing the patch as rejected, and the bug report as "won't fix". ---------------------------------------------------------------------- Comment By: Michael Bartl (midramas) Date: 2003-09-25 00:35 Message: Logged In: YES user_id=31511 I'd propose to close this patch due to the reasons given in the comment from M.v. Loewis. Additionaly the tempfile.mktemp() has been marked deprecated as of Python 2.3. The same procedure could be applied to the original bug #642391 since adding documentation to an insecure deprecated function only gives the developers more choices on blasting their systems. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-01-15 13:18 Message: Logged In: YES user_id=21627 I don't think this patch addresses the concern of bug 642391. The issue is not in which directory the temporary files are created, but whether the temporary files need to be files. They need not: mktemp can also be used to create temporary directories. Of course, as mktemp suffers from security problems, using mkdtemp (new in 2.3) is better to create temporary directories. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=662475&group_id=5470 From noreply at sourceforge.net Sat Oct 18 05:38:37 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 18 05:38:52 2003 Subject: [Patches] [ python-Patches-809535 ] Mention behavior of seek() on text files Message-ID: Patches item #809535, was opened at 2003-09-20 00:11 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=809535&group_id=5470 Category: Documentation Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Jeff Epler (jepler) Assigned to: Martin v. L?wis (loewis) Summary: Mention behavior of seek() on text files Initial Comment: Document the fact that seek() on text files can lead to undefined results, rather than leaving the user to read ftell() docs to find out. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 11:38 Message: Logged In: YES user_id=21627 Thanks for the patch. Applied as libstdtypes.tex 1.129.8.5 fileobject.c 2.179.8.4 libstdtypes.tex 1.135 fileobject.c 2.185 ---------------------------------------------------------------------- Comment By: Jeff Epler (jepler) Date: 2003-09-20 16:55 Message: Logged In: YES user_id=2772 ":se of other offsets" should have read "Use of other offsets". Or else it should match the libstdtypes.tex wording, "Other offsets cause undefined behavior." The patch I'm attaching now says "Use of other offets causes", and copies the docstring warning "not all file objects are seekable" into the tex documentation. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-09-20 13:07 Message: Logged In: YES user_id=21627 what do you mean with " :se of other offsets" ??? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=809535&group_id=5470 From noreply at sourceforge.net Sat Oct 18 05:43:20 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 18 05:43:39 2003 Subject: [Patches] [ python-Patches-755677 ] 755617: better docs for os.chmod Message-ID: Patches item #755677, was opened at 2003-06-17 05:35 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=755677&group_id=5470 Category: Documentation Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Christopher Blunck (blunck2) Assigned to: Martin v. L?wis (loewis) Summary: 755617: better docs for os.chmod Initial Comment: As per the discussion thread on c.l.p and summarized by Matthew Shomphe ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 11:43 Message: Logged In: YES user_id=21627 blunck2, are you willing to revise the patch in the indicated direction, i.e. document the real semantics of os.chmod on Windows, while keeping the material which primarily applies to Unix? ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-09-20 18:04 Message: Logged In: YES user_id=21627 I don't think that patch fixes the bug - IMO, the description of mode gets worse, not better, with this patch: 1. The mode is *not* a "four-digit number". It is a plain integer instead. Some people find it convenient to write this number in base8, using Python's octal number notation. 2. Other people find it convenient to use a symbolic bit mask to compute the number. Your patch removes the listing of the possible symbolic constants, which is bad. 3. You fail to mention some of the bits (e.g. the s-bits) which are available in the current documentation. 4. The patch fails to address the platform differences which atleast logistix considers important, in his comment to #755617 ---------------------------------------------------------------------- Comment By: Christopher Blunck (blunck2) Date: 2003-06-23 15:12 Message: Logged In: YES user_id=531881 Sure- According to the discussion here: http://groups.google.com/groups?hl=en&lr=&ie=UTF-8&threadm=mailman.1055808030.15325.python-list%40python.org&rnum=1&prev=/groups%3Fq%3Dos.chmod%2Bgroup:comp.lang.python.*%26hl%3Den%26lr%3D%26ie%3DUTF-8%26group%3Dcomp.lang.python.*%26selm%3Dmailman.1055808030.15325.python-list%2540python.org%26rnum%3D1 there was confusion as the behavior of os.chmod() on non-Unix platforms. Discussion led to a recommendation for a documentation change, which was submitted as an attachment to the bug report located here: http://www.python.org/sf/755617 The submitter of the bug report didn't know how to submit a patch. I decided to capture the documentation, add it to the appropriate tex file, produce a patch, and submit it to sf. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-06-21 15:33 Message: Logged In: YES user_id=21627 Can you give the rationale for this change, for those of us that don't know which thread you are referring to? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=755677&group_id=5470 From noreply at sourceforge.net Sat Oct 18 05:55:48 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 18 05:56:12 2003 Subject: [Patches] [ python-Patches-825679 ] document string.isfoo() behaviour with empty strings Message-ID: Patches item #825679, was opened at 2003-10-17 20:53 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825679&group_id=5470 Category: Documentation Group: Python 2.3 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Andrew Gaul (gaul) Assigned to: Nobody/Anonymous (nobody) Summary: document string.isfoo() behaviour with empty strings Initial Comment: Add documentation to string.isfoo() discussing behaviour with empty strings. Change wording to be consistent between docstrings and documentation. Change docstring double whitespace between words to single. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 11:55 Message: Logged In: YES user_id=21627 Thanks for the patch. Applied as libstdtypes.tex 1.136 stringobject.c 2.211 unicodeobject.c 2.200 libstdtypes.tex 1.129.8.6 stringobject.c 2.209.8.2 unicodeobject.c 2.190.6.8 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825679&group_id=5470 From noreply at sourceforge.net Sat Oct 18 05:58:33 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 18 05:58:57 2003 Subject: [Patches] [ python-Patches-825313 ] Add additional isxxx functions to string object. Message-ID: Patches item #825313, was opened at 2003-10-17 07:47 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825313&group_id=5470 Category: Core (C code) Group: Python 2.4 Status: Open Resolution: None Priority: 4 Submitted By: Eric Huss (ehuss) Assigned to: Nobody/Anonymous (nobody) Summary: Add additional isxxx functions to string object. Initial Comment: This patch adds the following ctype.h functions to the string object. iscntrl isgraph isprint ispunct isxdigit These are pretty standard C functions...I'm not sure why they were left out. It also deletes a lot of duplicated code. This patch might not be 100% useful because it does not have the unicode equivalents. Thoughts? ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 11:58 Message: Logged In: YES user_id=21627 The patch is incomplete, as it comes without documentation and test cases. Eric, I would normally request these at this point, but I'm also with Brett that wrapping these functions might be useless. What is the rationale for including them? ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-10-17 21:53 Message: Logged In: YES user_id=357491 I don't really see a good use for any of these. Chances that most people are going to need most of these is very minor (heck, I don't even know what isgraph would test for). isxdigit might be slightly helpful if you renamed it isnum, but you can fake that already with ``x.isalnum() and not x.isalpha()``. But in general I am -1 on these. str has enough methods as it is. ---------------------------------------------------------------------- Comment By: Andrew Gaul (gaul) Date: 2003-10-17 21:26 Message: Logged In: YES user_id=139865 I like shedding ~80 lines with is_helper, especially if you add inline. Otherwise, function call overhead might be incurred for every call to C isfoo() instead of inlining the comparison. I dislike increasing the distinction between ASCII and Unicode strings, although Unicode strings already have isdecimal and isnumeric methods which ASCII strings lack. I would at least add iscntrl, ispunct, and isxdigit to Unicode strings if they are added to ASCII strings. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825313&group_id=5470 From noreply at sourceforge.net Sat Oct 18 06:05:01 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 18 06:05:31 2003 Subject: [Patches] [ python-Patches-823259 ] Updated .spec file. Message-ID: Patches item #823259, was opened at 2003-10-14 09:50 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=823259&group_id=5470 Category: Build Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Sean Reifschneider (jafo) Assigned to: Nobody/Anonymous (nobody) Summary: Updated .spec file. Initial Comment: I have created a new .spec file with a few small changes and one larger one. This version detects if the HTML documentation is available, and continues building without the documentation if it is not available. This goes in Misc/RPMS ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 12:05 Message: Logged In: YES user_id=21627 I'm concerned with the replacement of /usr/local/bin/python - couldn't this also possibly change binary files, in an then-unpredictable manner? What files does that actually change? I'm also concerned with the silent changes. Can you please explicltly describe the smaller changes? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=823259&group_id=5470 From noreply at sourceforge.net Sat Oct 18 06:11:12 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 18 06:11:39 2003 Subject: [Patches] [ python-Patches-823775 ] use just built python interp. to build the docs. Message-ID: Patches item #823775, was opened at 2003-10-15 00:58 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=823775&group_id=5470 Category: Build Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Matthias Klose (doko) Assigned to: Nobody/Anonymous (nobody) Summary: use just built python interp. to build the docs. Initial Comment: this patch doesn't change the default behaviour, but does allow passing a PYTHON interpreter for building the docs. Of ycourse you could pass MKHOWTO as well, but then you have to know the environmnet (TEXINPUTS) as well. The "$(shell ...)" construct is already used, so it does not introduce a new incompatibility. [note: I think as the default the just built interpreter should be used to build the docs] ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 12:11 Message: Logged In: YES user_id=21627 The patch does not apply to the CVS trunk. Please don't remove the unused MKHOWTO line, and please provide separate patches for 2.3 and the trunk. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=823775&group_id=5470 From noreply at sourceforge.net Sat Oct 18 06:21:38 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 18 06:21:50 2003 Subject: [Patches] [ python-Patches-822994 ] StringIO.py clean-up. Message-ID: Patches item #822994, was opened at 2003-10-13 21:47 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=822994&group_id=5470 Category: Library (Lib) Group: Python 2.3 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Wojtek Walczak (gminick) Assigned to: Nobody/Anonymous (nobody) Summary: StringIO.py clean-up. Initial Comment: Well, a one frequently used piece of code closed into function, self.closed returns True/False instead of 1/0, self.softspace removed because it wasn't used. Sorry for wasting your time if you don't treat it as a clean-up ;) ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 12:21 Message: Logged In: YES user_id=21627 I found that isclosed is a bad function name: it is no predicate (i.e. doesn't return bool), so I have renamed the function, and committed the patch as StringIO.py 1.30. ---------------------------------------------------------------------- Comment By: Wojtek Walczak (gminick) Date: 2003-10-14 21:53 Message: Logged In: YES user_id=679226 Sorry, self.softspace is back again in the code. New patch attached. Thank you for a comment, Michael. ---------------------------------------------------------------------- Comment By: Michael Hudson (mwh) Date: 2003-10-14 13:43 Message: Logged In: YES user_id=6656 softspace can be used, just not in this file. don't take it out. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=822994&group_id=5470 From noreply at sourceforge.net Sat Oct 18 06:25:03 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 18 06:25:27 2003 Subject: [Patches] [ python-Patches-806800 ] NetBSD py_curses.h fix Message-ID: Patches item #806800, was opened at 2003-09-15 22:47 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=806800&group_id=5470 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Marc Recht (marc) Assigned to: Nobody/Anonymous (nobody) Summary: NetBSD py_curses.h fix Initial Comment: On NetBSD, [n]curses.h and stdlib.h/wchar.h use different guards against multiple definition of wchar_t and wint_t. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 12:25 Message: Logged In: YES user_id=21627 Ok, then I still maintain that this is a bug in FreeBSD - namely, in the package. There should then still be a test for versions, so that we know when we can take the work-around out. Otherwise, the work-around will stay in forever, as we have no means of knowing whether it is still needed. That would be bad. ---------------------------------------------------------------------- Comment By: Marc Recht (marc) Date: 2003-09-23 19:31 Message: Logged In: YES user_id=205 Just one note that might clarify things a bit more... ncurses is installed with the pkgsrc system (like FreeBSD's ports). It doesn't get installed with the base system nor is it in one of the system directories. (It's in /usr/pkg.) NetBSD has a curses implementation, but it has not (yet) all the features Python needs. Because of that we use GNU ncurses (atm 5.3). ---------------------------------------------------------------------- Comment By: Marc Recht (marc) Date: 2003-09-23 16:58 Message: Logged In: YES user_id=205 Oh. I think we're talking at cross-purposes. The _system_ curses isn't used, it's GNU ncurses. And ncurses and char.h clash if _XOPEN_SOURCE_EXTENDED is defined. Naturally the system curses and wchar.h could be included together. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-09-19 00:45 Message: Logged In: YES user_id=21627 Is it the case that curses.h and wchar.h cannot be simultaneously be included if a certain supported #define is given? If so, it is clearly a bug in the header files - it should not be possible to get conflicting declarations by just including system headers. Even if it applies to all released versions of the system, I still need an explicit list of what these versions are, and I need a compile-time failure if a version is encountered that isn't listed. That the next release is only a year away is a good thing - maybe they can fix the bug until then. They won't, of course, fix the bug if nobody tells them there is a bug... ---------------------------------------------------------------------- Comment By: Marc Recht (marc) Date: 2003-09-18 23:51 Message: Logged In: YES user_id=205 Hmm. I won't consider it a bug in NetBSD. Just a clash of declarations.. ;-) The attached patch is needed for 1.6.x and -current (which will be released not sooner than next year). I'm not sure about 1.5, but I'd bet it's the same. So, there's just no restriction possible. It's simply - all - (if _XOPEN_SOURCE_EXTENDED is defined). ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-09-18 20:33 Message: Logged In: YES user_id=21627 That is a work around a NetBSD bug, right? If so, there should be some procedure to retest presence of the bug in new NetBSD releases, and record the versions for which the bug has been found to be present. Then, when the newest release with the bug is not supported in Python anymore, the code can be removed (which might well be 10 years from now). If possible, a code fragment like #if (NetBSD_major == 3) or (NetBSD_major==4) // bug present, add work-around #else #error Please check whether the bug is still present #endif ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=806800&group_id=5470 From noreply at sourceforge.net Sat Oct 18 06:46:38 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 18 06:46:44 2003 Subject: [Patches] [ python-Patches-794400 ] startup file compiler flags Message-ID: Patches item #794400, was opened at 2003-08-25 02:15 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=794400&group_id=5470 Category: Core (C code) Group: None Status: Open Resolution: None Priority: 5 Submitted By: Eric Tiedemann (est) Assigned to: Nobody/Anonymous (nobody) Summary: startup file compiler flags Initial Comment: Allow the startup file to modify the compiler flags. This allows you, for example, to have true division automatically in interactive mode. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 12:46 Message: Logged In: YES user_id=21627 I think there should be some documentation changes to document what precisely can be done in the startup code. ---------------------------------------------------------------------- Comment By: Jeff Epler (jepler) Date: 2003-09-01 16:15 Message: Logged In: YES user_id=2772 Works for me. It's a simple change, even though some code was moved out of line into a separate static function. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=794400&group_id=5470 From noreply at sourceforge.net Sat Oct 18 10:51:07 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 18 10:51:14 2003 Subject: [Patches] [ python-Patches-823259 ] Updated .spec file. Message-ID: Patches item #823259, was opened at 2003-10-14 07:50 Message generated for change (Comment added) made by jafo You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=823259&group_id=5470 Category: Build Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Sean Reifschneider (jafo) Assigned to: Nobody/Anonymous (nobody) Summary: Updated .spec file. Initial Comment: I have created a new .spec file with a few small changes and one larger one. This version detects if the HTML documentation is available, and continues building without the documentation if it is not available. This goes in Misc/RPMS ---------------------------------------------------------------------- >Comment By: Sean Reifschneider (jafo) Date: 2003-10-18 14:51 Message: Logged In: YES user_id=81797 Ideally, the base Python release would not have explicit references to /usr/local/bin/python in it, but instead would use something like autoconf substitutions to put in the actual installation destination in the source. Note that the code which changes /usr/local/bin/python is already in for the 2.3.2 release. I will upload a new version of the patch which does not change /usr/local/bin/python. This will, of course, prevent the .spec file from producting RPMs, but that's ok -- the one that's currently in the head branch doesn't work either. Other changes include: Removal of patches, which can't be referenced from a build directly from the tar-file. Using the RPM tmp directory macro for the buildroot location. Ensuring that the clean directive doesn't accidentally delete the users root directory or another directory. --enable-unicode=ucs4 in configure line. Changing idle location. Sean ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 10:05 Message: Logged In: YES user_id=21627 I'm concerned with the replacement of /usr/local/bin/python - couldn't this also possibly change binary files, in an then-unpredictable manner? What files does that actually change? I'm also concerned with the silent changes. Can you please explicltly describe the smaller changes? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=823259&group_id=5470 From noreply at sourceforge.net Sat Oct 18 13:41:21 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 18 13:41:54 2003 Subject: [Patches] [ python-Patches-825814 ] Add list.copysort() Message-ID: Patches item #825814, was opened at 2003-10-17 19:34 Message generated for change (Comment added) made by rhettinger You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825814&group_id=5470 Category: Core (C code) Group: Python 2.4 Status: Open Resolution: None Priority: 5 Submitted By: Raymond Hettinger (rhettinger) Assigned to: Nobody/Anonymous (nobody) Summary: Add list.copysort() Initial Comment: As discussed on py-dev, this returns a sorted copy of a list while leaving the original intact. ---------------------------------------------------------------------- >Comment By: Raymond Hettinger (rhettinger) Date: 2003-10-18 12:41 Message: Logged In: YES user_id=80475 Rationale for the change --------------------- An inline sort is usable anywhere an expression is allowed. This includes important places like function call arguments and list comprehensions: todo = [t for t in tasks.copysort() if due_today(t)] genhistory(date, events.copysort(key=incidenttime)) Spreading these out over multiple lines is an unnecessary distractor from the problem domain, making the code harder to understand and maintain. Also, using copysort() eliminates a unnecessary variable that changes state from unsorted to sorted and has a lifetime longer than the data is actually needed. In longer code fragments, this decreases code complexity, code length, the number of variables, and decreases the risk of using a variable in the wrong state which is a common source of programming errors. ---------------------------------------------------------------------- Comment By: Raymond Hettinger (rhettinger) Date: 2003-10-18 01:26 Message: Logged In: YES user_id=80475 Revised the patch to avoid an unnecessary copy whenever the underlying object is not referenced anywhere else -- this occurs in the common use case: for elem in d.keys().copysort(): . . . ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825814&group_id=5470 From noreply at sourceforge.net Sat Oct 18 14:09:53 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 18 14:10:30 2003 Subject: [Patches] [ python-Patches-813200 ] Fix test_tempfile: space in Win32 install path bug #811082 Message-ID: Patches item #813200, was opened at 2003-09-26 19:59 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=813200&group_id=5470 Category: Tests Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Michael Bartl (midramas) Assigned to: Nobody/Anonymous (nobody) Summary: Fix test_tempfile: space in Win32 install path bug #811082 Initial Comment: Fix: - corrected arguments passed to spawnl function and added comment to explain tricky win32 behaviour Bug description: test_tempfile.py fails on XP (probably other platforms too) when Python is installed into \Program Files\Python2.3 ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 20:09 Message: Logged In: YES user_id=21627 The patch is incorrect. On Unix, I get "/home/martin/work/py2.4/python": can't open file '"/home/martin/work/py2.4/Lib/test/tf_inherit_check.py"' test test_tempfile failed -- Traceback (most recent call last): File "/home/martin/work/py2.4/Lib/test/test_tempfile.py", line 304, in test_noinherit self.failIf(retval > 0, "child process reports failure") File "/home/martin/work/py2.4/Lib/unittest.py", line 288, in failIf if expr: raise self.failureException, msg AssertionError: child process reports failure ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=813200&group_id=5470 From noreply at sourceforge.net Sat Oct 18 14:41:05 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 18 14:41:13 2003 Subject: [Patches] [ python-Patches-757624 ] Fixing recursive problem in SRE Message-ID: Patches item #757624, was opened at 2003-06-20 03:42 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=757624&group_id=5470 Category: Modules Group: None Status: Open Resolution: None Priority: 5 Submitted By: Gustavo Niemeyer (niemeyer) Assigned to: Gustavo Niemeyer (niemeyer) Summary: Fixing recursive problem in SRE Initial Comment: Here is a preview for the SRE change being discussed in python-dev mailing list. It also includes the changes in patch #572936 (groupref_exists). ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 20:41 Message: Logged In: YES user_id=21627 I assume this patch can be closed as outdated? ---------------------------------------------------------------------- Comment By: Gustavo Niemeyer (niemeyer) Date: 2003-06-26 18:52 Message: Logged In: YES user_id=7887 Version 5 fixes a minor bug due to a variable being used inside a macro and a submacro. Now submacro allocates it internally to avoid further problems. ---------------------------------------------------------------------- Comment By: Gustavo Niemeyer (niemeyer) Date: 2003-06-26 16:55 Message: Logged In: YES user_id=7887 Thanks for testing it! Here is another implementation (version 4), using a different approach. Unlike the other implementations, this one doesn't recurse at all, and introduce no new opcodes in the engine. ---------------------------------------------------------------------- Comment By: Andrew I MacIntyre (aimacintyre) Date: 2003-06-23 15:06 Message: Logged In: YES user_id=250749 version 3 of the patch survives a full regression test run on both FreeBSD 4.8 & 5.1, with USE_RECURSION_LIMIT reverted to 10000. ---------------------------------------------------------------------- Comment By: Gustavo Niemeyer (niemeyer) Date: 2003-06-22 03:13 Message: Logged In: YES user_id=7887 Updated version of the patch. More on the mailing list. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=757624&group_id=5470 From noreply at sourceforge.net Sat Oct 18 14:42:21 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 18 14:42:28 2003 Subject: [Patches] [ python-Patches-826074 ] cmath.log optional base argument, fixes #823209 Message-ID: Patches item #826074, was opened at 2003-10-18 13:42 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=826074&group_id=5470 Category: Modules Group: Python 2.4 Status: Open Resolution: None Priority: 5 Submitted By: Andrew Gaul (gaul) Assigned to: Nobody/Anonymous (nobody) Summary: cmath.log optional base argument, fixes #823209 Initial Comment: Fixes bug #823209. math.log allows an optional base argument, add the same functionality to cmath.log. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=826074&group_id=5470 From noreply at sourceforge.net Sat Oct 18 15:39:52 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 18 15:40:10 2003 Subject: [Patches] [ python-Patches-810754 ] socket.ssl should check certificates Message-ID: Patches item #810754, was opened at 2003-09-22 20:30 Message generated for change (Settings changed) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=810754&group_id=5470 Category: Modules Group: Python 2.2.x Status: Open Resolution: None Priority: 5 Submitted By: Damjan Georgievski (gdamjan) >Assigned to: Martin v. L?wis (loewis) Summary: socket.ssl should check certificates Initial Comment: I've decided to post here the patch proposed by Ed Phillips, since I think it's simple addition to the socket.ssl that will drastically increase its usefullness... The point of the patch is for a socket.ssl object to check the certificate received by the peer. http://mail.python.org/pipermail/python-list/2003-July/174933.html ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=810754&group_id=5470 From noreply at sourceforge.net Sat Oct 18 17:55:25 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 18 17:55:31 2003 Subject: [Patches] [ python-Patches-821093 ] fix doc typos Message-ID: Patches item #821093, was opened at 2003-10-10 11:45 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=821093&group_id=5470 Category: Documentation Group: Python 2.3 Status: Open Resolution: Accepted Priority: 5 Submitted By: George Yoshida (quiver) Assigned to: Nobody/Anonymous (nobody) Summary: fix doc typos Initial Comment: This patch fixes documentation typos(about 15 in total). Related directories are api, dist, inst, ref, and tut. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 23:55 Message: Logged In: YES user_id=21627 Am I missing something, or are some of these changes whitespace-only, e.g. -These are the ``Unicode Esacpe'' codec APIs: +These are the ``Unicode Escape'' codec APIs: If so, can you please update your patch to only include true typos? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=821093&group_id=5470 From noreply at sourceforge.net Sat Oct 18 18:05:58 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 18 18:06:27 2003 Subject: [Patches] [ python-Patches-792869 ] Tidying error messages in compile.c Message-ID: Patches item #792869, was opened at 2003-08-22 02:35 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=792869&group_id=5470 Category: Parser/Compiler Group: Python 2.3 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Steven Taschuk (staschuk) Assigned to: Nobody/Anonymous (nobody) Summary: Tidying error messages in compile.c Initial Comment: A couple minor tweaks: (1) for clarity, rename the macro LOCAL_GLOBAL to PARAM_GLOBAL, since this error message is used only for parameters being declared global; (2) for consistency, use that macro instead of an inline string in the first pass. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-19 00:05 Message: Logged In: YES user_id=21627 Thanks for the patch. Applied as compile.c 2.297. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=792869&group_id=5470 From noreply at sourceforge.net Sat Oct 18 18:06:56 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 18 18:07:09 2003 Subject: [Patches] [ python-Patches-791706 ] POP3 over SSL support for poplib Message-ID: Patches item #791706, was opened at 2003-08-20 07:53 Message generated for change (Settings changed) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=791706&group_id=5470 Category: Library (Lib) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Hector urtubia (mrbook) >Assigned to: Martin v. L?wis (loewis) Summary: POP3 over SSL support for poplib Initial Comment: This patch creates a class POP3_SSL which is a child of POP3 on the poplib module. This class is able to handle POP3 over SSL. It borrows some code from IMAP_SSL. ---------------------------------------------------------------------- Comment By: Hector urtubia (mrbook) Date: 2003-09-11 03:11 Message: Logged In: YES user_id=10927 I have added a patch for the documentation (lipoplibdoc- 1_0.patch) and have addressed most of the requests from the reviewer on newer patch revision (poplibssl-1_0.patch). - Tabs and spaces issues fixed - Fixed port on comment - Data is now read on big chunks - Unable to reuse base-claass __init__ because of parent's design issues. Cheers. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-08-31 18:38 Message: Logged In: YES user_id=21627 Can you please provide a patch for the documentation as well? Please don't mix tabs and spaces; I recommend to run reindent.py before producing the diff. In the class comment, the default port is incorrect. Please don't build up strings by adding one character at a time, use [c]StringIO instead, or a list. Also consider reading larger chunks of data a time, buffering extra data in the class. Try to reuse the base-class __init__. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=791706&group_id=5470 From noreply at sourceforge.net Sat Oct 18 18:09:19 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 18 18:09:42 2003 Subject: [Patches] [ python-Patches-787189 ] termios module on IRIX Message-ID: Patches item #787189, was opened at 2003-08-12 08:45 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=787189&group_id=5470 Category: Modules Group: None Status: Open Resolution: None Priority: 5 Submitted By: Marc Poinot (poinot) Assigned to: Nobody/Anonymous (nobody) Summary: termios module on IRIX Initial Comment: The termios.c module includes sys/termios.h in which a CTRL macro is present, but not defined because of the pre-processing switches: #if (_NO_POSIX && _NO_XOPEN4) || _ABIAPI #define CTRL(c) ((c)&037) Then, the sys/ioctl.h is included (at least by termios.c module) and this uses CTRL() macro ! This looks like a problem on the IRIX side, they should be consistent with their own headers. The simplest way I found was to add into termios.c the definition of CTRL: #if defined(__sgi) #define CTRL(c) ((c)&037) #endif Has to be put *before* the #include in Modules/termios.c ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-19 00:09 Message: Logged In: YES user_id=21627 In what cases would _ABIAPI be defined? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=787189&group_id=5470 From noreply at sourceforge.net Sat Oct 18 18:16:48 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 18 18:17:26 2003 Subject: [Patches] [ python-Patches-783188 ] support for server side transactions in _ssl Message-ID: Patches item #783188, was opened at 2003-08-05 02:18 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=783188&group_id=5470 Category: Modules Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Ilario Nardinocchi (illo) Assigned to: Nobody/Anonymous (nobody) Summary: support for server side transactions in _ssl Initial Comment: Added a parameter (server_mode, type int) to the newPySSLObject() function. If its value is non-zero, a server SSL transaction is attempted - by using SSL_accept() instead of SSL_connect(). Also, the parameter has been added to the PySocket_ssl() constructor function (it defaults to 0 for compatibility) and the ssl() documentation reflects the change. A new python function has been added (pending(), C function PySSL_SSLpending()), which calls SSL_pending() and returns its return value as a python integer. Added documentation for this one, too. The return value is the number of bytes still to be read from the input buffer, so that if it's greater than zero it is useless to call a select() in a nonblocking scenery. Trivial patch but it's the only way to code an SSL server without third-party stuff. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-19 00:16 Message: Logged In: YES user_id=21627 Can you please provide patches for Doc/lib/libsocket.tex as well? Contribution of a small example of an SSL server in Demo/sockets would be appreciated as well. The demo should ship with a pre-generated self-signed certificate (private key without pass phrase); comments inside the sslserver.py should list the openssl commands used to generate the certificate. Are you interested in contributing such an example? ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-08-05 08:28 Message: Logged In: YES user_id=21627 There's no uploaded file! You have to check the checkbox labeled "Check to Upload & Attach File" when you upload a file. In addition, even if you *did* check this checkbox, a bug in SourceForge prevents attaching a file when *creating* an issue. Please try again. (This is a SourceForge annoyance that we can do nothing about. :-( ) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=783188&group_id=5470 From noreply at sourceforge.net Sat Oct 18 19:00:54 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 18 19:01:00 2003 Subject: [Patches] [ python-Patches-821093 ] fix doc typos Message-ID: Patches item #821093, was opened at 2003-10-10 18:45 Message generated for change (Comment added) made by quiver You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=821093&group_id=5470 Category: Documentation Group: Python 2.3 Status: Open Resolution: Accepted Priority: 5 Submitted By: George Yoshida (quiver) Assigned to: Nobody/Anonymous (nobody) Summary: fix doc typos Initial Comment: This patch fixes documentation typos(about 15 in total). Related directories are api, dist, inst, ref, and tut. ---------------------------------------------------------------------- >Comment By: George Yoshida (quiver) Date: 2003-10-19 08:00 Message: Logged In: YES user_id=671362 "Esacpe" and "Escape" is different, although it might be difficult to notice the difference at first glance. s/ac/ca Thanks for your hard work, Martin. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-19 06:55 Message: Logged In: YES user_id=21627 Am I missing something, or are some of these changes whitespace-only, e.g. -These are the ``Unicode Esacpe'' codec APIs: +These are the ``Unicode Escape'' codec APIs: If so, can you please update your patch to only include true typos? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=821093&group_id=5470 From noreply at sourceforge.net Sun Oct 19 03:33:30 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 19 03:33:54 2003 Subject: [Patches] [ python-Patches-821093 ] fix doc typos Message-ID: Patches item #821093, was opened at 2003-10-10 11:45 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=821093&group_id=5470 Category: Documentation Group: Python 2.3 >Status: Closed Resolution: Accepted Priority: 5 Submitted By: George Yoshida (quiver) Assigned to: Nobody/Anonymous (nobody) Summary: fix doc typos Initial Comment: This patch fixes documentation typos(about 15 in total). Related directories are api, dist, inst, ref, and tut. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-19 09:33 Message: Logged In: YES user_id=21627 Thanks; I indeed failed to notice the difference :-) Committed as concrete.tex 1.28 init.tex 1.13 newtypes.tex 1.25 dist.tex 1.60 inst.tex 1.51 ref3.tex 1.117 ref5.tex 1.78 tut.tex 1.207 concrete.tex 1.25.10.2 init.tex 1.10.8.3 newtypes.tex 1.23.8.2 dist.tex 1.56.8.4 inst.tex 1.49.8.1 ref3.tex 1.114.4.3 ref5.tex 1.76.10.1 tut.tex 1.196.8.6 ---------------------------------------------------------------------- Comment By: George Yoshida (quiver) Date: 2003-10-19 01:00 Message: Logged In: YES user_id=671362 "Esacpe" and "Escape" is different, although it might be difficult to notice the difference at first glance. s/ac/ca Thanks for your hard work, Martin. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 23:55 Message: Logged In: YES user_id=21627 Am I missing something, or are some of these changes whitespace-only, e.g. -These are the ``Unicode Esacpe'' codec APIs: +These are the ``Unicode Escape'' codec APIs: If so, can you please update your patch to only include true typos? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=821093&group_id=5470 From noreply at sourceforge.net Sun Oct 19 03:46:17 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 19 03:46:32 2003 Subject: [Patches] [ python-Patches-751943 ] cgitb: make more usable for 'binary-only' software Message-ID: Patches item #751943, was opened at 2003-06-10 16:31 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=751943&group_id=5470 Category: Library (Lib) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Rob W.W. Hooft (hooft) Assigned to: Nobody/Anonymous (nobody) Summary: cgitb: make more usable for 'binary-only' software Initial Comment: I am abusing cgitb to show a traceback window for a GUI application in Qt. In such a case, the source code to the program is not always available. The stack trace is anyway useful to be submitted to the developers of the code. I attach a patch that should add some info to the HTML traceback made by cgitb in case the source file is not available. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-19 09:46 Message: Logged In: YES user_id=21627 Is that really generating a URL of "file://?"? It should not do that; instead, I think it should not generate a hyperlink for the file at all. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=751943&group_id=5470 From noreply at sourceforge.net Sun Oct 19 03:47:20 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 19 03:47:56 2003 Subject: [Patches] [ python-Patches-755286 ] Generate rpm filelist including directories Message-ID: Patches item #755286, was opened at 2003-06-16 14:57 Message generated for change (Settings changed) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=755286&group_id=5470 Category: Distutils and setup.py Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Michal Čihař (nijel) >Assigned to: Martin v. L?wis (loewis) Summary: Generate rpm filelist including directories Initial Comment: Attached patch adds --record-rpm option to distutils, that allows generating of rpm-like filelist, that contains also directories. Currently most rpm vendors are using some external commands to get dir list or have hard coded it in spec file. ---------------------------------------------------------------------- Comment By: Michal Čihař (nijel) Date: 2003-06-24 16:18 Message: Logged In: YES user_id=192186 Version 6 now works as expected for all python packages using distutils in SuSE distro. ---------------------------------------------------------------------- Comment By: Michal Čihař (nijel) Date: 2003-06-17 17:53 Message: Logged In: YES user_id=192186 Sorry for posting buch of patches here, but I test it with more and more modules and I find more and more problems :-) ---------------------------------------------------------------------- Comment By: Michal Čihař (nijel) Date: 2003-06-17 10:36 Message: Logged In: YES user_id=192186 Version 4 improves handling of mutliple levels of install directories. ---------------------------------------------------------------------- Comment By: Michal Čihař (nijel) Date: 2003-06-16 17:37 Message: Logged In: YES user_id=192186 One more update: - fix generating of dirs in chrooted installs for install_data - don't include directory for install_scripts ---------------------------------------------------------------------- Comment By: Michal Čihař (nijel) Date: 2003-06-16 15:49 Message: Logged In: YES user_id=192186 Updated version fixes problems with self defined get_outputs methods. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=755286&group_id=5470 From noreply at sourceforge.net Sun Oct 19 03:57:30 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 19 03:58:27 2003 Subject: [Patches] [ python-Patches-515003 ] Added HTTP{,S}ProxyConnection Message-ID: Patches item #515003, was opened at 2002-02-08 22:39 Message generated for change (Settings changed) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=515003&group_id=5470 Category: Library (Lib) Group: Python 2.3 Status: Open Resolution: None Priority: 3 Submitted By: Mihai Ibanescu (misa) >Assigned to: Martin v. L?wis (loewis) Summary: Added HTTP{,S}ProxyConnection Initial Comment: This patch adds HTTP*Connection classes for proxy connections. Authenticated proxies are also supported. One can argue urllib2 already implements this. It does not do HTTPS tunneling through proxies, and this is intended to be lower-level than urllib2. ---------------------------------------------------------------------- Comment By: Neal Norwitz (nnorwitz) Date: 2003-01-11 02:15 Message: Logged In: YES user_id=33168 Uploading patch from Isaac Salsberg. I removed some more comments. Jeremy (or Martin) can you review this. If it's read, I can check it in. There still needs to be a doc and tests. I'll check if either of the old patches has any. ---------------------------------------------------------------------- Comment By: Neal Norwitz (nnorwitz) Date: 2003-01-01 20:52 Message: Logged In: YES user_id=33168 Isaac, can you send me the patch? nnorwitz@users.sf.net should work ---------------------------------------------------------------------- Comment By: Isaac Salsberg (isalsberg) Date: 2002-12-20 02:54 Message: Logged In: YES user_id=663978 Neal, taht's right, I can not attach a file. I don't think is a good idea to close this patch, because Misa is still working on it to fix some persistence issue. The version I created is based on the current Misa's version, so it has the same persistence problem. It just was adapted to be used with Python 2.2.2. So we need to wait for Misa's final version. I sent the patch to Misa, in case he wants to atach it here meanwhile the last version arrives. Except for persistence, It is working for me in a production environment. Anyway, If You need the patch I can send it. Just give me an email address. ---------------------------------------------------------------------- Comment By: Neal Norwitz (nnorwitz) Date: 2002-12-15 03:09 Message: Logged In: YES user_id=33168 Isaac, I don't believe SF allows you to attach a file to someone else's patch. Please submit a new patch. In the comments for the new patch refer to this patch and indicate if it supercedes this patch (ie, should this patch be closed). Also, it would be nice if you can add a comment to this patch mentioning the new patch number. Thanks! ---------------------------------------------------------------------- Comment By: Isaac Salsberg (isalsberg) Date: 2002-12-15 01:52 Message: Logged In: YES user_id=663978 To make this patch work with the "buggy" IIS using python 2.2 or 2.2.1 with https, You need to install also these 2 patches: 551273 (fix httplib bug with 100 Continue) and 500311 (work around for buggy https servers) Python 2.2.2 by the other hand, has already incorparated those two patches, so You only need to add the HTTP{S} (515003) proxy patch. But since httplib has changed, Misa's diff file will fail. I have created a diff file that works with python 2.2.2, which also includes a new example that works using a certificate file in PEM format. I wanted to attach the file, however I could not find out how :-( ---------------------------------------------------------------------- Comment By: Mihai Ibanescu (misa) Date: 2002-11-05 21:56 Message: Logged In: YES user_id=205865 I am having problems with proxying and keepalive connections. Setting to a lower priority until I figure out the documentation. ---------------------------------------------------------------------- Comment By: Mihai Ibanescu (misa) Date: 2002-10-07 23:20 Message: Logged In: YES user_id=205865 Boy, two months. Yes, I'll go back to working on the patch. Sorry for the delay. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2002-10-07 23:17 Message: Logged In: YES user_id=21627 misa, is a patch forthcoming? ---------------------------------------------------------------------- Comment By: Mihai Ibanescu (misa) Date: 2002-07-15 23:37 Message: Logged In: YES user_id=205865 - I agree about the comments. I'll make them reasonable. - one underscore is fine - I intended to have a patch that works with python 1.5, but then again the module itself doesn't run with 1.5 anyway, so good point. - When you make a connection to a server through a proxy, you have to connect to the proxy, but everything else should be the same, i.e. the Host: field has to refer to the server and so on. I wanted to reuse the code from _set_hostport, which saves the host and port in self.host, self.port. Had to do it twice, once for the proxy hostname, once for the server's. _set_hostport takes care of the default port and of the "hostname:port" syntax, which is convenient. I'll put together a patched patch and upload it. ---------------------------------------------------------------------- Comment By: Jeremy Hylton (jhylton) Date: 2002-07-15 23:21 Message: Logged In: YES user_id=31392 The proposed classes seem useful enough, but I would like to make several suggestions for the implementation. - There are too many comments. Comments should only be added when the intent of the code needs to be explained. We definitely don't need one comment for each line of code. The comment in the HTTPS proxy putrequest() is an example of a helpful comment. - Just use a single underscore for private variables. - Please use string methods instead of the string module. - I don't understand the logic of switching the host/port back and forth. ---------------------------------------------------------------------- Comment By: Jeremy Hylton (jhylton) Date: 2002-07-15 22:52 Message: Logged In: YES user_id=31392 I'll take a look. ---------------------------------------------------------------------- Comment By: Guido van Rossum (gvanrossum) Date: 2002-07-12 17:46 Message: Logged In: YES user_id=6380 Assigning to Jeremy in the hope that he can provide a review. ---------------------------------------------------------------------- Comment By: Mihai Ibanescu (misa) Date: 2002-06-24 05:03 Message: Logged In: YES user_id=205865 The newer patch is generated against the latest CVS tree, and it provides additional documentation. ---------------------------------------------------------------------- Comment By: Mihai Ibanescu (misa) Date: 2002-06-11 20:47 Message: Logged In: YES user_id=205865 Sorry, been caught with a zillion of other things to do. I'll try to reorganize it somehow and ask for opinions. ---------------------------------------------------------------------- Comment By: Jeremy Hylton (jhylton) Date: 2002-06-11 20:42 Message: Logged In: YES user_id=31392 misa-- any progress on this patch? ---------------------------------------------------------------------- Comment By: Guido van Rossum (gvanrossum) Date: 2002-03-02 00:12 Message: Logged In: YES user_id=6380 OK, thanks; I'll wait! ---------------------------------------------------------------------- Comment By: Mihai Ibanescu (misa) Date: 2002-03-01 23:58 Message: Logged In: YES user_id=205865 I will add documentation and show the intended usage. urllib* doesn't deal with proxying over SSL (using CONNECT instead of GET/POST). urllib* also use the compatibility classes, HTTP/HTTPS, instead of HTTPConnection (this is not an argument by itself). Thanks for the suggestion. ---------------------------------------------------------------------- Comment By: Guido van Rossum (gvanrossum) Date: 2002-03-01 23:40 Message: Logged In: YES user_id=6380 This patch fails to seduce me. There's no explanation why this would be useful, or how it should be used, and no documentation, and a hint that urllib2 already does this. Maybe you can get someone who's known on python-dev to champion it, if you think it's useful? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=515003&group_id=5470 From noreply at sourceforge.net Sun Oct 19 10:18:52 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 19 10:19:10 2003 Subject: [Patches] [ python-Patches-757624 ] Fixing recursive problem in SRE Message-ID: Patches item #757624, was opened at 2003-06-20 01:42 Message generated for change (Comment added) made by niemeyer You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=757624&group_id=5470 Category: Modules Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Gustavo Niemeyer (niemeyer) Assigned to: Gustavo Niemeyer (niemeyer) Summary: Fixing recursive problem in SRE Initial Comment: Here is a preview for the SRE change being discussed in python-dev mailing list. It also includes the changes in patch #572936 (groupref_exists). ---------------------------------------------------------------------- >Comment By: Gustavo Niemeyer (niemeyer) Date: 2003-10-19 14:18 Message: Logged In: YES user_id=7887 Committed as: Doc/lib/libre.tex: 1.107 Lib/sre_compile.py: 1.50 Lib/sre_constants.py: 1.34 Lib/sre_parse.py: 1.58 Lib/test/test_re.py: 1.46 Misc/NEWS: 1.871 Modules/_sre.c: 2.101 Modules/sre.h: 2.23 Modules/sre_constants.h: 2.16 ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 18:41 Message: Logged In: YES user_id=21627 I assume this patch can be closed as outdated? ---------------------------------------------------------------------- Comment By: Gustavo Niemeyer (niemeyer) Date: 2003-06-26 16:52 Message: Logged In: YES user_id=7887 Version 5 fixes a minor bug due to a variable being used inside a macro and a submacro. Now submacro allocates it internally to avoid further problems. ---------------------------------------------------------------------- Comment By: Gustavo Niemeyer (niemeyer) Date: 2003-06-26 14:55 Message: Logged In: YES user_id=7887 Thanks for testing it! Here is another implementation (version 4), using a different approach. Unlike the other implementations, this one doesn't recurse at all, and introduce no new opcodes in the engine. ---------------------------------------------------------------------- Comment By: Andrew I MacIntyre (aimacintyre) Date: 2003-06-23 13:06 Message: Logged In: YES user_id=250749 version 3 of the patch survives a full regression test run on both FreeBSD 4.8 & 5.1, with USE_RECURSION_LIMIT reverted to 10000. ---------------------------------------------------------------------- Comment By: Gustavo Niemeyer (niemeyer) Date: 2003-06-22 01:13 Message: Logged In: YES user_id=7887 Updated version of the patch. More on the mailing list. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=757624&group_id=5470 From noreply at sourceforge.net Sun Oct 19 10:23:40 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 19 10:23:43 2003 Subject: [Patches] [ python-Patches-572936 ] (?(id/name)yes|no) re implementation Message-ID: Patches item #572936, was opened at 2002-06-24 01:41 Message generated for change (Comment added) made by niemeyer You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=572936&group_id=5470 Category: Library (Lib) Group: Python 2.3 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Gustavo Niemeyer (niemeyer) Assigned to: Gustavo Niemeyer (niemeyer) Summary: (?(id/name)yes|no) re implementation Initial Comment: This patch implements a regular expression feature, which allows some interesting patterns, in the same way as implemented in perl. For example, (?(1)yes|no) matches with "yes" if group "1" exists, and with "no", if it doesn't. Without this feature, the regular expression must be duplicated to get the same results. In addition to perl's feature, it will also accept a Python named group as argument. Here's an example: (<)?\w+@\w+(\.\w+)+(?(1)>) This is a poor email matching regular expression, which will match with or without the "<>" symbols. ---------------------------------------------------------------------- >Comment By: Gustavo Niemeyer (niemeyer) Date: 2003-10-19 14:23 Message: Logged In: YES user_id=7887 Comitted with patch #757624. ---------------------------------------------------------------------- Comment By: Gustavo Niemeyer (niemeyer) Date: 2003-06-14 05:37 Message: Logged In: YES user_id=7887 Ack!! I'm not going to ask Guido if you belive it's not worth for 2.3. I'm attaching a new version of the patch, updated to the current HEAD, and including tests. Thanks for your attention! ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-06-14 05:15 Message: Logged In: YES user_id=21627 Please don't apply the patch before 2.3; this is in beta now, so no new features are allowed (unless you get BDFL permission, of course). ---------------------------------------------------------------------- Comment By: Gustavo Niemeyer (niemeyer) Date: 2003-06-14 03:52 Message: Logged In: YES user_id=7887 Martin, I've checked your concern about making "(X)|(?(1)Y)" an error, and unfortunately the current framework doesn't implement enough state information to catch this. Notice that this is not implemented in very similar cases, like "(X)|\1", which does exactly the same thing as "(X)|(?(1)X)". I'll be applying that patch as soon as I check it against the current HEAD, and implement some tests (and before it completes its first year of life 8-). Thanks! ---------------------------------------------------------------------- Comment By: Gustavo Niemeyer (niemeyer) Date: 2003-04-20 22:09 Message: Logged In: YES user_id=7887 I see. I'll try to improve the patch with your suggestions as soon as I get some time to work on it. Thanks for your support. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-04-20 21:57 Message: Logged In: YES user_id=21627 Exactly: My example makes no sense, it will always be false since the reference is to an alternative that cannot be simultaneously be taken. Therefore, I think this should be an error. ---------------------------------------------------------------------- Comment By: Gustavo Niemeyer (niemeyer) Date: 2003-04-20 08:12 Message: Logged In: YES user_id=7887 About the test cases, they're missing indeed. I can write some while applying the patch. About being experimental, IIRC, it is listed like experimental in the Perl documentation for several years, and will probably stay like this forever. :-) Anyway, IMO this shouldn't affect our evaluation of the importance of that feature for Python's sre. About semantic restriction, do you mean check if the backreference is lesser than the current group? Should be doable. OTOH, I don't understand your example. In "(X)|(?(1)Y)", there's no sense in using (?(1), as it will always be false. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-04-20 06:23 Message: Logged In: YES user_id=21627 I like the patch in principle, but I have a number of additional concerns: - there are no test cases - the feature is declared experimental in perlre(1). Why? - Shouldn't there be a semantic restriction that the back reference is only allowed if it points to a group that is known to precede? I.e. is (X)|(?(1)Y) valid? If not, the restriction should be atleast documented, but if possible, it should also be implemented. ---------------------------------------------------------------------- Comment By: Gustavo Niemeyer (niemeyer) Date: 2003-04-19 21:30 Message: Logged In: YES user_id=7887 That patch is around for a long time. Should I work on it, fixing that problem, and apply it? Do you agree with the feature inclusion? I remember that the main reason for implementing this is because it is hard to achieve the same results without it. You have to rewrite the whole match twice inside an or'ed group (e.g. "(<... match email ...>|... match email ...)"). ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-04-19 08:50 Message: Logged In: YES user_id=21627 If you add new opcodes, you should also change SRE_MAGIC. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=572936&group_id=5470 From noreply at sourceforge.net Sun Oct 19 14:30:33 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 19 14:30:42 2003 Subject: [Patches] [ python-Patches-477441 ] Mutable PyCObject Message-ID: Patches item #477441, was opened at 2001-11-02 10:02 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=477441&group_id=5470 Category: None Group: None >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: Michael Abbott (araneidae) Assigned to: Nobody/Anonymous (nobody) Summary: Mutable PyCObject Initial Comment: I'd like to add the following code to Core\Objects\cobject.c together with the associated declaration in include\cobject.h . The purpose of this is to allow PyCObjects to be mutable when required. Obviously this doesn't change the language semantics, but is a convenience in the implementation of certain Python extensions. /* The void pointer already in the given PyCObject is replaced with the given * new value. The caller is responsible for first checking that the given * PyObject really is a PyCObject. */ void PyCObject_SetVoidPtr(PyObject *self, void *cobj) { ((PyCObject *)self)->cobject = cobj; } (I'm not to sure about the procedure for submissions of this type!) ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-19 20:30 Message: Logged In: YES user_id=21627 This is now implemented in concrete.tex 1.29 cobject.h 2.12 NEWS 1.872 cobject.c 2.16 ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-05-13 04:05 Message: Logged In: YES user_id=357491 Since the code is actually in the summary I am going to make this a patch. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=477441&group_id=5470 From noreply at sourceforge.net Sun Oct 19 14:36:23 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 19 14:36:36 2003 Subject: [Patches] [ python-Patches-823259 ] Updated .spec file. Message-ID: Patches item #823259, was opened at 2003-10-14 09:50 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=823259&group_id=5470 Category: Build Group: Python 2.3 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Sean Reifschneider (jafo) Assigned to: Nobody/Anonymous (nobody) Summary: Updated .spec file. Initial Comment: I have created a new .spec file with a few small changes and one larger one. This version detects if the HTML documentation is available, and continues building without the documentation if it is not available. This goes in Misc/RPMS ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-19 20:36 Message: Logged In: YES user_id=21627 Thanks for the patch. Committed as python-2.3.spec 1.2.12.4 and 1.3. If the change to replace /usr/local is needed, please do contribute it. However, if so, I would still like to know what files it actually changes, and whether it could possibly change binaries. ---------------------------------------------------------------------- Comment By: Sean Reifschneider (jafo) Date: 2003-10-18 16:51 Message: Logged In: YES user_id=81797 Ideally, the base Python release would not have explicit references to /usr/local/bin/python in it, but instead would use something like autoconf substitutions to put in the actual installation destination in the source. Note that the code which changes /usr/local/bin/python is already in for the 2.3.2 release. I will upload a new version of the patch which does not change /usr/local/bin/python. This will, of course, prevent the .spec file from producting RPMs, but that's ok -- the one that's currently in the head branch doesn't work either. Other changes include: Removal of patches, which can't be referenced from a build directly from the tar-file. Using the RPM tmp directory macro for the buildroot location. Ensuring that the clean directive doesn't accidentally delete the users root directory or another directory. --enable-unicode=ucs4 in configure line. Changing idle location. Sean ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 12:05 Message: Logged In: YES user_id=21627 I'm concerned with the replacement of /usr/local/bin/python - couldn't this also possibly change binary files, in an then-unpredictable manner? What files does that actually change? I'm also concerned with the silent changes. Can you please explicltly describe the smaller changes? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=823259&group_id=5470 From noreply at sourceforge.net Sun Oct 19 14:41:40 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 19 14:41:55 2003 Subject: [Patches] [ python-Patches-825639 ] let's get rid of cyclic object comparison Message-ID: Patches item #825639, was opened at 2003-10-17 19:49 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825639&group_id=5470 Category: Core (C code) Group: Python 2.4 Status: Open Resolution: None Priority: 5 Submitted By: Armin Rigo (arigo) Assigned to: Nobody/Anonymous (nobody) Summary: let's get rid of cyclic object comparison Initial Comment: Comparison of objects with recursive references is a cool feature but it leaves too many questions open and feels too much like a "do-what-i-mean" hack. Attached patch casts it into the obscure world of CVS history. On the positive side, the patch contributes a Py_EnterRecursiveCall()/Py_LeaveRecursiveCall() pair of functions to the C API, to use at any point where an infinite C-level recursion could occur. This is now used by: eval_frame() PyObject_Compare() PyObject_RichCompare() instance_call() and maybe it should be extended to cPickle.c, which has its own notion of maximum nesting as well. The diff also changes the tests to expect a RuntimeError when comparing nested structures. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-19 20:41 Message: Logged In: YES user_id=21627 I think the patch needs to be discussed on python-dev to get a chance to be accepted. It should also be accompanied with a more elaborate rationale, and a guideline on how applications that rely on the feature could detect the change, and how those applications need to be updated. For example, I find the change to the pickle tester unacceptable: you can't just drop the structural-equivalence test, since it is the primary purpose of this test to establish structural equivalence. So perhaps you should put a custom structural-equivalence algorithm into pickletester, and replace the assertEquals with that. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825639&group_id=5470 From noreply at sourceforge.net Sun Oct 19 16:46:11 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 19 16:49:30 2003 Subject: [Patches] [ python-Patches-813391 ] _sre stack overflow on FreeBSD/amd64 and /sparc64 Message-ID: Patches item #813391, was opened at 2003-09-27 05:21 Message generated for change (Settings changed) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=813391&group_id=5470 Category: Library (Lib) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Hye-Shik Chang (perky) >Assigned to: Martin v. L?wis (loewis) Summary: _sre stack overflow on FreeBSD/amd64 and /sparc64 Initial Comment: FreeBSD/amd64 and /sparc64 require even smaller limits. (FreeBSD/ia64 is safe enough with 6500.) Please see the attachment. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-09-27 19:26 Message: Logged In: YES user_id=21627 The patch likely becomes obsolete when the removal of recursion in sre is implemented. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=813391&group_id=5470 From 240026 at email.com Mon Oct 20 15:10:50 2003 From: 240026 at email.com (240026@email.com) Date: Mon Oct 20 02:08:03 2003 Subject: [Patches] Keep your inbox clean 240026 Message-ID: An HTML attachment was scrubbed... URL: http://mail.python.org/pipermail/patches/attachments/20031020/e320e8c7/attachment.html From noreply at sourceforge.net Mon Oct 20 10:35:38 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 20 10:37:35 2003 Subject: [Patches] [ python-Patches-810751 ] Fix many doc typos Message-ID: Patches item #810751, was opened at 2003-09-22 20:26 Message generated for change (Comment added) made by doerwalter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=810751&group_id=5470 Category: None Group: None >Status: Closed Resolution: Accepted Priority: 5 Submitted By: Walter D?rwald (doerwalter) Assigned to: Walter D?rwald (doerwalter) Summary: Fix many doc typos Initial Comment: This patch fixes many documentation and docstring typos related to duplicate words. ---------------------------------------------------------------------- >Comment By: Walter D?rwald (doerwalter) Date: 2003-10-20 16:35 Message: Logged In: YES user_id=89016 OK, finally checked in both on the HEAD and the release23-maint branch. ---------------------------------------------------------------------- Comment By: Raymond Hettinger (rhettinger) Date: 2003-09-22 21:10 Message: Logged In: YES user_id=80475 Go ahead and apply these. Also, backport to 2.3.1 if you have time. I had already fixed a couple of them but most are new. Be sure to whitespace normalize the *.py files in the patch. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=810751&group_id=5470 From noreply at sourceforge.net Mon Oct 20 17:00:20 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 20 17:03:41 2003 Subject: [Patches] [ python-Patches-813391 ] _sre stack overflow on FreeBSD/amd64 and /sparc64 Message-ID: Patches item #813391, was opened at 2003-09-27 05:21 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=813391&group_id=5470 Category: Library (Lib) Group: Python 2.3 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Hye-Shik Chang (perky) Assigned to: Martin v. L?wis (loewis) Summary: _sre stack overflow on FreeBSD/amd64 and /sparc64 Initial Comment: FreeBSD/amd64 and /sparc64 require even smaller limits. (FreeBSD/ia64 is safe enough with 6500.) Please see the attachment. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-20 23:00 Message: Logged In: YES user_id=21627 Committed as 2.99.8.1. This doesn't apply for CVS trunk, as the recursion has been removed. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-09-27 19:26 Message: Logged In: YES user_id=21627 The patch likely becomes obsolete when the removal of recursion in sre is implemented. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=813391&group_id=5470 From noreply at sourceforge.net Tue Oct 21 05:11:04 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Tue Oct 21 05:11:08 2003 Subject: [Patches] [ python-Patches-827386 ] absolute paths cause problems for MSVC Message-ID: Patches item #827386, was opened at 2003-10-21 09:11 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=827386&group_id=5470 Category: Distutils and setup.py Group: None Status: Open Resolution: None Priority: 5 Submitted By: eric jones (eaj) Assigned to: Nobody/Anonymous (nobody) Summary: absolute paths cause problems for MSVC Initial Comment: When source files are given in the form: c:\foo\bar.c the object file is written to: c:\foo\bar.o instead of the build\temp.win32-2.3 directory. This is because the object_filenames method doesn't chop off the drive name from source file name base before trying to concatenate the build directory with the base. This results in the build directory being ignored. The ccompiler.py object_filenames does it right, so I just copied its behavior. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=827386&group_id=5470 From noreply at sourceforge.net Tue Oct 21 07:10:09 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Tue Oct 21 07:10:39 2003 Subject: [Patches] [ python-Patches-780821 ] More robust MSVC6 finder Message-ID: Patches item #780821, was opened at 2003-07-31 13:50 Message generated for change (Comment added) made by murraysteele You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=780821&group_id=5470 Category: Distutils and setup.py Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Garth T Kidd (gtk) Assigned to: Jeremy Hylton (jhylton) Summary: More robust MSVC6 finder Initial Comment: My VS6 install on XP didn't set the r"Software\Microsoft\Devstudio\6.0\Build System" registry key relied upon by distutils.msvccompiler to find the compiler and linker executable. As a backup to the registry paths, this patch looks up the MSVCDIR environment variable and ensures its basename is appropriate for the Python build version: if self.__version == 6: matchbase = 'vc98' elif self.__version == 7: matchbase = 'vc7' Works fine on my machine, so long as I run VCVARS32.BAT, and fails appropriately if I ran the wrong VCVARS32.BAT by mistake (I have Visual Studio Net 2003 also installed). The patch should be applied to distutils/msvccompiler.py. ---------------------------------------------------------------------- Comment By: Murray Steele (murraysteele) Date: 2003-10-21 12:10 Message: Logged In: YES user_id=891425 Having come across this problem myself, it seems that MSVC 6 doesn't create the r"Software\Microsoft\Devstudio\6.0\Build System" registry keys until *after* you run the actual Visual Studio IDE. So just doing a plain install and never running the IDE isn't enough. This isn't much of a fix, just some kind of documentation incase it bites some other fumbling developer in the future. Someone somewhere else (http://sourceforge.net/tracker/?func=detail&atid=105470&aid=451285&group_id=5470) suggested using the Environment Variables as well as the registry keys in distutils to check for compiler correctness. Seems like a plan to me. And there is some more chat about this problem here http://sourceforge.net/tracker/?func=detail&atid=305470&aid=614770&group_id=5470 ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-08-01 08:16 Message: Logged In: YES user_id=21627 I'm curious, though, how you installed VS6 without getting the registry settings. Doesn't this mean your installation of VS6 is broken? ---------------------------------------------------------------------- Comment By: Garth T Kidd (gtk) Date: 2003-08-01 05:06 Message: Logged In: YES user_id=59803 WARNING: the first patch contains a typo. s/nstring/string/ and you'll be fine. New version attached. ---------------------------------------------------------------------- Comment By: Jeremy Hylton (jhylton) Date: 2003-07-31 23:09 Message: Logged In: YES user_id=31392 I've desired the same functionality in the past. ---------------------------------------------------------------------- Comment By: Garth T Kidd (gtk) Date: 2003-07-31 13:52 Message: Logged In: YES user_id=59803 Whups. The patch didn't attach. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=780821&group_id=5470 From noreply at sourceforge.net Tue Oct 21 08:58:36 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Tue Oct 21 08:58:48 2003 Subject: [Patches] [ python-Patches-648322 ] asyncore loop_once and remove poll2 Message-ID: Patches item #648322, was opened at 2002-12-04 05:55 Message generated for change (Settings changed) made by akuchling You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=648322&group_id=5470 Category: Library (Lib) Group: None Status: Open Resolution: None Priority: 5 Submitted By: Kjetil Jacobsen (kjetilja) >Assigned to: A.M. Kuchling (akuchling) Summary: asyncore loop_once and remove poll2 Initial Comment: this patch does two things to asyncore.py, none of them should break any existing code which uses the module: 1) remove the (broken) poll2 function, and rather make a reference from poll2 to poll3 in the module namespace (i.e. if someone actually uses the poll2 function, poll3 will be called instead). 2) add a function loop_once which performs the asyncore loop once instead of until the socket map is empty. asyncore.loop_once has the same function signature as asyncore.loop. ---------------------------------------------------------------------- Comment By: Kjetil Jacobsen (kjetilja) Date: 2002-12-05 13:46 Message: Logged In: YES user_id=5685 asyncore.poll2 is broken because it does not mask the EINTR exception when invoking the poll.poll function. this causes asyncore.poll2 to not have the same semantics as asyncore.poll and asyncore.poll3. i don't see the point in preserving support for the poll2 function, as the poll function is now automatically a part of the select module if the system has poll support. or am i missing something obvious here? :) if use_poll is set and there is no poll on the system, asyncore.loop and asyncore.loop_once will fail the same way they did before. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2002-12-05 11:49 Message: Logged In: YES user_id=21627 Can you please explain in what way poll2 is broken? Also, what happens if use_poll is set, but there is no poll available on the system? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=648322&group_id=5470 From noreply at sourceforge.net Tue Oct 21 10:49:46 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Tue Oct 21 10:49:51 2003 Subject: [Patches] [ python-Patches-827559 ] SimpleHTTPServer directory-indexing "bug" fix Message-ID: Patches item #827559, was opened at 2003-10-21 14:49 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=827559&group_id=5470 Category: Library (Lib) Group: Python 2.2.x Status: Open Resolution: None Priority: 5 Submitted By: Chris Gonnerman (solomoriah) Assigned to: Nobody/Anonymous (nobody) Summary: SimpleHTTPServer directory-indexing "bug" fix Initial Comment: The SimpleHTTPServer.py module, when presented with a URL of the form: http://some.site.com/directory should redirect the browser to: http://some.site.com/directory/ This is evidently a standard behavior of major webservers (Apache and IIS at least). SimpleHTTPServer does not do this, but fortunately it is simple to implement (patch attached, naturally). I am providing a fix for 2.2 but this problem appears to be in earlier versions, and is also in 2.3. This patch appears to work fine for 2.3. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=827559&group_id=5470 From noreply at sourceforge.net Tue Oct 21 10:50:14 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Tue Oct 21 10:50:16 2003 Subject: [Patches] [ python-Patches-827561 ] SimpleHTTPServer directory-indexing "bug" fix Message-ID: Patches item #827561, was opened at 2003-10-21 14:50 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=827561&group_id=5470 Category: Library (Lib) Group: Python 2.2.x Status: Open Resolution: None Priority: 5 Submitted By: Chris Gonnerman (solomoriah) Assigned to: Nobody/Anonymous (nobody) Summary: SimpleHTTPServer directory-indexing "bug" fix Initial Comment: The SimpleHTTPServer.py module, when presented with a URL of the form: http://some.site.com/directory should redirect the browser to: http://some.site.com/directory/ This is evidently a standard behavior of major webservers (Apache and IIS at least). SimpleHTTPServer does not do this, but fortunately it is simple to implement (patch attached, naturally). I am providing a fix for 2.2 but this problem appears to be in earlier versions, and is also in 2.3. This patch appears to work fine for 2.3. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=827561&group_id=5470 From noreply at sourceforge.net Tue Oct 21 17:59:35 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Tue Oct 21 17:59:45 2003 Subject: [Patches] [ python-Patches-813200 ] Fix test_tempfile: space in Win32 install path bug #811082 Message-ID: Patches item #813200, was opened at 2003-09-26 19:59 Message generated for change (Comment added) made by midramas You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=813200&group_id=5470 Category: Tests Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Michael Bartl (midramas) Assigned to: Nobody/Anonymous (nobody) Summary: Fix test_tempfile: space in Win32 install path bug #811082 Initial Comment: Fix: - corrected arguments passed to spawnl function and added comment to explain tricky win32 behaviour Bug description: test_tempfile.py fails on XP (probably other platforms too) when Python is installed into \Program Files\Python2.3 ---------------------------------------------------------------------- >Comment By: Michael Bartl (midramas) Date: 2003-10-21 23:59 Message: Logged In: YES user_id=31511 Stupid me! As written in the comment the fix only applies for windows so the OS should have been checked. Uploaded a new patch, which was tested on Linux & Windows XP. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 20:09 Message: Logged In: YES user_id=21627 The patch is incorrect. On Unix, I get "/home/martin/work/py2.4/python": can't open file '"/home/martin/work/py2.4/Lib/test/tf_inherit_check.py"' test test_tempfile failed -- Traceback (most recent call last): File "/home/martin/work/py2.4/Lib/test/test_tempfile.py", line 304, in test_noinherit self.failIf(retval > 0, "child process reports failure") File "/home/martin/work/py2.4/Lib/unittest.py", line 288, in failIf if expr: raise self.failureException, msg AssertionError: child process reports failure ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=813200&group_id=5470 From noreply at sourceforge.net Tue Oct 21 18:44:49 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Tue Oct 21 18:46:02 2003 Subject: [Patches] [ python-Patches-806800 ] NetBSD py_curses.h fix Message-ID: Patches item #806800, was opened at 2003-09-15 22:47 Message generated for change (Comment added) made by marc You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=806800&group_id=5470 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Marc Recht (marc) Assigned to: Nobody/Anonymous (nobody) Summary: NetBSD py_curses.h fix Initial Comment: On NetBSD, [n]curses.h and stdlib.h/wchar.h use different guards against multiple definition of wchar_t and wint_t. ---------------------------------------------------------------------- >Comment By: Marc Recht (marc) Date: 2003-10-22 00:44 Message: Logged In: YES user_id=205 NetBSD ;-) But, you're right. It's the problem of the ncurses package and not NetBSD's (nor FreeBSD's since it has a similar fix). It has also already been fixed in the dev. version of ncurses. I'm going to backport the fix for the NetBSD pkgsrc version of ncurses, but the problem remains for people who are using (or try to use) stock python and ncurses sources. I still don't see a version test here. Digging in CVS shows that wchar_t has been around for ages now (and it's going to stay). A solution could be to test for the existence of wchar_t in configure and change the test to something like: if defined(_XOPEN_SOURCE_EXTENDED) && defined(HAS_WCHAR_T) && defined(NCURSES_VERSION) #ifndef _WCHAR_T #define _WCHAR_T [...] And thus making it OS independent. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 12:25 Message: Logged In: YES user_id=21627 Ok, then I still maintain that this is a bug in FreeBSD - namely, in the package. There should then still be a test for versions, so that we know when we can take the work-around out. Otherwise, the work-around will stay in forever, as we have no means of knowing whether it is still needed. That would be bad. ---------------------------------------------------------------------- Comment By: Marc Recht (marc) Date: 2003-09-23 19:31 Message: Logged In: YES user_id=205 Just one note that might clarify things a bit more... ncurses is installed with the pkgsrc system (like FreeBSD's ports). It doesn't get installed with the base system nor is it in one of the system directories. (It's in /usr/pkg.) NetBSD has a curses implementation, but it has not (yet) all the features Python needs. Because of that we use GNU ncurses (atm 5.3). ---------------------------------------------------------------------- Comment By: Marc Recht (marc) Date: 2003-09-23 16:58 Message: Logged In: YES user_id=205 Oh. I think we're talking at cross-purposes. The _system_ curses isn't used, it's GNU ncurses. And ncurses and char.h clash if _XOPEN_SOURCE_EXTENDED is defined. Naturally the system curses and wchar.h could be included together. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-09-19 00:45 Message: Logged In: YES user_id=21627 Is it the case that curses.h and wchar.h cannot be simultaneously be included if a certain supported #define is given? If so, it is clearly a bug in the header files - it should not be possible to get conflicting declarations by just including system headers. Even if it applies to all released versions of the system, I still need an explicit list of what these versions are, and I need a compile-time failure if a version is encountered that isn't listed. That the next release is only a year away is a good thing - maybe they can fix the bug until then. They won't, of course, fix the bug if nobody tells them there is a bug... ---------------------------------------------------------------------- Comment By: Marc Recht (marc) Date: 2003-09-18 23:51 Message: Logged In: YES user_id=205 Hmm. I won't consider it a bug in NetBSD. Just a clash of declarations.. ;-) The attached patch is needed for 1.6.x and -current (which will be released not sooner than next year). I'm not sure about 1.5, but I'd bet it's the same. So, there's just no restriction possible. It's simply - all - (if _XOPEN_SOURCE_EXTENDED is defined). ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-09-18 20:33 Message: Logged In: YES user_id=21627 That is a work around a NetBSD bug, right? If so, there should be some procedure to retest presence of the bug in new NetBSD releases, and record the versions for which the bug has been found to be present. Then, when the newest release with the bug is not supported in Python anymore, the code can be removed (which might well be 10 years from now). If possible, a code fragment like #if (NetBSD_major == 3) or (NetBSD_major==4) // bug present, add work-around #else #error Please check whether the bug is still present #endif ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=806800&group_id=5470 From noreply at sourceforge.net Tue Oct 21 23:57:18 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Tue Oct 21 23:57:42 2003 Subject: [Patches] [ python-Patches-806800 ] NetBSD py_curses.h fix Message-ID: Patches item #806800, was opened at 2003-09-16 06:47 Message generated for change (Comment added) made by anthonybaxter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=806800&group_id=5470 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Marc Recht (marc) Assigned to: Nobody/Anonymous (nobody) Summary: NetBSD py_curses.h fix Initial Comment: On NetBSD, [n]curses.h and stdlib.h/wchar.h use different guards against multiple definition of wchar_t and wint_t. ---------------------------------------------------------------------- >Comment By: Anthony Baxter (anthonybaxter) Date: 2003-10-22 13:57 Message: Logged In: YES user_id=29957 Note that the configure script in the trunk and 2.3 branch already has a workaround for this - it doesn't define the _XOPEN_SOURCE_EXTENDED macro for FreeBSD and Darwin. If the same fix is needed for NetBSD, could you supply a patch for configure.in? ---------------------------------------------------------------------- Comment By: Marc Recht (marc) Date: 2003-10-22 08:44 Message: Logged In: YES user_id=205 NetBSD ;-) But, you're right. It's the problem of the ncurses package and not NetBSD's (nor FreeBSD's since it has a similar fix). It has also already been fixed in the dev. version of ncurses. I'm going to backport the fix for the NetBSD pkgsrc version of ncurses, but the problem remains for people who are using (or try to use) stock python and ncurses sources. I still don't see a version test here. Digging in CVS shows that wchar_t has been around for ages now (and it's going to stay). A solution could be to test for the existence of wchar_t in configure and change the test to something like: if defined(_XOPEN_SOURCE_EXTENDED) && defined(HAS_WCHAR_T) && defined(NCURSES_VERSION) #ifndef _WCHAR_T #define _WCHAR_T [...] And thus making it OS independent. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 20:25 Message: Logged In: YES user_id=21627 Ok, then I still maintain that this is a bug in FreeBSD - namely, in the package. There should then still be a test for versions, so that we know when we can take the work-around out. Otherwise, the work-around will stay in forever, as we have no means of knowing whether it is still needed. That would be bad. ---------------------------------------------------------------------- Comment By: Marc Recht (marc) Date: 2003-09-24 03:31 Message: Logged In: YES user_id=205 Just one note that might clarify things a bit more... ncurses is installed with the pkgsrc system (like FreeBSD's ports). It doesn't get installed with the base system nor is it in one of the system directories. (It's in /usr/pkg.) NetBSD has a curses implementation, but it has not (yet) all the features Python needs. Because of that we use GNU ncurses (atm 5.3). ---------------------------------------------------------------------- Comment By: Marc Recht (marc) Date: 2003-09-24 00:58 Message: Logged In: YES user_id=205 Oh. I think we're talking at cross-purposes. The _system_ curses isn't used, it's GNU ncurses. And ncurses and char.h clash if _XOPEN_SOURCE_EXTENDED is defined. Naturally the system curses and wchar.h could be included together. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-09-19 08:45 Message: Logged In: YES user_id=21627 Is it the case that curses.h and wchar.h cannot be simultaneously be included if a certain supported #define is given? If so, it is clearly a bug in the header files - it should not be possible to get conflicting declarations by just including system headers. Even if it applies to all released versions of the system, I still need an explicit list of what these versions are, and I need a compile-time failure if a version is encountered that isn't listed. That the next release is only a year away is a good thing - maybe they can fix the bug until then. They won't, of course, fix the bug if nobody tells them there is a bug... ---------------------------------------------------------------------- Comment By: Marc Recht (marc) Date: 2003-09-19 07:51 Message: Logged In: YES user_id=205 Hmm. I won't consider it a bug in NetBSD. Just a clash of declarations.. ;-) The attached patch is needed for 1.6.x and -current (which will be released not sooner than next year). I'm not sure about 1.5, but I'd bet it's the same. So, there's just no restriction possible. It's simply - all - (if _XOPEN_SOURCE_EXTENDED is defined). ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-09-19 04:33 Message: Logged In: YES user_id=21627 That is a work around a NetBSD bug, right? If so, there should be some procedure to retest presence of the bug in new NetBSD releases, and record the versions for which the bug has been found to be present. Then, when the newest release with the bug is not supported in Python anymore, the code can be removed (which might well be 10 years from now). If possible, a code fragment like #if (NetBSD_major == 3) or (NetBSD_major==4) // bug present, add work-around #else #error Please check whether the bug is still present #endif ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=806800&group_id=5470 From noreply at sourceforge.net Wed Oct 22 10:03:58 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 22 10:04:27 2003 Subject: [Patches] [ python-Patches-806800 ] NetBSD py_curses.h fix Message-ID: Patches item #806800, was opened at 2003-09-15 22:47 Message generated for change (Comment added) made by marc You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=806800&group_id=5470 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Marc Recht (marc) Assigned to: Nobody/Anonymous (nobody) Summary: NetBSD py_curses.h fix Initial Comment: On NetBSD, [n]curses.h and stdlib.h/wchar.h use different guards against multiple definition of wchar_t and wint_t. ---------------------------------------------------------------------- >Comment By: Marc Recht (marc) Date: 2003-10-22 16:03 Message: Logged In: YES user_id=205 ATM i'm doing some tests with a patch that disables _XOPEN_SOURCE_EXTENDEND on NetBSD 1.5/1.5.* NetBSD 1.6/1.6.* and some older versions of -current. For newer versions of -curernt the definition of _NETBSD_SOURCE 'fixes' the problems introduced by the posix macros. The curses problem is more a generic problem. wchar_t / wint_t are defined as "integer types" by POSIX see: http://www.opengroup.org/onlinepubs/007904975/basedefs/stddef.h.html http://www.opengroup.org/onlinepubs/007904975/basedefs/wchar.h.html On NetBSD wchar_t is an 'int' and ncurses defines it to 'unsigned long'. Thus the declaration clash. And this can happen on any os that defines wchar_t and uses ncurses for python. Because of that i think the test should be something like: if defined(_XOPEN_SOURCE_EXTENDED) && defined(HAS_WCHAR_T) && defined(NCURSES_VERSION) (And maybe a similar with HAS_WINT_Tif we can't assume that the os declares wint_t if it declares wchar_t.) ---------------------------------------------------------------------- Comment By: Anthony Baxter (anthonybaxter) Date: 2003-10-22 05:57 Message: Logged In: YES user_id=29957 Note that the configure script in the trunk and 2.3 branch already has a workaround for this - it doesn't define the _XOPEN_SOURCE_EXTENDED macro for FreeBSD and Darwin. If the same fix is needed for NetBSD, could you supply a patch for configure.in? ---------------------------------------------------------------------- Comment By: Marc Recht (marc) Date: 2003-10-22 00:44 Message: Logged In: YES user_id=205 NetBSD ;-) But, you're right. It's the problem of the ncurses package and not NetBSD's (nor FreeBSD's since it has a similar fix). It has also already been fixed in the dev. version of ncurses. I'm going to backport the fix for the NetBSD pkgsrc version of ncurses, but the problem remains for people who are using (or try to use) stock python and ncurses sources. I still don't see a version test here. Digging in CVS shows that wchar_t has been around for ages now (and it's going to stay). A solution could be to test for the existence of wchar_t in configure and change the test to something like: if defined(_XOPEN_SOURCE_EXTENDED) && defined(HAS_WCHAR_T) && defined(NCURSES_VERSION) #ifndef _WCHAR_T #define _WCHAR_T [...] And thus making it OS independent. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 12:25 Message: Logged In: YES user_id=21627 Ok, then I still maintain that this is a bug in FreeBSD - namely, in the package. There should then still be a test for versions, so that we know when we can take the work-around out. Otherwise, the work-around will stay in forever, as we have no means of knowing whether it is still needed. That would be bad. ---------------------------------------------------------------------- Comment By: Marc Recht (marc) Date: 2003-09-23 19:31 Message: Logged In: YES user_id=205 Just one note that might clarify things a bit more... ncurses is installed with the pkgsrc system (like FreeBSD's ports). It doesn't get installed with the base system nor is it in one of the system directories. (It's in /usr/pkg.) NetBSD has a curses implementation, but it has not (yet) all the features Python needs. Because of that we use GNU ncurses (atm 5.3). ---------------------------------------------------------------------- Comment By: Marc Recht (marc) Date: 2003-09-23 16:58 Message: Logged In: YES user_id=205 Oh. I think we're talking at cross-purposes. The _system_ curses isn't used, it's GNU ncurses. And ncurses and char.h clash if _XOPEN_SOURCE_EXTENDED is defined. Naturally the system curses and wchar.h could be included together. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-09-19 00:45 Message: Logged In: YES user_id=21627 Is it the case that curses.h and wchar.h cannot be simultaneously be included if a certain supported #define is given? If so, it is clearly a bug in the header files - it should not be possible to get conflicting declarations by just including system headers. Even if it applies to all released versions of the system, I still need an explicit list of what these versions are, and I need a compile-time failure if a version is encountered that isn't listed. That the next release is only a year away is a good thing - maybe they can fix the bug until then. They won't, of course, fix the bug if nobody tells them there is a bug... ---------------------------------------------------------------------- Comment By: Marc Recht (marc) Date: 2003-09-18 23:51 Message: Logged In: YES user_id=205 Hmm. I won't consider it a bug in NetBSD. Just a clash of declarations.. ;-) The attached patch is needed for 1.6.x and -current (which will be released not sooner than next year). I'm not sure about 1.5, but I'd bet it's the same. So, there's just no restriction possible. It's simply - all - (if _XOPEN_SOURCE_EXTENDED is defined). ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-09-18 20:33 Message: Logged In: YES user_id=21627 That is a work around a NetBSD bug, right? If so, there should be some procedure to retest presence of the bug in new NetBSD releases, and record the versions for which the bug has been found to be present. Then, when the newest release with the bug is not supported in Python anymore, the code can be removed (which might well be 10 years from now). If possible, a code fragment like #if (NetBSD_major == 3) or (NetBSD_major==4) // bug present, add work-around #else #error Please check whether the bug is still present #endif ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=806800&group_id=5470 From noreply at sourceforge.net Wed Oct 22 10:28:49 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 22 10:29:08 2003 Subject: [Patches] [ python-Patches-648322 ] asyncore loop_once and remove poll2 Message-ID: Patches item #648322, was opened at 2002-12-04 05:55 Message generated for change (Comment added) made by akuchling You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=648322&group_id=5470 Category: Library (Lib) Group: None Status: Open Resolution: None Priority: 5 Submitted By: Kjetil Jacobsen (kjetilja) Assigned to: A.M. Kuchling (akuchling) Summary: asyncore loop_once and remove poll2 Initial Comment: this patch does two things to asyncore.py, none of them should break any existing code which uses the module: 1) remove the (broken) poll2 function, and rather make a reference from poll2 to poll3 in the module namespace (i.e. if someone actually uses the poll2 function, poll3 will be called instead). 2) add a function loop_once which performs the asyncore loop once instead of until the socket map is empty. asyncore.loop_once has the same function signature as asyncore.loop. ---------------------------------------------------------------------- >Comment By: A.M. Kuchling (akuchling) Date: 2003-10-22 10:28 Message: Logged In: YES user_id=11375 poll2() is written for a "poll" extension module that came with the Medusa distribution, so it'll never be used with a Python installation and poll2() can be safely removed. I'm less enthusiastic about loop_once(). Existing code that needs to loop once has been simply calling asyncore.poll(), which works fine (though perhaps suboptimally -- but 99% of asyncore applications won't care). ---------------------------------------------------------------------- Comment By: Kjetil Jacobsen (kjetilja) Date: 2002-12-05 13:46 Message: Logged In: YES user_id=5685 asyncore.poll2 is broken because it does not mask the EINTR exception when invoking the poll.poll function. this causes asyncore.poll2 to not have the same semantics as asyncore.poll and asyncore.poll3. i don't see the point in preserving support for the poll2 function, as the poll function is now automatically a part of the select module if the system has poll support. or am i missing something obvious here? :) if use_poll is set and there is no poll on the system, asyncore.loop and asyncore.loop_once will fail the same way they did before. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2002-12-05 11:49 Message: Logged In: YES user_id=21627 Can you please explain in what way poll2 is broken? Also, what happens if use_poll is set, but there is no poll available on the system? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=648322&group_id=5470 From noreply at sourceforge.net Wed Oct 22 10:40:29 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 22 10:40:35 2003 Subject: [Patches] [ python-Patches-648322 ] asyncore loop_once and remove poll2 Message-ID: Patches item #648322, was opened at 2002-12-04 05:55 Message generated for change (Comment added) made by akuchling You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=648322&group_id=5470 Category: Library (Lib) Group: None Status: Open Resolution: None Priority: 5 Submitted By: Kjetil Jacobsen (kjetilja) Assigned to: A.M. Kuchling (akuchling) Summary: asyncore loop_once and remove poll2 Initial Comment: this patch does two things to asyncore.py, none of them should break any existing code which uses the module: 1) remove the (broken) poll2 function, and rather make a reference from poll2 to poll3 in the module namespace (i.e. if someone actually uses the poll2 function, poll3 will be called instead). 2) add a function loop_once which performs the asyncore loop once instead of until the socket map is empty. asyncore.loop_once has the same function signature as asyncore.loop. ---------------------------------------------------------------------- >Comment By: A.M. Kuchling (akuchling) Date: 2003-10-22 10:40 Message: Logged In: YES user_id=11375 Partially checked in; the existing poll2() implementation has been removed in rev.1.43 in CVS. ---------------------------------------------------------------------- Comment By: A.M. Kuchling (akuchling) Date: 2003-10-22 10:28 Message: Logged In: YES user_id=11375 poll2() is written for a "poll" extension module that came with the Medusa distribution, so it'll never be used with a Python installation and poll2() can be safely removed. I'm less enthusiastic about loop_once(). Existing code that needs to loop once has been simply calling asyncore.poll(), which works fine (though perhaps suboptimally -- but 99% of asyncore applications won't care). ---------------------------------------------------------------------- Comment By: Kjetil Jacobsen (kjetilja) Date: 2002-12-05 13:46 Message: Logged In: YES user_id=5685 asyncore.poll2 is broken because it does not mask the EINTR exception when invoking the poll.poll function. this causes asyncore.poll2 to not have the same semantics as asyncore.poll and asyncore.poll3. i don't see the point in preserving support for the poll2 function, as the poll function is now automatically a part of the select module if the system has poll support. or am i missing something obvious here? :) if use_poll is set and there is no poll on the system, asyncore.loop and asyncore.loop_once will fail the same way they did before. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2002-12-05 11:49 Message: Logged In: YES user_id=21627 Can you please explain in what way poll2 is broken? Also, what happens if use_poll is set, but there is no poll available on the system? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=648322&group_id=5470 From noreply at sourceforge.net Wed Oct 22 12:01:31 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 22 12:02:24 2003 Subject: [Patches] [ python-Patches-827561 ] SimpleHTTPServer directory-indexing "bug" fix Message-ID: Patches item #827561, was opened at 2003-10-21 16:50 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=827561&group_id=5470 Category: Library (Lib) Group: Python 2.2.x >Status: Closed >Resolution: Duplicate Priority: 5 Submitted By: Chris Gonnerman (solomoriah) Assigned to: Nobody/Anonymous (nobody) Summary: SimpleHTTPServer directory-indexing "bug" fix Initial Comment: The SimpleHTTPServer.py module, when presented with a URL of the form: http://some.site.com/directory should redirect the browser to: http://some.site.com/directory/ This is evidently a standard behavior of major webservers (Apache and IIS at least). SimpleHTTPServer does not do this, but fortunately it is simple to implement (patch attached, naturally). I am providing a fix for 2.2 but this problem appears to be in earlier versions, and is also in 2.3. This patch appears to work fine for 2.3. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-22 18:01 Message: Logged In: YES user_id=21627 Duplicate of 827559. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=827561&group_id=5470 From noreply at sourceforge.net Wed Oct 22 12:25:40 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 22 12:25:59 2003 Subject: [Patches] [ python-Patches-828336 ] Allow set swig include dirs in setup.py Message-ID: Patches item #828336, was opened at 2003-10-22 18:25 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=828336&group_id=5470 Category: Distutils and setup.py Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Artur Frysiak (wiget) Assigned to: Nobody/Anonymous (nobody) Summary: Allow set swig include dirs in setup.py Initial Comment: There is no method to pass information about include dirs to swig. Some extension modules (eg M2Crypto) sugest change distutils sources to compile it. I write this patch to avoid changing distutils for all swinged extensions. Simply autor of extension may add swig_include_dirs = ['strangedir', 'verystrangedir'] to Extension() definition. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=828336&group_id=5470 From noreply at sourceforge.net Wed Oct 22 13:56:34 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 22 13:56:49 2003 Subject: [Patches] [ python-Patches-828384 ] PyModule_AddObject one-liner Message-ID: Patches item #828384, was opened at 2003-10-22 09:56 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=828384&group_id=5470 Category: Core (C code) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Greg Chapman (glchapman) Assigned to: Nobody/Anonymous (nobody) Summary: PyModule_AddObject one-liner Initial Comment: The attached patch adds one line to the PyModule_AddObject function so that if the supplied object is NULL, and an exception is already set, that exception is left alone rather than being masked by an error from within PyModule_AddObject. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=828384&group_id=5470 From noreply at sourceforge.net Thu Oct 23 02:02:34 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Thu Oct 23 02:02:41 2003 Subject: [Patches] [ python-Patches-813200 ] Fix test_tempfile: space in Win32 install path bug #811082 Message-ID: Patches item #813200, was opened at 2003-09-26 19:59 Message generated for change (Settings changed) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=813200&group_id=5470 Category: Tests Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Michael Bartl (midramas) >Assigned to: Martin v. L?wis (loewis) Summary: Fix test_tempfile: space in Win32 install path bug #811082 Initial Comment: Fix: - corrected arguments passed to spawnl function and added comment to explain tricky win32 behaviour Bug description: test_tempfile.py fails on XP (probably other platforms too) when Python is installed into \Program Files\Python2.3 ---------------------------------------------------------------------- Comment By: Michael Bartl (midramas) Date: 2003-10-21 23:59 Message: Logged In: YES user_id=31511 Stupid me! As written in the comment the fix only applies for windows so the OS should have been checked. Uploaded a new patch, which was tested on Linux & Windows XP. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 20:09 Message: Logged In: YES user_id=21627 The patch is incorrect. On Unix, I get "/home/martin/work/py2.4/python": can't open file '"/home/martin/work/py2.4/Lib/test/tf_inherit_check.py"' test test_tempfile failed -- Traceback (most recent call last): File "/home/martin/work/py2.4/Lib/test/test_tempfile.py", line 304, in test_noinherit self.failIf(retval > 0, "child process reports failure") File "/home/martin/work/py2.4/Lib/unittest.py", line 288, in failIf if expr: raise self.failureException, msg AssertionError: child process reports failure ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=813200&group_id=5470 From noreply at sourceforge.net Thu Oct 23 02:10:43 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Thu Oct 23 02:10:58 2003 Subject: [Patches] [ python-Patches-806800 ] NetBSD py_curses.h fix Message-ID: Patches item #806800, was opened at 2003-09-15 22:47 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=806800&group_id=5470 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Marc Recht (marc) Assigned to: Nobody/Anonymous (nobody) Summary: NetBSD py_curses.h fix Initial Comment: On NetBSD, [n]curses.h and stdlib.h/wchar.h use different guards against multiple definition of wchar_t and wint_t. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-23 08:10 Message: Logged In: YES user_id=21627 I disagree that the bug is in ncurses. ncurses supports conditional definition of wchar_t/wint_t, which normally should be defined by the platform. ncurses does so by testing for the _WCHAR_T and wchar_t macros, so for interoperability, the system should define _WCHAR_T (even though there is no standard requiring the definition of _WCHAR_T). This has nothing to do with _XOPEN_SOURCE_EXTENDED. Now, that might provide an alternative solution: if the system has wchar_t, and fails to define _WCHAR_T, we should define it ourselves before including ncurses.h. ---------------------------------------------------------------------- Comment By: Marc Recht (marc) Date: 2003-10-22 16:03 Message: Logged In: YES user_id=205 ATM i'm doing some tests with a patch that disables _XOPEN_SOURCE_EXTENDEND on NetBSD 1.5/1.5.* NetBSD 1.6/1.6.* and some older versions of -current. For newer versions of -curernt the definition of _NETBSD_SOURCE 'fixes' the problems introduced by the posix macros. The curses problem is more a generic problem. wchar_t / wint_t are defined as "integer types" by POSIX see: http://www.opengroup.org/onlinepubs/007904975/basedefs/stddef.h.html http://www.opengroup.org/onlinepubs/007904975/basedefs/wchar.h.html On NetBSD wchar_t is an 'int' and ncurses defines it to 'unsigned long'. Thus the declaration clash. And this can happen on any os that defines wchar_t and uses ncurses for python. Because of that i think the test should be something like: if defined(_XOPEN_SOURCE_EXTENDED) && defined(HAS_WCHAR_T) && defined(NCURSES_VERSION) (And maybe a similar with HAS_WINT_Tif we can't assume that the os declares wint_t if it declares wchar_t.) ---------------------------------------------------------------------- Comment By: Anthony Baxter (anthonybaxter) Date: 2003-10-22 05:57 Message: Logged In: YES user_id=29957 Note that the configure script in the trunk and 2.3 branch already has a workaround for this - it doesn't define the _XOPEN_SOURCE_EXTENDED macro for FreeBSD and Darwin. If the same fix is needed for NetBSD, could you supply a patch for configure.in? ---------------------------------------------------------------------- Comment By: Marc Recht (marc) Date: 2003-10-22 00:44 Message: Logged In: YES user_id=205 NetBSD ;-) But, you're right. It's the problem of the ncurses package and not NetBSD's (nor FreeBSD's since it has a similar fix). It has also already been fixed in the dev. version of ncurses. I'm going to backport the fix for the NetBSD pkgsrc version of ncurses, but the problem remains for people who are using (or try to use) stock python and ncurses sources. I still don't see a version test here. Digging in CVS shows that wchar_t has been around for ages now (and it's going to stay). A solution could be to test for the existence of wchar_t in configure and change the test to something like: if defined(_XOPEN_SOURCE_EXTENDED) && defined(HAS_WCHAR_T) && defined(NCURSES_VERSION) #ifndef _WCHAR_T #define _WCHAR_T [...] And thus making it OS independent. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 12:25 Message: Logged In: YES user_id=21627 Ok, then I still maintain that this is a bug in FreeBSD - namely, in the package. There should then still be a test for versions, so that we know when we can take the work-around out. Otherwise, the work-around will stay in forever, as we have no means of knowing whether it is still needed. That would be bad. ---------------------------------------------------------------------- Comment By: Marc Recht (marc) Date: 2003-09-23 19:31 Message: Logged In: YES user_id=205 Just one note that might clarify things a bit more... ncurses is installed with the pkgsrc system (like FreeBSD's ports). It doesn't get installed with the base system nor is it in one of the system directories. (It's in /usr/pkg.) NetBSD has a curses implementation, but it has not (yet) all the features Python needs. Because of that we use GNU ncurses (atm 5.3). ---------------------------------------------------------------------- Comment By: Marc Recht (marc) Date: 2003-09-23 16:58 Message: Logged In: YES user_id=205 Oh. I think we're talking at cross-purposes. The _system_ curses isn't used, it's GNU ncurses. And ncurses and char.h clash if _XOPEN_SOURCE_EXTENDED is defined. Naturally the system curses and wchar.h could be included together. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-09-19 00:45 Message: Logged In: YES user_id=21627 Is it the case that curses.h and wchar.h cannot be simultaneously be included if a certain supported #define is given? If so, it is clearly a bug in the header files - it should not be possible to get conflicting declarations by just including system headers. Even if it applies to all released versions of the system, I still need an explicit list of what these versions are, and I need a compile-time failure if a version is encountered that isn't listed. That the next release is only a year away is a good thing - maybe they can fix the bug until then. They won't, of course, fix the bug if nobody tells them there is a bug... ---------------------------------------------------------------------- Comment By: Marc Recht (marc) Date: 2003-09-18 23:51 Message: Logged In: YES user_id=205 Hmm. I won't consider it a bug in NetBSD. Just a clash of declarations.. ;-) The attached patch is needed for 1.6.x and -current (which will be released not sooner than next year). I'm not sure about 1.5, but I'd bet it's the same. So, there's just no restriction possible. It's simply - all - (if _XOPEN_SOURCE_EXTENDED is defined). ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-09-18 20:33 Message: Logged In: YES user_id=21627 That is a work around a NetBSD bug, right? If so, there should be some procedure to retest presence of the bug in new NetBSD releases, and record the versions for which the bug has been found to be present. Then, when the newest release with the bug is not supported in Python anymore, the code can be removed (which might well be 10 years from now). If possible, a code fragment like #if (NetBSD_major == 3) or (NetBSD_major==4) // bug present, add work-around #else #error Please check whether the bug is still present #endif ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=806800&group_id=5470 From noreply at sourceforge.net Thu Oct 23 07:13:49 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Thu Oct 23 07:14:13 2003 Subject: [Patches] [ python-Patches-825639 ] let's get rid of cyclic object comparison Message-ID: Patches item #825639, was opened at 2003-10-17 17:49 Message generated for change (Comment added) made by arigo You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825639&group_id=5470 Category: Core (C code) Group: Python 2.4 Status: Open Resolution: None Priority: 5 Submitted By: Armin Rigo (arigo) Assigned to: Nobody/Anonymous (nobody) Summary: let's get rid of cyclic object comparison Initial Comment: Comparison of objects with recursive references is a cool feature but it leaves too many questions open and feels too much like a "do-what-i-mean" hack. Attached patch casts it into the obscure world of CVS history. On the positive side, the patch contributes a Py_EnterRecursiveCall()/Py_LeaveRecursiveCall() pair of functions to the C API, to use at any point where an infinite C-level recursion could occur. This is now used by: eval_frame() PyObject_Compare() PyObject_RichCompare() instance_call() and maybe it should be extended to cPickle.c, which has its own notion of maximum nesting as well. The diff also changes the tests to expect a RuntimeError when comparing nested structures. ---------------------------------------------------------------------- >Comment By: Armin Rigo (arigo) Date: 2003-10-23 11:13 Message: Logged In: YES user_id=4771 Ok. Before I reply to python-dev let me point out that I tried not to weaken any test. I guess you thought I just removed some tests, because I indeed usually replaced a group of self.assertXxx() lines with a smaller number of assertions, but as far as I can tell they all test the structure as much as the original assertions, and sometimes even more. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-19 18:41 Message: Logged In: YES user_id=21627 I think the patch needs to be discussed on python-dev to get a chance to be accepted. It should also be accompanied with a more elaborate rationale, and a guideline on how applications that rely on the feature could detect the change, and how those applications need to be updated. For example, I find the change to the pickle tester unacceptable: you can't just drop the structural-equivalence test, since it is the primary purpose of this test to establish structural equivalence. So perhaps you should put a custom structural-equivalence algorithm into pickletester, and replace the assertEquals with that. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825639&group_id=5470 From noreply at sourceforge.net Thu Oct 23 08:15:28 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Thu Oct 23 08:15:52 2003 Subject: [Patches] [ python-Patches-772077 ] small fix for setup.py Message-ID: Patches item #772077, was opened at 2003-07-16 00:13 Message generated for change (Comment added) made by akuchling You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=772077&group_id=5470 Category: Build Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Tim Rice (tim1470) Assigned to: A.M. Kuchling (akuchling) Summary: small fix for setup.py Initial Comment: On UnixWare platforms readline module doesn't build because it needs -lcurses. Here is a patch that corrects this. This should also be applied to the 2.2 tree. here is the error. *** WARNING: renaming "readline" since importing it failed: dynamic linker: ./python: relocation error: symbol not found: tputs; referenced from: /usr/local/lib/libreadline.so.3 ---------------------------------------------------------------------- >Comment By: A.M. Kuchling (akuchling) Date: 2003-10-23 08:15 Message: Logged In: YES user_id=11375 Question: why does the second test use 'unixware' and 'openunix8', while the first test uses only 'unixware'? ---------------------------------------------------------------------- Comment By: Tim Rice (tim1470) Date: 2003-09-25 16:02 Message: Logged In: YES user_id=618097 patch2 doesn't quite worlk but it's on the right track I've attached setup.py.patch3 that does work. ---------------------------------------------------------------------- Comment By: A.M. Kuchling (akuchling) Date: 2003-09-25 13:52 Message: Logged In: YES user_id=11375 There's already an earlier bit of code that adds /usr/ccs/lib on OSF/1, so maybe it's better to just add Unixware to that test. Does the new attached patch work for you? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=772077&group_id=5470 From noreply at sourceforge.net Thu Oct 23 11:56:12 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Thu Oct 23 11:57:20 2003 Subject: [Patches] [ python-Patches-813200 ] Fix test_tempfile: space in Win32 install path bug #811082 Message-ID: Patches item #813200, was opened at 2003-09-26 19:59 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=813200&group_id=5470 Category: Tests Group: Python 2.3 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Michael Bartl (midramas) Assigned to: Martin v. L?wis (loewis) Summary: Fix test_tempfile: space in Win32 install path bug #811082 Initial Comment: Fix: - corrected arguments passed to spawnl function and added comment to explain tricky win32 behaviour Bug description: test_tempfile.py fails on XP (probably other platforms too) when Python is installed into \Program Files\Python2.3 ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-23 17:56 Message: Logged In: YES user_id=21627 Thanks, committed as test_tempfile.py 1.16 and 1.14.8.3; NEWS 1.831.4.65. ---------------------------------------------------------------------- Comment By: Michael Bartl (midramas) Date: 2003-10-21 23:59 Message: Logged In: YES user_id=31511 Stupid me! As written in the comment the fix only applies for windows so the OS should have been checked. Uploaded a new patch, which was tested on Linux & Windows XP. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 20:09 Message: Logged In: YES user_id=21627 The patch is incorrect. On Unix, I get "/home/martin/work/py2.4/python": can't open file '"/home/martin/work/py2.4/Lib/test/tf_inherit_check.py"' test test_tempfile failed -- Traceback (most recent call last): File "/home/martin/work/py2.4/Lib/test/test_tempfile.py", line 304, in test_noinherit self.failIf(retval > 0, "child process reports failure") File "/home/martin/work/py2.4/Lib/unittest.py", line 288, in failIf if expr: raise self.failureException, msg AssertionError: child process reports failure ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=813200&group_id=5470 From noreply at sourceforge.net Thu Oct 23 13:51:02 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Thu Oct 23 13:51:07 2003 Subject: [Patches] [ python-Patches-829073 ] ref. manual talks of 'sequence' instead of 'iterable' Message-ID: Patches item #829073, was opened at 2003-10-23 19:51 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=829073&group_id=5470 Category: Documentation Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Gerrit Holl (gerrit) Assigned to: Nobody/Anonymous (nobody) Summary: ref. manual talks of 'sequence' instead of 'iterable' Initial Comment: The language reference of Python 2.3 and the one of Python 2.4a0 says the expression_list in a for statement should yield a sequence. However, it may yield any iterable, so this is not really true. It is correct earlier in the text, since it does say "or other iterable object" earlier. This patch changes the mention of "sequence" to "iterable" in two more occurences of the language reference of the for statement. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=829073&group_id=5470 From noreply at sourceforge.net Thu Oct 23 14:11:13 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Thu Oct 23 14:11:21 2003 Subject: [Patches] [ python-Patches-825313 ] Add additional isxxx functions to string object. Message-ID: Patches item #825313, was opened at 2003-10-16 22:47 Message generated for change (Comment added) made by ehuss You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825313&group_id=5470 Category: Core (C code) Group: Python 2.4 Status: Open Resolution: None Priority: 4 Submitted By: Eric Huss (ehuss) Assigned to: Nobody/Anonymous (nobody) Summary: Add additional isxxx functions to string object. Initial Comment: This patch adds the following ctype.h functions to the string object. iscntrl isgraph isprint ispunct isxdigit These are pretty standard C functions...I'm not sure why they were left out. It also deletes a lot of duplicated code. This patch might not be 100% useful because it does not have the unicode equivalents. Thoughts? ---------------------------------------------------------------------- >Comment By: Eric Huss (ehuss) Date: 2003-10-23 11:11 Message: Logged In: YES user_id=393416 isprint is useful to make sure there are "safe" characters in a string. In a tty-based application, and you have potentially hostile text to display to the user, you want to make sure that no terminal control characters are sent. isgraph is exactly the same as isprint, except it does not include the space character. I do not understand Brett's comment about isxdigit. I would avoid renaming it since the naming convention already follows the C functions. And it is not the same as isalnum and isalpha...which is the same as isdigit (which already exists). isxdigit tests for a hexadecimal character (0-9 a-f A-F). I think it would be mildly useful. I can follow up with a patch for documentation and unit tests. As for Unicode support, unforutnately I do not know where to begin to update makeunicodedata.py. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 02:58 Message: Logged In: YES user_id=21627 The patch is incomplete, as it comes without documentation and test cases. Eric, I would normally request these at this point, but I'm also with Brett that wrapping these functions might be useless. What is the rationale for including them? ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-10-17 12:53 Message: Logged In: YES user_id=357491 I don't really see a good use for any of these. Chances that most people are going to need most of these is very minor (heck, I don't even know what isgraph would test for). isxdigit might be slightly helpful if you renamed it isnum, but you can fake that already with ``x.isalnum() and not x.isalpha()``. But in general I am -1 on these. str has enough methods as it is. ---------------------------------------------------------------------- Comment By: Andrew Gaul (gaul) Date: 2003-10-17 12:26 Message: Logged In: YES user_id=139865 I like shedding ~80 lines with is_helper, especially if you add inline. Otherwise, function call overhead might be incurred for every call to C isfoo() instead of inlining the comparison. I dislike increasing the distinction between ASCII and Unicode strings, although Unicode strings already have isdecimal and isnumeric methods which ASCII strings lack. I would at least add iscntrl, ispunct, and isxdigit to Unicode strings if they are added to ASCII strings. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825313&group_id=5470 From noreply at sourceforge.net Thu Oct 23 17:38:25 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Thu Oct 23 17:38:39 2003 Subject: [Patches] [ python-Patches-772077 ] small fix for setup.py Message-ID: Patches item #772077, was opened at 2003-07-15 21:13 Message generated for change (Comment added) made by tim1470 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=772077&group_id=5470 Category: Build Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Tim Rice (tim1470) Assigned to: A.M. Kuchling (akuchling) Summary: small fix for setup.py Initial Comment: On UnixWare platforms readline module doesn't build because it needs -lcurses. Here is a patch that corrects this. This should also be applied to the 2.2 tree. here is the error. *** WARNING: renaming "readline" since importing it failed: dynamic linker: ./python: relocation error: symbol not found: tputs; referenced from: /usr/local/lib/libreadline.so.3 ---------------------------------------------------------------------- >Comment By: Tim Rice (tim1470) Date: 2003-10-23 14:38 Message: Logged In: YES user_id=618097 sys.platform returns unixware7 so I added ther first test. The OpenUNIX product name has been dropped in favor of UnixWare again. So I don't expect any other openunixN Now I can't remember why I added the first hunk instead of just the second hunk with s/unixware/unixware7/ ---------------------------------------------------------------------- Comment By: A.M. Kuchling (akuchling) Date: 2003-10-23 05:15 Message: Logged In: YES user_id=11375 Question: why does the second test use 'unixware' and 'openunix8', while the first test uses only 'unixware'? ---------------------------------------------------------------------- Comment By: Tim Rice (tim1470) Date: 2003-09-25 13:02 Message: Logged In: YES user_id=618097 patch2 doesn't quite worlk but it's on the right track I've attached setup.py.patch3 that does work. ---------------------------------------------------------------------- Comment By: A.M. Kuchling (akuchling) Date: 2003-09-25 10:52 Message: Logged In: YES user_id=11375 There's already an earlier bit of code that adds /usr/ccs/lib on OSF/1, so maybe it's better to just add Unixware to that test. Does the new attached patch work for you? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=772077&group_id=5470 From noreply at sourceforge.net Thu Oct 23 20:34:31 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Thu Oct 23 20:34:53 2003 Subject: [Patches] [ python-Patches-825313 ] Add additional isxxx functions to string object. Message-ID: Patches item #825313, was opened at 2003-10-16 22:47 Message generated for change (Comment added) made by bcannon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825313&group_id=5470 Category: Core (C code) Group: Python 2.4 Status: Open Resolution: None Priority: 4 Submitted By: Eric Huss (ehuss) Assigned to: Nobody/Anonymous (nobody) Summary: Add additional isxxx functions to string object. Initial Comment: This patch adds the following ctype.h functions to the string object. iscntrl isgraph isprint ispunct isxdigit These are pretty standard C functions...I'm not sure why they were left out. It also deletes a lot of duplicated code. This patch might not be 100% useful because it does not have the unicode equivalents. Thoughts? ---------------------------------------------------------------------- >Comment By: Brett Cannon (bcannon) Date: 2003-10-23 17:34 Message: Logged In: YES user_id=357491 You don't need to understand my comment because I goofed. For some reason I remember reading ``help(str.isdigit)`` and it saying it only worked for a single character. I still don't find these that useful. isgraph seems especially useless since you could easily just strip the whitespace out and then call isprint on it. For the argument of keeping the names with C, that is not valid. This is being introduced into Python for the first time and thus should have a proper name. There is not enough of a widespread connection to C in terms of these functions to have to worry about keeping the name the same. Regardless of all of this I am still -1 on all of the methods. ---------------------------------------------------------------------- Comment By: Eric Huss (ehuss) Date: 2003-10-23 11:11 Message: Logged In: YES user_id=393416 isprint is useful to make sure there are "safe" characters in a string. In a tty-based application, and you have potentially hostile text to display to the user, you want to make sure that no terminal control characters are sent. isgraph is exactly the same as isprint, except it does not include the space character. I do not understand Brett's comment about isxdigit. I would avoid renaming it since the naming convention already follows the C functions. And it is not the same as isalnum and isalpha...which is the same as isdigit (which already exists). isxdigit tests for a hexadecimal character (0-9 a-f A-F). I think it would be mildly useful. I can follow up with a patch for documentation and unit tests. As for Unicode support, unforutnately I do not know where to begin to update makeunicodedata.py. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 02:58 Message: Logged In: YES user_id=21627 The patch is incomplete, as it comes without documentation and test cases. Eric, I would normally request these at this point, but I'm also with Brett that wrapping these functions might be useless. What is the rationale for including them? ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-10-17 12:53 Message: Logged In: YES user_id=357491 I don't really see a good use for any of these. Chances that most people are going to need most of these is very minor (heck, I don't even know what isgraph would test for). isxdigit might be slightly helpful if you renamed it isnum, but you can fake that already with ``x.isalnum() and not x.isalpha()``. But in general I am -1 on these. str has enough methods as it is. ---------------------------------------------------------------------- Comment By: Andrew Gaul (gaul) Date: 2003-10-17 12:26 Message: Logged In: YES user_id=139865 I like shedding ~80 lines with is_helper, especially if you add inline. Otherwise, function call overhead might be incurred for every call to C isfoo() instead of inlining the comparison. I dislike increasing the distinction between ASCII and Unicode strings, although Unicode strings already have isdecimal and isnumeric methods which ASCII strings lack. I would at least add iscntrl, ispunct, and isxdigit to Unicode strings if they are added to ASCII strings. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825313&group_id=5470 From noreply at sourceforge.net Thu Oct 23 20:44:51 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Thu Oct 23 20:46:27 2003 Subject: [Patches] [ python-Patches-829073 ] ref. manual talks of 'sequence' instead of 'iterable' Message-ID: Patches item #829073, was opened at 2003-10-23 10:51 Message generated for change (Comment added) made by bcannon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=829073&group_id=5470 Category: Documentation Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Gerrit Holl (gerrit) Assigned to: Nobody/Anonymous (nobody) Summary: ref. manual talks of 'sequence' instead of 'iterable' Initial Comment: The language reference of Python 2.3 and the one of Python 2.4a0 says the expression_list in a for statement should yield a sequence. However, it may yield any iterable, so this is not really true. It is correct earlier in the text, since it does say "or other iterable object" earlier. This patch changes the mention of "sequence" to "iterable" in two more occurences of the language reference of the for statement. ---------------------------------------------------------------------- >Comment By: Brett Cannon (bcannon) Date: 2003-10-23 17:44 Message: Logged In: YES user_id=357491 This is slightly touchy wording. It does accept an object that defines __getitem__ and not __iter__, and vice-versa. And since iterables can be thought of as sequences it still basically works. But I have no issue moving over to "iterable", personally. I am going to let someone else weigh in on this. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=829073&group_id=5470 From noreply at sourceforge.net Fri Oct 24 03:34:19 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 24 03:34:39 2003 Subject: [Patches] [ python-Patches-825313 ] Add additional isxxx functions to string object. Message-ID: Patches item #825313, was opened at 2003-10-17 07:47 Message generated for change (Comment added) made by lemburg You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825313&group_id=5470 Category: Core (C code) Group: Python 2.4 Status: Open Resolution: None >Priority: 1 Submitted By: Eric Huss (ehuss) Assigned to: Nobody/Anonymous (nobody) Summary: Add additional isxxx functions to string object. Initial Comment: This patch adds the following ctype.h functions to the string object. iscntrl isgraph isprint ispunct isxdigit These are pretty standard C functions...I'm not sure why they were left out. It also deletes a lot of duplicated code. This patch might not be 100% useful because it does not have the unicode equivalents. Thoughts? ---------------------------------------------------------------------- >Comment By: M.-A. Lemburg (lemburg) Date: 2003-10-24 09:34 Message: Logged In: YES user_id=38388 -1 from here. You can have the same using a regular expression character group built using the unicodedata(base) or just using a static mapping for 8-bit chars. There are too few use cases for these methods that it would make sense adding extra logic and static data to make the mapping fast enough. Brett, feel free to close this request. ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-10-24 02:34 Message: Logged In: YES user_id=357491 You don't need to understand my comment because I goofed. For some reason I remember reading ``help(str.isdigit)`` and it saying it only worked for a single character. I still don't find these that useful. isgraph seems especially useless since you could easily just strip the whitespace out and then call isprint on it. For the argument of keeping the names with C, that is not valid. This is being introduced into Python for the first time and thus should have a proper name. There is not enough of a widespread connection to C in terms of these functions to have to worry about keeping the name the same. Regardless of all of this I am still -1 on all of the methods. ---------------------------------------------------------------------- Comment By: Eric Huss (ehuss) Date: 2003-10-23 20:11 Message: Logged In: YES user_id=393416 isprint is useful to make sure there are "safe" characters in a string. In a tty-based application, and you have potentially hostile text to display to the user, you want to make sure that no terminal control characters are sent. isgraph is exactly the same as isprint, except it does not include the space character. I do not understand Brett's comment about isxdigit. I would avoid renaming it since the naming convention already follows the C functions. And it is not the same as isalnum and isalpha...which is the same as isdigit (which already exists). isxdigit tests for a hexadecimal character (0-9 a-f A-F). I think it would be mildly useful. I can follow up with a patch for documentation and unit tests. As for Unicode support, unforutnately I do not know where to begin to update makeunicodedata.py. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 11:58 Message: Logged In: YES user_id=21627 The patch is incomplete, as it comes without documentation and test cases. Eric, I would normally request these at this point, but I'm also with Brett that wrapping these functions might be useless. What is the rationale for including them? ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-10-17 21:53 Message: Logged In: YES user_id=357491 I don't really see a good use for any of these. Chances that most people are going to need most of these is very minor (heck, I don't even know what isgraph would test for). isxdigit might be slightly helpful if you renamed it isnum, but you can fake that already with ``x.isalnum() and not x.isalpha()``. But in general I am -1 on these. str has enough methods as it is. ---------------------------------------------------------------------- Comment By: Andrew Gaul (gaul) Date: 2003-10-17 21:26 Message: Logged In: YES user_id=139865 I like shedding ~80 lines with is_helper, especially if you add inline. Otherwise, function call overhead might be incurred for every call to C isfoo() instead of inlining the comparison. I dislike increasing the distinction between ASCII and Unicode strings, although Unicode strings already have isdecimal and isnumeric methods which ASCII strings lack. I would at least add iscntrl, ispunct, and isxdigit to Unicode strings if they are added to ASCII strings. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825313&group_id=5470 From noreply at sourceforge.net Fri Oct 24 08:11:40 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 24 08:11:54 2003 Subject: [Patches] [ python-Patches-772077 ] small fix for setup.py Message-ID: Patches item #772077, was opened at 2003-07-16 00:13 Message generated for change (Comment added) made by akuchling You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=772077&group_id=5470 Category: Build Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Tim Rice (tim1470) Assigned to: A.M. Kuchling (akuchling) Summary: small fix for setup.py Initial Comment: On UnixWare platforms readline module doesn't build because it needs -lcurses. Here is a patch that corrects this. This should also be applied to the 2.2 tree. here is the error. *** WARNING: renaming "readline" since importing it failed: dynamic linker: ./python: relocation error: symbol not found: tputs; referenced from: /usr/local/lib/libreadline.so.3 ---------------------------------------------------------------------- >Comment By: A.M. Kuchling (akuchling) Date: 2003-10-24 08:11 Message: Logged In: YES user_id=11375 So does the attached patch work? It just checks for openunix8 or unixware7. ---------------------------------------------------------------------- Comment By: Tim Rice (tim1470) Date: 2003-10-23 17:38 Message: Logged In: YES user_id=618097 sys.platform returns unixware7 so I added ther first test. The OpenUNIX product name has been dropped in favor of UnixWare again. So I don't expect any other openunixN Now I can't remember why I added the first hunk instead of just the second hunk with s/unixware/unixware7/ ---------------------------------------------------------------------- Comment By: A.M. Kuchling (akuchling) Date: 2003-10-23 08:15 Message: Logged In: YES user_id=11375 Question: why does the second test use 'unixware' and 'openunix8', while the first test uses only 'unixware'? ---------------------------------------------------------------------- Comment By: Tim Rice (tim1470) Date: 2003-09-25 16:02 Message: Logged In: YES user_id=618097 patch2 doesn't quite worlk but it's on the right track I've attached setup.py.patch3 that does work. ---------------------------------------------------------------------- Comment By: A.M. Kuchling (akuchling) Date: 2003-09-25 13:52 Message: Logged In: YES user_id=11375 There's already an earlier bit of code that adds /usr/ccs/lib on OSF/1, so maybe it's better to just add Unixware to that test. Does the new attached patch work for you? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=772077&group_id=5470 From noreply at sourceforge.net Fri Oct 24 08:14:05 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 24 08:14:20 2003 Subject: [Patches] [ python-Patches-508730 ] CGIHTTPServer execfile should save cwd Message-ID: Patches item #508730, was opened at 2002-01-25 18:41 Message generated for change (Comment added) made by akuchling You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=508730&group_id=5470 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Dan Grassi (dgrassi) Assigned to: Nobody/Anonymous (nobody) Summary: CGIHTTPServer execfile should save cwd Initial Comment: In CGIHTTPServer when running a script via execfile the cwd is not saved and restored. If the executed script changes the cwd subsequent requests will fail because self.translate_path in SimpleHTTPServer relies on the cwd. One fix is to suround the execfile call with save_cwd = os.getcwd() and os.chdir(save_cwd) Here is the proposed fix starting at line 254: + save_cwd = os.getcwd() try: try: sys.argv = [scriptfile] if '=' not in decoded_query: sys.argv.append(decoded_query) sys.stdout = self.wfile sys.stdin = self.rfile execfile(scriptfile, {"__name__": "__main__"}) finally: + os.chdir(save_cwd) ---------------------------------------------------------------------- >Comment By: A.M. Kuchling (akuchling) Date: 2003-10-24 08:14 Message: Logged In: YES user_id=11375 It looks like a bug worth fixing, and the proposed patch seems reasonable. ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-05-16 20:47 Message: Logged In: YES user_id=357491 Since a patch is in the comments I am making this a patch instead of a bug. As for the idea, it seems good to me. Anyone else care to comment? ---------------------------------------------------------------------- Comment By: Dan Grassi (dgrassi) Date: 2002-01-25 18:55 Message: Logged In: YES user_id=366473 Here is the (hopefully) properly indented fix: + save_cwd = os.getcwd() try: try: sys.argv = [scriptfile] if '=' not in decoded_query: sys.argv.append(decoded_query) sys.stdout = self.wfile sys.stdin = self.rfile execfile(scriptfile, {"__name__": "__main__"}) finally: + os.chdir(save_cwd) ---------------------------------------------------------------------- Comment By: Dan Grassi (dgrassi) Date: 2002-01-25 18:48 Message: Logged In: YES user_id=366473 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=508730&group_id=5470 From noreply at sourceforge.net Fri Oct 24 12:06:49 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 24 12:07:28 2003 Subject: [Patches] [ python-Patches-806800 ] NetBSD py_curses.h fix Message-ID: Patches item #806800, was opened at 2003-09-15 22:47 Message generated for change (Comment added) made by marc You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=806800&group_id=5470 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Marc Recht (marc) Assigned to: Nobody/Anonymous (nobody) Summary: NetBSD py_curses.h fix Initial Comment: On NetBSD, [n]curses.h and stdlib.h/wchar.h use different guards against multiple definition of wchar_t and wint_t. ---------------------------------------------------------------------- >Comment By: Marc Recht (marc) Date: 2003-10-24 18:06 Message: Logged In: YES user_id=205 No, it's a bug in ncurses <= 5.3. It has been fixed in the current development version of ncurses. And - in the ncurses case - it has to do wich _XOPEN_SOURCE_EXTENDED, because ncurses only defines wchar_t/wint_t then. I followed your suggestion and made a new patch which defines HAVE_WCHAR_T/_WINT and _WCHAR_T / _WINT_T if the system provides them. I'm not 100% sure of the wchar_t test, I'm testing only stddef.h for wchar_t. (POSIX requires it to be defined there...) I'm not sure if the system should define _WCHAR_T (and thus polluting the namespace), since the only systems which are using the define are Solaris and Linux. (AFAIK) ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-23 08:10 Message: Logged In: YES user_id=21627 I disagree that the bug is in ncurses. ncurses supports conditional definition of wchar_t/wint_t, which normally should be defined by the platform. ncurses does so by testing for the _WCHAR_T and wchar_t macros, so for interoperability, the system should define _WCHAR_T (even though there is no standard requiring the definition of _WCHAR_T). This has nothing to do with _XOPEN_SOURCE_EXTENDED. Now, that might provide an alternative solution: if the system has wchar_t, and fails to define _WCHAR_T, we should define it ourselves before including ncurses.h. ---------------------------------------------------------------------- Comment By: Marc Recht (marc) Date: 2003-10-22 16:03 Message: Logged In: YES user_id=205 ATM i'm doing some tests with a patch that disables _XOPEN_SOURCE_EXTENDEND on NetBSD 1.5/1.5.* NetBSD 1.6/1.6.* and some older versions of -current. For newer versions of -curernt the definition of _NETBSD_SOURCE 'fixes' the problems introduced by the posix macros. The curses problem is more a generic problem. wchar_t / wint_t are defined as "integer types" by POSIX see: http://www.opengroup.org/onlinepubs/007904975/basedefs/stddef.h.html http://www.opengroup.org/onlinepubs/007904975/basedefs/wchar.h.html On NetBSD wchar_t is an 'int' and ncurses defines it to 'unsigned long'. Thus the declaration clash. And this can happen on any os that defines wchar_t and uses ncurses for python. Because of that i think the test should be something like: if defined(_XOPEN_SOURCE_EXTENDED) && defined(HAS_WCHAR_T) && defined(NCURSES_VERSION) (And maybe a similar with HAS_WINT_Tif we can't assume that the os declares wint_t if it declares wchar_t.) ---------------------------------------------------------------------- Comment By: Anthony Baxter (anthonybaxter) Date: 2003-10-22 05:57 Message: Logged In: YES user_id=29957 Note that the configure script in the trunk and 2.3 branch already has a workaround for this - it doesn't define the _XOPEN_SOURCE_EXTENDED macro for FreeBSD and Darwin. If the same fix is needed for NetBSD, could you supply a patch for configure.in? ---------------------------------------------------------------------- Comment By: Marc Recht (marc) Date: 2003-10-22 00:44 Message: Logged In: YES user_id=205 NetBSD ;-) But, you're right. It's the problem of the ncurses package and not NetBSD's (nor FreeBSD's since it has a similar fix). It has also already been fixed in the dev. version of ncurses. I'm going to backport the fix for the NetBSD pkgsrc version of ncurses, but the problem remains for people who are using (or try to use) stock python and ncurses sources. I still don't see a version test here. Digging in CVS shows that wchar_t has been around for ages now (and it's going to stay). A solution could be to test for the existence of wchar_t in configure and change the test to something like: if defined(_XOPEN_SOURCE_EXTENDED) && defined(HAS_WCHAR_T) && defined(NCURSES_VERSION) #ifndef _WCHAR_T #define _WCHAR_T [...] And thus making it OS independent. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 12:25 Message: Logged In: YES user_id=21627 Ok, then I still maintain that this is a bug in FreeBSD - namely, in the package. There should then still be a test for versions, so that we know when we can take the work-around out. Otherwise, the work-around will stay in forever, as we have no means of knowing whether it is still needed. That would be bad. ---------------------------------------------------------------------- Comment By: Marc Recht (marc) Date: 2003-09-23 19:31 Message: Logged In: YES user_id=205 Just one note that might clarify things a bit more... ncurses is installed with the pkgsrc system (like FreeBSD's ports). It doesn't get installed with the base system nor is it in one of the system directories. (It's in /usr/pkg.) NetBSD has a curses implementation, but it has not (yet) all the features Python needs. Because of that we use GNU ncurses (atm 5.3). ---------------------------------------------------------------------- Comment By: Marc Recht (marc) Date: 2003-09-23 16:58 Message: Logged In: YES user_id=205 Oh. I think we're talking at cross-purposes. The _system_ curses isn't used, it's GNU ncurses. And ncurses and char.h clash if _XOPEN_SOURCE_EXTENDED is defined. Naturally the system curses and wchar.h could be included together. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-09-19 00:45 Message: Logged In: YES user_id=21627 Is it the case that curses.h and wchar.h cannot be simultaneously be included if a certain supported #define is given? If so, it is clearly a bug in the header files - it should not be possible to get conflicting declarations by just including system headers. Even if it applies to all released versions of the system, I still need an explicit list of what these versions are, and I need a compile-time failure if a version is encountered that isn't listed. That the next release is only a year away is a good thing - maybe they can fix the bug until then. They won't, of course, fix the bug if nobody tells them there is a bug... ---------------------------------------------------------------------- Comment By: Marc Recht (marc) Date: 2003-09-18 23:51 Message: Logged In: YES user_id=205 Hmm. I won't consider it a bug in NetBSD. Just a clash of declarations.. ;-) The attached patch is needed for 1.6.x and -current (which will be released not sooner than next year). I'm not sure about 1.5, but I'd bet it's the same. So, there's just no restriction possible. It's simply - all - (if _XOPEN_SOURCE_EXTENDED is defined). ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-09-18 20:33 Message: Logged In: YES user_id=21627 That is a work around a NetBSD bug, right? If so, there should be some procedure to retest presence of the bug in new NetBSD releases, and record the versions for which the bug has been found to be present. Then, when the newest release with the bug is not supported in Python anymore, the code can be removed (which might well be 10 years from now). If possible, a code fragment like #if (NetBSD_major == 3) or (NetBSD_major==4) // bug present, add work-around #else #error Please check whether the bug is still present #endif ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=806800&group_id=5470 From noreply at sourceforge.net Fri Oct 24 14:21:13 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 24 14:21:35 2003 Subject: [Patches] [ python-Patches-772077 ] small fix for setup.py Message-ID: Patches item #772077, was opened at 2003-07-15 21:13 Message generated for change (Comment added) made by tim1470 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=772077&group_id=5470 Category: Build Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Tim Rice (tim1470) Assigned to: A.M. Kuchling (akuchling) Summary: small fix for setup.py Initial Comment: On UnixWare platforms readline module doesn't build because it needs -lcurses. Here is a patch that corrects this. This should also be applied to the 2.2 tree. here is the error. *** WARNING: renaming "readline" since importing it failed: dynamic linker: ./python: relocation error: symbol not found: tputs; referenced from: /usr/local/lib/libreadline.so.3 ---------------------------------------------------------------------- >Comment By: Tim Rice (tim1470) Date: 2003-10-24 11:21 Message: Logged In: YES user_id=618097 Yes it works fine. ---------------------------------------------------------------------- Comment By: A.M. Kuchling (akuchling) Date: 2003-10-24 05:11 Message: Logged In: YES user_id=11375 So does the attached patch work? It just checks for openunix8 or unixware7. ---------------------------------------------------------------------- Comment By: Tim Rice (tim1470) Date: 2003-10-23 14:38 Message: Logged In: YES user_id=618097 sys.platform returns unixware7 so I added ther first test. The OpenUNIX product name has been dropped in favor of UnixWare again. So I don't expect any other openunixN Now I can't remember why I added the first hunk instead of just the second hunk with s/unixware/unixware7/ ---------------------------------------------------------------------- Comment By: A.M. Kuchling (akuchling) Date: 2003-10-23 05:15 Message: Logged In: YES user_id=11375 Question: why does the second test use 'unixware' and 'openunix8', while the first test uses only 'unixware'? ---------------------------------------------------------------------- Comment By: Tim Rice (tim1470) Date: 2003-09-25 13:02 Message: Logged In: YES user_id=618097 patch2 doesn't quite worlk but it's on the right track I've attached setup.py.patch3 that does work. ---------------------------------------------------------------------- Comment By: A.M. Kuchling (akuchling) Date: 2003-09-25 10:52 Message: Logged In: YES user_id=11375 There's already an earlier bit of code that adds /usr/ccs/lib on OSF/1, so maybe it's better to just add Unixware to that test. Does the new attached patch work for you? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=772077&group_id=5470 From noreply at sourceforge.net Fri Oct 24 14:26:59 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 24 14:27:19 2003 Subject: [Patches] [ python-Patches-772077 ] small fix for setup.py Message-ID: Patches item #772077, was opened at 2003-07-16 00:13 Message generated for change (Comment added) made by akuchling You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=772077&group_id=5470 Category: Build Group: Python 2.3 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Tim Rice (tim1470) Assigned to: A.M. Kuchling (akuchling) Summary: small fix for setup.py Initial Comment: On UnixWare platforms readline module doesn't build because it needs -lcurses. Here is a patch that corrects this. This should also be applied to the 2.2 tree. here is the error. *** WARNING: renaming "readline" since importing it failed: dynamic linker: ./python: relocation error: symbol not found: tputs; referenced from: /usr/local/lib/libreadline.so.3 ---------------------------------------------------------------------- >Comment By: A.M. Kuchling (akuchling) Date: 2003-10-24 14:26 Message: Logged In: YES user_id=11375 Applied (finally :) ) as rev. 1.175 of setup.py; thanks! ---------------------------------------------------------------------- Comment By: Tim Rice (tim1470) Date: 2003-10-24 14:21 Message: Logged In: YES user_id=618097 Yes it works fine. ---------------------------------------------------------------------- Comment By: A.M. Kuchling (akuchling) Date: 2003-10-24 08:11 Message: Logged In: YES user_id=11375 So does the attached patch work? It just checks for openunix8 or unixware7. ---------------------------------------------------------------------- Comment By: Tim Rice (tim1470) Date: 2003-10-23 17:38 Message: Logged In: YES user_id=618097 sys.platform returns unixware7 so I added ther first test. The OpenUNIX product name has been dropped in favor of UnixWare again. So I don't expect any other openunixN Now I can't remember why I added the first hunk instead of just the second hunk with s/unixware/unixware7/ ---------------------------------------------------------------------- Comment By: A.M. Kuchling (akuchling) Date: 2003-10-23 08:15 Message: Logged In: YES user_id=11375 Question: why does the second test use 'unixware' and 'openunix8', while the first test uses only 'unixware'? ---------------------------------------------------------------------- Comment By: Tim Rice (tim1470) Date: 2003-09-25 16:02 Message: Logged In: YES user_id=618097 patch2 doesn't quite worlk but it's on the right track I've attached setup.py.patch3 that does work. ---------------------------------------------------------------------- Comment By: A.M. Kuchling (akuchling) Date: 2003-09-25 13:52 Message: Logged In: YES user_id=11375 There's already an earlier bit of code that adds /usr/ccs/lib on OSF/1, so maybe it's better to just add Unixware to that test. Does the new attached patch work for you? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=772077&group_id=5470 From john-hvyt at yahoo.com Fri Oct 24 14:29:10 2003 From: john-hvyt at yahoo.com (john-hvyt@yahoo.com) Date: Fri Oct 24 15:25:03 2003 Subject: [Patches] Stamina-RX Message-ID: <302101c39a5c$b75f4a10$d5800b0a@edhkopmrhpi> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.python.org/pipermail/patches/attachments/20031024/5c8aba81/attachment-0001.html From noreply at sourceforge.net Fri Oct 24 16:06:05 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 24 16:07:51 2003 Subject: [Patches] [ python-Patches-828384 ] PyModule_AddObject one-liner Message-ID: Patches item #828384, was opened at 2003-10-22 19:56 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=828384&group_id=5470 Category: Core (C code) Group: Python 2.3 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Greg Chapman (glchapman) Assigned to: Nobody/Anonymous (nobody) Summary: PyModule_AddObject one-liner Initial Comment: The attached patch adds one line to the PyModule_AddObject function so that if the supplied object is NULL, and an exception is already set, that exception is left alone rather than being masked by an error from within PyModule_AddObject. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-24 22:06 Message: Logged In: YES user_id=21627 Thanks for the patch; applied as modsupport.c 2.69. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=828384&group_id=5470 From noreply at sourceforge.net Fri Oct 24 16:10:01 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 24 16:10:58 2003 Subject: [Patches] [ python-Patches-812378 ] normalize whitespace Message-ID: Patches item #812378, was opened at 2003-09-25 13:13 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=812378&group_id=5470 Category: Demos and tools Group: Python 2.3 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: George Yoshida (quiver) Assigned to: Nobody/Anonymous (nobody) Summary: normalize whitespace Initial Comment: I normalized some old codes to use 4-space indent. * Lib/distutils/sysconfig.py 8-space indent was used at two places and a tab at one place. Change them into 4-space indents to be consistent with other indents. * Tools/ Change 8-space tabs into 4-space indents. Changes are made to all Python scripts except those at Tools/freeze directory. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-24 22:10 Message: Logged In: YES user_id=21627 Thanks for the patch. Committed as sysconfig.py 1.58 faqconf.py 1.25 template.py 1.2 EXAMPLE.py 1.3 ScrolledListbox.py 1.2 PyncheWidget.py 2.28 StripViewer.py 2.16 _checkversion.py 1.2 checkversions.py 1.4 pyversioncheck.py 1.5 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=812378&group_id=5470 From noreply at sourceforge.net Fri Oct 24 16:11:32 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 24 16:11:37 2003 Subject: [Patches] [ python-Patches-814560 ] deprecated modules Message-ID: Patches item #814560, was opened at 2003-09-29 18:54 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=814560&group_id=5470 Category: Documentation Group: None >Status: Closed >Resolution: Invalid Priority: 5 Submitted By: Juan David Ib??ez Palomar (jdavid) Assigned to: Nobody/Anonymous (nobody) Summary: deprecated modules Initial Comment: it would be nice if the "Global Module Index" showed the deprecated modules clearly separated from the non deprecated modules ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-24 22:11 Message: Logged In: YES user_id=21627 Closed as suggested. ---------------------------------------------------------------------- Comment By: Terry J. Reedy (tjreedy) Date: 2003-10-05 22:20 Message: Logged In: YES user_id=593130 This is not a patch submission. It also dupicates bug report [ 816725 ] mark deprecated modules in indexes. Please close. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=814560&group_id=5470 From noreply at sourceforge.net Fri Oct 24 16:49:47 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 24 16:49:55 2003 Subject: [Patches] [ python-Patches-825313 ] Add additional isxxx functions to string object. Message-ID: Patches item #825313, was opened at 2003-10-16 22:47 Message generated for change (Comment added) made by bcannon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825313&group_id=5470 Category: Core (C code) Group: Python 2.4 >Status: Closed >Resolution: Rejected Priority: 1 Submitted By: Eric Huss (ehuss) Assigned to: Nobody/Anonymous (nobody) Summary: Add additional isxxx functions to string object. Initial Comment: This patch adds the following ctype.h functions to the string object. iscntrl isgraph isprint ispunct isxdigit These are pretty standard C functions...I'm not sure why they were left out. It also deletes a lot of duplicated code. This patch might not be 100% useful because it does not have the unicode equivalents. Thoughts? ---------------------------------------------------------------------- >Comment By: Brett Cannon (bcannon) Date: 2003-10-24 13:49 Message: Logged In: YES user_id=357491 OK, having MA, Martin, and me say "no" works for me. This patch is rejected. Sorry, Eric. What you might want to do, though, Eric, is see if you could help out with the proposed textutil module that has recently been proposed on python-dev. Basically the only thing that would go into this mystical module is a new string substitution function, but this might have a place there. That thread is entitled "Can we please have a better dict interpolation syntax?" from this month (October 2003). ---------------------------------------------------------------------- Comment By: M.-A. Lemburg (lemburg) Date: 2003-10-24 00:34 Message: Logged In: YES user_id=38388 -1 from here. You can have the same using a regular expression character group built using the unicodedata(base) or just using a static mapping for 8-bit chars. There are too few use cases for these methods that it would make sense adding extra logic and static data to make the mapping fast enough. Brett, feel free to close this request. ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-10-23 17:34 Message: Logged In: YES user_id=357491 You don't need to understand my comment because I goofed. For some reason I remember reading ``help(str.isdigit)`` and it saying it only worked for a single character. I still don't find these that useful. isgraph seems especially useless since you could easily just strip the whitespace out and then call isprint on it. For the argument of keeping the names with C, that is not valid. This is being introduced into Python for the first time and thus should have a proper name. There is not enough of a widespread connection to C in terms of these functions to have to worry about keeping the name the same. Regardless of all of this I am still -1 on all of the methods. ---------------------------------------------------------------------- Comment By: Eric Huss (ehuss) Date: 2003-10-23 11:11 Message: Logged In: YES user_id=393416 isprint is useful to make sure there are "safe" characters in a string. In a tty-based application, and you have potentially hostile text to display to the user, you want to make sure that no terminal control characters are sent. isgraph is exactly the same as isprint, except it does not include the space character. I do not understand Brett's comment about isxdigit. I would avoid renaming it since the naming convention already follows the C functions. And it is not the same as isalnum and isalpha...which is the same as isdigit (which already exists). isxdigit tests for a hexadecimal character (0-9 a-f A-F). I think it would be mildly useful. I can follow up with a patch for documentation and unit tests. As for Unicode support, unforutnately I do not know where to begin to update makeunicodedata.py. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-18 02:58 Message: Logged In: YES user_id=21627 The patch is incomplete, as it comes without documentation and test cases. Eric, I would normally request these at this point, but I'm also with Brett that wrapping these functions might be useless. What is the rationale for including them? ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-10-17 12:53 Message: Logged In: YES user_id=357491 I don't really see a good use for any of these. Chances that most people are going to need most of these is very minor (heck, I don't even know what isgraph would test for). isxdigit might be slightly helpful if you renamed it isnum, but you can fake that already with ``x.isalnum() and not x.isalpha()``. But in general I am -1 on these. str has enough methods as it is. ---------------------------------------------------------------------- Comment By: Andrew Gaul (gaul) Date: 2003-10-17 12:26 Message: Logged In: YES user_id=139865 I like shedding ~80 lines with is_helper, especially if you add inline. Otherwise, function call overhead might be incurred for every call to C isfoo() instead of inlining the comparison. I dislike increasing the distinction between ASCII and Unicode strings, although Unicode strings already have isdecimal and isnumeric methods which ASCII strings lack. I would at least add iscntrl, ispunct, and isxdigit to Unicode strings if they are added to ASCII strings. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825313&group_id=5470 From noreply at sourceforge.net Fri Oct 24 22:49:54 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 24 22:49:58 2003 Subject: [Patches] [ python-Patches-829951 ] Fixes smtplib starttls HELO errors Message-ID: Patches item #829951, was opened at 2003-10-24 19:49 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=829951&group_id=5470 Category: Library (Lib) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: John Draper (jdcrunchman) Assigned to: Nobody/Anonymous (nobody) Summary: Fixes smtplib starttls HELO errors Initial Comment: smtplib.starttls() needs to include does_esmtp=0. Without this, the "size=" suffix on MAIL FROM lines causes server errors since the MTA defaults to HELO mode. This is also necessary in order to conform to RFC 2487 section 5.2, which states after TLS is started, all prior knowledge (including esmtp capability) must be discarded. This bug exists in Python 2.3.2 and earlier. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=829951&group_id=5470 From gofpetrq at myownemail.com Sat Oct 25 09:15:10 2003 From: gofpetrq at myownemail.com (Owners) Date: Sat Oct 25 00:15:18 2003 Subject: [Patches] Some unknown facts about ..... sajlnafx Message-ID: An HTML attachment was scrubbed... URL: http://mail.python.org/pipermail/patches/attachments/20031025/398e89aa/attachment.html From noreply at sourceforge.net Sat Oct 25 05:36:09 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 25 05:36:34 2003 Subject: [Patches] [ python-Patches-825417 ] telnetlib timeout fix (bug 822974) Message-ID: Patches item #825417, was opened at 2003-10-17 12:24 Message generated for change (Comment added) made by johahn You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825417&group_id=5470 Category: Library (Lib) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Johan M. Hahn (johahn) Assigned to: Nobody/Anonymous (nobody) Summary: telnetlib timeout fix (bug 822974) Initial Comment: Timeout behaviour do not match the docs. This patch fixes the read_until and expect methods to decreese the timeout between subsequent calls to select.select. See bu g 822974 for more info. My system: Python 2.3 final Windows 2000 5.00.2951 sp4 ...johahn ---------------------------------------------------------------------- >Comment By: Johan M. Hahn (johahn) Date: 2003-10-25 11:36 Message: Logged In: YES user_id=887415 Uploaded some simple code for producing the bug and also testing the patch. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825417&group_id=5470 From noreply at sourceforge.net Sat Oct 25 06:31:09 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 25 06:31:19 2003 Subject: [Patches] [ python-Patches-830070 ] itertoolsmodule.c: islice error messages (827190) Message-ID: Patches item #830070, was opened at 2003-10-25 12:31 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=830070&group_id=5470 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Johan M. Hahn (johahn) Assigned to: Nobody/Anonymous (nobody) Summary: itertoolsmodule.c: islice error messages (827190) Initial Comment: >>> import itertools >>> itertools.islice('abc', 0) >>> itertools.islice('abc', -2) Traceback (most recent call last): File "", line 1, in -toplevel- itertools.islice([1,2,3], -2) ValueError: Indices for islice() must be positive. Error message is changed to "Indices for islice() must be non-negative." since 0 is allowed. >>> itertools.islice('abc', -1) Traceback (most recent call last): File "", line 1, in -toplevel- itertools.islice([1,2,3], -1) ValueError: Stop argument must be an integer or None. Clearly -1 is an integer. This was due to some optimization in itertoolsmodule.c. If PyInt_AsLong returned -1 it was taken as a conversion error. I added an additional else statement to distinguish the two cases that change the variable to -2 if it was in fact -1 to begin with. A little 'hacky' but it seems like the best soloution and it doesn't undo the optimization. ...johahn ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=830070&group_id=5470 From noreply at sourceforge.net Sat Oct 25 06:40:57 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 25 06:41:10 2003 Subject: [Patches] [ python-Patches-830070 ] itertoolsmodule.c: islice error messages (827190) Message-ID: Patches item #830070, was opened at 2003-10-25 12:31 Message generated for change (Comment added) made by johahn You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=830070&group_id=5470 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Johan M. Hahn (johahn) Assigned to: Nobody/Anonymous (nobody) Summary: itertoolsmodule.c: islice error messages (827190) Initial Comment: >>> import itertools >>> itertools.islice('abc', 0) >>> itertools.islice('abc', -2) Traceback (most recent call last): File "", line 1, in -toplevel- itertools.islice([1,2,3], -2) ValueError: Indices for islice() must be positive. Error message is changed to "Indices for islice() must be non-negative." since 0 is allowed. >>> itertools.islice('abc', -1) Traceback (most recent call last): File "", line 1, in -toplevel- itertools.islice([1,2,3], -1) ValueError: Stop argument must be an integer or None. Clearly -1 is an integer. This was due to some optimization in itertoolsmodule.c. If PyInt_AsLong returned -1 it was taken as a conversion error. I added an additional else statement to distinguish the two cases that change the variable to -2 if it was in fact -1 to begin with. A little 'hacky' but it seems like the best soloution and it doesn't undo the optimization. ...johahn ---------------------------------------------------------------------- >Comment By: Johan M. Hahn (johahn) Date: 2003-10-25 12:40 Message: Logged In: YES user_id=887415 Let me add that the code has not been compiled. I just noticed two missing { in the first patch and uploaded a new version. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=830070&group_id=5470 From noreply at sourceforge.net Sat Oct 25 23:07:57 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 25 23:08:12 2003 Subject: [Patches] [ python-Patches-830341 ] python-mode.el: (py-point 'bod) doesn't quite work Message-ID: Patches item #830341, was opened at 2003-10-26 03:07 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=830341&group_id=5470 Category: Demos and tools Group: None Status: Open Resolution: None Priority: 5 Submitted By: Dale Hagglund (dhagglund) Assigned to: Nobody/Anonymous (nobody) Summary: python-mode.el: (py-point 'bod) doesn't quite work Initial Comment: I hope the category is right. It's the only one that seemed close. The code for py-point in python-mode.el should pass 'either to py-beginning-of-def-or-class and py-end-of-def-or-class. The attached patch does this. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=830341&group_id=5470 From noreply at sourceforge.net Sun Oct 26 02:45:39 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 26 02:45:47 2003 Subject: [Patches] [ python-Patches-819077 ] fix import problem(unittest.py) Message-ID: Patches item #819077, was opened at 2003-10-07 16:23 Message generated for change (Settings changed) made by quiver You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=819077&group_id=5470 Category: Library (Lib) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: George Yoshida (quiver) >Assigned to: Steve Purcell (purcell) Summary: fix import problem(unittest.py) Initial Comment: This patch includes 3 changes to unittest.py. * Don't import unittest.(important) unittest is imported in the original script. This can be the cause of trouble. * cast float (trivial) TextTestRunner.run() method has the line as follows: timeTaken = float(stopTime - startTime) However, time.time() returns the time by a floating point number by default. So you don't need to cast the value to a float. * fix typo (trivial) """Note that decimal places (from zero) is usually ...""" 'is' should be 'are'. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=819077&group_id=5470 From noreply at sourceforge.net Sun Oct 26 05:41:11 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 26 05:41:25 2003 Subject: [Patches] [ python-Patches-819077 ] fix import problem(unittest.py) Message-ID: Patches item #819077, was opened at 2003-10-07 09:23 Message generated for change (Comment added) made by purcell You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=819077&group_id=5470 Category: Library (Lib) Group: Python 2.3 >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: George Yoshida (quiver) Assigned to: Steve Purcell (purcell) Summary: fix import problem(unittest.py) Initial Comment: This patch includes 3 changes to unittest.py. * Don't import unittest.(important) unittest is imported in the original script. This can be the cause of trouble. * cast float (trivial) TextTestRunner.run() method has the line as follows: timeTaken = float(stopTime - startTime) However, time.time() returns the time by a floating point number by default. So you don't need to cast the value to a float. * fix typo (trivial) """Note that decimal places (from zero) is usually ...""" 'is' should be 'are'. ---------------------------------------------------------------------- >Comment By: Steve Purcell (purcell) Date: 2003-10-26 11:41 Message: Logged In: YES user_id=21477 Thanks George! At some point in the distant past I believe it was necessary to import 'unittest', otherwise the 'TestCase' that a module saw was not the same as the 'TestCase' seen within 'unittest', and the user's TestCase subclasses were not recognised as subclasses of the TestCase seen within unittest. I see no evidence that this is the case now, so I'm incorporating this and your other 2 changes. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=819077&group_id=5470 From noreply at sourceforge.net Sun Oct 26 11:47:48 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 26 11:48:06 2003 Subject: [Patches] [ python-Patches-810754 ] socket.ssl should check certificates Message-ID: Patches item #810754, was opened at 2003-09-22 20:30 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=810754&group_id=5470 Category: Modules Group: Python 2.2.x >Status: Closed >Resolution: Rejected Priority: 5 Submitted By: Damjan Georgievski (gdamjan) Assigned to: Martin v. L?wis (loewis) Summary: socket.ssl should check certificates Initial Comment: I've decided to post here the patch proposed by Ed Phillips, since I think it's simple addition to the socket.ssl that will drastically increase its usefullness... The point of the patch is for a socket.ssl object to check the certificate received by the peer. http://mail.python.org/pipermail/python-list/2003-July/174933.html ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-26 17:47 Message: Logged In: YES user_id=21627 I think you are mis-interpreting the purpose of the key_file and cert_file arguments. They do *not* indicate the certificate of the trusted CAs, but provide the key and certificate of the *client*. By re-interpreting the cert_file as the file of the trusted CAs, you break client-side authentication. Therefore, i reject this patch. That said, I do agree that checking server-side certificates is a useful think, so I encourage you to provide a new patch which does that, e.g. by adding a certificate_chain_file argument (or some such). ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=810754&group_id=5470 From noreply at sourceforge.net Sun Oct 26 11:51:00 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 26 11:51:08 2003 Subject: [Patches] [ python-Patches-803998 ] [_ssl.c] SSL_write() called with -1 as size Message-ID: Patches item #803998, was opened at 2003-09-10 22:51 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=803998&group_id=5470 Category: Modules Group: None Status: Open Resolution: None Priority: 5 Submitted By: Ilario Nardinocchi (illo) Assigned to: Martin v. L?wis (loewis) Summary: [_ssl.c] SSL_write() called with -1 as size Initial Comment: In the inner do/while loop of PySSL_SSLwrite(), whenever a SSL_write() needs to be called again after a SSL_ERROR_WANT_{READ,WRITE} error, its "len" parameter is set to -1, leading to a segfault. I can't believe nobody ever noticed that :) ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-26 17:51 Message: Logged In: YES user_id=21627 Why are you passing the address of count, and not the value of count, to SSL_write? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=803998&group_id=5470 From noreply at sourceforge.net Sun Oct 26 11:59:50 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 26 11:59:54 2003 Subject: [Patches] [ python-Patches-723364 ] terminal type option subnegotiation in telnetlib Message-ID: Patches item #723364, was opened at 2003-04-17 23:13 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=723364&group_id=5470 Category: Library (Lib) Group: Python 2.2.x >Status: Closed >Resolution: Out of Date Priority: 5 Submitted By: Jon Willeke (willeke) Assigned to: Martin v. L?wis (loewis) Summary: terminal type option subnegotiation in telnetlib Initial Comment: The attached patch makes it possible for an option negotiation callback to subnegotiate the terminal type option (per RFC 1091). The patch does the following: * defines the SB and SE commands (per RFC 854) * defines QUAL_IS and QUAL_SEND (adapted from ) * passes SB ... SE to callback in process_rawq() A simple callback would specify the terminal type as follows: * respond to IAC DO TTYPE with IAC WILL TTYPE * respond to IAC SB TTYPE QUAL_SEND IAC SE with IAC SB TTYPE QUAL_IS 'vt100' IAC SE ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-26 17:59 Message: Logged In: YES user_id=21627 It appears to me that this patch is already superceded by patch #630829, which is released with Python 2.3. If you disagree, please update the patch to the current code base, and identify aspects not yet implemented. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=723364&group_id=5470 From noreply at sourceforge.net Sun Oct 26 12:17:18 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 26 12:17:28 2003 Subject: [Patches] [ python-Patches-803998 ] [_ssl.c] SSL_write() called with -1 as size Message-ID: Patches item #803998, was opened at 2003-09-10 22:51 Message generated for change (Comment added) made by illo You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=803998&group_id=5470 Category: Modules Group: None Status: Open Resolution: None Priority: 5 Submitted By: Ilario Nardinocchi (illo) Assigned to: Martin v. L?wis (loewis) Summary: [_ssl.c] SSL_write() called with -1 as size Initial Comment: In the inner do/while loop of PySSL_SSLwrite(), whenever a SSL_write() needs to be called again after a SSL_ERROR_WANT_{READ,WRITE} error, its "len" parameter is set to -1, leading to a segfault. I can't believe nobody ever noticed that :) ---------------------------------------------------------------------- >Comment By: Ilario Nardinocchi (illo) Date: 2003-10-26 18:17 Message: Logged In: YES user_id=626684 since there is no '&count' in the _ssl.c code I'm using, I assume it's a typo I fixed just after uploading the patch, but I cannot recall it, it happened a long ago. Sorry. I don't upload the patch because from what I'm seeing it's just a matter of deleting the '&'. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-26 17:51 Message: Logged In: YES user_id=21627 Why are you passing the address of count, and not the value of count, to SSL_write? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=803998&group_id=5470 From noreply at sourceforge.net Sun Oct 26 13:19:15 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 26 13:19:23 2003 Subject: [Patches] [ python-Patches-825639 ] let's get rid of cyclic object comparison Message-ID: Patches item #825639, was opened at 2003-10-17 17:49 Message generated for change (Comment added) made by arigo You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825639&group_id=5470 Category: Core (C code) Group: Python 2.4 Status: Open Resolution: None Priority: 5 Submitted By: Armin Rigo (arigo) Assigned to: Nobody/Anonymous (nobody) Summary: let's get rid of cyclic object comparison Initial Comment: Comparison of objects with recursive references is a cool feature but it leaves too many questions open and feels too much like a "do-what-i-mean" hack. Attached patch casts it into the obscure world of CVS history. On the positive side, the patch contributes a Py_EnterRecursiveCall()/Py_LeaveRecursiveCall() pair of functions to the C API, to use at any point where an infinite C-level recursion could occur. This is now used by: eval_frame() PyObject_Compare() PyObject_RichCompare() instance_call() and maybe it should be extended to cPickle.c, which has its own notion of maximum nesting as well. The diff also changes the tests to expect a RuntimeError when comparing nested structures. ---------------------------------------------------------------------- >Comment By: Armin Rigo (arigo) Date: 2003-10-26 18:19 Message: Logged In: YES user_id=4771 Another version of the patch. This one is quite faster -- I'm measuring the performance of: a = [5] * 1000 b = [a] * 1000 b == b for which test is appears now to have no measurable penalty. The drawback of this patch is a few extra obscure macros in ceval.h. Read the new comment in ceval.c for the idea. ---------------------------------------------------------------------- Comment By: Armin Rigo (arigo) Date: 2003-10-23 11:13 Message: Logged In: YES user_id=4771 Ok. Before I reply to python-dev let me point out that I tried not to weaken any test. I guess you thought I just removed some tests, because I indeed usually replaced a group of self.assertXxx() lines with a smaller number of assertions, but as far as I can tell they all test the structure as much as the original assertions, and sometimes even more. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-19 18:41 Message: Logged In: YES user_id=21627 I think the patch needs to be discussed on python-dev to get a chance to be accepted. It should also be accompanied with a more elaborate rationale, and a guideline on how applications that rely on the feature could detect the change, and how those applications need to be updated. For example, I find the change to the pickle tester unacceptable: you can't just drop the structural-equivalence test, since it is the primary purpose of this test to establish structural equivalence. So perhaps you should put a custom structural-equivalence algorithm into pickletester, and replace the assertEquals with that. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825639&group_id=5470 From noreply at sourceforge.net Mon Oct 27 04:22:15 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 27 04:22:23 2003 Subject: [Patches] [ python-Patches-830858 ] update docs for inspect module Message-ID: Patches item #830858, was opened at 2003-10-27 18:22 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=830858&group_id=5470 Category: Documentation Group: Python 2.2.x Status: Open Resolution: None Priority: 5 Submitted By: George Yoshida (quiver) Assigned to: Nobody/Anonymous (nobody) Summary: update docs for inspect module Initial Comment: The docs of inspect module says that, "The nine functions whose names begin with ``is''" but there are more functions like that. www.python.org/doc/2.3.2/lib/inspect-types.html After inspect module was introduced in 2.1, ismethoddescriptor was added in 2.2 and isdatadescriptor was added in 2.3. So for Python 2.2 the number is 10, and for Python 2.3 the number is 11. >>> import sys, inspect >>> print sys.version 2.3.2 (#1, Oct 9 2003, 12:03:29) [GCC 3.3.1 (cygming special)] >>> filter(lambda x:x.startswith('is'), dir(inspect)) ['isbuiltin', 'isclass', 'iscode', 'isdatadescriptor', 'isfra me', 'isfunction', 'ismethod', 'ismethoddescriptor', 'is module', 'isroutine', 'istraceback'] >>> len(_) 11 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=830858&group_id=5470 From noreply at sourceforge.net Mon Oct 27 09:09:09 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 27 09:09:34 2003 Subject: [Patches] [ python-Patches-817854 ] sprout more file operations in SSLFile, fixes 792101 Message-ID: Patches item #817854, was opened at 2003-10-04 22:28 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=817854&group_id=5470 Category: Library (Lib) Group: Python 2.3 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Andrew Gaul (gaul) Assigned to: Nobody/Anonymous (nobody) Summary: sprout more file operations in SSLFile, fixes 792101 Initial Comment: Fixes bug #792101. Add readlines, fileno, and support iterator protocol so that SSLFile implements all the file operations that urllib.urlopen describes. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-27 15:09 Message: Logged In: YES user_id=21627 Thanks for the patch. Committed as httplib.py 1.79.8.1 and 1.80, NEWS 1.831.4.68. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=817854&group_id=5470 From noreply at sourceforge.net Mon Oct 27 09:25:30 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 27 09:25:59 2003 Subject: [Patches] [ python-Patches-803998 ] [_ssl.c] SSL_write() called with -1 as size Message-ID: Patches item #803998, was opened at 2003-09-10 22:51 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=803998&group_id=5470 Category: Modules Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Ilario Nardinocchi (illo) Assigned to: Martin v. L?wis (loewis) Summary: [_ssl.c] SSL_write() called with -1 as size Initial Comment: In the inner do/while loop of PySSL_SSLwrite(), whenever a SSL_write() needs to be called again after a SSL_ERROR_WANT_{READ,WRITE} error, its "len" parameter is set to -1, leading to a segfault. I can't believe nobody ever noticed that :) ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-27 15:25 Message: Logged In: YES user_id=21627 Thanks for the patch. Committed (with that change) as _ssl.c 1.13.6.2 and 1.15; NEWS 1.831.4.69. ---------------------------------------------------------------------- Comment By: Ilario Nardinocchi (illo) Date: 2003-10-26 18:17 Message: Logged In: YES user_id=626684 since there is no '&count' in the _ssl.c code I'm using, I assume it's a typo I fixed just after uploading the patch, but I cannot recall it, it happened a long ago. Sorry. I don't upload the patch because from what I'm seeing it's just a matter of deleting the '&'. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-26 17:51 Message: Logged In: YES user_id=21627 Why are you passing the address of count, and not the value of count, to SSL_write? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=803998&group_id=5470 From noreply at sourceforge.net Mon Oct 27 19:37:01 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 27 19:37:11 2003 Subject: [Patches] [ python-Patches-628301 ] Experimental Inno Setup Win32 installer Message-ID: Patches item #628301, was opened at 2002-10-25 00:59 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=628301&group_id=5470 Category: Windows Group: None Status: Open Resolution: None Priority: 5 Submitted By: Bruce Dodson (bdodson_esrican) >Assigned to: Thomas Heller (theller) Summary: Experimental Inno Setup Win32 installer Initial Comment: I found the Inno Setup script for Python in the Python 2.2.1 source tree, and decided to hack on it a bit. Since I didn't want to deploy a custom build of Python (wanted to use the original), one of my changes is something you won't want: instead of looking in PCBuild etc. for the files, it expects the files to be laid out the way the WISE installer does it. However it should be easy to change this back so it works against the Python VC source / build tree. Be that as it may, this version has a few changes that you may or may not want: 1) incorporates Mark Hammond's win32 libraries (but not Pythonwin) 2) deletes PYC and PYO files on uninstall, so that the install directory can be properly removed. 3) uses Inno Setup Extensions (http://www.wintax.nl/isx) to enable scripted behavior, e.g. behave differently based on whether an administrator is running the install. 4) uses wildcards to make the script shorter. I do like the original author's idea of using a Python script to generate the ISS script; that would allow the files to be listed explicitly rather than relying on wildcards as I did here. The addition of Mark's stuff is something that interests me, since I can't redistribute ActivePython and find it cumbersome to include 2 installers plus my own; however it is not necessarily something that you are going to care about. The other changes may be more interesting to you. This script is based on the one found in Python 2.2.1 source tree, but I have compiled and tested it against Python 2.2.2. To test, run the Python WISE installer and Mark's win32all installer. Then copy python22.dll etc. from system32 to Python22\sysdir. Copy the ISS file into the Python22 directory. Running the ISX compiler against python.iss. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-28 01:37 Message: Logged In: YES user_id=21627 I'm tempted to reject this on the grounds that Inno setup is likely not being used in the future to build Python distributions; it's more likely to be WISE until that gets replaced with MSI. That said, it might be useful to merely distribute the files with Python; if you think it is, please indicate so. Consider that there might be nothing wrong with maintaining your own installer, as a separate project. I assign this to Thomas Heller, who is the current manager of the Windows packaging; Thomas, feel free to either reject or accept this - I see little point in keeping it open. ---------------------------------------------------------------------- Comment By: Bruce Dodson (bdodson_esrican) Date: 2003-08-01 02:26 Message: Logged In: YES user_id=533196 I've enhanced this further, to include the vcredist stuff, and to account for the directory tree changes in Python 2.3 (IDLE moved, etc). If you're interested in checking it out, I've compiled an experimental installer and published it at http://sourceforge.net/projects/avpython/, in the pythonsetup package. The updated source script is there as well. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=628301&group_id=5470 From noreply at sourceforge.net Mon Oct 27 23:40:49 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 27 23:40:57 2003 Subject: [Patches] [ python-Patches-628301 ] Experimental Inno Setup Win32 installer Message-ID: Patches item #628301, was opened at 2002-10-24 19:59 Message generated for change (Comment added) made by bdodson_esrican You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=628301&group_id=5470 Category: Windows Group: None Status: Open Resolution: None Priority: 5 Submitted By: Bruce Dodson (bdodson_esrican) Assigned to: Thomas Heller (theller) Summary: Experimental Inno Setup Win32 installer Initial Comment: I found the Inno Setup script for Python in the Python 2.2.1 source tree, and decided to hack on it a bit. Since I didn't want to deploy a custom build of Python (wanted to use the original), one of my changes is something you won't want: instead of looking in PCBuild etc. for the files, it expects the files to be laid out the way the WISE installer does it. However it should be easy to change this back so it works against the Python VC source / build tree. Be that as it may, this version has a few changes that you may or may not want: 1) incorporates Mark Hammond's win32 libraries (but not Pythonwin) 2) deletes PYC and PYO files on uninstall, so that the install directory can be properly removed. 3) uses Inno Setup Extensions (http://www.wintax.nl/isx) to enable scripted behavior, e.g. behave differently based on whether an administrator is running the install. 4) uses wildcards to make the script shorter. I do like the original author's idea of using a Python script to generate the ISS script; that would allow the files to be listed explicitly rather than relying on wildcards as I did here. The addition of Mark's stuff is something that interests me, since I can't redistribute ActivePython and find it cumbersome to include 2 installers plus my own; however it is not necessarily something that you are going to care about. The other changes may be more interesting to you. This script is based on the one found in Python 2.2.1 source tree, but I have compiled and tested it against Python 2.2.2. To test, run the Python WISE installer and Mark's win32all installer. Then copy python22.dll etc. from system32 to Python22\sysdir. Copy the ISS file into the Python22 directory. Running the ISX compiler against python.iss. ---------------------------------------------------------------------- >Comment By: Bruce Dodson (bdodson_esrican) Date: 2003-10-28 00:40 Message: Logged In: YES user_id=533196 Thank you for the response. I don't expect Inno to replace the WISE installer as the official Python distribution for Windows; I hope I did not give that impression. To clarify: what I've done is merely an enhanced / updated version of the Inno Setup sample that appears in the Python source tree on CVS (dist/PCBuild/python.iss). ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-27 20:37 Message: Logged In: YES user_id=21627 I'm tempted to reject this on the grounds that Inno setup is likely not being used in the future to build Python distributions; it's more likely to be WISE until that gets replaced with MSI. That said, it might be useful to merely distribute the files with Python; if you think it is, please indicate so. Consider that there might be nothing wrong with maintaining your own installer, as a separate project. I assign this to Thomas Heller, who is the current manager of the Windows packaging; Thomas, feel free to either reject or accept this - I see little point in keeping it open. ---------------------------------------------------------------------- Comment By: Bruce Dodson (bdodson_esrican) Date: 2003-07-31 21:26 Message: Logged In: YES user_id=533196 I've enhanced this further, to include the vcredist stuff, and to account for the directory tree changes in Python 2.3 (IDLE moved, etc). If you're interested in checking it out, I've compiled an experimental installer and published it at http://sourceforge.net/projects/avpython/, in the pythonsetup package. The updated source script is there as well. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=628301&group_id=5470 From noreply at sourceforge.net Tue Oct 28 02:34:02 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Tue Oct 28 02:34:11 2003 Subject: [Patches] [ python-Patches-830070 ] itertoolsmodule.c: islice error messages (827190) Message-ID: Patches item #830070, was opened at 2003-10-25 05:31 Message generated for change (Comment added) made by rhettinger You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=830070&group_id=5470 Category: None Group: None >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: Johan M. Hahn (johahn) Assigned to: Nobody/Anonymous (nobody) Summary: itertoolsmodule.c: islice error messages (827190) Initial Comment: >>> import itertools >>> itertools.islice('abc', 0) >>> itertools.islice('abc', -2) Traceback (most recent call last): File "", line 1, in -toplevel- itertools.islice([1,2,3], -2) ValueError: Indices for islice() must be positive. Error message is changed to "Indices for islice() must be non-negative." since 0 is allowed. >>> itertools.islice('abc', -1) Traceback (most recent call last): File "", line 1, in -toplevel- itertools.islice([1,2,3], -1) ValueError: Stop argument must be an integer or None. Clearly -1 is an integer. This was due to some optimization in itertoolsmodule.c. If PyInt_AsLong returned -1 it was taken as a conversion error. I added an additional else statement to distinguish the two cases that change the variable to -2 if it was in fact -1 to begin with. A little 'hacky' but it seems like the best soloution and it doesn't undo the optimization. ...johahn ---------------------------------------------------------------------- >Comment By: Raymond Hettinger (rhettinger) Date: 2003-10-28 02:34 Message: Logged In: YES user_id=80475 Fixed the error messages. See Modules/itertoolsmodule.c 1.25 ---------------------------------------------------------------------- Comment By: Johan M. Hahn (johahn) Date: 2003-10-25 05:40 Message: Logged In: YES user_id=887415 Let me add that the code has not been compiled. I just noticed two missing { in the first patch and uploaded a new version. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=830070&group_id=5470 From noreply at sourceforge.net Tue Oct 28 07:08:17 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Tue Oct 28 07:08:34 2003 Subject: [Patches] [ python-Patches-825639 ] let's get rid of cyclic object comparison Message-ID: Patches item #825639, was opened at 2003-10-17 17:49 Message generated for change (Comment added) made by arigo You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825639&group_id=5470 Category: Core (C code) Group: Python 2.4 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Armin Rigo (arigo) Assigned to: Nobody/Anonymous (nobody) Summary: let's get rid of cyclic object comparison Initial Comment: Comparison of objects with recursive references is a cool feature but it leaves too many questions open and feels too much like a "do-what-i-mean" hack. Attached patch casts it into the obscure world of CVS history. On the positive side, the patch contributes a Py_EnterRecursiveCall()/Py_LeaveRecursiveCall() pair of functions to the C API, to use at any point where an infinite C-level recursion could occur. This is now used by: eval_frame() PyObject_Compare() PyObject_RichCompare() instance_call() and maybe it should be extended to cPickle.c, which has its own notion of maximum nesting as well. The diff also changes the tests to expect a RuntimeError when comparing nested structures. ---------------------------------------------------------------------- >Comment By: Armin Rigo (arigo) Date: 2003-10-28 12:08 Message: Logged In: YES user_id=4771 For full details: http://mail.python.org/pipermail/python-dev/2003-October/039445.html Checked in: Misc/NEWS (rev: 1.879) Include/ceval.h (rev: 2.50) Python/ceval.c (rev: 2.371) Objects/classobject.c (rev: 2.173) Objects/object.c (rev: 2.211) Lib/test/pickletester.py (rev: 1.56) Lib/test/test_builtin.py (rev: 1.24) Lib/test/test_copy.py (rev: 1.12) Lib/test/test_richcmp.py (rev: 1.10) ---------------------------------------------------------------------- Comment By: Armin Rigo (arigo) Date: 2003-10-26 18:19 Message: Logged In: YES user_id=4771 Another version of the patch. This one is quite faster -- I'm measuring the performance of: a = [5] * 1000 b = [a] * 1000 b == b for which test is appears now to have no measurable penalty. The drawback of this patch is a few extra obscure macros in ceval.h. Read the new comment in ceval.c for the idea. ---------------------------------------------------------------------- Comment By: Armin Rigo (arigo) Date: 2003-10-23 11:13 Message: Logged In: YES user_id=4771 Ok. Before I reply to python-dev let me point out that I tried not to weaken any test. I guess you thought I just removed some tests, because I indeed usually replaced a group of self.assertXxx() lines with a smaller number of assertions, but as far as I can tell they all test the structure as much as the original assertions, and sometimes even more. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-19 18:41 Message: Logged In: YES user_id=21627 I think the patch needs to be discussed on python-dev to get a chance to be accepted. It should also be accompanied with a more elaborate rationale, and a guideline on how applications that rely on the feature could detect the change, and how those applications need to be updated. For example, I find the change to the pickle tester unacceptable: you can't just drop the structural-equivalence test, since it is the primary purpose of this test to establish structural equivalence. So perhaps you should put a custom structural-equivalence algorithm into pickletester, and replace the assertEquals with that. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825639&group_id=5470 From noreply at sourceforge.net Tue Oct 28 15:28:36 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Tue Oct 28 15:28:45 2003 Subject: [Patches] [ python-Patches-628301 ] Experimental Inno Setup Win32 installer Message-ID: Patches item #628301, was opened at 2002-10-25 00:59 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=628301&group_id=5470 Category: Windows Group: None Status: Open Resolution: None Priority: 5 Submitted By: Bruce Dodson (bdodson_esrican) >Assigned to: Martin v. L?wis (loewis) Summary: Experimental Inno Setup Win32 installer Initial Comment: I found the Inno Setup script for Python in the Python 2.2.1 source tree, and decided to hack on it a bit. Since I didn't want to deploy a custom build of Python (wanted to use the original), one of my changes is something you won't want: instead of looking in PCBuild etc. for the files, it expects the files to be laid out the way the WISE installer does it. However it should be easy to change this back so it works against the Python VC source / build tree. Be that as it may, this version has a few changes that you may or may not want: 1) incorporates Mark Hammond's win32 libraries (but not Pythonwin) 2) deletes PYC and PYO files on uninstall, so that the install directory can be properly removed. 3) uses Inno Setup Extensions (http://www.wintax.nl/isx) to enable scripted behavior, e.g. behave differently based on whether an administrator is running the install. 4) uses wildcards to make the script shorter. I do like the original author's idea of using a Python script to generate the ISS script; that would allow the files to be listed explicitly rather than relying on wildcards as I did here. The addition of Mark's stuff is something that interests me, since I can't redistribute ActivePython and find it cumbersome to include 2 installers plus my own; however it is not necessarily something that you are going to care about. The other changes may be more interesting to you. This script is based on the one found in Python 2.2.1 source tree, but I have compiled and tested it against Python 2.2.2. To test, run the Python WISE installer and Mark's win32all installer. Then copy python22.dll etc. from system32 to Python22\sysdir. Copy the ISS file into the Python22 directory. Running the ISX compiler against python.iss. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-28 21:28 Message: Logged In: YES user_id=21627 Thanks for the clarification; unfortunately, I still don't understand: All you suggest is that your file replaces the one in CVS? That sounds fine to me. ---------------------------------------------------------------------- Comment By: Bruce Dodson (bdodson_esrican) Date: 2003-10-28 05:40 Message: Logged In: YES user_id=533196 Thank you for the response. I don't expect Inno to replace the WISE installer as the official Python distribution for Windows; I hope I did not give that impression. To clarify: what I've done is merely an enhanced / updated version of the Inno Setup sample that appears in the Python source tree on CVS (dist/PCBuild/python.iss). ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-28 01:37 Message: Logged In: YES user_id=21627 I'm tempted to reject this on the grounds that Inno setup is likely not being used in the future to build Python distributions; it's more likely to be WISE until that gets replaced with MSI. That said, it might be useful to merely distribute the files with Python; if you think it is, please indicate so. Consider that there might be nothing wrong with maintaining your own installer, as a separate project. I assign this to Thomas Heller, who is the current manager of the Windows packaging; Thomas, feel free to either reject or accept this - I see little point in keeping it open. ---------------------------------------------------------------------- Comment By: Bruce Dodson (bdodson_esrican) Date: 2003-08-01 02:26 Message: Logged In: YES user_id=533196 I've enhanced this further, to include the vcredist stuff, and to account for the directory tree changes in Python 2.3 (IDLE moved, etc). If you're interested in checking it out, I've compiled an experimental installer and published it at http://sourceforge.net/projects/avpython/, in the pythonsetup package. The updated source script is there as well. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=628301&group_id=5470 From noreply at sourceforge.net Tue Oct 28 16:58:52 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Tue Oct 28 16:58:55 2003 Subject: [Patches] [ python-Patches-775057 ] fix problem in about dialog Message-ID: Patches item #775057, was opened at 2003-07-21 11:01 Message generated for change (Comment added) made by nnorwitz You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=775057&group_id=5470 Category: IDLE Group: Python 2.4 >Status: Closed Resolution: Accepted Priority: 5 Submitted By: Neal Norwitz (nnorwitz) Assigned to: Neal Norwitz (nnorwitz) Summary: fix problem in about dialog Initial Comment: The attached patch should be self explanatory. Need to import tkMessageBox and use the correct variable name (fn, not filename). ---------------------------------------------------------------------- >Comment By: Neal Norwitz (nnorwitz) Date: 2003-10-28 16:58 Message: Logged In: YES user_id=33168 Checked in as: * Lib/idlelib/aboutDialog.py 1.14 and 1.13.8.1 ---------------------------------------------------------------------- Comment By: Kurt B. Kaiser (kbk) Date: 2003-07-22 13:46 Message: Logged In: YES user_id=149084 Looks fine, please once the CVS opens again please check in and backport to 2.3.1. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=775057&group_id=5470 From noreply at sourceforge.net Tue Oct 28 18:53:30 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Tue Oct 28 18:53:38 2003 Subject: [Patches] [ python-Patches-832058 ] deprecate buffer object Message-ID: Patches item #832058, was opened at 2003-10-28 23:53 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=832058&group_id=5470 Category: Core (C code) Group: None Status: Open Resolution: None Priority: 5 Submitted By: Neil Schemenauer (nascheme) Assigned to: Nobody/Anonymous (nobody) Summary: deprecate buffer object Initial Comment: This has not been well tested but I don't have time right now. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=832058&group_id=5470 From noreply at sourceforge.net Tue Oct 28 19:40:46 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Tue Oct 28 19:41:20 2003 Subject: [Patches] [ python-Patches-825814 ] Add list.sorted() Message-ID: Patches item #825814, was opened at 2003-10-17 19:34 Message generated for change (Comment added) made by rhettinger You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825814&group_id=5470 Category: Core (C code) Group: Python 2.4 Status: Open Resolution: None Priority: 5 Submitted By: Raymond Hettinger (rhettinger) >Assigned to: Alex Martelli (aleax) >Summary: Add list.sorted() Initial Comment: As discussed on py-dev, this returns a sorted copy of a list while leaving the original intact. ---------------------------------------------------------------------- >Comment By: Raymond Hettinger (rhettinger) Date: 2003-10-28 19:40 Message: Logged In: YES user_id=80475 Alex, can you give this patch a second review. I did not put in additional classmethod warnings because all plausible misunderstandings raise an error anyway. ---------------------------------------------------------------------- Comment By: Raymond Hettinger (rhettinger) Date: 2003-10-18 12:41 Message: Logged In: YES user_id=80475 Rationale for the change --------------------- An inline sort is usable anywhere an expression is allowed. This includes important places like function call arguments and list comprehensions: todo = [t for t in tasks.copysort() if due_today(t)] genhistory(date, events.copysort(key=incidenttime)) Spreading these out over multiple lines is an unnecessary distractor from the problem domain, making the code harder to understand and maintain. Also, using copysort() eliminates a unnecessary variable that changes state from unsorted to sorted and has a lifetime longer than the data is actually needed. In longer code fragments, this decreases code complexity, code length, the number of variables, and decreases the risk of using a variable in the wrong state which is a common source of programming errors. ---------------------------------------------------------------------- Comment By: Raymond Hettinger (rhettinger) Date: 2003-10-18 01:26 Message: Logged In: YES user_id=80475 Revised the patch to avoid an unnecessary copy whenever the underlying object is not referenced anywhere else -- this occurs in the common use case: for elem in d.keys().copysort(): . . . ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825814&group_id=5470 From noreply at sourceforge.net Tue Oct 28 21:29:43 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Tue Oct 28 21:29:49 2003 Subject: [Patches] [ python-Patches-628301 ] Experimental Inno Setup Win32 installer Message-ID: Patches item #628301, was opened at 2002-10-24 19:59 Message generated for change (Comment added) made by bdodson_esrican You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=628301&group_id=5470 Category: Windows Group: None Status: Open Resolution: None Priority: 5 Submitted By: Bruce Dodson (bdodson_esrican) Assigned to: Martin v. L?wis (loewis) Summary: Experimental Inno Setup Win32 installer Initial Comment: I found the Inno Setup script for Python in the Python 2.2.1 source tree, and decided to hack on it a bit. Since I didn't want to deploy a custom build of Python (wanted to use the original), one of my changes is something you won't want: instead of looking in PCBuild etc. for the files, it expects the files to be laid out the way the WISE installer does it. However it should be easy to change this back so it works against the Python VC source / build tree. Be that as it may, this version has a few changes that you may or may not want: 1) incorporates Mark Hammond's win32 libraries (but not Pythonwin) 2) deletes PYC and PYO files on uninstall, so that the install directory can be properly removed. 3) uses Inno Setup Extensions (http://www.wintax.nl/isx) to enable scripted behavior, e.g. behave differently based on whether an administrator is running the install. 4) uses wildcards to make the script shorter. I do like the original author's idea of using a Python script to generate the ISS script; that would allow the files to be listed explicitly rather than relying on wildcards as I did here. The addition of Mark's stuff is something that interests me, since I can't redistribute ActivePython and find it cumbersome to include 2 installers plus my own; however it is not necessarily something that you are going to care about. The other changes may be more interesting to you. This script is based on the one found in Python 2.2.1 source tree, but I have compiled and tested it against Python 2.2.2. To test, run the Python WISE installer and Mark's win32all installer. Then copy python22.dll etc. from system32 to Python22\sysdir. Copy the ISS file into the Python22 directory. Running the ISX compiler against python.iss. ---------------------------------------------------------------------- >Comment By: Bruce Dodson (bdodson_esrican) Date: 2003-10-28 22:29 Message: Logged In: YES user_id=533196 Exactly. Some people might find the script useful in the real world (including me!), but the same would be true of any good sample. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-28 16:28 Message: Logged In: YES user_id=21627 Thanks for the clarification; unfortunately, I still don't understand: All you suggest is that your file replaces the one in CVS? That sounds fine to me. ---------------------------------------------------------------------- Comment By: Bruce Dodson (bdodson_esrican) Date: 2003-10-28 00:40 Message: Logged In: YES user_id=533196 Thank you for the response. I don't expect Inno to replace the WISE installer as the official Python distribution for Windows; I hope I did not give that impression. To clarify: what I've done is merely an enhanced / updated version of the Inno Setup sample that appears in the Python source tree on CVS (dist/PCBuild/python.iss). ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-27 20:37 Message: Logged In: YES user_id=21627 I'm tempted to reject this on the grounds that Inno setup is likely not being used in the future to build Python distributions; it's more likely to be WISE until that gets replaced with MSI. That said, it might be useful to merely distribute the files with Python; if you think it is, please indicate so. Consider that there might be nothing wrong with maintaining your own installer, as a separate project. I assign this to Thomas Heller, who is the current manager of the Windows packaging; Thomas, feel free to either reject or accept this - I see little point in keeping it open. ---------------------------------------------------------------------- Comment By: Bruce Dodson (bdodson_esrican) Date: 2003-07-31 21:26 Message: Logged In: YES user_id=533196 I've enhanced this further, to include the vcredist stuff, and to account for the directory tree changes in Python 2.3 (IDLE moved, etc). If you're interested in checking it out, I've compiled an experimental installer and published it at http://sourceforge.net/projects/avpython/, in the pythonsetup package. The updated source script is there as well. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=628301&group_id=5470 From noreply at sourceforge.net Wed Oct 29 01:56:10 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 29 01:56:14 2003 Subject: [Patches] [ python-Patches-825814 ] Add list.sorted() Message-ID: Patches item #825814, was opened at 2003-10-17 19:34 Message generated for change (Comment added) made by rhettinger You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825814&group_id=5470 Category: Core (C code) Group: Python 2.4 >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: Raymond Hettinger (rhettinger) >Assigned to: Nobody/Anonymous (nobody) Summary: Add list.sorted() Initial Comment: As discussed on py-dev, this returns a sorted copy of a list while leaving the original intact. ---------------------------------------------------------------------- >Comment By: Raymond Hettinger (rhettinger) Date: 2003-10-29 01:56 Message: Logged In: YES user_id=80475 Applied. ---------------------------------------------------------------------- Comment By: Raymond Hettinger (rhettinger) Date: 2003-10-28 19:40 Message: Logged In: YES user_id=80475 Alex, can you give this patch a second review. I did not put in additional classmethod warnings because all plausible misunderstandings raise an error anyway. ---------------------------------------------------------------------- Comment By: Raymond Hettinger (rhettinger) Date: 2003-10-18 12:41 Message: Logged In: YES user_id=80475 Rationale for the change --------------------- An inline sort is usable anywhere an expression is allowed. This includes important places like function call arguments and list comprehensions: todo = [t for t in tasks.copysort() if due_today(t)] genhistory(date, events.copysort(key=incidenttime)) Spreading these out over multiple lines is an unnecessary distractor from the problem domain, making the code harder to understand and maintain. Also, using copysort() eliminates a unnecessary variable that changes state from unsorted to sorted and has a lifetime longer than the data is actually needed. In longer code fragments, this decreases code complexity, code length, the number of variables, and decreases the risk of using a variable in the wrong state which is a common source of programming errors. ---------------------------------------------------------------------- Comment By: Raymond Hettinger (rhettinger) Date: 2003-10-18 01:26 Message: Logged In: YES user_id=80475 Revised the patch to avoid an unnecessary copy whenever the underlying object is not referenced anywhere else -- this occurs in the common use case: for elem in d.keys().copysort(): . . . ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825814&group_id=5470 From noreply at sourceforge.net Wed Oct 29 04:46:06 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 29 04:46:20 2003 Subject: [Patches] [ python-Patches-825814 ] Add list.sorted() Message-ID: Patches item #825814, was opened at 2003-10-18 02:34 Message generated for change (Comment added) made by aleax You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825814&group_id=5470 Category: Core (C code) Group: Python 2.4 Status: Closed Resolution: Fixed Priority: 5 Submitted By: Raymond Hettinger (rhettinger) Assigned to: Nobody/Anonymous (nobody) Summary: Add list.sorted() Initial Comment: As discussed on py-dev, this returns a sorted copy of a list while leaving the original intact. ---------------------------------------------------------------------- >Comment By: Alex Martelli (aleax) Date: 2003-10-29 10:46 Message: Logged In: YES user_id=60314 Looks good to me! I understand not wanting -- given the clean and spare code for list.sorted -- to go to the considerable trouble needed to give more specific error messages; however, if we release like this we WILL get questions about it on c.l.py and help@python.org -- "why doesn't ''for x in mydict.keys().sorted():'' work?!" etc. Do you mind if eventually I _do_ try to ensure the error messages specifically mention list.sorted being a classmethod and requiring one iterable argument? ---------------------------------------------------------------------- Comment By: Raymond Hettinger (rhettinger) Date: 2003-10-29 07:56 Message: Logged In: YES user_id=80475 Applied. ---------------------------------------------------------------------- Comment By: Raymond Hettinger (rhettinger) Date: 2003-10-29 01:40 Message: Logged In: YES user_id=80475 Alex, can you give this patch a second review. I did not put in additional classmethod warnings because all plausible misunderstandings raise an error anyway. ---------------------------------------------------------------------- Comment By: Raymond Hettinger (rhettinger) Date: 2003-10-18 19:41 Message: Logged In: YES user_id=80475 Rationale for the change --------------------- An inline sort is usable anywhere an expression is allowed. This includes important places like function call arguments and list comprehensions: todo = [t for t in tasks.copysort() if due_today(t)] genhistory(date, events.copysort(key=incidenttime)) Spreading these out over multiple lines is an unnecessary distractor from the problem domain, making the code harder to understand and maintain. Also, using copysort() eliminates a unnecessary variable that changes state from unsorted to sorted and has a lifetime longer than the data is actually needed. In longer code fragments, this decreases code complexity, code length, the number of variables, and decreases the risk of using a variable in the wrong state which is a common source of programming errors. ---------------------------------------------------------------------- Comment By: Raymond Hettinger (rhettinger) Date: 2003-10-18 08:26 Message: Logged In: YES user_id=80475 Revised the patch to avoid an unnecessary copy whenever the underlying object is not referenced anywhere else -- this occurs in the common use case: for elem in d.keys().copysort(): . . . ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=825814&group_id=5470 From noreply at sourceforge.net Fri Oct 31 05:02:38 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 31 05:02:43 2003 Subject: [Patches] [ python-Patches-788404 ] ignore "b" and "t" mode modifiers in posix_popen Message-ID: Patches item #788404, was opened at 2003-08-14 00:53 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=788404&group_id=5470 Category: Library (Lib) Group: Python 2.3 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Andrew Gaul (gaul) Assigned to: Martin v. L?wis (loewis) Summary: ignore "b" and "t" mode modifiers in posix_popen Initial Comment: Fixes bug 703198. This patch removes any "b" or "t" modifiers, which have meaning in Windows (binary and text modes, respectively), but not in POSIX. This allows users to write portable code between Windows and POSIX when working on binary data in pipes: os.popen(cmd, 'rb'). ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-31 11:02 Message: Logged In: YES user_id=21627 Thanks for the patch. Applied as NEWS 1.831.4.70 posixmodule.c 2.300.8.4 posixmodule.c 2.307 ---------------------------------------------------------------------- Comment By: Andrew Gaul (gaul) Date: 2003-09-01 14:13 Message: Logged In: YES user_id=139865 *puzzles over why patch is so backward* Yes, it modifies an immutable object - double plus ungood. Attached is a simpler patch which does the right thing. Sorry, I do not know what was going through my head at the time. My best guess was that I thought that mode was a safe, mutable copy of the immutable Python string and I wanted to allow modes like "br", which the MSDN docs actually say are invalid ('b' and 't' modifiers must be appended). Note that the behaviour of POSIX posix_popen in this patch differs from Windows posix_popen, as the latter allows treats "rw", "r+", and "rr" as "r". In all three cases, POSIX systems throw "OSError: [Errno 22] Invalid argument" at pipe creation. In the case of "rw", Windows systems throw "IOError: [Errno 9] Bad file descriptor" when the read-only pipe is first written to. Ideally, Windows posix_popen should be modified to the new POSIX behaviour to give earlier error reporting. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-08-31 18:42 Message: Logged In: YES user_id=21627 Maybe I'm mistaken: Does this patch really modify the string object that is being passed? This would not be good: strings are immutable. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=788404&group_id=5470 From noreply at sourceforge.net Fri Oct 31 07:53:10 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 31 07:53:14 2003 Subject: [Patches] [ python-Patches-791706 ] POP3 over SSL support for poplib Message-ID: Patches item #791706, was opened at 2003-08-20 07:53 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=791706&group_id=5470 Category: Library (Lib) Group: Python 2.3 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Hector urtubia (mrbook) Assigned to: Martin v. L?wis (loewis) Summary: POP3 over SSL support for poplib Initial Comment: This patch creates a class POP3_SSL which is a child of POP3 on the poplib module. This class is able to handle POP3 over SSL. It borrows some code from IMAP_SSL. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-31 13:53 Message: Logged In: YES user_id=21627 Thanks for the patch. Applied as libpoplib.tex 1.16 poplib.py 1.22 ACKS 1.252 NEWS 1.882 ---------------------------------------------------------------------- Comment By: Hector urtubia (mrbook) Date: 2003-09-11 03:11 Message: Logged In: YES user_id=10927 I have added a patch for the documentation (lipoplibdoc- 1_0.patch) and have addressed most of the requests from the reviewer on newer patch revision (poplibssl-1_0.patch). - Tabs and spaces issues fixed - Fixed port on comment - Data is now read on big chunks - Unable to reuse base-claass __init__ because of parent's design issues. Cheers. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-08-31 18:38 Message: Logged In: YES user_id=21627 Can you please provide a patch for the documentation as well? Please don't mix tabs and spaces; I recommend to run reindent.py before producing the diff. In the class comment, the default port is incorrect. Please don't build up strings by adding one character at a time, use [c]StringIO instead, or a list. Also consider reading larger chunks of data a time, buffering extra data in the class. Try to reuse the base-class __init__. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=791706&group_id=5470 From noreply at sourceforge.net Fri Oct 31 08:01:59 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 31 08:02:06 2003 Subject: [Patches] [ python-Patches-787189 ] termios module on IRIX Message-ID: Patches item #787189, was opened at 2003-08-12 08:45 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=787189&group_id=5470 Category: Modules Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Marc Poinot (poinot) Assigned to: Nobody/Anonymous (nobody) Summary: termios module on IRIX Initial Comment: The termios.c module includes sys/termios.h in which a CTRL macro is present, but not defined because of the pre-processing switches: #if (_NO_POSIX && _NO_XOPEN4) || _ABIAPI #define CTRL(c) ((c)&037) Then, the sys/ioctl.h is included (at least by termios.c module) and this uses CTRL() macro ! This looks like a problem on the IRIX side, they should be consistent with their own headers. The simplest way I found was to add into termios.c the definition of CTRL: #if defined(__sgi) #define CTRL(c) ((c)&037) #endif Has to be put *before* the #include in Modules/termios.c ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-31 14:01 Message: Logged In: YES user_id=21627 Committed as termios.c 2.37.8.1 and 2.38. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-19 00:09 Message: Logged In: YES user_id=21627 In what cases would _ABIAPI be defined? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=787189&group_id=5470 From noreply at sourceforge.net Fri Oct 31 08:05:44 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 31 08:05:50 2003 Subject: [Patches] [ python-Patches-785689 ] pydoc's usage should use basename Message-ID: Patches item #785689, was opened at 2003-08-09 01:44 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=785689&group_id=5470 Category: Library (Lib) Group: Python 2.3 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Matthias Klose (doko) Assigned to: Nobody/Anonymous (nobody) Summary: pydoc's usage should use basename Initial Comment: pydoc should output only the basename, not the full path. +++ Lib/pydoc.py 2003-08-09 01:40:58.000000000 +0200 @@ -2090,7 +2090,7 @@ print value except (getopt.error, BadUsage): - cmd = sys.argv[0] + cmd = os.path.basename(sys.argv[0]) print """pydoc - the Python documentation tool %s ... ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-31 14:05 Message: Logged In: YES user_id=21627 Thanks for the patch. Committed as pydoc.py 1.86.8.1 and 1.89 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=785689&group_id=5470 From noreply at sourceforge.net Fri Oct 31 08:08:16 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 31 08:08:27 2003 Subject: [Patches] [ python-Patches-784231 ] getopt_long_only() Message-ID: Patches item #784231, was opened at 2003-08-06 17:25 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=784231&group_id=5470 Category: Library (Lib) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Souza (s3a) Assigned to: Nobody/Anonymous (nobody) Summary: getopt_long_only() Initial Comment: A getopt_long_only() implementation for the `getopt' module. Note that it has one slight difference from the glibc version, related to the `-W' behavior, in that it _really_ treats `-W foo' _as_ `--foo'; therefore, when `foo' is not a valid long option, this is an error --- rather than returning the option ('-W', 'foo') as though `W:' instead of `W;' had been specified. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-31 14:08 Message: Logged In: YES user_id=21627 I see no harm in adding this function. However, the patch is incomplete: it lacks changes to Doc/lib/libgetopt.tex. s3a, can you please provide these changes? ---------------------------------------------------------------------- Comment By: Johannes Gijsbers (jlgijsbers) Date: 2003-08-28 20:17 Message: Logged In: YES user_id=469548 I'm not sure we want to support this: our new option-parsing library optparse rejects this behavior (see http://python.org/doc/current/lib/optparse-terminology.html), and our gnu_getopt wasn't intended to work exactly like gnu_getopt (see http://python.org/sf/473512). On the other hand, your patch seems to work well, although you should add tests and a documentation patch. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=784231&group_id=5470 From noreply at sourceforge.net Fri Oct 31 08:50:06 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 31 08:50:09 2003 Subject: [Patches] [ python-Patches-531629 ] Add multicall support to xmlrpclib Message-ID: Patches item #531629, was opened at 2002-03-19 00:00 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=531629&group_id=5470 Category: Library (Lib) Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Brian Quinlan (bquinlan) Assigned to: Martin v. L?wis (loewis) Summary: Add multicall support to xmlrpclib Initial Comment: Adds a new object to xmlrpclib that allows the user to boxcared XML-RPC requests e.g. server_proxy = ServerProxy(...) multicall = MultiCall(server_proxy) multicall.add(2,3) multicall.get_address("Guido") add_result, address = multicall() see http://www.xmlrpc.com/discuss/msgReader$1208 ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-31 14:50 Message: Logged In: YES user_id=21627 Thanks for the patch. Applied as libxmlrpclib.tex 1.15 xmlrpclib.py 1.31 NEWS 1.883 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=531629&group_id=5470 From noreply at sourceforge.net Fri Oct 31 08:51:59 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 31 08:52:05 2003 Subject: [Patches] [ python-Patches-608182 ] Enhanced file constructor Message-ID: Patches item #608182, was opened at 2002-09-12 05:45 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=608182&group_id=5470 Category: Core (C code) Group: Python 2.3 >Status: Closed >Resolution: Rejected Priority: 5 Submitted By: Taral (taral) Assigned to: Nobody/Anonymous (nobody) Summary: Enhanced file constructor Initial Comment: This patch allows the file constructor to take a file descriptor, allowing for much easier extension of its functionality. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-31 14:51 Message: Logged In: YES user_id=21627 I'm rejecting the patch, on grounds that nobody sees any need for it but the submitter. ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-06-03 06:47 Message: Logged In: YES user_id=357491 You can use groups.google.com or python-list@python.org. ---------------------------------------------------------------------- Comment By: Taral (taral) Date: 2003-06-02 21:33 Message: Logged In: YES user_id=25129 No, I don't have usenet access. ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-06-01 23:21 Message: Logged In: YES user_id=357491 Has a discussion comp.lang.python occured to judge the demand for this feature? ---------------------------------------------------------------------- Comment By: Taral (taral) Date: 2003-05-09 18:37 Message: Logged In: YES user_id=25129 Okay, you have a good point. I could convert it to this format: file(filename[, mode[, buffering[, fd]]]) or file(filename[,mode[, buffering]][, fd=fd]) That should satisfy the type requirement. I kind of prefer the keyword version, but that's just me. I know about the containment solution, but I can't pass containers to functions that expect isinstance(arg, file). (As for os.popen, that's happens to be why I made this patch in the first case. I needed to extend popen functionality, and this was the minimum way to do it without violating the above isinstance requirement.) ---------------------------------------------------------------------- Comment By: Tim Peters (tim_one) Date: 2003-05-09 05:53 Message: Logged In: YES user_id=31435 You do need to convince people it's a good idea. I cringe for two reasons: it mixes up a higher-level facility with a lower-level one; and, in a language with dynamic typing, it's *helpful* that file(xyz, 'w') raises TypeError today when the runtime type of xyz is an integer. This catches a serious error before it can harm files. I'd dislike losing that error detection more than I'd like the new facility this offers. Perhaps I'm in a small minority, though, in which case a discussion on comp.lang.python could reveal that. Someone there will point out that while you can't get what you want directly via subclassing file today, you can get the effect via containment and a __getattr__ hook (to delegate the file methods you don't want to intercept to the contained file object). That covers cases this patch doesn't, too, such as file objects returned by os.popen() (i.e., even with this patch, there are still "file objects that CANNOT be subclassed"). ---------------------------------------------------------------------- Comment By: Taral (taral) Date: 2003-05-09 04:32 Message: Logged In: YES user_id=25129 I have a very good reason! Without it, there are file objects that CANNOT be subclassed, specifically those created via os.fdopen. Yes, I am _still_ waiting for this to go in. Do I need to do something else on some mailing list to get people to notice it? ---------------------------------------------------------------------- Comment By: Brett Cannon (bcannon) Date: 2003-05-09 03:09 Message: Logged In: YES user_id=357491 This functionality has still not made it into 2.3b1 . If no one speaks up and comes up with a good argument to apply this by May 15 I am going to reject this patch. ---------------------------------------------------------------------- Comment By: Taral (taral) Date: 2003-01-31 21:12 Message: Logged In: YES user_id=25129 Didn't make it into 2.3alpha? ---------------------------------------------------------------------- Comment By: Taral (taral) Date: 2002-09-12 20:39 Message: Logged In: YES user_id=25129 class some_class(file): def __init__(self, arg): fd = do_some_os_stuff_with_forks_and_pipes_or_sockets return file.__init__(self, fd, 'r') def close(self): do_some_cleanup_stuff return file.close(self) and so on. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2002-09-12 08:59 Message: Logged In: YES user_id=21627 What's wrong with os.fdopen? Why is f = file(10, "r") much easier than f = os.fdopen(10, "r") ---------------------------------------------------------------------- Comment By: Taral (taral) Date: 2002-09-12 07:31 Message: Logged In: YES user_id=25129 Okay, fixed it all. Passes 'make test' on linux/x86 with default configure (does not test dbm/gdbm/mpz/bsddb). (btw, old versions can be deleted) ---------------------------------------------------------------------- Comment By: Neal Norwitz (nnorwitz) Date: 2002-09-12 06:10 Message: Logged In: YES user_id=33168 fp's and fd's are not interchangable. The variable should be called fd, since it's an int. fill_file_fields() 2nd arg is a FILE*, not an int. So you would need to do file = fdopen(fd, mode), then pass file as the 2nd arg. In order for this patch to be accepted, a test would also need to be added (see Lib/test/test_file.py) and doc should be updated (see Doc/lib/libfuncs.tex). ---------------------------------------------------------------------- Comment By: Taral (taral) Date: 2002-09-12 05:47 Message: Logged In: YES user_id=25129 Bah, forgot the variable. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=608182&group_id=5470 From noreply at sourceforge.net Fri Oct 31 08:54:32 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 31 08:54:40 2003 Subject: [Patches] [ python-Patches-599331 ] PEP 269 Implementation Message-ID: Patches item #599331, was opened at 2002-08-23 19:03 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=599331&group_id=5470 Category: Parser/Compiler Group: Python 2.3 Status: Open Resolution: Later Priority: 1 Submitted By: Jon Riehl (jriehl) Assigned to: Nobody/Anonymous (nobody) Summary: PEP 269 Implementation Initial Comment: The following are files for the implementation of PEP 269. The primary changes to the core involve moving required pgen modules from the pgen only module list to the Python library module list in Makefile.pre.in. Some of the modules required better memory allocation and management and the corresponding deallocators are in the Python extension module (maybe these should be moved into the pgen modules in Parser). Initially included are two implementations. The first is a basic implementation that follows the PEP API more or less. The second (currently unfinished) implementation provides a more object oriented interface to the extension module. Please note there are some commented out modifications to setup.py as I was unable to build the extension module(s) automagically. For some reason the linker I was using (on a BSD box) complained that it couldn't find the _Py_pgen symbol, even though I verified its existence in the new Python library. Maybe it is checking against an older Python library on the system? Things to be done (as of initial submission) include resolving on a single interface, documenting the one true interface, and finishing any unimplemented routines (such as are found in the OO implementation). In the final integration, a pgenmodule.c file should be added to the Modules directory in the main distribution. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-31 14:54 Message: Logged In: YES user_id=21627 Jon, are you still interested in taking this further? ---------------------------------------------------------------------- Comment By: Guido van Rossum (gvanrossum) Date: 2003-04-17 17:12 Message: Logged In: YES user_id=6380 I've checked in the changes to the parser and Makefile etc. This means you should be able to distribute pgenmodule.c as a clean extension to Python 2.3. I've decided not to incorporate pgenmodule.c at this time. There are three problems with it as I see it: - The C coding style is really different, and makes it hard to read: 2-space indents instead of tabs, spaces before left parentheses in argument lists, space between * and name in things like "PyObject * name", placement of curly braces, reversal of arguments to comparisons (e.g. "NULL != x"), and long strings of underscores in comments. - The code isn't robust enough: I got a segfault (can't remember after what sequence of events, sorry), and it caused a SystemError (error return without exception set) when the grammar file couldn't be read. - The pgen API seems a bit strange -- some things that I would expect to be methods of AST objects are functions in the pgen module (even when a companion function *is* an AST method). - The unit test doesn't fit in the Python test framework. - I cooked up a little expression grammar and tried to parse a sample string, but all I got was exceptions. I guess I am missing something, but there's no tutorial that explains me how to do things (I was copying the code from test_pgen.py which works :-( ). Nevertheless, thanks for the work so far -- I'm sure at some point pgen will be usable from Python! ---------------------------------------------------------------------- Comment By: Guido van Rossum (gvanrossum) Date: 2003-04-14 22:44 Message: Logged In: YES user_id=6380 OK, reading the README now... ---------------------------------------------------------------------- Comment By: Guido van Rossum (gvanrossum) Date: 2003-02-05 17:42 Message: Logged In: YES user_id=6380 Closed. Jon, if you're still interested in this, upload something new and reopen the patch (or I can do that). ---------------------------------------------------------------------- Comment By: Guido van Rossum (gvanrossum) Date: 2002-11-14 18:32 Message: Logged In: YES user_id=6380 Lowering priority until Jon has his next version ready. ---------------------------------------------------------------------- Comment By: Guido van Rossum (gvanrossum) Date: 2002-09-13 06:35 Message: Logged In: YES user_id=6380 Cool. Maybe I'll get to it, maybe not. :-( ---------------------------------------------------------------------- Comment By: Jon Riehl (jriehl) Date: 2002-09-12 20:04 Message: Logged In: YES user_id=22448 Guido, as per my private message, I'll attempt to submit another patch by the end of the month, pending resumption of "work" on the 23rd. Commitment of the memory allocation patch is fine, and any future patches would be against the updated pgen code (I don't have commit permissions, so someone else will have to do this possibly.) ---------------------------------------------------------------------- Comment By: Guido van Rossum (gvanrossum) Date: 2002-09-09 14:09 Message: Logged In: YES user_id=6380 I looked a bit, and it's very raw - the author admits that. Jon, are you still working on this? Do you have a more polished version? Maybe we can separate out the memory allocation patches and commit these already? They don't break anything. ---------------------------------------------------------------------- Comment By: Guido van Rossum (gvanrossum) Date: 2002-09-03 21:44 Message: Logged In: YES user_id=6380 I guess I'm going to hve to look at this to pronounce... ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=599331&group_id=5470 From noreply at sourceforge.net Fri Oct 31 08:56:57 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 31 08:57:05 2003 Subject: [Patches] [ python-Patches-562501 ] Add isxxx() methods to string objects Message-ID: Patches item #562501, was opened at 2002-05-30 20:00 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=562501&group_id=5470 Category: Core (C code) Group: Python 2.4 >Status: Closed >Resolution: Rejected Priority: 5 Submitted By: Raymond Hettinger (rhettinger) Assigned to: Raymond Hettinger (rhettinger) Summary: Add isxxx() methods to string objects Initial Comment: Here's the patch for the isxxx methods. If it's up to spec, let me know and I'll add documentation and expand the unittests. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-31 14:56 Message: Logged In: YES user_id=21627 Patch #825313, which is identical to this one, was just rejected, so it is probably time to reject this as well. ---------------------------------------------------------------------- Comment By: M.-A. Lemburg (lemburg) Date: 2002-10-21 00:20 Message: Logged In: YES user_id=38388 I'd suggest to start with the standard ASCII characters for the methods you are suggesting to add and then complete the sets using the various categories listed on http://www.unicode.org/Public/UNIDATA/UnicodeData.html e.g. punctation (P*) is a general category in the Unicode database, control too (Cc). Visibility and printability depend on available fonts, so I'm not sure what to do about these. Hex chars are the same as for 8-bit strings. ---------------------------------------------------------------------- Comment By: Raymond Hettinger (rhettinger) Date: 2002-10-20 23:12 Message: Logged In: YES user_id=80475 This one is taking a while because I'm not entirely clear on the inclusion/exclusion criteria for classifying Unicode characters for the various isxxx methods. I'm spending some time with the big Unicode 3.0 book and will post a patch when I know how to proceed. If any one already has a clear sense of direction, I'm all ears. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2002-10-07 23:46 Message: Logged In: YES user_id=21627 Raymond, any news on this? I like the idea. ---------------------------------------------------------------------- Comment By: Raymond Hettinger (rhettinger) Date: 2002-06-30 21:58 Message: Logged In: YES user_id=80475 Unassigning this because I'm away for five weeks. The equivalent Unicode operations are not as clearly defined as they are for Ascii. Was researching what is done in other programming languages. Also, there was a py-dev discussion that suggested that the function names be changed to something more clear than their names in C. ---------------------------------------------------------------------- Comment By: Guido van Rossum (gvanrossum) Date: 2002-05-30 20:41 Message: Logged In: YES user_id=6380 Thanks! But what about adding the same methods to Unicode objects? I think that's the point of using methods -- supporting the same operations for both string types. Also, Paul Prescod wanted ishexdigit instead of isxdigit. Not sure if I agree. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=562501&group_id=5470 From noreply at sourceforge.net Fri Oct 31 09:03:29 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 31 09:03:34 2003 Subject: [Patches] [ python-Patches-628301 ] Experimental Inno Setup Win32 installer Message-ID: Patches item #628301, was opened at 2002-10-25 00:59 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=628301&group_id=5470 Category: Windows Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Bruce Dodson (bdodson_esrican) Assigned to: Martin v. L?wis (loewis) Summary: Experimental Inno Setup Win32 installer Initial Comment: I found the Inno Setup script for Python in the Python 2.2.1 source tree, and decided to hack on it a bit. Since I didn't want to deploy a custom build of Python (wanted to use the original), one of my changes is something you won't want: instead of looking in PCBuild etc. for the files, it expects the files to be laid out the way the WISE installer does it. However it should be easy to change this back so it works against the Python VC source / build tree. Be that as it may, this version has a few changes that you may or may not want: 1) incorporates Mark Hammond's win32 libraries (but not Pythonwin) 2) deletes PYC and PYO files on uninstall, so that the install directory can be properly removed. 3) uses Inno Setup Extensions (http://www.wintax.nl/isx) to enable scripted behavior, e.g. behave differently based on whether an administrator is running the install. 4) uses wildcards to make the script shorter. I do like the original author's idea of using a Python script to generate the ISS script; that would allow the files to be listed explicitly rather than relying on wildcards as I did here. The addition of Mark's stuff is something that interests me, since I can't redistribute ActivePython and find it cumbersome to include 2 installers plus my own; however it is not necessarily something that you are going to care about. The other changes may be more interesting to you. This script is based on the one found in Python 2.2.1 source tree, but I have compiled and tested it against Python 2.2.2. To test, run the Python WISE installer and Mark's win32all installer. Then copy python22.dll etc. from system32 to Python22\sysdir. Copy the ISS file into the Python22 directory. Running the ISX compiler against python.iss. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-31 15:03 Message: Logged In: YES user_id=21627 Ok, I have committed Python-2.3.2-Win32-159-Setup.iss as python.iss 1.7. ---------------------------------------------------------------------- Comment By: Bruce Dodson (bdodson_esrican) Date: 2003-10-29 03:29 Message: Logged In: YES user_id=533196 Exactly. Some people might find the script useful in the real world (including me!), but the same would be true of any good sample. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-28 21:28 Message: Logged In: YES user_id=21627 Thanks for the clarification; unfortunately, I still don't understand: All you suggest is that your file replaces the one in CVS? That sounds fine to me. ---------------------------------------------------------------------- Comment By: Bruce Dodson (bdodson_esrican) Date: 2003-10-28 05:40 Message: Logged In: YES user_id=533196 Thank you for the response. I don't expect Inno to replace the WISE installer as the official Python distribution for Windows; I hope I did not give that impression. To clarify: what I've done is merely an enhanced / updated version of the Inno Setup sample that appears in the Python source tree on CVS (dist/PCBuild/python.iss). ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2003-10-28 01:37 Message: Logged In: YES user_id=21627 I'm tempted to reject this on the grounds that Inno setup is likely not being used in the future to build Python distributions; it's more likely to be WISE until that gets replaced with MSI. That said, it might be useful to merely distribute the files with Python; if you think it is, please indicate so. Consider that there might be nothing wrong with maintaining your own installer, as a separate project. I assign this to Thomas Heller, who is the current manager of the Windows packaging; Thomas, feel free to either reject or accept this - I see little point in keeping it open. ---------------------------------------------------------------------- Comment By: Bruce Dodson (bdodson_esrican) Date: 2003-08-01 02:26 Message: Logged In: YES user_id=533196 I've enhanced this further, to include the vcredist stuff, and to account for the directory tree changes in Python 2.3 (IDLE moved, etc). If you're interested in checking it out, I've compiled an experimental installer and published it at http://sourceforge.net/projects/avpython/, in the pythonsetup package. The updated source script is there as well. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=628301&group_id=5470 From noreply at sourceforge.net Fri Oct 31 09:06:11 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 31 09:06:15 2003 Subject: [Patches] [ python-Patches-830341 ] python-mode.el: (py-point 'bod) doesn't quite work Message-ID: Patches item #830341, was opened at 2003-10-26 04:07 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=830341&group_id=5470 Category: Demos and tools Group: None >Status: Closed >Resolution: Rejected Priority: 5 Submitted By: Dale Hagglund (dhagglund) Assigned to: Nobody/Anonymous (nobody) Summary: python-mode.el: (py-point 'bod) doesn't quite work Initial Comment: I hope the category is right. It's the only one that seemed close. The code for py-point in python-mode.el should pass 'either to py-beginning-of-def-or-class and py-end-of-def-or-class. The attached patch does this. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-31 15:06 Message: Logged In: YES user_id=21627 python-mode is now maintained at http://sourceforge.net/projects/python-mode Please resubmit your path there; rejecting it here. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=830341&group_id=5470 From noreply at sourceforge.net Fri Oct 31 10:28:32 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 31 10:28:38 2003 Subject: [Patches] [ python-Patches-833710 ] --enable-shared Solaris install bug Message-ID: Patches item #833710, was opened at 2003-10-31 16:28 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=833710&group_id=5470 Category: Build Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Ondrej Palkovsky (ondrap) Assigned to: Nobody/Anonymous (nobody) Summary: --enable-shared Solaris install bug Initial Comment: I was trying to build Python 2.3.2 on Solaris 2.8 (sparc). After running: ./configure --enable-shared make make install The install phase fails to install the shared library complaining that it is impossible to link 'libpython.so' to 'libpython.so'. I have fixed the configure.in, so that now it installs correctly. The 'INSTSONAME' was not properly defined on Solaris. In addition it may be worth checking in the Makefile (about line 612 of Makefile.pre.in) if INSTSONAME is the same as LDLIBRARY and linking only if they differ. This is already done in another part of the Makefile to avoid same problem. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=833710&group_id=5470 From noreply at sourceforge.net Fri Oct 31 10:37:00 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 31 10:37:05 2003 Subject: [Patches] [ python-Patches-830858 ] update docs for inspect module Message-ID: Patches item #830858, was opened at 2003-10-27 10:22 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=830858&group_id=5470 Category: Documentation Group: Python 2.2.x >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: George Yoshida (quiver) Assigned to: Nobody/Anonymous (nobody) Summary: update docs for inspect module Initial Comment: The docs of inspect module says that, "The nine functions whose names begin with ``is''" but there are more functions like that. www.python.org/doc/2.3.2/lib/inspect-types.html After inspect module was introduced in 2.1, ismethoddescriptor was added in 2.2 and isdatadescriptor was added in 2.3. So for Python 2.2 the number is 10, and for Python 2.3 the number is 11. >>> import sys, inspect >>> print sys.version 2.3.2 (#1, Oct 9 2003, 12:03:29) [GCC 3.3.1 (cygming special)] >>> filter(lambda x:x.startswith('is'), dir(inspect)) ['isbuiltin', 'isclass', 'iscode', 'isdatadescriptor', 'isfra me', 'isfunction', 'ismethod', 'ismethoddescriptor', 'is module', 'isroutine', 'istraceback'] >>> len(_) 11 ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-31 16:37 Message: Logged In: YES user_id=21627 Thanks for the patch. Applied as libinspect.tex 1.10.6.2, 1.13.10.1, and 1.14 test_inspect.py 1.12.8.1 and 1.13 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=830858&group_id=5470 From noreply at sourceforge.net Fri Oct 31 10:42:45 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 31 10:42:53 2003 Subject: [Patches] [ python-Patches-833710 ] --enable-shared Solaris install bug Message-ID: Patches item #833710, was opened at 2003-10-31 16:28 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=833710&group_id=5470 Category: Build Group: Python 2.3 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Ondrej Palkovsky (ondrap) Assigned to: Nobody/Anonymous (nobody) Summary: --enable-shared Solaris install bug Initial Comment: I was trying to build Python 2.3.2 on Solaris 2.8 (sparc). After running: ./configure --enable-shared make make install The install phase fails to install the shared library complaining that it is impossible to link 'libpython.so' to 'libpython.so'. I have fixed the configure.in, so that now it installs correctly. The 'INSTSONAME' was not properly defined on Solaris. In addition it may be worth checking in the Makefile (about line 612 of Makefile.pre.in) if INSTSONAME is the same as LDLIBRARY and linking only if they differ. This is already done in another part of the Makefile to avoid same problem. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-31 16:42 Message: Logged In: YES user_id=21627 Thanks for the patch. Applied as configure 1.429 configure.in 1.439 configure 1.416.4.10 configure.in 1.427.4.9 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=833710&group_id=5470 From noreply at sourceforge.net Fri Oct 31 10:48:51 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 31 10:48:54 2003 Subject: [Patches] [ python-Patches-829951 ] Fixes smtplib starttls HELO errors Message-ID: Patches item #829951, was opened at 2003-10-25 04:49 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=829951&group_id=5470 Category: Library (Lib) Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: John Draper (jdcrunchman) Assigned to: Nobody/Anonymous (nobody) Summary: Fixes smtplib starttls HELO errors Initial Comment: smtplib.starttls() needs to include does_esmtp=0. Without this, the "size=" suffix on MAIL FROM lines causes server errors since the MTA defaults to HELO mode. This is also necessary in order to conform to RFC 2487 section 5.2, which states after TLS is started, all prior knowledge (including esmtp capability) must be discarded. This bug exists in Python 2.3.2 and earlier. ---------------------------------------------------------------------- >Comment By: Martin v. L?wis (loewis) Date: 2003-10-31 16:48 Message: Logged In: YES user_id=21627 Shouldn't you also reset other state, such as esmtp_features? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=829951&group_id=5470 From noreply at sourceforge.net Fri Oct 31 19:25:08 2003 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 31 19:25:51 2003 Subject: [Patches] [ python-Patches-515003 ] Added HTTP{,S}ProxyConnection Message-ID: Patches item #515003, was opened at 2002-02-08 13:39 Message generated for change (Comment added) made by gstein You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=515003&group_id=5470 Category: Library (Lib) Group: Python 2.3 Status: Open Resolution: None Priority: 3 Submitted By: Mihai Ibanescu (misa) Assigned to: Martin v. L?wis (loewis) Summary: Added HTTP{,S}ProxyConnection Initial Comment: This patch adds HTTP*Connection classes for proxy connections. Authenticated proxies are also supported. One can argue urllib2 already implements this. It does not do HTTPS tunneling through proxies, and this is intended to be lower-level than urllib2. ---------------------------------------------------------------------- >Comment By: Greg Stein (gstein) Date: 2003-10-31 16:25 Message: Logged In: YES user_id=6501 Eek. Following this model, then when we want to add Basic authentication support, then we'll have the following classes: HTTPBasicConnection HTTPSBasicConnection HTTPBasicProxyConnection HTTPSBasicProxyConnection Oh, and what if we want Digest support? Another set of four? But what if we want the connection to support *both* Basic or Digest, depending upon how the server was configured? Let's not forget the client certificates. Oh, and layering DAV capability on this. The point is: adding features by adding classes will produce a combinatoric nightmare. While I certainly agree with the idea of pushing proxy support "down" from urllib(2) into the basic http classes, I'd rather see a design that doesn't require a new class for every feature combination. PEP 268 was the start of an attempt to rationalize the various features around HTTP. Some of the basic feature sets to support: * SSL * various forms of authentication (Basic, Digest, client cert, ...) * WebDAV * Proxy * Proxy auth I'd much rather see proxy features folded right into the connection classes, than to spawn new ones. Even better, I'd suggest picking up PEP 268 and modifying it where "you" (whoever might read this comment) disagree or have further design ideas. (IOW, count me a -1 to the approach suggested by this patch) ---------------------------------------------------------------------- Comment By: Neal Norwitz (nnorwitz) Date: 2003-01-10 17:15 Message: Logged In: YES user_id=33168 Uploading patch from Isaac Salsberg. I removed some more comments. Jeremy (or Martin) can you review this. If it's read, I can check it in. There still needs to be a doc and tests. I'll check if either of the old patches has any. ---------------------------------------------------------------------- Comment By: Neal Norwitz (nnorwitz) Date: 2003-01-01 11:52 Message: Logged In: YES user_id=33168 Isaac, can you send me the patch? nnorwitz@users.sf.net should work ---------------------------------------------------------------------- Comment By: Isaac Salsberg (isalsberg) Date: 2002-12-19 17:54 Message: Logged In: YES user_id=663978 Neal, taht's right, I can not attach a file. I don't think is a good idea to close this patch, because Misa is still working on it to fix some persistence issue. The version I created is based on the current Misa's version, so it has the same persistence problem. It just was adapted to be used with Python 2.2.2. So we need to wait for Misa's final version. I sent the patch to Misa, in case he wants to atach it here meanwhile the last version arrives. Except for persistence, It is working for me in a production environment. Anyway, If You need the patch I can send it. Just give me an email address. ---------------------------------------------------------------------- Comment By: Neal Norwitz (nnorwitz) Date: 2002-12-14 18:09 Message: Logged In: YES user_id=33168 Isaac, I don't believe SF allows you to attach a file to someone else's patch. Please submit a new patch. In the comments for the new patch refer to this patch and indicate if it supercedes this patch (ie, should this patch be closed). Also, it would be nice if you can add a comment to this patch mentioning the new patch number. Thanks! ---------------------------------------------------------------------- Comment By: Isaac Salsberg (isalsberg) Date: 2002-12-14 16:52 Message: Logged In: YES user_id=663978 To make this patch work with the "buggy" IIS using python 2.2 or 2.2.1 with https, You need to install also these 2 patches: 551273 (fix httplib bug with 100 Continue) and 500311 (work around for buggy https servers) Python 2.2.2 by the other hand, has already incorparated those two patches, so You only need to add the HTTP{S} (515003) proxy patch. But since httplib has changed, Misa's diff file will fail. I have created a diff file that works with python 2.2.2, which also includes a new example that works using a certificate file in PEM format. I wanted to attach the file, however I could not find out how :-( ---------------------------------------------------------------------- Comment By: Mihai Ibanescu (misa) Date: 2002-11-05 12:56 Message: Logged In: YES user_id=205865 I am having problems with proxying and keepalive connections. Setting to a lower priority until I figure out the documentation. ---------------------------------------------------------------------- Comment By: Mihai Ibanescu (misa) Date: 2002-10-07 14:20 Message: Logged In: YES user_id=205865 Boy, two months. Yes, I'll go back to working on the patch. Sorry for the delay. ---------------------------------------------------------------------- Comment By: Martin v. L?wis (loewis) Date: 2002-10-07 14:17 Message: Logged In: YES user_id=21627 misa, is a patch forthcoming? ---------------------------------------------------------------------- Comment By: Mihai Ibanescu (misa) Date: 2002-07-15 14:37 Message: Logged In: YES user_id=205865 - I agree about the comments. I'll make them reasonable. - one underscore is fine - I intended to have a patch that works with python 1.5, but then again the module itself doesn't run with 1.5 anyway, so good point. - When you make a connection to a server through a proxy, you have to connect to the proxy, but everything else should be the same, i.e. the Host: field has to refer to the server and so on. I wanted to reuse the code from _set_hostport, which saves the host and port in self.host, self.port. Had to do it twice, once for the proxy hostname, once for the server's. _set_hostport takes care of the default port and of the "hostname:port" syntax, which is convenient. I'll put together a patched patch and upload it. ---------------------------------------------------------------------- Comment By: Jeremy Hylton (jhylton) Date: 2002-07-15 14:21 Message: Logged In: YES user_id=31392 The proposed classes seem useful enough, but I would like to make several suggestions for the implementation. - There are too many comments. Comments should only be added when the intent of the code needs to be explained. We definitely don't need one comment for each line of code. The comment in the HTTPS proxy putrequest() is an example of a helpful comment. - Just use a single underscore for private variables. - Please use string methods instead of the string module. - I don't understand the logic of switching the host/port back and forth. ---------------------------------------------------------------------- Comment By: Jeremy Hylton (jhylton) Date: 2002-07-15 13:52 Message: Logged In: YES user_id=31392 I'll take a look. ---------------------------------------------------------------------- Comment By: Guido van Rossum (gvanrossum) Date: 2002-07-12 08:46 Message: Logged In: YES user_id=6380 Assigning to Jeremy in the hope that he can provide a review. ---------------------------------------------------------------------- Comment By: Mihai Ibanescu (misa) Date: 2002-06-23 20:03 Message: Logged In: YES user_id=205865 The newer patch is generated against the latest CVS tree, and it provides additional documentation. ---------------------------------------------------------------------- Comment By: Mihai Ibanescu (misa) Date: 2002-06-11 11:47 Message: Logged In: YES user_id=205865 Sorry, been caught with a zillion of other things to do. I'll try to reorganize it somehow and ask for opinions. ---------------------------------------------------------------------- Comment By: Jeremy Hylton (jhylton) Date: 2002-06-11 11:42 Message: Logged In: YES user_id=31392 misa-- any progress on this patch? ---------------------------------------------------------------------- Comment By: Guido van Rossum (gvanrossum) Date: 2002-03-01 15:12 Message: Logged In: YES user_id=6380 OK, thanks; I'll wait! ---------------------------------------------------------------------- Comment By: Mihai Ibanescu (misa) Date: 2002-03-01 14:58 Message: Logged In: YES user_id=205865 I will add documentation and show the intended usage. urllib* doesn't deal with proxying over SSL (using CONNECT instead of GET/POST). urllib* also use the compatibility classes, HTTP/HTTPS, instead of HTTPConnection (this is not an argument by itself). Thanks for the suggestion. ---------------------------------------------------------------------- Comment By: Guido van Rossum (gvanrossum) Date: 2002-03-01 14:40 Message: Logged In: YES user_id=6380 This patch fails to seduce me. There's no explanation why this would be useful, or how it should be used, and no documentation, and a hint that urllib2 already does this. Maybe you can get someone who's known on python-dev to champion it, if you think it's useful? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=515003&group_id=5470