[Patches] [ python-Patches-551093 ] Cygwin forced --enable-shared patch

[noreply@sourceforge.net]

Patches item #551093, was opened at 2002-05-01 09:47
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=551093&group_id=5470

Category: Build
Group: None
Status: Closed
Resolution: Accepted
Priority: 5
Submitted By: Jason Tishler (jlt63)
Assigned to: Martin v. Löwis (loewis)
Summary: Cygwin forced --enable-shared patch

Initial Comment:
This patch forces the configure --enable-shared
option under Cygwin even if not specified by the
user. Cygwin, like Win32, requires a shared python
library.

----------------------------------------------------------------------

>Comment By: Jason Tishler (jlt63)
Date: 2002-05-03 07:23

Message:
Logged In: YES 
user_id=86216

I just tried Cygwin and its possible albeit painful.
One must edit their Modules/Setup file to make
"all" standard modules static too. Otherwise,
when the interpretter loads a standard module it
goes bang! I presume that Win32 would have
similar problems.

BTW, thanks for accepting my patch take 2.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2002-05-02 21:54

Message:
Logged In: YES 
user_id=21627

That patch looks fine, applied as configure.in 1.314,
configure 1.304.

As for building Python statically: the MSVC project files
certainly don't support it. I haven't tried, but I can see
no reason why this configuration couldn't work.

----------------------------------------------------------------------

Comment By: Jason Tishler (jlt63)
Date: 2002-05-02 12:09

Message:
Logged In: YES 
user_id=86216

Is the attached any better?

BTW, can one build Win32 Python statically?

Note that currently, Cygwin Python cannot be built
statically. To do so would require additional work...

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2002-05-02 09:28

Message:
Logged In: YES 
user_id=21627

Given that cygwin has indeed the same requirements as the
VC++ build, I think it is fine to let enable-shared
*default* to shared. 

However, it is not good style to force it: it is perfectly
sensible to build a python.exe/libpython.a, as the
requirement for a shared python.dll only comes up when you
want to load modules dynamically. In cases where you can
statically link alll modules that you will ever need (in
particular for frozen applications), it would be unfortunate
if you are forced to use a python dll (since it would not
allow for stand-alone binaries).

Hence, I'm rejecting the patch in its current form; feel
free to resubmit it in a form where an explicit
--disable-shared would override the default.

----------------------------------------------------------------------

Comment By: Michael Hudson (mwh)
Date: 2002-05-02 06:08

Message:
Logged In: YES 
user_id=6656

Martin, is this good style?

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=551093&group_id=5470